friendica/friendica-addons
9
4
Fork 16
Code Issues 3 Pull requests 2 Releases 16 Wiki Activity

Audon audioplayer App #1414

Merged
MrPetovan merged 19 commits from :develop into develop 2023-08-18 18:41:35 +02:00
Conversation 5 Commits 19 Files changed 4 +6 -6
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 1ee297b698 - Show all commits

12
audon/audon.php
View file

@ -1,6 +1,6 @@
<?php
/*
* Name: audon Application
* Name: AUDON Application
loma-one marked this conversation as resolved Outdated
MrPetovan commented 2023-08-18 16:05:41 +02:00
Outdated
Review
Copy link

Please capitalize the Audon name when not used in code context.

Please capitalize the Audon name when not used in code context.
loma-one marked this conversation as resolved Outdated
MrPetovan commented 2023-08-18 16:28:19 +02:00
Outdated
Review
Copy link

Thanks for the change, however I meant "Audon", not "AUDON". I'll highlight the other instances I noticed.

Thanks for the change, however I meant "Audon", not "AUDON". I'll highlight the other instances I noticed.
* Description: add a audon instance for audio. Based on webRTC Addon
loma-one marked this conversation as resolved Outdated
MrPetovan commented 2023-08-18 16:28:39 +02:00
Outdated
Review
Copy link

Add an Audon instance

`Add an Audon instance`
* Version: 0.1
* Author: Stephen Mahood <https://friends.mayfirst.org/profile/marxistvegan>
@ -26,13 +26,13 @@ function audon_addon_admin(string &$o)
{
$t = Renderer::getMarkupTemplate('admin.tpl', 'addon/audon/');
$o = Renderer::replaceMacros($t, [
'$submit' => DI::l10n()->t('Save Settings'),
'$submit' => DI::l10n()->t('Save Settings'),
'$audonurl' => [
'audonurl',
DI::l10n()->t('audon Base URL'),
DI::config()->get('audon','audonurl'),
'audonurl',
DI::l10n()->t('audon Base URL'),
loma-one marked this conversation as resolved Outdated
MrPetovan commented 2023-08-18 16:30:25 +02:00
Outdated
Review
Copy link
			DI::l10n()->t('Audon Base URL'),
```php DI::l10n()->t('Audon Base URL'), ```
DI::config()->get('audon','audonurl'),
loma-one marked this conversation as resolved Outdated
MrPetovan commented 2023-08-18 16:06:11 +02:00
Outdated
Review
Copy link

Code standards: Please add a space after commas.

Code standards: Please add a space after commas.
loma-one marked this conversation as resolved
MrPetovan commented 2023-08-18 16:29:09 +02:00
Review
Copy link
			DI::config()->get('audon', 'audonurl'),
```php DI::config()->get('audon', 'audonurl'), ```
DI::l10n()->t('Page your users will create a audon Audio chat room on. For example you could use https://audon.space.'),
loma-one marked this conversation as resolved Outdated
MrPetovan commented 2023-08-18 16:29:27 +02:00
Outdated
Review
Copy link

Page your users will create an Audon audio chat room on. For example you could use https://audon.space.

`Page your users will create an Audon audio chat room on. For example you could use https://audon.space.`
],
],
]);
}