Audon audioplayer App #1414

Merged
MrPetovan merged 19 commits from :develop into develop 2023-08-18 18:41:35 +02:00
Contributor

Audon is an audioplayer that allows different users to meet for a private conversation. The player has been packaged as an app and only embeds the player.

Audon is an audioplayer that allows different users to meet for a private conversation. The player has been packaged as an app and only embeds the player.
loma-one added 6 commits 2023-08-18 16:00:05 +02:00
This Addon based on webrtc. Audon is a service of realtime audio chat.
With small changes, the WebRTC addon could be adapted to Audon so that it can be loaded into an iframe. In the ifram, the Friendica handle can be connected and a room opened. Audio conversations between Friendica users are possible.
https://github.com/friendica/friendica-addons/pull/1357
MrPetovan requested changes 2023-08-18 16:07:58 +02:00
audon/audon.php Outdated
@ -0,0 +1,68 @@
<?php
/*
* Name: audon Application
Owner

Please capitalize the Audon name when not used in code context.

Please capitalize the Audon name when not used in code context.
loma-one marked this conversation as resolved
audon/audon.php Outdated
@ -0,0 +30,4 @@
'$audonurl' => [
'audonurl',
DI::l10n()->t('audon Base URL'),
DI::config()->get('audon','audonurl'),
Owner

Code standards: Please add a space after commas.

Code standards: Please add a space after commas.
loma-one marked this conversation as resolved
@ -0,0 +1,2 @@
{{include file="field_input.tpl" field=$audonurl}}
<div class="submit"><input type="submit" name="page_site" value="{{$submit}}" /></div>
Owner

Please use a <button> element instead, since you aren't checking the value of page_site, you can omit the name and value attribute.

<button type="submit">{{$submit}}</button>
Please use a `<button>` element instead, since you aren't checking the value of `page_site`, you can omit the `name` and `value` attribute. ```html <button type="submit">{{$submit}}</button> ```
loma-one marked this conversation as resolved
loma-one added 1 commit 2023-08-18 16:17:50 +02:00
loma-one added 1 commit 2023-08-18 16:18:35 +02:00
loma-one added 1 commit 2023-08-18 16:24:06 +02:00
Author
Contributor

Hope it fits

Hope it fits
loma-one closed this pull request 2023-08-18 16:25:47 +02:00
loma-one reopened this pull request 2023-08-18 16:26:02 +02:00
MrPetovan requested changes 2023-08-18 16:32:38 +02:00
audon/audon.php Outdated
@ -0,0 +1,68 @@
<?php
/*
* Name: AUDON Application
Owner

Thanks for the change, however I meant "Audon", not "AUDON". I'll highlight the other instances I noticed.

Thanks for the change, however I meant "Audon", not "AUDON". I'll highlight the other instances I noticed.
loma-one marked this conversation as resolved
audon/audon.php Outdated
@ -0,0 +1,68 @@
<?php
/*
* Name: AUDON Application
* Description: add a audon instance for audio. Based on webRTC Addon
Owner

Add an Audon instance

`Add an Audon instance`
loma-one marked this conversation as resolved
audon/audon.php Outdated
@ -0,0 +19,4 @@
function audon_app_menu(array &$b)
{
$b['app_menu'][] = '<div class="app-title"><a href="audon">' . DI::l10n()->t('audon Audiochat') . '</a></div>';
Owner

Audon Audiochat

`Audon Audiochat`
loma-one marked this conversation as resolved
audon/audon.php Outdated
@ -0,0 +29,4 @@
'$submit' => DI::l10n()->t('Save Settings'),
'$audonurl' => [
'audonurl',
DI::l10n()->t('audon Base URL'),
Owner
			DI::l10n()->t('Audon Base URL'),
```php DI::l10n()->t('Audon Base URL'), ```
loma-one marked this conversation as resolved
@ -0,0 +30,4 @@
'$audonurl' => [
'audonurl',
DI::l10n()->t('audon Base URL'),
DI::config()->get('audon','audonurl'),
Owner
			DI::config()->get('audon', 'audonurl'),
```php DI::config()->get('audon', 'audonurl'), ```
loma-one marked this conversation as resolved
audon/audon.php Outdated
@ -0,0 +31,4 @@
'audonurl',
DI::l10n()->t('audon Base URL'),
DI::config()->get('audon','audonurl'),
DI::l10n()->t('Page your users will create a audon Audio chat room on. For example you could use https://audon.space.'),
Owner

Page your users will create an Audon audio chat room on. For example you could use https://audon.space.

`Page your users will create an Audon audio chat room on. For example you could use https://audon.space.`
loma-one marked this conversation as resolved
audon/audon.php Outdated
@ -0,0 +53,4 @@
$o = '';
/* landingpage to create chatrooms */
$audonurl = DI::config()->get('audon','audonurl');
Owner
	$audonurl = DI::config()->get('audon', 'audonurl');
```php $audonurl = DI::config()->get('audon', 'audonurl'); ```
loma-one marked this conversation as resolved
@ -0,0 +59,4 @@
$o .= '<h2>' . DI::l10n()->t('Audio Chat') . '</h2>';
$o .= '<p>' . DI::l10n()->t('Audon is an audio conferencing tool. Connect your account to Audon and create a room. Share the generated link to talk to other participants.') . '</p>';
if ($audonurl == '') {
$o .= '<p>' . DI::l10n()->t('Please contact your friendica administrator to remind them to configure the Audon addon.') . '</p>';
Owner

Please contact your Friendica administrator to remind them to configure the Audon addon.

`Please contact your Friendica administrator to remind them to configure the Audon addon.`
loma-one marked this conversation as resolved
loma-one added 1 commit 2023-08-18 16:48:16 +02:00
loma-one added 1 commit 2023-08-18 16:51:31 +02:00
MrPetovan requested changes 2023-08-18 16:54:22 +02:00
MrPetovan left a comment
Owner

Thank you for your changes, please regenerate the messages.po file now that you changed the translation strings in the code.

Thank you for your changes, please regenerate the messages.po file now that you changed the translation strings in the code.
loma-one added 1 commit 2023-08-18 17:19:05 +02:00
MrPetovan requested changes 2023-08-18 17:24:24 +02:00
MrPetovan left a comment
Owner

What command did you use to generate the translation file? It should be bin/run_xgettext.sh -a audon from the base Friendica folder. The generated file should be audon/lang/C/messages.po.

What command did you use to generate the translation file? It should be `bin/run_xgettext.sh -a audon` from the base Friendica folder. The generated file should be `audon/lang/C/messages.po`.
Author
Contributor

When running bin/run_xgettext.sh -a audon I get an error message:

...:/var/www/html/friendica# bin/run_xgettext.sh -a audon Extract strings to /var/www/html/friendica/bin/../addon/audon/lang/C/messages.po.. Reading file 1/16...bin/run_xgettext.sh: Zeile 89: xgettext: Kommando nicht gefunden.

When running `bin/run_xgettext.sh -a audon` I get an error message: `...:/var/www/html/friendica# bin/run_xgettext.sh -a audon Extract strings to /var/www/html/friendica/bin/../addon/audon/lang/C/messages.po.. Reading file 1/16...bin/run_xgettext.sh: Zeile 89: xgettext: Kommando nicht gefunden.`
Owner

Can you make sure the gettext package is installed on your system? It can be on your development machine, it doesn't have to be on the server you're running Friendica.

Can you make sure the `gettext` package is installed on your system? It can be on your development machine, it doesn't have to be on the server you're running Friendica.
loma-one added 1 commit 2023-08-18 18:26:03 +02:00
Owner

Can you please rename the audon/lang/C file to audon/lang/C/messages.po? Otherwise Transifex won't be able to pick up the translation strings.

Can you please rename the `audon/lang/C` file to `audon/lang/C/messages.po`? Otherwise Transifex won't be able to pick up the translation strings.
loma-one added 1 commit 2023-08-18 18:35:34 +02:00
Signed-off-by: loma-one <loma-one@noreply.git.friendi.ca>
loma-one added 1 commit 2023-08-18 18:36:04 +02:00
loma-one added 1 commit 2023-08-18 18:36:33 +02:00
loma-one added 1 commit 2023-08-18 18:37:40 +02:00
loma-one added 1 commit 2023-08-18 18:38:09 +02:00
loma-one added 1 commit 2023-08-18 18:38:32 +02:00
MrPetovan approved these changes 2023-08-18 18:41:23 +02:00
MrPetovan added the
2023.09
label 2023-08-18 18:41:32 +02:00
MrPetovan merged commit b76f143e60 into develop 2023-08-18 18:41:35 +02:00
Author
Contributor

Thank for your Support

Thank for your Support
Sign in to join this conversation.
No description provided.