friendica
/
friendica-addons
7
2
Fork 13
Code Issues 3 Pull Requests 3 Releases 16 Wiki Activity

[advancedcontentfilter] Ship standalone Vue 2 library with addon #1300

Merged
MrPetovan merged 1 commits from bug/12054-advancedcontentfilter-static-vue into develop 2022-10-29 19:34:23 +02:00
Conversation 5 Commits 1 Files Changed 3 +11906 -1
MrPetovan commented 2022-10-29 03:18:20 +02:00 (Migrated from github.com)
Copy Link

Fixes https://github.com/friendica/friendica/issues/12054

  • The Composer Bower package stopped including the dist/vue.min.js which was required by the addon
Fixes https://github.com/friendica/friendica/issues/12054 - The Composer Bower package stopped including the dist/vue.min.js which was required by the addon
nupplaphil commented 2022-10-29 09:43:39 +02:00 (Migrated from github.com)
Copy Link

Wouldn't we probably miss security upgrades for Vue because it's no more managed? Isn't this a risk, is it?

Wouldn't we probably miss security upgrades for Vue because it's no more managed? Isn't this a risk, is it?
👍 1
Quix0r (Migrated from github.com) approved these changes 2022-10-29 15:23:11 +02:00
MrPetovan commented 2022-10-29 18:11:19 +02:00 (Migrated from github.com)
Copy Link

At this point, I don't really care anymore. I tried my best to use two different Javascript package managers and both were utterly disappointing.

I would be curious about the security risks of this particular application, though.

At this point, I don't really care anymore. I tried my best to use two different Javascript package managers and both were utterly disappointing. I would be curious about the security risks of this particular application, though.
❤️ 1
nupplaphil commented 2022-10-29 19:34:19 +02:00 (Migrated from github.com)
Copy Link

Hm, sadly but I see ...

Hm, sadly but I see ...
Quix0r commented 2022-10-30 18:06:01 +01:00 (Migrated from github.com)
Copy Link

Cannot we rewrite this to a non-vuejs version?

Cannot we rewrite this to a non-vuejs version?
MrPetovan commented 2022-10-30 19:09:34 +01:00 (Migrated from github.com)
Copy Link

Probably, this addon project was a good opportunity for me to find out what Vue was about but it definitely doesn't have to be using Vue.

Probably, this addon project was a good opportunity for me to find out what Vue was about but it definitely doesn't have to be using Vue.
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
Quix0r
Labels
Clear labels   
2018.09

   
2019.01

   
2019.03

   
2019.06

   
2019.09

   
2019.12

   
2020.03

   
2020.06

   
2020.09

   
2020.12

   
2021.03

   
2021.07

   
2021.09

   
2022.02

   
2022.06

   
2022.09

   
2022.12

   
2023.04

   
2023.05

   
2023.09

   
2024.03

   
2024.06

   
dependencies

Pull requests that update a dependency file

  
Hackathon 2021
No Label
2018.09
2019.01
2019.03
2019.06
2019.09
2019.12
2020.03
2020.06
2020.09
2020.12
2021.03
2021.07
2021.09
2022.02
2022.06
2022.09
2022.12
2023.04
2023.05
2023.09
2024.03
2024.06
dependencies
Hackathon 2021
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-addons#1300
No description provided.
Delete Branch "bug/12054-advancedcontentfilter-static-vue"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?