friendica/friendica-addons

Fork 16

rework saml addon #1588

Merged

MrPetovan merged 5 commits from jakob/friendica-addons:fix-saml-display-settings into develop

2025-01-23 14:31:50 +01:00

jakob commented

2025-01-15 14:36:01 +01:00

Contributor

fix #1587
remove css-side hiding of elements, which was broken.
remove them or make them readonly via javascript

fix #1587 remove css-side hiding of elements, which was broken. remove them or make them readonly via javascript

👍 1

jakob added 1 commit 2025-01-15 14:36:02 +01:00

rework saml addon cbc6dc9caf

fix #1587
remove css-side hiding of elements, which was broken.
remove them or make them readonly via javascript

tobias commented

2025-01-15 17:00:14 +01:00

Owner

As commented in your issue at github, I think the root of the issue comes from different themes in use. Hence the question does your theme work with vier and frio?

As commented in your issue at github, I think the root of the issue comes from different themes in use. Hence the question does your theme work with `vier` and `frio`?

tobias added the

2025.02

label 2025-01-16 06:46:33 +01:00

tobias commented

2025-01-16 07:05:39 +01:00

Owner

I tested your changes with the vier theme, setting the email read only works. However the password fields have different ids (for the wrapper it is wrapper_mpassword not id_wrapper_mpassword).

Another thing. Would it be possible to add a hint to the user that their email and passwords are locked because of the usage of the SAML addon and that they should change their settings there.

I tested your changes with the `vier` theme, setting the email read only works. However the password fields have different ids (for the wrapper it is `wrapper_mpassword` not `id_wrapper_mpassword`). Another thing. Would it be possible to add a hint to the user that their email and passwords are locked because of the usage of the SAML addon and that they should change their settings *there*.

jakob added 1 commit 2025-01-16 18:53:42 +01:00

fix view in vier and frio 56a5f58823

jakob commented

2025-01-16 18:55:06 +01:00

Author

Contributor

I thought about this hint for users...
But this must be translated... i'm not sure, how to handle this.

I thought about this hint for users... But this must be translated... i'm not sure, how to handle this.

👍 1

jakob added 1 commit 2025-01-17 03:05:17 +01:00

replace password-handling with hint 109fa7a766

also add hint to email-field

jakob added 1 commit 2025-01-17 03:06:49 +01:00

Merge branch 'develop' into fix-saml-display-settings 54188f0135

jakob added 1 commit 2025-01-17 03:26:18 +01:00

translation for saml-hint 55ee815660

jakob commented

2025-01-17 12:35:25 +01:00

Author

Contributor

I don't know, how to use transiflex.
Can someone do this task for me?

I don't know, how to use transiflex. Can someone do this task for me?

tobias commented

2025-01-21 06:41:15 +01:00

Owner

Once the PR is merged transifex will update the sources for the translation and will pick up your new string(s). Then they will be presented to the translators who can then translate them.