Should group_text.php be renamed ? #1493

New Issue

Open

opened 2024-03-26 15:51:54 +01:00 by haheute · 6 comments

haheute commented

2024-03-26 15:51:54 +01:00

Contributor

I found that I can't activate the addon "circle_text" in the Admin Settings..
Could it be that the file "group_text.php" should be renamed (maybe to "circle_text.php" )?

Maybe it was forgotten..(?)

I found that I can't activate the addon "circle_text" in the Admin Settings.. Could it be that the file "group_text.php" should be renamed (maybe to "circle_text.php" )? Maybe it was forgotten..(?)

circle_text-addon.jpg

11 KiB

MrPetovan added the

2024.06

label 2024-03-26 16:08:52 +01:00

MrPetovan commented

2024-03-26 16:08:56 +01:00

Owner

Thanks for the catch, to fix this issue, either:

the addon folder should be renamed to group_text to restore the addon active on installs older than the rename.

the addon file should be renamed to circle_text.php for consistency.

Thanks for the catch, to fix this issue, either: - the addon folder should be renamed to `group_text` to restore the addon active on installs older than the rename. OR - the addon file should be renamed to `circle_text.php` for consistency.

haheute commented

2024-03-26 16:11:16 +01:00

Author

Contributor

Okay. I don't know what the addon does, but I believe there was something with renaming groups to circles? So maybe rename the file to circle_text.php?

Okay. I don't know what the addon does, but I believe there was something with renaming groups to circles? So maybe rename the file to `circle_text.php`?

MrPetovan commented

2024-03-26 16:15:53 +01:00

Owner

It's meant to hide profile pictures in circle edition screens. But if the addon folder is renamed like we did, it will be disabled for installs that had enabled it under its former name.

haheute commented

2024-03-26 16:23:16 +01:00

Author

Contributor

if the addon folder is renamed like we did, it will be disabled for installs that had enabled it under its former name

OK. I don't really understand. You have already renamed the folder..(?) Would that not mean it is already "too late" ?
Then it would be no problem to also rename the file to circle_text.php?

I'm confused..

> if the addon folder is renamed like we did, it will be disabled for installs that had enabled it under its former name OK. I don't really understand. You have already renamed the folder..(?) Would that not mean it is already "too late" ? Then it would be no problem to also rename the file to `circle_text.php`? I'm confused..

MrPetovan commented

2024-03-26 17:53:31 +01:00

Owner

Yes, like I said there are two ways to fix this issue, both are valid, and I outlined the consequences for each. Maybe I wasn't clear.

tobias commented

2024-03-27 08:32:47 +01:00

Owner

As the addon could not be activated in its current form, all the installations that had it running had the groups_name addon activated (and likely it is now broken for them).

Maybe we might want to have the original directory name restored, copied it over to circle_name (there change the file name) and then deprecate the group_name addon so that only the circle_addon is available for new installations but the group_name addon keeps working for those using it.

As the addon could not be activated in its current form, all the installations that had it running had the groups_name addon activated (and likely it is now broken for them). Maybe we might want to have the original directory name restored, copied it over to circle_name (there change the file name) and then deprecate the group_name addon so that only the circle_addon is available for new installations but the group_name addon keeps working for those using it.