[advancedcontentfilter] Ship standalone Vue 2 library with addon #1300

Merged
MrPetovan merged 1 commit from bug/12054-advancedcontentfilter-static-vue into develop 2022-10-29 19:34:23 +02:00
MrPetovan commented 2022-10-29 03:18:20 +02:00 (Migrated from github.com)

Fixes https://github.com/friendica/friendica/issues/12054

  • The Composer Bower package stopped including the dist/vue.min.js which was required by the addon
Fixes https://github.com/friendica/friendica/issues/12054 - The Composer Bower package stopped including the dist/vue.min.js which was required by the addon
nupplaphil commented 2022-10-29 09:43:39 +02:00 (Migrated from github.com)

Wouldn't we probably miss security upgrades for Vue because it's no more managed? Isn't this a risk, is it?

Wouldn't we probably miss security upgrades for Vue because it's no more managed? Isn't this a risk, is it?
Quix0r (Migrated from github.com) approved these changes 2022-10-29 15:23:11 +02:00
MrPetovan commented 2022-10-29 18:11:19 +02:00 (Migrated from github.com)

At this point, I don't really care anymore. I tried my best to use two different Javascript package managers and both were utterly disappointing.

I would be curious about the security risks of this particular application, though.

At this point, I don't really care anymore. I tried my best to use two different Javascript package managers and both were utterly disappointing. I would be curious about the security risks of this particular application, though.
nupplaphil commented 2022-10-29 19:34:19 +02:00 (Migrated from github.com)

Hm, sadly but I see ...

Hm, sadly but I see ...
Quix0r commented 2022-10-30 18:06:01 +01:00 (Migrated from github.com)

Cannot we rewrite this to a non-vuejs version?

Cannot we rewrite this to a non-vuejs version?
MrPetovan commented 2022-10-30 19:09:34 +01:00 (Migrated from github.com)

Probably, this addon project was a good opportunity for me to find out what Vue was about but it definitely doesn't have to be using Vue.

Probably, this addon project was a good opportunity for me to find out what Vue was about but it definitely doesn't have to be using Vue.
Sign in to join this conversation.
No description provided.