friendica
/
dir
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
Labels Milestones

Cleanups of "use" and "new" statements #61

Merged
Quix0r merged 2 commits from cleanups/use-app-class into master 4 years ago
Conversation 6 Commits 2 Files Changed 10
Quix0r commented 4 years ago (Migrated from github.com)

Some cleanups:

  • "use" should be executed before any other line (except strict mode line)
  • "import" App class before use it
  • sure braces with "new" operator as this invokes the constructor
  • set CHMOD 777 for Shell script
Some cleanups: - "use" should be executed before any other line (except strict mode line) - "import" App class before use it - sure braces with "new" operator as this invokes the constructor - set CHMOD 777 for Shell script
MrPetovan commented 4 years ago (Migrated from github.com)

Please change the base branch of this PR to develop instead of master currently.

Please change the base branch of this PR to `develop` instead of `master` currently.
😆 1
Quix0r commented 4 years ago (Migrated from github.com)

Oh, sorry. I didn't saw develop. I mean, it doesn't exist here. :)

Oh, sorry. I didn't saw `develop`. I mean, it doesn't exist here. :)
MrPetovan (Migrated from github.com) approved these changes 4 years ago
MrPetovan commented 4 years ago (Migrated from github.com)

Oooh, it's the dir repo! Then in this case it is deprecated and will be archived at some point in the future. Thanks for your contribution though!

Oooh, it's the dir repo! Then in this case it is deprecated and will be archived at some point in the future. Thanks for your contribution though!
👍 1
Quix0r commented 4 years ago (Migrated from github.com)

I have cloned the new repository and will switch to it soon. Thank you for merging it anyway.

I have cloned the new repository and will switch to it soon. Thank you for merging it anyway.
Quix0r commented 4 years ago (Migrated from github.com)

In friendica-directory I have found no develop branch, too. Just to mention it. :-)

In `friendica-directory` I have found no `develop` branch, too. Just to mention it. :-)
MrPetovan commented 4 years ago (Migrated from github.com)

Of course, I had no reason no to merge it, since it isn't archived yet. The official Friendica directory still runs on this codebase, because the new one doesn't completely cover the existing API.

Of course, I had no reason no to merge it, since it isn't archived yet. The official Friendica directory still runs on this codebase, because the new one doesn't completely cover the existing API.

Reviewers

MrPetovan
The pull request has been merged as abda067ca1.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
MrPetovan
Labels
Apply labels
Clear labels
bug duplicate enhancement invalid question wontfix
No Label bug duplicate enhancement invalid question wontfix
Milestone
Set milestone
Clear milestone
No items
No Milestone
Assignees
Assign users
Clear assignees
No Assignees
1 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: friendica/dir#61
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'cleanups/use-app-class'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes