friendica
/
dir
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

wrong download link #28

Merged
MrPetovan merged 7 commits from issue/#25 into master 2017-08-04 03:43:25 +02:00
Conversation 0 Commits 7 Files Changed 15 +120 -67
MrPetovan commented 2017-08-02 03:35:38 +02:00 (Migrated from github.com)
Copy Link

Fixes #25

Fixes #25
tobiasd (Migrated from github.com) reviewed 2017-08-02 05:58:34 +02:00
maintenance.html
@ -0,0 +31,4 @@
</h2>
<p class="about">
The Friendica Directory is unavailable at this time, please connect with <a href="https://friendica.mrpetovan.com/profile/hypolite">hypolite@friendica.mrpetovan.com</a> for updates about its status.
tobiasd (Migrated from github.com) commented 2017-08-02 05:53:16 +02:00
Copy Link

Can we make this link configurable? So that other people running a directory server can change it to another contact account.

Can we make this link configurable? So that other people running a directory server can change it to another contact account.
mod/servers.php
tobiasd (Migrated from github.com) commented 2017-08-02 05:56:02 +02:00
Copy Link

I think after the 2nd if the curly brackets are missing ;-)

I *think* after the 2nd if the curly brackets are missing ;-)
annando (Migrated from github.com) reviewed 2017-08-02 20:04:42 +02:00
annando (Migrated from github.com) left a comment
Copy Link

Just like @tobiasd already said: Having the mail address configurable would be better.

Just like @tobiasd already said: Having the mail address configurable would be better.
mod/servers.php
annando (Migrated from github.com) commented 2017-08-02 19:51:09 +02:00
Copy Link

@tobiasd they could be added - but their missing doesn't provoke a syntax error.

@tobiasd they could be added - but their missing doesn't provoke a syntax error.
mod/stats.php
@ -9,0 +9,4 @@
$view->output();
killme();
}
annando (Migrated from github.com) commented 2017-08-02 19:53:34 +02:00
Copy Link

Weren't these linefeeds only in classes?

Weren't these linefeeds only in classes?
MrPetovan (Migrated from github.com) reviewed 2017-08-02 20:17:17 +02:00
maintenance.html
@ -0,0 +31,4 @@
</h2>
<p class="about">
The Friendica Directory is unavailable at this time, please connect with <a href="https://friendica.mrpetovan.com/profile/hypolite">hypolite@friendica.mrpetovan.com</a> for updates about its status.
MrPetovan (Migrated from github.com) commented 2017-08-02 20:17:17 +02:00
Copy Link

I'm not sure, this is supposed to be an always working page even when nothing else does.

I'm not sure, this is supposed to be an always working page even when nothing else does.
MrPetovan (Migrated from github.com) reviewed 2017-08-02 20:17:41 +02:00
mod/servers.php
MrPetovan (Migrated from github.com) commented 2017-08-02 20:17:41 +02:00
Copy Link

Good catch, I'll add them.

Good catch, I'll add them.
MrPetovan (Migrated from github.com) reviewed 2017-08-02 20:20:13 +02:00
mod/stats.php
@ -9,0 +9,4 @@
$view->output();
killme();
}
MrPetovan (Migrated from github.com) commented 2017-08-02 20:20:13 +02:00
Copy Link

It's possible, this is my IDE formatting setup, I must have had a good reason to set it up like that, or it was like that by default. I'll revert to the most common way across friendica's repos.

It's possible, this is my IDE formatting setup, I must have had a good reason to set it up like that, or it was like that by default. I'll revert to the most common way across friendica's repos.
tobiasd (Migrated from github.com) reviewed 2017-08-03 07:15:29 +02:00
mod/servers.php
tobiasd (Migrated from github.com) commented 2017-08-03 07:15:29 +02:00
Copy Link

No, it's not a syntax error :-)

No, it's not a syntax error :-)
tobiasd (Migrated from github.com) reviewed 2017-08-03 10:10:54 +02:00
maintenance.html
@ -0,0 +31,4 @@
</h2>
<p class="about">
The Friendica Directory is unavailable at this time, please connect with <a href="https://friendica.mrpetovan.com/profile/hypolite">hypolite@friendica.mrpetovan.com</a> for updates about its status.
tobiasd (Migrated from github.com) commented 2017-08-03 10:10:54 +02:00
Copy Link

My bad. When I looked at the code yesterday I had the impression it was a template.

My bad. When I looked at the code yesterday I had the impression it was a template.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: friendica/dir#28
No description provided.
Delete Branch "issue/#25"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?