friendica
/
dir
6
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Cleanups of "use" and "new" statements #61

Merged
Quix0r merged 2 commits from cleanups/use-app-class into master 2019-01-04 01:42:37 +01:00
Conversation 6 Commits 2 Files Changed 10 +23 -23
Quix0r commented 2019-01-03 23:00:30 +01:00 (Migrated from github.com)
Copy Link

Some cleanups:

  • "use" should be executed before any other line (except strict mode line)
  • "import" App class before use it
  • sure braces with "new" operator as this invokes the constructor
  • set CHMOD 777 for Shell script
Some cleanups: - "use" should be executed before any other line (except strict mode line) - "import" App class before use it - sure braces with "new" operator as this invokes the constructor - set CHMOD 777 for Shell script
MrPetovan commented 2019-01-03 23:12:36 +01:00 (Migrated from github.com)
Copy Link

Please change the base branch of this PR to develop instead of master currently.

Please change the base branch of this PR to `develop` instead of `master` currently.
😆 1
Quix0r commented 2019-01-04 00:29:14 +01:00 (Migrated from github.com)
Copy Link

Oh, sorry. I didn't saw develop. I mean, it doesn't exist here. :)

Oh, sorry. I didn't saw `develop`. I mean, it doesn't exist here. :)
MrPetovan (Migrated from github.com) approved these changes 2019-01-04 01:42:19 +01:00
MrPetovan commented 2019-01-04 01:42:24 +01:00 (Migrated from github.com)
Copy Link

Oooh, it's the dir repo! Then in this case it is deprecated and will be archived at some point in the future. Thanks for your contribution though!

Oooh, it's the dir repo! Then in this case it is deprecated and will be archived at some point in the future. Thanks for your contribution though!
👍 1
Quix0r commented 2019-01-04 14:06:22 +01:00 (Migrated from github.com)
Copy Link

I have cloned the new repository and will switch to it soon. Thank you for merging it anyway.

I have cloned the new repository and will switch to it soon. Thank you for merging it anyway.
Quix0r commented 2019-01-04 14:16:57 +01:00 (Migrated from github.com)
Copy Link

In friendica-directory I have found no develop branch, too. Just to mention it. :-)

In `friendica-directory` I have found no `develop` branch, too. Just to mention it. :-)
MrPetovan commented 2019-01-04 15:14:27 +01:00 (Migrated from github.com)
Copy Link

Of course, I had no reason no to merge it, since it isn't archived yet. The official Friendica directory still runs on this codebase, because the new one doesn't completely cover the existing API.

Of course, I had no reason no to merge it, since it isn't archived yet. The official Friendica directory still runs on this codebase, because the new one doesn't completely cover the existing API.
Sign in to join this conversation.
Reviewers
No reviewers
MrPetovan
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: friendica/dir#61
No description provided.
Delete Branch "cleanups/use-app-class"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?