6041f74df6
New constant for federated protocols
2019-07-01 18:00:55 +00:00
3121d967c5
Item delivery data must only be stored when there is data
2019-06-29 08:30:48 +00:00
9bf065c9d8
Merge remote-tracking branch 'upstream/develop' into delivery-statistics
2019-06-28 14:08:54 +00:00
7b4bba66db
Merge pull request #7323 from annando/contact-discovery
...
Removing functionality from OnePoll.php
2019-06-28 07:08:57 -04:00
0a15222576
Collect data about used protocols for delivery
2019-06-28 09:03:58 +00:00
8838a1f2d1
Avoid overwriting of avatars for feeds
2019-06-28 04:26:49 +00:00
4db3c79d04
Archive/unarchive the contacts
2019-06-27 05:03:58 +00:00
Dean Townsley
fdbd160141
Add spaces for standards compliance
2019-06-24 21:37:44 -05:00
Dean Townsley
59553ab978
Don't try to auth for public images
2019-06-24 19:45:50 -05:00
bca1dc1ca4
Moving functionality to the contact model
2019-06-24 03:25:01 +00:00
037cf01a15
Merge remote-tracking branch 'upstream/master' into contact-discovery
2019-06-24 03:23:57 +00:00
fa191bd821
Merge pull request #7305 from deantownsley/imageauthfix
...
Make authentication work for local private images
2019-06-23 15:18:15 -04:00
Michael Vogel
9559266075
todo added
2019-06-23 12:01:14 +02:00
857469d16a
Constantly updating public contacts
2019-06-23 09:27:40 +00:00
Michael Vogel
f84e2e9d93
Fix for distribution of event deletions
2019-06-23 08:41:49 +02:00
Dean Townsley
b5e195b415
Add auth to load sequence for photos
...
This allows private photos to load on any page. Previously auth
depended on some other thing like the enclosing page triggering the
authentication of the specific contact for the photo owner.
2019-06-22 12:24:30 -05:00
14c28868eb
Issue 6477: Use the correct content-type to resize the images
2019-06-20 20:09:33 +00:00
f0849b0a93
Merge pull request #7284 from annando/fix-fatal
...
Don't send activities to "null" endpoints
2019-06-19 23:42:21 -04:00
2e4e8bdf0a
Don't send activities to "null" endpoints
2019-06-20 03:06:34 +00:00
2ba4116118
Merge pull request #7282 from annando/issue-6477
...
Issue 6477: Automatically repair self contact avatar
2019-06-19 16:12:56 -04:00
f878cc2623
Fix for PR 7280
2019-06-19 18:38:22 +00:00
b55546b726
Merge remote-tracking branch 'upstream/2019.06-rc' into issue-6477
2019-06-19 18:26:59 +00:00
6bd5be281e
Normalise it
2019-06-19 17:21:35 +00:00
4ab772ed67
Issue 6477: Automatically repair self contact avatar
2019-06-19 17:05:29 +00:00
b48a49b0f5
Added timeout
2019-06-18 08:05:45 +00:00
ea90554e7f
Fix the base url detection of AP profiles
2019-06-18 07:47:21 +00:00
496910e750
Issue #5983 : Ignore reshares from blocked and ignored contacts
2019-06-17 11:55:19 +00:00
14725bbd6a
Fix undefined index addr notices in Model\Contact::getIdForURL
...
- Addresses https://github.com/friendica/friendica/issues/6918#issuecomment-502393030
2019-06-15 17:16:10 -04:00
f6f22378f1
Ignored stuff must be stored.
2019-06-14 18:34:17 +00:00
2482072457
Issue 5983: Central check for blocked and ignored contacts added
2019-06-14 05:25:10 +00:00
5b291abc7f
Restore show_connect flag in Model\Profile::sidebar
2019-06-13 03:26:42 -04:00
Philipp
6c6e3058f2
Merge pull request #7260 from annando/sanitize-input
...
Sanitize the date for mails
2019-06-13 09:11:41 +02:00
20eb7ae73f
Empty dates are now set to today as well
2019-06-13 05:43:00 +00:00
6970fb2862
Issue 7142: Prevent respawn of "remote self" items
2019-06-13 05:06:52 +00:00
2ae4371606
Sanitize the date for mails
2019-06-13 03:22:15 +00:00
422ebb5d58
Fix notice in Model\Profile
2019-06-12 19:41:15 +00:00
Philipp
fb63274aaf
Merge pull request #7250 from MrPetovan/bug/6410-normalize-message-button
...
Normalize message button in profile sidebar
2019-06-12 17:56:05 +02:00
304c144bc2
Use App::getBaseURL instead of System::getBaseURL in Model\Profile::load
...
Co-Authored-By: Philipp <admin+Github@philipp.info>
2019-06-12 10:56:41 -04:00
76a420fbe9
Avoid fatal error when AP contact has no photo
2019-06-11 05:26:16 +00:00
3aebb92cf3
Rework Profile::sidebar profile link conditions
...
- Now show Follow, Unfollow, Atom Feed and Message in profile sidebar more consistently with the status of the current visitor
- Remove pseudo-field contact.remoteconnect
2019-06-10 21:56:03 -04:00
61c79ce9ee
Add new Model\Contact::canReceivePrivateMessages method
2019-06-10 21:29:11 -04:00
0fbfb7c970
Prevents an endless loop when only the non-public contact is available in Contact::magicLinkByContact
2019-06-10 19:10:39 -04:00
d7d44e1af7
Merge pull request #7245 from annando/unify-constants
...
Fix delivery counter for poking / unify delivery commands
2019-06-10 11:59:40 -04:00
41dc243186
Fix delivery counter for poking / unify delivery commands
2019-06-10 14:19:24 +00:00
165607ffe7
Merge pull request #7242 from nupplaphil/bugs/6917-php_warning
...
Add typed parameter for methods in `Friendica\Util\Network`
2019-06-10 09:22:27 -04:00
Philipp Holzer
cc7444d84d
Move internal recursion-counter to the end of all cur/fetchUrl parameters
2019-06-10 14:34:54 +02:00
1c6bf7d25a
Add App parameter to Module\Profile::sidebar method prototype
2019-06-10 08:21:06 -04:00
Philipp Holzer
236c0dc248
Check $contact['id']
...
- see https://github.com/friendica/friendica/issues/6918#issuecomment-498043313
2019-06-10 12:36:42 +02:00
44a49a8d7d
Ensure that pokes are always send only via DFRN
2019-06-06 04:26:02 +00:00
f0de19dd8a
Merge pull request #7208 from nupplaphil/bug/6916-filetag
...
Adding null checks before FileTag method (fix fatal)
2019-05-31 01:47:52 -04:00
Philipp Holzer
c76258c370
catching nulls for FileTag
2019-05-30 13:54:35 +02:00
Philipp Holzer
694cd82d0e
Bugfix - author-network (adding to unset list during insert)
2019-05-29 21:48:03 +02:00
Philipp Holzer
7334be803d
Bugfix - item_id
2019-05-29 21:40:21 +02:00
Philipp Holzer
766a10b3b6
Adding author-network to ITEM::ITEM_FIELDLIST
...
see https://github.com/friendica/friendica/issues/6918#issuecomment-493515358
2019-05-29 20:09:20 +02:00
Philipp Holzer
15ffb70c5f
Adding item_id to Item::ITEM_FIELDLIST
...
see https://github.com/friendica/friendica/issues/6918#issuecomment-493515358
2019-05-29 20:08:21 +02:00
Philipp
9245942a0c
Merge pull request #7199 from MrPetovan/bug/7171-filer-network
...
Allow commas in saved folder names
2019-05-29 07:03:44 +02:00
Philipp
e557457158
Merge pull request #7201 from annando/mail-db-error
...
Fix Issue 7196
2019-05-28 20:02:39 +02:00
ae940755c7
Fix Issue 7196
2019-05-28 17:39:26 +00:00
6de3449cae
Add new fileToArray and arrayToFile methods to Module\FileTag
2019-05-27 17:38:36 -04:00
96402e306a
Fix formatting of Model\FileTag
...
- Normalize indent style
- Remove extraneous new lines after ifs/foreachs
2019-05-27 17:38:32 -04:00
Philipp
5c2cca432f
Merge pull request #7170 from MrPetovan/bug/6981-contact-request-blocked
...
Contact requests blocked
2019-05-25 20:20:36 +02:00
14a78807d7
Use self::isBlocked and self:isBlockedByUser in Model\Contact::addRelationship
2019-05-20 16:34:17 -04:00
62dfcbb074
Prevent contact relationships with node- or user-level blocked contacts
2019-05-20 15:29:20 -04:00
ea77f214d7
Add return value to Model\Contact::addRelationship to remove protocol-specific code from it
2019-05-20 15:29:20 -04:00
3114754f4b
Refactor Model\Contact::addRelationship
...
- Remove unused parameter $item
- Replace q() call with DBA::insert
- Update check on $contact that can only be an array now
- Add moethod doc block
2019-05-20 15:29:20 -04:00
c65faecc8c
Add current tab parameter to Model\Profile::getTabs
2019-05-20 15:09:33 -04:00
709eba6ce3
Move /viewcontacts to /profile/{nickname}/contacts[/{type}]
...
- Add contact relationship filter to profile contacts page
- Include feed contacts in contacts page and contact widget
2019-05-20 14:50:09 -04:00
Philipp Holzer
5f068b07f9
some improvements
2019-05-19 03:12:22 +02:00
Philipp Holzer
8bb85b1da7
Move mod/randprof to src/Module/RandomProfile
2019-05-18 22:17:57 +02:00
79cb5b1bae
Add block reason editing in Model\Contact
2019-05-15 19:28:00 -04:00
a14f868134
Make Module\TwoFactorRecoveryCode::markUsedForUser return false for already used code
...
- Add PHP Doc in Module\TwoFactorRecoveryCode
2019-05-13 13:32:21 -04:00
a7feb4bf9f
Add Two-factor recovery code model
...
- [DBA] Add NULL value handling in condition array
2019-05-13 01:52:00 -04:00
f04bb820ad
Magic links should work again
2019-05-10 07:38:10 +00:00
d9f6a58229
Mail: Set the "reply" value when it is a reply
2019-05-09 20:52:52 +00:00
b8a23369b6
Mail storing is now centralized
2019-05-08 05:44:22 +00:00
626709159f
Some cleaning up
2019-05-06 18:46:30 +00:00
bb8d297ae4
Merge pull request #7097 from nupplaphil/task/mod_after_PR_fixing
...
Fixings for Mod-Refactorings
2019-05-05 20:28:57 -04:00
8af0ae171e
Merge pull request #7083 from nupplaphil/task/mod_friendica
...
Move mod/friendica to src/Module/Friendica
2019-05-05 14:19:57 -04:00
039f9490dd
Optimized Profile::searchProfiles & Bugfix Contact::getProbeDataFromDatabase
2019-05-05 18:40:36 +02:00
0244a231d5
Fixes "parent-guid" notice - finally
2019-05-05 15:48:57 +00:00
f3cae4bf0c
Fixes notices
2019-05-05 14:12:43 +00:00
e17db489ee
Merge pull request #7095 from annando/ap-connect
...
Switching from legacy DFRN connect to ActivityPub
2019-05-05 09:37:43 -04:00
0efab157c4
Reverted storing the protocol at all the time
2019-05-05 10:36:51 +00:00
Michael Vogel
2365193691
AP: Support of request messages
2019-05-05 11:17:45 +02:00
9123361d61
added feedback
2019-05-05 10:00:28 +02:00
6f787f2422
Move mod/friendica to src/Module/Friendica
2019-05-04 10:14:29 +02:00
Philipp
c9cce8492e
Merge pull request #7000 from MrPetovan/task/6999-no-probe-magic-link
...
Remove probing in magic link construction
2019-05-03 08:43:26 +02:00
Michael Vogel
33931ff15e
Corrected order
2019-05-03 08:13:02 +02:00
b1222e174e
Ensure that an existing contact isn't archived or pending
2019-05-03 05:54:40 +00:00
Michael Vogel
949fd1e8bf
Fixes undefined variable
2019-05-03 06:01:01 +02:00
8010ccdc21
Merge pull request #7072 from nupplaphil/task/mod_directory
...
Move mod/directory to src/Module/Directory
2019-05-02 20:03:13 -04:00
d48b100f78
Merge pull request #7069 from nupplaphil/task/mod_allfriends
...
Move mod/allfriends to src/Module/AllFriends
2019-05-02 20:03:05 -04:00
47d03058d1
Added feedback
2019-05-02 23:26:02 +02:00
e6bf97777f
Remove /display/{nick}/{id} URL structure publishing
...
- Remove support for defunct Friendica F-Droid app
2019-05-02 17:04:17 -04:00
2e9b2d72be
Move mod/directory to src/Module/Directory
2019-05-02 22:49:33 +02:00
c5e7abf9c5
Move mod/allfriends to src/Module/AllFriends
2019-05-02 22:03:27 +02:00
a4dffee5f4
Fix wrong error message when updated a contact
2019-05-02 19:22:43 +00:00
Philipp
2628da422a
Merge pull request #7068 from MrPetovan/task/7047-theme-error-page
...
Themed error page redux
2019-05-02 21:15:29 +02:00
Philipp
774d04cd2f
Merge pull request #7044 from MrPetovan/task/router
...
Move mod/admin to src/Module/Admin
2019-05-02 18:26:30 +02:00
41f781c52a
Replace System::httpExit() by HTTPException throwing
2019-05-02 11:37:09 -04:00
Philipp
07cb887885
Merge pull request #7067 from MrPetovan/task/remove-app-error
...
Remove App->error
2019-05-02 17:24:56 +02:00
71546705f8
Add Model\Contact::select method
2019-05-02 09:55:49 -04:00
9774c95b80
Remove duplicate $baseurl template variable
...
- Remove unused $overwriteURL parameter in Renderer::replaceMacros
2019-05-02 09:55:48 -04:00
28f316b7e4
Replace the legacy DFRN connection process with AP
2019-05-02 13:05:31 +00:00
7b1ea6cad6
Remove App->error
2019-05-01 21:17:03 -04:00
90248f6bb7
Move .well-known, webfinger, xrd to src/Module/
2019-05-01 18:25:04 +02:00
eef85584c2
AP: Parsing of messages from Pleroma should work now again
2019-04-26 06:17:37 +00:00
0e29ec200f
Follow up to #7036 : Automatically update AP contacts
2019-04-25 05:24:53 +00:00
ffd6896bd2
Probing of Pleroma contacts does work again
2019-04-24 20:08:43 +00:00
Philipp
2376399168
Merge pull request #7034 from annando/api-announce
...
API: Fix the displaying of reshared posts
2019-04-24 09:07:52 +02:00
dd7406f285
API: Fix the displaying of reshared posts
2019-04-24 04:26:23 +00:00
5233434d94
proper split cronjob functions
2019-04-22 14:22:00 +02:00
6056081d5a
Move mod/nodeinfo to src/Module/Nodeinfo
2019-04-22 14:00:17 +02:00
49d12b5fae
Remove probing in magic link construction
...
- Use Contact::getProbeDataFromDatabase and Contact::magicLinkByContact instead of Contact::getIdForURL and Contact::magicLinkbyId in Contact::magicLink
- Add default value for $cid parameter in Contact::getProbeDataFromDatabase
2019-04-12 08:50:44 -04:00
6a2c0b3cc7
Merge pull request #6989 from nupplaphil/task/basePath_baseUrl_fix
...
Automatic BaseURL determination fix
2019-04-11 04:07:20 -04:00
4e9316fc15
Fix warnings
2019-04-09 17:58:28 +00:00
8748aff110
Avoid some more warning
2019-04-09 11:44:35 +00:00
d58147413f
Avoid update of non native contacts, fix most warnings
2019-04-09 11:28:45 +00:00
84a6e390ab
Fetch data from the given contact number, if already present
2019-04-09 08:47:57 +00:00
bca7419987
Avoid overwriting existing contacts with bad data
2019-04-09 08:35:29 +00:00
318a3ca785
Create own base URL class which holds the whole base url business logic
2019-04-09 08:31:16 +02:00
90eea919a4
New contact field "updated", fix warnings
2019-04-09 05:15:23 +00:00
a2ca14def4
Removed a worker call - this needs more work
2019-04-08 21:35:00 +00:00
c088249e1b
Update the contact in the background
2019-04-08 21:05:33 +00:00
f387d85cdb
Fetch profile data from different contact tables when we won't or can't probe via network
2019-04-08 20:41:18 +00:00
46a99a05a1
Remove the queue from the core
2019-04-05 18:04:39 +00:00
cbe574f6f6
Preparation to be able to store "announce" activities
2019-03-28 05:45:50 +00:00
2df2f623e1
Store the follow activity in the "item-activity" table
2019-03-27 21:46:32 +00:00
55325f191b
Merge remote-tracking branch 'upstream/develop' into ap-delivery-failure
2019-03-26 21:36:46 +00:00
fe0c516c3f
Added field for "shared" inbox
2019-03-26 05:14:47 +00:00
18f3ff7b8e
Unarchive inboxes on profile update
2019-03-25 22:43:00 +00:00
6473e5a069
typo
2019-03-22 22:56:57 -04:00
8237e73e26
Adding REAMDEs to directories
2019-03-22 22:56:57 -04:00
083820b107
Moving mod/feedtest to src/Module/Feedtest
2019-03-22 22:55:49 -04:00
dbfb0b6cff
Added app class variable
2019-03-19 06:57:37 +00:00
0aab620d32
Enable remote authentication with HTTP Signatures
2019-03-19 06:44:51 +00:00
cd0d6cb626
Forums now are working with AP as well
2019-03-14 18:44:41 +00:00
35ff932613
Follow up to 6834: Don't store item when the server is blocked
2019-03-10 21:19:21 +00:00
6f07bfb772
Add missing fields to Register::getPending()
...
- Addresses https://github.com/friendica/friendica/issues/6338#issuecomment-470882973
2019-03-08 21:57:18 -05:00
e89d56be6d
Improved contact update from probe
2019-03-07 00:13:39 +00:00
7217d24a97
Replace isset by array_key_exists on array class constant in Model\Term
...
- Addresses https://github.com/friendica/friendica/issues/6386#issuecomment-467835406
2019-02-27 08:00:04 -05:00
bd7aaacfb0
fixing links in photoMenu
2019-02-26 10:19:08 +01:00
82072bae46
Add missing use statement in Model\Term
2019-02-24 13:33:11 -05:00
Michael Vogel
fa5525d084
Merge pull request #6726 from MrPetovan/task/6676-fix-implicit-mentions
...
Fix last batch of implicit mentions issues
2019-02-24 15:40:11 +01:00
Michael Vogel
df5ea1fab0
Merge pull request #6732 from MrPetovan/bug/1777-fix-blocked-contact-group
...
Allow to remove blocked contact from groups
2019-02-24 14:30:36 +01:00
dbcca9cfac
Hide "never" on profile
2019-02-23 18:37:51 -05:00
7ab986bc97
Move group module to src/
2019-02-23 17:32:40 -05:00
b939faf4ef
Add contact removal from all groups when blocked
2019-02-23 17:32:40 -05:00
f4745c5936
Add doc to Model\Term
2019-02-23 17:32:13 -05:00
67aa188830
Improve Logger calls
...
- Add context in various calls
- Remove deprecated Logger::log call in Processor
2019-02-23 17:32:13 -05:00
8c1db51a76
Improve Logger calls
...
- Replace various deprecated Logger::log calls
- Reassign log level for verbose log calls
2019-02-23 17:32:11 -05:00
1917f04153
Rewrite Term class
...
- Move term type constants from TERM_* to Term::*
- Move term object type constants from TERM_OBJ_* to Term::OBJECT_TYPE_*
- Add Term::isType() method
- Add Strings::startsWith() method
2019-02-23 17:32:11 -05:00
7320c5e8e8
Normalize Contact::magicLinkByContact method name
2019-02-23 17:32:10 -05:00
8c3aebc376
Bugfixings in Config
...
- replaced usage of "!<unset>!" with null-returns
- fixed bool settings (0/1)
- fixed overriding config-values
- fixed basepath problems
2019-02-22 23:51:13 +01:00
4375edd63e
Merge pull request #6719 from annando/worker-scheduler
...
New scheduler mechanism - now to the correct branch
2019-02-21 16:12:19 -05:00
3450f12cba
Changed log calls
2019-02-21 19:32:31 +00:00
9fa812b35d
Rewrites:
...
- converted single-line if() block to multi-line and with curly braces
- "imported" SPL classes to have unified code style
- always initialize your variables ... :-/
- added some empty lines/spaces for better readability
Signed-off-by: Roland Häder <roland@mxchange.org>
2019-02-19 01:56:41 +01:00
rabuzarus
c59ba94648
fix magic links for item mentions
2019-02-17 17:19:57 +01:00
73ecf2100e
Indentions
2019-02-13 10:22:36 +00:00
44ac0275ab
Issue 6603: Events are now fetchable via AP
2019-02-13 07:17:19 +00:00
8cb2ab2a90
Should fix "DB Error 1205: Lock wait timeout exceeded; try restarting transaction"
2019-02-12 21:10:45 +00:00
6fd8b5f365
Don't send single item delete commands to protocols that support account removal
2019-02-11 20:30:08 +00:00
7939cacc44
The function moved from the user to the contact class
2019-02-10 17:19:10 +00:00
758eabd2f6
Removed test output
2019-02-10 12:21:16 +00:00
f88a1c0b51
Merge branch 'check-follow' of github.com:annando/friendica into develop
2019-02-10 11:29:58 +00:00
cf3a46b126
Don't store multiple follow request from a single person
2019-02-10 11:28:17 +00:00
b6e2c254fb
Merge pull request #6616 from m4sk1n/patch-1
...
fix typo
2019-02-10 08:12:58 +01:00
marcin mikołajczak
12a44c7bb9
fix typo
2019-02-09 08:42:55 +01:00
e6a75b2609
Add alias field to ActivityPub contacts
2019-02-08 22:32:50 -05:00
7572843083
Merge pull request #6601 from annando/false-notifications
...
Hopefully final fix for false notifications
2019-02-07 08:41:56 -05:00
ebe767b290
Hopefully final fix for false notifications
2019-02-07 05:38:43 +00:00
a0b14a46cb
Merge pull request #6581 from nupplaphil/config_refact
...
Config Refactoring
2019-02-06 09:57:41 -05:00
633d04049b
Lower priority for removing users
2019-02-03 23:55:46 +00:00
1e0e1674f2
4) Adding Factories to other entrypoints
2019-02-03 22:46:50 +01:00
9525e07971
Fix greedy regular expression and move code block escaping after tag extraction in Model\Item
2019-01-29 20:25:51 -05:00
2bd62bfdea
Merge pull request #6554 from Ixiter/develop-bbcode-tags
...
Fixed some bugs with weird tagging in [code] blocks and tagging of multiple ##
2019-01-29 17:11:54 -05:00
Peter Liebetrau
c3e5c77eb3
BBcode, Tags - changes for #pullrequestreview-197771905
2019-01-29 22:34:28 +01:00
Peter Liebetrau
5080778ea6
BBcode, Tags - moved [code] escaping before BBCode::getTags() call
2019-01-29 21:54:20 +01:00
Peter Liebetrau
87b1d0a4d7
BBcode, Tags - fixed doubbbllee trroubbllee
2019-01-29 21:35:11 +01:00
Peter Liebetrau
d8bd1921ee
BBcode, Tags - fix BBCode created tags in [code] blocks, fix usage of multiple ## created tags
2019-01-29 21:17:11 +01:00
8d84f33f15
Merge pull request #6541 from annando/mentions
...
Display mentioned users and in the comment box by default
2019-01-29 07:56:30 -05:00
fabrixxm
a7d45682e7
Filesystem storage: handle basepath with trailing slash
2019-01-29 12:36:23 +01:00
fabrixxm
ec94318a35
Filesystem storage: set permission on folders and files
...
files are set 0660 and folders 0770.
fix #6545
2019-01-29 12:35:30 +01:00
d40b2792b6
Display mentioned users and in the comment box by default
2019-01-28 21:22:03 +00:00
7cba8942c7
Fix: Connector posts now do work again (postopts hadn't been stored)
2019-01-24 21:06:53 +00:00
49c9b6f9ff
Fix possibly undefined variables
2019-01-23 09:06:59 -05:00
64847e7cc8
Fix types in doc blocks/prototypes
2019-01-23 09:06:58 -05:00
5ea033db33
Remove unused variable in Model\Item
2019-01-23 09:06:58 -05:00
d5ce74672e
Fix method scope in Model\Attach
2019-01-23 09:06:57 -05:00
aa3532cd3b
Fix wrong class constant in Model\APContact
2019-01-22 01:57:46 -05:00
504945f9df
Improve page flags doc block in Model\User
2019-01-21 11:12:53 -05:00
41edcd1028
Fix bad rebase in Model/Contact
2019-01-21 11:12:52 -05:00
3c50a11ff1
Fix wrong operators in Model\Item and Model\Contact
2019-01-21 11:12:51 -05:00
28397fc5fc
Fix method parameter type in Model\Attach
2019-01-21 11:12:50 -05:00
57ab858486
Fix calls to DBA::select missing parameters
2019-01-21 11:12:50 -05:00
7f2dc40601
Fix potential bugs without expected behavior change
...
- Fix uninitialized variables
- Fix potentially not set variables
- Fix wrong parameter default value
- Fix method scope
- Fix missing return value
2019-01-21 11:04:19 -05:00
3d839bb176
Move Contact::ACCOUNT_TYPE_* constants to User::ACCOUNT_TYPE_*
...
- Keep Contact::TYPE_* constants for comparison with contact.contact-type
2019-01-21 10:56:27 -05:00
ad9c67663d
Move Contact::Page_* constants to User::PAGE_FLAGS_*
2019-01-21 10:55:37 -05:00
11a4a57bfe
Update HTML::contactBlock and Profile::load with new ContactBlock widget
2019-01-21 10:55:36 -05:00
4a95ca280d
Remove unused code
...
- Remove commented code
- Remove unused/immediately overwritten variables
- Remove extraneous parameters
- Remove unreachable code
- Remove duplicate array keys
2019-01-21 10:48:40 -05:00
cb3f09ae4f
Refactor namespaces
...
- Remove unused use statements
- Add required use statements
- Escape global classes
2019-01-21 10:43:42 -05:00
070aa016e0
Update more PHPDoc, including in include/
2019-01-21 10:39:28 -05:00
af9067a381
Update PHPDoc in mod/
2019-01-21 10:39:27 -05:00
3282ce5389
Fix PHPDoc comments project-wide
2019-01-21 10:35:51 -05:00
fabrixxm
24d7ffa3fe
Update "storage" console command
...
add support to move data in 'attach' table
2019-01-21 10:00:48 -05:00
fabrixxm
b640024b51
Item model, fix deletion of all attachments
...
Item model delete all attachments on item deletion, but it should check
if same attachment isn't used somewhere else.
2019-01-21 10:00:45 -05:00
fabrixxm
906b7841d4
Fix Attach model store() and storeFile()
2019-01-21 10:00:45 -05:00
fabrixxm
15b0a7a4d8
Photo model. Small fix to update()
...
pass `$old_fields` param to `DBA::update()`
2019-01-21 10:00:45 -05:00
fabrixxm
b7b3086263
Attach: store, update, delete. Model and views
2019-01-21 10:00:44 -05:00
fabrixxm
fc2b804ccc
Move mod/attach to src, add Attach model, update attach table to use storage backends
2019-01-21 10:00:44 -05:00
55e54bb950
Replace deprecated Addon::callHooks with Hook::callAll
...
- Update documentation
2019-01-21 09:50:56 -05:00
16fabb4e04
Replace misuses ItemDeliveryData::FIELD_LIST with LEGACY_FIELD_LIST
2019-01-21 09:39:15 -05:00
38734f17b9
Honor item delivery data legacy fields
2019-01-21 09:39:15 -05:00
85eb6affdf
Unit test fix
2019-01-21 09:39:14 -05:00
1696ad962e
Add delivery queue number manipulation
...
- Add new ItemDeliveryData model class
- Add queue_count initialization in Notifier
- Add queue_done incrementation in various Delivery tasks
2019-01-21 09:36:51 -05:00
dea1a98a5d
Fix various documentation issues/unused variables
2019-01-21 09:33:24 -05:00
578a391393
Add missing methods to Storage\SystemResource
...
Part of #6263
2019-01-21 09:12:31 -05:00
fabrixxm
bbbc15a5eb
Method getPhoto of Photo model should return false on error
...
Instead of red circle image, which breaks proxy module
2019-01-21 09:12:31 -05:00
fabrixxm
4e38bc8a0d
Use DBA::exists() in Photo::exists()
2019-01-21 09:12:31 -05:00
fabrixxm
55292c954b
Remove resourceid parameter from Photo::exists()
2019-01-21 09:12:29 -05:00
fabrixxm
8c75c26361
Use Model\Photo as much as possible
...
Most important is to use `Photo::delete()` to have backend
to remove data.
2019-01-21 09:12:28 -05:00
fabrixxm
d549787bc1
Remove empty line before code
2019-01-21 09:11:41 -05:00
fabrixxm
15a3fc05d3
Photo model: set edited and updated on update, fix exists(), docs
2019-01-21 09:11:40 -05:00
fabrixxm
fdc6608af8
Add storage options form in admin/site page
2019-01-21 09:11:39 -05:00
fabrixxm
6a0ed7c298
Add storage backend manager class
2019-01-21 09:11:34 -05:00
fabrixxm
e5c2d4e2f8
Add Database storage backend
...
This storage store files data in a separate database table
2019-01-21 09:11:33 -05:00
fabrixxm
6e85a18678
Storage: throw StorageException on errors
2019-01-21 09:10:47 -05:00
fabrixxm
7df3f117ac
Photo model: fix docs, don't update "created" field
...
in store() if photo exists, don't update "created" timestamp
2019-01-21 09:10:47 -05:00
fabrixxm
6f59c82978
Code standards
2019-01-21 09:10:46 -05:00
fabrixxm
69fcdaf9ab
Photo model: set updated field in update()
2019-01-21 09:10:45 -05:00
fabrixxm
3e13799e70
Add update() to Photo model
...
Edit mod/photos.php to use Photo model
2019-01-21 09:10:45 -05:00
fabrixxm
cbb5124d59
Code standards
2019-01-21 09:02:57 -05:00
fabrixxm
ea0cd6c919
Filesystem storage: add "index.html" files in dirs
2019-01-21 09:02:57 -05:00
fabrixxm
234c110d38
Model/Photo: use self select functions, reuse backend, fix quotes, add delete()
2019-01-21 09:01:52 -05:00
fabrixxm
9317a1c054
Address code standards issues
2019-01-21 08:57:30 -05:00
fabrixxm
12dd7b552f
Add Filesystem storage backend and store photo via backend
2019-01-21 08:57:29 -05:00
fabrixxm
9b2e3fa916
Add IStorage interface
...
storage classes should implement this interface
2019-01-21 08:57:29 -05:00
fabrixxm
3b3c4e8cc7
Pluggable storage backends: first steps
...
- add backend related columns in photo table
- add system resource storage class
- add code to load image data from backend class
- return "nosign" image as photo meta with SystemResource backend
2019-01-21 08:57:28 -05:00
fabrixxm
b96dbcd4cb
Move Photo module, update Photo model
2019-01-21 08:40:47 -05:00
Jeroen De Meerleer
4d81158dd1
Translated gender etc. in profile view
2019-01-21 08:40:45 -05:00
rabuzarus
528d175baa
Bugfix - provide magic links for remote user in magicLink()
2019-01-18 17:50:21 +01:00
c8bfa0c661
Bugfix: Private posts of contacts hadn't been displayed on the contact's page
2019-01-18 06:22:15 +00:00
c359c162a7
Issue 6282: Update the contact data regularly (including the network)
2019-01-16 21:39:56 +00:00
5554448162
Now storing the "manually approve" data / fix update routine
2019-01-14 06:36:08 +00:00
c1dec50248
Avoiding some notices
2019-01-13 18:03:13 +00:00
d113ccd93c
Making Friendica compatible to Nextcloud Social
2019-01-13 09:38:01 +00:00
297a549590
Issue 6282: Update the forum status of contacts
2019-01-12 16:09:27 +00:00
c4038e7af1
Merge pull request #6432 from annando/deleted-pending
...
Don't show deleted contacts, changed "pending" behaviour
2019-01-12 09:08:31 -05:00
28f14c7d60
Don't show deleted contacts, changed "pending" behaviour
2019-01-12 13:28:14 +00:00
abf20368b0
Rework Profile::getThemeUid to ignore query parameter and include $a->profile_uid
...
- Use new version in frio default.php file
- Use new version in Theme::getStylesheetPath
2019-01-12 02:23:01 -05:00
59f701d5a9
Merge pull request #6419 from annando/unfollow
...
Unfollow should now work with Pleroma again
2019-01-10 11:08:23 +01:00
6bc865ff4d
Merge pull request #6356 from MrPetovan/task/6355-add-password-rules
...
Add password rules
2019-01-10 10:37:32 +01:00
1a702359f1
Unfollow should now work with Pleroma again
2019-01-10 07:24:12 +00:00
6ae6a8a983
Don't show deleted contacts, set new AP contacts as "pending" until they are accepted
2019-01-09 13:23:11 +00:00
e447375cdd
Merge branch '2019.01-rc' into bug/6334-escape-get-app
2019-01-06 16:38:48 -05:00
7e19506435
Issue 6394: The contact location has to be BBEncoded
2019-01-06 21:04:10 +00:00
3022abe74c
Reset the "forum" and "prv" field
2019-01-05 23:02:58 +00:00
e88734e218
Periodically update contacts / update the contact type
2019-01-05 22:04:32 +00:00
5e1ceb57de
Escape global namespaced get_app() calls
...
- Add deprecated status
2019-01-03 21:27:36 -05:00
e86b8ef782
Use nickname instead of email for Login Name
2019-01-03 20:42:29 -05:00
rabuzarus
67a8f9dbd4
Bugfix - the remote user also has magicLinks again
2019-01-02 17:47:53 +01:00
58adb5b431
Add password checks in User::updatePassword
2019-01-01 01:15:51 -05:00
909c9d0309
Increase auto-generated passwords to 12 chars + leading capital
2019-01-01 01:14:45 -05:00
961f737f36
Use User::updatePasswordHashed directly when re-hashing a password
2019-01-01 01:14:44 -05:00
Michael Vogel
94eca77041
Merge pull request #6315 from MrPetovan/bug/6309-add-fulltext-index-profile
...
Rework mod/match and mod/msearch
2018-12-27 18:04:06 +01:00
620395378e
Normalize uses of Strings::formatNetworkName to $network_link
...
- Unescape HTML template variable $network_link
2018-12-26 11:11:38 -05:00
f274357ad6
Issue-6329: Prevent double encoding
2018-12-26 11:21:42 +00:00
a8b0aa8c8d
Normalize expected format for event fields summary, desc and location
...
- Remove unnecessary HTML escaping on event submit
- Add HTML escaping on event display
- Add HTML to BBCode conversion for received ActivityPub events
2018-12-24 23:00:35 -05:00
c9c9fc3a96
Code cleanup in events
...
- Replace killme() with exit()
- Use correctly escaped query string
- Simplify perms2str input filtering
- Add expected json header to /events/json
2018-12-24 23:00:35 -05:00
acaee626f5
Remove include/ requires that are now done directly from Composer
2018-12-24 09:56:25 -05:00
faa30adf68
Handles issue 6122 - the self contact will be updated when it seems to be invalid
2018-12-22 20:12:32 +00:00
b6e1571b1e
Fix various notices
2018-12-15 04:32:47 -05:00
b08e5ab41b
Issue 6259: Suppress contact group widget only on network page
2018-12-14 06:33:57 +00:00
5a802bc474
Merge pull request #6261 from annando/fix-magic
...
Fix for magic auth
2018-12-13 17:03:44 -05:00
9ea0864394
Some added to-do
2018-12-13 21:41:19 +00:00
705211100b
Fix for magic auth
2018-12-13 21:19:57 +00:00
7c11194a2c
Use Contact::isFollower instead
2018-12-13 11:53:15 -05:00
096093766a
Add check for relationship with remote user for connect display
2018-12-12 22:22:43 -05:00
f2e2066d33
Non public content is now displayed again to visitors.
2018-12-09 13:09:49 +00:00
8fbe0d46e9
Fix for remote authentication when visiting contact's pages
2018-12-08 20:28:01 +00:00
95c150ef28
Added to-do
2018-12-04 14:20:25 +00:00
5c20f21dd8
Improved fallback when the probing fails
2018-12-04 14:17:55 +00:00
491fc5f78a
Issue 6168: "redir" now mostly use OWA
2018-12-04 07:12:55 +00:00
3a9db3f637
Merge pull request #6222 from annando/long-uri
...
Avoid problems with too long URI (should only happen with some RSS feeds)
2018-12-02 19:18:45 -05:00
c5558cc459
Merge pull request #6224 from annando/dba-delete-contact
...
Avoid duplicated contacts, improve contact deletion, avoid memory issues
2018-12-02 16:16:59 -05:00
066a040cc7
Avoid duplicated contacts, improve contact deletion, avoid memory issues
2018-12-02 16:25:25 +00:00
3d14977b73
Avoid problems with too long URI (should only happen some RSS feeds)
2018-12-02 14:49:28 +00:00
Michael Vogel
5a3991d4f7
Merge pull request #6219 from MrPetovan/task/remove-x
...
Remove x()
2018-12-01 23:40:51 +01:00
458981f75c
Replace x() by isset(), !empty() or defaults()
...
- Remove extraneous parentheses around empty() calls
- Remove duplicate calls to intval(), count() or strlen() after empty()
- Replace ternary operators outputting binary value with empty() return value
- Rewrite defaults() without x()
2018-11-30 09:06:22 -05:00
Jonny Tischbein
f0d290eb18
Fix Term exists check on link which isn't stored for hashtags anymore to check on term.
2018-11-27 22:54:16 +01:00
92556e5161
Fix user account removal expiration delay
2018-11-24 20:59:18 -05:00
54f4ac6ae0
Remove redirection from User::remove
2018-11-24 20:58:41 -05:00
0dd120bb06
Normalize quotes in User::remove
2018-11-24 20:58:11 -05:00
0bae80a2d3
Update deprecated calls in Model\user and mod/removeme
2018-11-24 20:56:38 -05:00
9d2f474c07
Fix open registration email
2018-11-24 20:55:18 -05:00
Michael Vogel
3f4636d490
Merge pull request #6183 from MrPetovan/bug/6135-hide-follower-only-birthdays
...
Hide follower-only birthday reminders
2018-11-24 15:55:43 +01:00
6b845b35d3
Merge pull request #6197 from annando/hide-short-groups
...
Don't show the group filter where there is only one
2018-11-24 08:22:43 -05:00
Michael Vogel
42a3610a79
Merge pull request #6184 from MrPetovan/task/normalize-bbcode-hashtags
...
Normalize BBCode hashtags links
2018-11-24 13:14:50 +01:00
a3a2147def
Don't show the group filter where there is only one
2018-11-24 12:10:30 +00:00
fb0140a62b
Checking for blocked user does now check for blocked domain as well
2018-11-22 21:43:16 +00:00
81f89ccae8
Remove stored URL from hashtag terms
2018-11-22 09:33:42 -05:00
4874f7f8ab
Remove useless rawurlencode calls for building hashtag bbcode
...
- Fix some formatting
2018-11-22 09:32:41 -05:00
14df030f44
Add contact conditions to getBirthdays/updateBirthdays
2018-11-22 00:15:44 -05:00
de5ee56d2f
Move DFRN::birthdayEvent() to Event::createBirthday
2018-11-22 00:15:09 -05:00
d71e856535
Replace remaining occurrences of "0001-01-01" with DBA::NULL_DATE
2018-11-21 23:53:45 -05:00
Jonny Tischbein
458b0f3545
Change how to decide between empty update and not called field file
2018-11-17 16:04:54 +01:00
Jonny Tischbein
56406b9910
Fix SQL Error if no items where found + Fix setting to null
2018-11-17 13:22:32 +01:00
Jonny Tischbein
52eb2281e4
Fix deleting last element from saved folder + Fix displaying empty saved folder
2018-11-17 12:41:00 +01:00
6ad082a710
Improved delete text to clarify AP comment delete behaviour
2018-11-15 06:36:06 +00:00
b5fa518998
Don't suggest hidden contacts / Added AP to the suggestions
2018-11-13 05:52:21 +00:00
aaae7b56df
Replace obsolete Addon::callHooks call with Hook::callAll in Model\Contact
2018-11-10 08:18:16 -05:00
Adam Magness
218f0734be
Rename removeTags to escapeTags
...
rename function and update calls.
2018-11-09 13:29:42 -05:00
Adam Magness
063f0e9cb0
Rename escapeTags to escapeHtml
...
rename function and update calls.
2018-11-09 13:27:58 -05:00
Adam Magness
b5a97c1abe
Move getTags to BBCode
...
move getTags function to BBCode class and update calls.
2018-11-09 13:24:19 -05:00
Adam Magness
e4354a0d7b
Update and Remove isValidEmail
...
change function calls, and remove unneeded function.
2018-11-09 13:18:42 -05:00
Adam Magness
ffc406d819
normalise_link calls
...
implement normaliseLink function
2018-11-08 11:28:29 -05:00
Adam Magness
5276c28a78
link_compare calls
...
implement compareLink function.
2018-11-08 10:46:50 -05:00
Adam Magness
b73af72deb
deindent calls
...
implement function in new class
2018-11-08 10:26:49 -05:00
Adam Magness
916b3e551e
format_network_name calls
...
implement formatNetworkName function
2018-11-08 10:24:47 -05:00
Adam Magness
b99925060a
autoname calls
...
implement getRandomName function
2018-11-08 10:22:20 -05:00
Adam Magness
0e01568ccd
escape_tags calls
...
implement escapeTags function
2018-11-08 10:20:03 -05:00
Adam Magness
a0f65ca7a1
notags calls
...
implement removeTags function
2018-11-08 10:14:37 -05:00
Adam Magness
991f259ecb
random_string calls
...
implement getRandomHex function
2018-11-08 08:45:46 -05:00
1a3c88b042
Merge pull request #6097 from nupplaphil/refactor_user_identities
...
Refactoring identities to Model\User::identities
2018-11-08 06:54:48 -05:00
8ad721988b
Refactoring identities to Model\User::identities
2018-11-08 00:38:55 +01:00
Adam Magness
003eee5912
Standards
...
fix indentation level, replace x() with !empty()
2018-11-07 14:16:59 -05:00
b24998a1ed
Avoid notice in gcontact
2018-11-07 18:26:49 +00:00
Adam Magness
7cb9138201
Move another function
...
move get_plink to Item class, and also fix up getApp since we extend BaseObject
2018-11-07 07:19:39 -05:00
Adam Magness
d50a1edef4
Split text to Item
...
move functions from text.php to Item class
2018-11-06 21:12:41 -05:00
Adam Magness
352da9bcf3
Update function calls
...
update function calls for moved functions
2018-11-06 09:52:58 -05:00
Adam Magness
a71eb1d127
functions moved to HTML class
...
update function calls to moved class.
2018-11-05 21:06:26 -05:00
Adam Magness
9e51be7554
Revert "Update function calls"
...
This reverts commit 748fb8b946
2018-11-05 13:07:07 -05:00
Adam Magness
748fb8b946
Update function calls
...
update function calls to new class
2018-11-05 07:40:18 -05:00
Adam Magness
b07d47b0f7
Update function calls
...
update function calls to new names
2018-11-05 07:24:14 -05:00
Adam Magness
61bc9facc8
Implement functions
...
implement functions relocated to xml class
2018-11-05 07:24:14 -05:00
1395bdc188
Preparations for a relocation message / fix for notice
2018-11-02 21:57:06 +00:00
1b43d459b6
Fix for delivering forum posts again
2018-11-01 23:52:06 +00:00
Adam Magness
70f01d6c00
Template Engine and props to Renderer
...
move methods and props from App to Renderer
2018-10-31 13:25:38 -04:00
Adam Magness
35abc4bb64
get markup template
...
implement getMarkupTemplate function
2018-10-31 10:44:06 -04:00
Adam Magness
91facd2d0a
replace macros
...
implement new replaceMacros function
2018-10-31 10:35:50 -04:00
Adam Magness
02be1d316d
Documentation
...
add proper documentation.
2018-10-31 07:32:22 -04:00
Adam Magness
d9b558a8ed
Update function calls
...
update function calls to new class.
2018-10-30 14:51:45 -04:00
Adam Magness
3a604029eb
Create FileTag class
...
create class and move functions
2018-10-30 14:51:21 -04:00
Adam Magness
50da89d861
Logger Levels
...
update logger levels in calls
2018-10-30 09:58:45 -04:00
Adam Magness
14fde5dc9b
Log function
...
implement log() function.
2018-10-30 09:57:14 -04:00
84be62982a
Diaspora signature transport via AP/DFRN should be repaired now
2018-10-29 21:15:37 +00:00
4831688dc0
Diaspora signatures are now stored and transmitted correctly
2018-10-27 14:35:22 +00:00
73f596cc46
Fixes duplicated transmissions and not working undo of like/dislike
2018-10-27 11:09:23 +00:00
f174bc1bc2
Merge pull request #6028 from annando/issue-5913
...
Issue 5913: Fix fatal error in "RemoveUser"
2018-10-26 00:32:16 -04:00
348e0300a6
Issue 5913: Fix fatal error in "RemoveUser"
2018-10-26 04:27:23 +00:00
Jonny Tischbein
e022bac339
Code Standard + renaming deleteAllTags + move its call and add type param
2018-10-25 21:47:10 +02:00
Jonny Tischbein
26ed71cc14
Only perform Term::deleteAllTags when needed + not needed redirect
2018-10-25 21:47:10 +02:00
Jonny Tischbein
272eb5eb82
fix doxygen header + indent
2018-10-25 21:47:10 +02:00
Jonny Tischbein
fd2e06781d
Fix adding / removing photo tags + tagrm delete via GET + Item::update / add Term::deleteAllTags
2018-10-25 21:47:10 +02:00
14237a9599
Move $pager and $page_offset out of App
...
- Move infinite scroll data output in a module hook
- Use Pager instead of paginate() and alt_pager()
2018-10-25 00:07:15 -04:00
cb75c40f4e
adapted profile pic resize to 300px for whole system
2018-10-23 16:36:57 +02:00
e511790d62
Move NULL_DATE from boot.php to DBA::NULL_DATETIME
...
- Add DBA::NULL_DATE constant
2018-10-22 16:50:55 -04:00
363d00cc45
Adding $a->getBaseURL for Worker in profile_photo
...
Adding a TODO for Contact::magicLink
2018-10-22 22:13:39 +02:00
d00ddc01af
Split goaway to System::externalRedirectTo() and App->internalRedirect()
2018-10-22 22:13:35 +02:00
2ef81108b3
Renamed System::redirect() to $a->redirect()
2018-10-22 22:13:22 +02:00
5c13ecdf6e
Improved parsing of AP profiles
2018-10-22 07:24:47 +00:00
Michael Vogel
277fe547a1
Merge pull request #5978 from MrPetovan/task/make-username-length-configurable
...
Make username length configurable
2018-10-21 23:42:44 +02:00
4ec56a0975
Sets maximum to 64 for username_min/max_length config keys
2018-10-21 17:28:40 -04:00
c1bca43fee
Changing default/max values for username_min/max_length
...
- Restoring legacy default values (3 and 48 respectively)
- Lowering the max value to 150 to take the full profile URL length into
account
2018-10-21 15:10:51 -04:00
b08408c086
Add safeguard for username_min|max_length mutual exclusion
2018-10-21 08:28:24 -04:00
d360bf926a
Use username_min/max_length config keys in Model\User::create
2018-10-20 16:33:54 -04:00
4392858662
Move Global Functions - Part 3
...
- Replaced every CACHE definition
- Moved check_url to App->checkURL()
- Removed unused definition "ZCURL_TIMEOUT"
2018-10-20 18:19:55 +02:00
Benjamin Lorteau
d9209b9c7a
Use local temporary directory for PasswordExposedChecker cache
2018-10-19 11:26:48 -04:00
ec0d3a6eac
Merge pull request #5946 from JonnyTischbein/move_include_security
...
Move and Split include/security
2018-10-19 08:55:08 -04:00
Michael Vogel
8cecc9fb97
Merge pull request #5962 from friendica/bug/5960-fix-register-email-translation-params
...
Remove superfluous L10n::t() parameter in Model\user
2018-10-19 05:34:24 +02:00
Michael Vogel
45156652cc
Merge pull request #5963 from MrPetovan/bug/5956-catch-more-diaspora-magic-links
...
Diaspora: Widen the magic link regular expression
2018-10-19 05:30:52 +02:00
d0681075bf
Add itemsource module
2018-10-18 22:49:25 -04:00
18763e32af
Remove superfluous L10n::t() parameter in Model\user
2018-10-18 18:22:48 -04:00
0628b44f8e
The handling with item-content and item-activity had been simplified
2018-10-18 21:35:48 +00:00
da2a17495d
Merge pull request #5951 from annando/endless-contact
...
Avoid endless loop when trying to fetch contact id
2018-10-18 00:44:07 -04:00
92816dc725
Improved loop detection
2018-10-18 03:33:08 +00:00
35da40c2cb
Avoid endless loop when trying to fetch contact id
2018-10-18 03:01:34 +00:00
Jonny Tischbein
a937cf06a3
add remaning/moving to files not touch by refactoring because of typo
2018-10-17 22:35:49 +02:00
Jonny Tischbein
f3fc1f36ca
Renaming functions + moving functions from security to Model/Item and BaseModule + fix multiline comments
2018-10-17 21:30:41 +02:00
Michael Vogel
389685e099
Merge pull request #5920 from MrPetovan/bug/remove-password-from-register
...
Avoid storing plaintext password in register table
2018-10-17 21:04:11 +02:00
e254ace9d5
Merge pull request #5947 from annando/uri-id
...
Use "uri-id" for item relations
2018-10-17 14:45:40 -04:00
62ad755980
Use "uri-id" for item relations
2018-10-17 18:34:24 +00:00
Jonny Tischbein
05be2db725
Move include/security tp /src/Core/Authentication and /src/Util/Security
2018-10-17 14:19:58 +02:00
c50be325bd
Remove unused parameter $selected in Model\Item::fieldlist
2018-10-16 18:30:24 -04:00
35a73b729f
Onepoll hadn't polled anymore / small relocation in zrlinit for better logging
2018-10-16 13:17:01 +00:00
012fe3c11e
Avoid endless loop at magic auth
2018-10-16 06:32:12 +00:00
8d0f4710a4
Signed Diaspora posts should now be stored more reliable
2018-10-15 21:42:55 +00:00
Benjamin Lorteau
9e1065ff87
Improve transition from previous behavior
...
- Simplify Model\User methods parameter list
- Use DBA methods in mod/regmod
- Replace killme with exit in mod/regmod
- Simplify goaway() calls
2018-10-15 11:58:52 -04:00
756a4f1111
Fix remaining instances of "contacts"
2018-10-14 18:02:54 -04:00
74c5f1f684
Merge pull request #5891 from JonnyTischbein/move_module_contacts
...
Move module contacts
2018-10-14 16:42:50 -04:00
540adaf829
Use Model\Register methods in modules
...
- Update registration emails to avoid storing the plaintext password in
the register table
- Remove redundant sprintf() when used with L10n::t()
- Remove redundant Systen::baseUrl() with goaway()
2018-10-14 12:26:18 -04:00
123992384b
Create Model\Register
...
- Add Model\User::exists method
2018-10-14 11:34:34 -04:00
7f143c3159
Fix various spelling mistakes
2018-10-14 11:32:54 -04:00
efad4936b0
OStatus contacts are now automatically converted to AP
2018-10-13 18:13:01 +00:00
Jonny Tischbein
bfa05156ca
change links from /contacts to /contact
2018-10-13 13:29:56 +02:00
4d4dd1a99c
Some beautification
2018-10-12 20:52:22 +00:00
1b18be6715
The virtuel fields for the diaspora signatures have to be removed at any time
2018-10-12 18:47:32 +00:00
2dec8895a9
Curl Response Refactoring
...
- extended Curl to parse Curl Response
- refactored Network::curl()
- replaced every Network::curl() execution with the new Curl container
2018-10-10 21:08:43 +02:00
307286fc47
parameters and getURLpath to getURLPath
2018-10-10 01:18:47 +02:00
5a02e39a65
Rename App Methods
...
- renamed a lot of App methods to CamelCase
- replaced direct public variables with get-/set-Methods
2018-10-10 00:16:06 +02:00
510032444f
The owner of a "like" should be the author
2018-10-06 08:51:52 +00:00
09302367d5
Include AP in the contact search
2018-10-06 03:17:44 +00:00
fa7cddc669
AP Bugfix: Following a soapbox now works / rapid follow/unfollow should work now
2018-10-05 06:35:50 +00:00
cbfc3d0c28
Fix error / "about" is now converted to BBCode
2018-10-03 19:00:32 +00:00
8841519c0d
Renamed functions
2018-10-03 15:41:51 +00:00
3ab837f3c7
Functionality is now split
2018-10-03 09:15:38 +00:00
518d461a8f
Issue 5811: "objects" instead of "object"
2018-10-02 20:12:38 +00:00
3020b0fdc4
Fix missing mentions
2018-10-02 14:48:57 +00:00
fcfd04bcc9
Normalize the mentions and ensure to not have duplicates
2018-10-02 09:04:32 +00:00
e71f497295
Renamed
2018-09-30 08:14:05 +00:00
82987d018a
Some changes for better code quality
2018-09-30 07:21:57 +00:00
da79566125
Relocated function
2018-09-28 03:56:41 +00:00
cb9be8a7ab
UUID is now createUUID
2018-09-27 11:52:15 +00:00
dd38b7e329
Avoid warnings
2018-09-26 20:36:47 +00:00
60b0759b50
UUID instead of GUID
2018-09-26 20:03:46 +00:00
9ec30010c5
APContact stuff is moved to an own class
2018-09-26 17:24:29 +00:00
834422d52f
Merge remote-tracking branch 'upstream/develop' into ap1
2018-09-24 21:48:40 +00:00
a6996601d5
Merge pull request #5789 from friendica/master
...
Update develop from master-2019.09
2018-09-23 18:55:20 -04:00
8c7e5bb776
all endpoints are now working
2018-09-23 17:29:31 +00:00
6df6d82427
We can now like and dislike
2018-09-23 08:52:07 +00:00
f772ece86f
New delivery module for ap
2018-09-17 21:13:08 +00:00
91d1b4de5d
We now use the conversation data with AP
2018-09-17 05:51:05 +00:00
6f3b2b6586
Handling of unlisted posts, better uid detection
2018-09-16 09:06:09 +00:00
2eabe45a8e
Contact reject does work now as well
2018-09-15 22:25:58 +00:00
e45206ae5d
Merge remote-tracking branch 'upstream/2018.08-rc' into ap1
2018-09-15 20:49:46 +00:00
86bd283705
The whole contact handling does work now, yeah ...
2018-09-15 20:31:05 +00:00
6a8ebc8639
Contact follow and unfollow workd partially
2018-09-15 18:54:45 +00:00
fb5b6e4a14
New uri format for our posts that is AP compatible
2018-09-15 07:37:34 +00:00
61e2c7d20d
Added AP to many network conditions / enabling inbox processing
2018-09-14 16:51:32 +00:00
8b96a53fba
Burn notices, burn
2018-09-11 04:10:11 +00:00
bd2b3b1ef5
LockDriverFixings
...
- release Locks in case of failures
- adding some cache tests
2018-09-06 08:11:18 +02:00
rabuzarus
75a2576f78
use magic links in single event view
2018-09-06 01:42:35 +02:00
9ef1d827f3
Restore the behaviour to remove the remote contact upon termination
2018-09-05 05:02:06 +00:00
703c668a37
More notices ...
2018-09-02 08:01:13 +00:00
a3570d0027
Fix: Missing gserver entries - show correct server platform
2018-08-30 09:52:38 +00:00
c72d1bc8fd
Issue 5653: The mastodonemoji addon hadn't got all needed data.
2018-08-29 20:46:52 +00:00
Michael Vogel
c7f8f190b9
Oh no, even more notices ... ( #5697 )
2018-08-29 14:28:13 -04:00
Michael Vogel
49dad00570
Issue 5260: Ensure that user data is really deleted ( #5666 )
...
* Issue 5260: Ensure that user data is really deleted
* Missing files
2018-08-25 17:48:50 -04:00
Michael Vogel
edcd0a3744
Issue 4960: Ignoring and blocking of contacts should work again ( #5657 )
...
* Issue 4960: Ignoring and blocking of contacts should work again
* Renamed functions
* This function should be renamed as well.
* We now have a frontend to block and ignore public contacts
* Hide some parts for public contacts
* Removed notices, public contact is now accessible from dirfind as well
* We now show contact conversations and contact posts
* We now use a new conversation mode
* The update functionality is disabled until it will work completely
* Fixing tabs chaos
* Update after posts on the contacts page will now work
* Show connect link
2018-08-25 09:48:00 -04:00
Roland Häder
61693419e8
Cleanups: isResult() more used, readability improved ( #5608 )
...
* [diaspora]: Maybe SimpleXMLElement is the right type-hint?
* Changes proposed + pre-renaming:
- pre-renamed $db -> $connection
- added TODOs for not allowing bad method invocations (there is a
BadMethodCallException in SPL)
* If no record is found, below $r[0] will fail with a E_NOTICE and the code
doesn't behave as expected.
* Ops, one more left ...
* Continued:
- added documentation for Contact::updateSslPolicy() method
- added type-hint for $contact of same method
- empty lines added + TODO where the bug origins that $item has no element 'body'
* Added empty lines for better readability
* Cleaned up:
- no more x() (deprecated) usage but empty() instead
- fixed mixing of space/tab indending
- merged else/if block goether in elseif() (lesser nested code blocks)
* Re-fixed DBM -> DBA switch
* Fixes/rewrites:
- use empty()/isset() instead of deprecated x()
- merged 2 nested if() blocks into one
- avoided nested if() block inside else block by rewriting it to elseif()
- $contact_id is an integer, let's test on > 0 here
- added a lot spaces and some empty lines for better readability
* Rewrite:
- moved all CONTACT_* constants from boot.php to Contact class
* CR request:
- renamed Contact::CONTACT_IS_* -> Contact::* ;-)
* Rewrites:
- moved PAGE_* to Friendica\Model\Profile class
- fixed mixure with "Contact::* rewrite"
* Ops, one still there (return is no function)
* Rewrite to Proxy class:
- introduced new Friendica\Network\Proxy class for in exchange of proxy_*()
functions
- moved also all PROXY_* constants there as Proxy::*
- removed now no longer needed mod/proxy.php loading as composer's auto-load
will do this for us
- renamed those proxy_*() functions to better names:
+ proxy_init() -> Proxy::init() (public)
+ proxy_url() -> Proxy::proxifyUrl() (public)
+ proxy_parse_html() -> Proxy::proxifyHtml() (public)
+ proxy_is_local_image() -> Proxy::isLocalImage() (private)
+ proxy_parse_query() -> Proxy::parseQuery() (private)
+ proxy_img_cb() -> Proxy::replaceUrl() (private)
* CR request:
- moved all PAGE_* constants to Friendica\Model\Contact class
- fixed all references of both classes
* Ops, need to set $a here ...
* CR request:
- moved Proxy class to Friendica\Module
- extended BaseModule
* Ops, no need for own instance of $a when self::getApp() is around.
* Proxy-rewrite:
- proxy_url() and proxy_parse_html() are both non-module functions (now
methods)
- so they must be splitted into a seperate class
- also the SIZE_* and DEFAULT_TIME constants are both not relevant to module
* No instances from utility classes
* Fixed error:
- proxify*() is now located in `Friendica\Util\ProxyUtils`
* Moved back to original place, ops? How did they move here? Well, it was not
intended by me.
* Removed duplicate (left-over from split) constants and static array. Thank to
MrPetovan finding it.
* Renamed ProxyUtils -> Proxy and aliased it back to ProxyUtils.
* Rewrite:
- stopped using deprecated NETWORK_* constants, now Protocol::* should be used
- still left them intact for slow/lazy developers ...
* Ops, was added accidentally ...
* Ops, why these wrong moves?
* Ops, one to much (thanks to MrPetovan)
* Ops, wrong moving ...
* moved back to original place ...
* spaces added
* empty lines add for better readability.
* convertered spaces -> tab for code indenting.
* CR request: Add space between if and brace.
* CR requests fixed + move reverted
- ops, src/Module/*.php has been moved to src/Network/ accidentally
- reverted some parts in src/Database/DBA.php as pointed out by Annando
- removed internal TODO items
- added some spaces for better readability
2018-08-24 01:05:49 -04:00
Michael Vogel
dc3d2d5988
"dba" is now "DBA". This hadn't been respected at some places ( #5655 )
...
* "dba" is now "DBA". This hadn't been respected at some places
* Cleaning up unneeded stuff
2018-08-23 09:51:58 -04:00
Michael Vogel
54aee2aaa7
Removed notices that revealed themselfes over night ... ( #5645 )
...
* Removed notices that revealed themselfes over night ...
* And more notices removed that occured over night
* One more ..
* Some more notices of the day ...
2018-08-21 17:35:09 +02:00
Michael Vogel
7f3fb34c24
Some easy to replace "q" calls have been replaced by "DBA" calls ( #5632 )
...
* Some easy to replace "q" calls have been replaced by "DBA" calls
* Simplified the GUID creation
* And one in the API ...
* And OStatus has got some DBA calls more
* Just some more replaced database calls
* The event query is now simplified
* Events are now shown again
* subthread is now using the DBA calls as well
* Some more replaced database calls
* And some more replaced database calls and prevented notices
* Better use gravity
* Some more replaced database stuff
* Some more replaced database calls in DFRN.php
* The gcontact class now has got the new DBA functions as well
* The Contact class is now changed to new database functions as well
* Small correction
* We can now delete without cascade
* One more functionality is safe for future changes
2018-08-19 12:46:10 +00:00
Michael Vogel
ab5cedfa50
placeholder for a funny commit description for removing some more notices ( #5631 )
2018-08-19 01:52:21 +00:00
Michael Vogel
060e887a31
And still there are notices that have to be removed ... ( #5629 )
...
* And still there are notices that have to be removed ...
* Notice removed in ACL part
* Fix missing fields for notifications
* Fixes issue 5630
2018-08-18 08:20:50 +02:00
d5c2c41b02
Merge pull request #5626 from annando/notices-oh-yeah
...
Removed notices, will it ever end?
2018-08-17 09:33:02 +02:00
0342f9e084
Removed notices, will it ever end?
2018-08-17 03:19:42 +00:00
bb0cf93374
Fix for storing posts of private forums
2018-08-15 20:13:10 +00:00
e8334c4655
Use the Item class instead of DBA calls when possible
2018-08-15 04:41:49 +00:00
29aa90ec09
Remove contacts in the background
2018-08-12 17:15:47 +00:00
Roland Häder
e06fc2aa69
Stopped using deprecated constants NETWORK_* ( #5537 )
...
* Rewrite:
- stopped using deprecated NETWORK_* constants, now Protocol::* should be used
- still left them intact for slow/lazy developers ...
* Removed deprecated NETWORK_* constants as per code reviewer's request.
2018-08-11 22:40:44 +02:00
bf5896d4e3
Merge pull request #5598 from annando/issue-3838
...
Added a note concerning the question how to fix issue 3838
2018-08-11 07:48:33 +02:00
7d945e8504
Added a note concerning the question how to fix issue 3838
2018-08-10 20:28:41 +00:00
170dd2a705
Some more removed notices
2018-08-10 19:39:43 +00:00
f82580c2ef
Avoid probing for contacts if we don't want to update
2018-08-09 06:19:23 +00:00
Michael Vogel
276abfaba6
Issue 5158: Ignore all threads, even public ones ( #5588 )
...
* Issue 5158: Ignore all threads, even public ones
* Remove some notice
* Now it really should work
* Using "defaults"
2018-08-08 22:32:11 +02:00
Michael Vogel
eaf81e5e66
Merge pull request #5563 from MrPetovan/bug/5470-fix-various-notices
...
Fix various notices
2018-08-07 21:34:47 +02:00
Michael Vogel
8c2efa6df4
Facebook and App.net is removed from nearly all places ( #5581 )
...
* Facebook is removed from nearly all places
* Remove app.net as well - it's dead for some time now
2018-08-07 17:06:51 +02:00
4921303133
Issue 5541: Don't do magic things when the remote site doesn't support it
2018-08-06 19:59:41 +00:00
Michael Vogel
c032011143
Post update script for setting the uri-id ( #5573 )
...
* Post update is working now
* Changed text.
2018-08-06 18:40:41 +02:00
Hypolite Petovan
6a57574091
Fix missing $profile['nickname'] in Model\Profile
2018-08-05 15:56:41 +02:00
Michael Vogel
ef1c73fb6b
Merge pull request #5561 from MrPetovan/bug/4584-fix-twitter-gif-still-image
...
Restore source storing for Twitter conversations
2018-08-05 14:00:19 +02:00
Hypolite Petovan
ea45a78218
Increase Twitter parcel constant value
2018-08-05 13:59:33 +02:00
Michael Vogel
fa46e97f27
We now store the uri data in a separate table ( #5560 )
...
* We now have a item-uri table
* Fixing line endings
* New item uri table
* Rescued ItemURI.php file
* Reverting some git problem
* Corrected the dbstructure file
* Updated database.sql / we now store content in the new id fields
2018-08-05 13:09:59 +02:00
Hypolite Petovan
c4e69b7766
Add conversation storage for Twitter
2018-08-05 12:34:33 +02:00
Hypolite Petovan
6678208915
Add new Conversation::PARCEL_TWITTER constant
2018-08-05 12:25:47 +02:00
Hypolite Petovan
c13dc549ed
Rename PROTOCOL_* constants to Model\Conversation::PARCEL_*
...
- Remove unused Conversation::PROTOCOL_GS_CONVERSATION constant
- Remove now renamed PROTOCOL_* constant declarations
2018-08-05 12:24:42 +02:00
Michael Vogel
8dea36bd8f
We shouldn't cascade this deletion as well ( #5558 )
2018-08-05 11:02:36 +02:00
Michael Vogel
2f2b134e58
Fixes issue 5321: Likes can be undone and comments can be deleted again ( #5557 )
2018-08-05 06:35:11 +02:00
Michael Vogel
c72c64a6d8
Notices again ( #5543 )
...
* And again notices
* Notices in the directory
* Much more places
* Fix some double $
* Notice in ping
* Missing field
* Fix: We now remove deleted users from the directory
* Some more stuff
* Notices when removing users
* Added logging
* More logging
* Two more
2018-08-02 07:21:01 +02:00
Hypolite Petovan
4d17fb36d1
Fix missing fields in event reminder ( #5540 )
2018-08-01 09:27:13 +02:00
Michael Vogel
9d0f18c0b3
Yeah, and again notices ... ( #5536 )
...
* Yeah, and again notices ...
* And some more
* Block access without given user name
* Reformatting
2018-08-01 07:29:58 +02:00
Michael Vogel
71b1638d9a
Once again, notices ... ( #5535 )
2018-07-31 18:39:23 +02:00
Michael Vogel
c39e0dcf2a
Fix for vanishing notes ( #5531 )
...
* Fix for vanishing notes
* The field needs to be part of the selected fields ...
2018-07-30 22:23:48 -04:00
Roland Häder
4d39164c1e
[WIP] Rewrite to Proxy class: ( #5507 )
...
* Rewrite to Proxy class:
- introduced new Friendica\Network\Proxy class for in exchange of proxy_*()
functions
- moved also all PROXY_* constants there as Proxy::*
- removed now no longer needed mod/proxy.php loading as composer's auto-load
will do this for us
- renamed those proxy_*() functions to better names:
+ proxy_init() -> Proxy::init() (public)
+ proxy_url() -> Proxy::proxifyUrl() (public)
+ proxy_parse_html() -> Proxy::proxifyHtml() (public)
+ proxy_is_local_image() -> Proxy::isLocalImage() (private)
+ proxy_parse_query() -> Proxy::parseQuery() (private)
+ proxy_img_cb() -> Proxy::replaceUrl() (private)
* Ops, need to set $a here ...
* CR request:
- moved Proxy class to Friendica\Module
- extended BaseModule
* Ops, no need for own instance of $a when self::getApp() is around.
* Proxy-rewrite:
- proxy_url() and proxy_parse_html() are both non-module functions (now
methods)
- so they must be splitted into a seperate class
- also the SIZE_* and DEFAULT_TIME constants are both not relevant to module
* No instances from utility classes
* Fixed error:
- proxify*() is now located in `Friendica\Util\ProxyUtils`
* Moved back to original place, ops? How did they move here? Well, it was not
intended by me.
* Removed duplicate (left-over from split) constants and static array. Thank to
MrPetovan finding it.
* Renamed ProxyUtils -> Proxy and aliased it back to ProxyUtils.
2018-07-30 22:06:22 -04:00
Michael Vogel
a2cea16954
Some more notices ( #5526 )
...
* Some more notices
* Fixed nasty to find notice in DFRN and OStatus
* And more notices ...
* Yeah, some removed notices ... again ...
2018-07-30 06:41:20 +02:00
02d4b1098e
Merge pull request #5519 from annando/test-2
...
Moved expiring of item content
2018-07-29 11:45:50 +02:00
6add589c3f
Removed some test logging
2018-07-29 04:38:14 +00:00
bc38420801
Some more notices removed
2018-07-29 04:04:23 +00:00
dc9b10fb09
Moved expiring of item content
2018-07-29 03:54:34 +00:00
Michael Vogel
36d4516e7a
Missing stuff in "develop"? ( #5516 )
...
* "post-type" replaces "bookmark" and "type"
* Removed some more type
* Added index to permission set
* The permission set is now stored
* The permission set is now removed upon expiry
* Post update now stores the permission set
* New file
* Permissions are now sorted
* The permission set is now used for item permissions
* Check for allow_cid, ... is superfluous. Checking for "private" is enough
* We query the permissionset
* Permissions are displayed correctly
* Changed index
* We don't store the permissions in the item table anymore
* Permission fields are now deprecated
* Reversed ...
* Postupdate now handles "postopts" as well
* Set deprecated fields to "null" if empty
* Postupdates are enabled again
* "post-type" replaces "bookmark" and "type"
* The permission set is now stored
* The permission set is now removed upon expiry
* Postupdate now handles "postopts" as well
2018-07-28 13:11:46 -04:00
Roland Häder
4a22710b3b
Moved global PAGE_* to Profile class ( #5500 )
...
* Rewrites:
- moved PAGE_* to Friendica\Model\Profile class
* Fixed more rewrites from plain (global namespace) PAGE_* to Friendica\Models\Profile class
* CR request:
- moved all PAGE_* constants to Friendica\Model\Contact class
- fixed all references of both classes
* CR request:
- moved ACCOUNT_TYPE_* constants from boot.php to Contact::ACCOUNT_TYPE_*
* Just copy-pasted this code from boot.php, needs to be changed to `const ACCOUNT_TYPE_FOO = x;`
* Ops, melting brain cells here ... :-/
2018-07-27 19:25:57 -04:00
Michael Vogel
5f77e98d76
Postupdate is now working again ( #5512 )
...
* "post-type" replaces "bookmark" and "type"
* Removed some more type
* Added index to permission set
* The permission set is now stored
* The permission set is now removed upon expiry
* Post update now stores the permission set
* New file
* Permissions are now sorted
* The permission set is now used for item permissions
* Check for allow_cid, ... is superfluous. Checking for "private" is enough
* We query the permissionset
* Permissions are displayed correctly
* Changed index
* We don't store the permissions in the item table anymore
* Permission fields are now deprecated
* Reversed ...
* Postupdate now handles "postopts" as well
* Set deprecated fields to "null" if empty
* Postupdates are enabled again
2018-07-27 19:24:26 -04:00
Michael Vogel
986106a8f7
Item storage: Permissions aren't stored in the items anymore ( #5495 )
...
* The permission set is now used for item permissions
* Check for allow_cid, ... is superfluous. Checking for "private" is enough
* We query the permissionset
* Permissions are displayed correctly
* Changed index
* We don't store the permissions in the item table anymore
* Permission fields are now deprecated
* Reversed ...
2018-07-25 19:14:55 -04:00
Roland Häder
37253656e3
Moved CONTACT_* constants to Friendica\Model\Contact class, lesser in global namespace ( #5490 )
...
* Rewrite:
- moved all CONTACT_* constants from boot.php to Contact class
* CR request:
- renamed Contact::CONTACT_IS_* -> Contact::* ;-)
2018-07-24 22:53:46 -04:00
Michael Vogel
5a8654194a
Merge pull request #5452 from MrPetovan/bug/5443-fix-worker-notices
...
Fix notices in OEmbed et al.
2018-07-24 17:11:53 +02:00
Michael Vogel
be8b68aaaf
Store guid and plink with event ( #5485 )
...
* Store guid and plink with event
* One space too much
2018-07-24 10:01:31 -04:00
Hypolite Petovan
b6e3da8443
Move addLanguageToItemArray call when body is ensured
2018-07-24 08:52:25 -04:00
Hypolite Petovan
4e9ba728c4
Fix undefined index body in Model\Item
2018-07-24 07:54:12 -04:00
Michael Vogel
ca2c316de0
Some removed notices when viewing events ( #5483 )
2018-07-24 07:51:50 -04:00
Hypolite Petovan
a6fb3568f9
Rename dbesc to DBA::escape
2018-07-23 15:30:54 -04:00
Hypolite Petovan
ecea7425f8
Rename DBA::is_result to DBA::isResult
2018-07-23 11:04:14 -04:00
Hypolite Petovan
0ec44f3e8a
Rename DBM method calls to DBA method calls
2018-07-23 11:02:24 -04:00
Hypolite Petovan
8ddb94ef06
Use DateTimeFormat::utc() instead of DBM::date()
2018-07-23 10:57:47 -04:00
Michael Vogel
2d0a749734
Merge pull request #5431 from MrPetovan/task/5410-rename-database-methods
...
Move DBA to src/ part 3.1: Rename DBA methods
2018-07-23 15:18:58 +02:00
Roland Häder
4eb6707dc9
Cleanup: ( #5463 )
...
- rewrote x() to empty() as it is deprecated
- fixed indending for some entries
2018-07-22 21:18:21 -04:00
Hypolite Petovan
415b982d39
Rename DBA::num_rows to DBA::numRows
2018-07-22 19:27:35 -04:00
Hypolite Petovan
4db98eb43d
Rename DBA::inArray to DBA::toArray
2018-07-22 19:27:35 -04:00
Hypolite Petovan
f051ae1698
Rename DBA::fetch_first to DBA::fetchFirst
2018-07-22 19:27:34 -04:00
Hypolite Petovan
e42cf4d4fc
Rename DBA::affected_rows to DBA::affectedRows
2018-07-22 19:27:34 -04:00
Roland Häder
7876d6547b
Fixed E_NOTICEs when uploading profile picture ( #5456 )
...
* Fixed E_NOTICEs when uploading profile picture.
* Fixed E_NOTICEs when $_POST doesn't contain these fields.
2018-07-22 16:01:14 -04:00
Michael Vogel
7382be2766
Some more notices ( #5424 )
2018-07-20 14:07:54 -04:00
Hypolite Petovan
af6dbc654f
Rename Friendica\Database\dba to Friendica\Database\DBA
2018-07-20 08:19:26 -04:00
045358cb88
Wrong "use" for config
2018-07-20 06:04:23 +00:00
Hypolite Petovan
daa1177e3a
Update use statement lists with new Friendica\Database\dba class
...
- Remove unused use statement
- Remove superfluous use statements (classes in the same namespace)
- Add missing use statements
2018-07-19 22:15:21 -04:00
Michael Vogel
01b67c4eb3
Little fixes ( #5414 )
...
* We now store the item delivery data in a separate table
* Reorganized table structure
* Fix a notice when using the profiler / ensure that permissions are strings
2018-07-19 18:40:39 -04:00
Michael Vogel
ec49d004e3
We now store the item delivery data in a separate table ( #5413 )
...
* We now store the item delivery data in a separate table
* Reorganized table structure
2018-07-19 17:56:52 -04:00
Michael Vogel
5af9596dde
New item field "Post-type" and new table "permissionset" ( #5408 )
...
* "post-type" replaces "bookmark" and "type"
* Removed some more type
* Added index to permission set
* The permission set is now stored
* The permission set is now removed upon expiry
* Post update now stores the permission set
* New file
* Permissions are now sorted
* Changed documentation
2018-07-19 09:52:05 -04:00
Roland Häder
346790cbbc
According to @annando and @MrPetovan , $emailcc is no item field (column) and ( #5401 )
...
should be initialized empty (I did it above the `if()` block).
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-18 17:26:14 -04:00
Michael Vogel
66a103e36a
Merge pull request #5295 from MrPetovan/task/4889-move-config-to-config
...
Move configuration to config/
2018-07-18 11:04:35 +02:00
Roland Häder
a41e49c84a
Fixes for E_NOTICE in mod/item.php ( #5393 )
...
* Fixes applied:
- `if (is_array($some_array))` is better code style than `if ($some_array)` as
the `if()` block really needs an array to be found
- same with `if ($some_id)`, maybe `if ($some_id > 0)` is a more proper check
- added missing field 'emailcc' to Item::ITEM_FIELDLIST
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixes E_NOTICE of missing variable (PHP's lazyness again).
Signed-off-by: Roland Häder <roland@mxchange.org>
* Use !empty() to avoid accessing empty array.
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-17 18:18:42 -04:00
Hypolite Petovan
762a786611
Replace direct accesses to App->config by Config::get/set calls
2018-07-16 19:38:16 -04:00
Hypolite Petovan
e952d6677b
Rename App->path to App->urlpath
2018-07-16 19:38:13 -04:00
Michael Vogel
d3a2ed85fe
Next item structure works ( #5380 )
...
* Use "LEFT JOIN" to always fetch the item. Needed for update routines.
* New conversion routine that now covers every item
* Post update is now activated
* We now use a hash based upon RIPEMD-320 for content and activity
* The hash doesn't contain the plink anymore
* Legacy item fields are now "null"able
* New hash function for a server unique item hash
* Introduction of the legacy mode (usage of old item fields)
* Code simplification
* We don't need the "uri" fields anymore in item-activity and item-content
* Use the "created" and not the "received" date for the hash
* Avoiding several notices
* Some more warnings removed
* Improved uri-hash / Likes on Diaspora are now getting a creation date
* Corrected the post update version
* Ensure an unique uri-hash
* Don't delete orhaned item data at the moment
* Partly reworked, due to strange behaviour
* Some more parts reworked
* Using the uri currently seems to be more reliable
* Using the uri here as well
* Use the hash values again
* Grouped item fields in different categories
* Notices again
* use the gravity (we always should)
* Added hint for disabled post updates
* Notices ...
* Issue #5337 : Personal notes are displayed again
* Use the gravity again
2018-07-15 14:36:20 -04:00
Hypolite Petovan
ffc8b2a79a
Rework smilies class and module
...
- Add new replaceFromArray function to enable smilies replacement with
an arbitrary array
- Moved $sample logic from class to module
2018-07-15 08:03:12 -04:00
Roland Häder
6b5d90333f
Fixes for some E_NOTICE and type-hints added ( #5358 )
...
* Fixed http://github to https://github
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixes for #4965 :
- updated messages.po file
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixed E_NOTICE where isset()/empty() was absent.
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixed missing variable $sql_order causing E_NOTICE.
Signed-off-by: Roland Häder <roland@mxchange.org>
* Continued:
- added array type-hint where known (some)
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixes:
- in Profile::load() $user is now only one-dimensional
- $a->get_hostname is no property, it is a method
Signed-off-by: Roland Häder <roland@mxchange.org>
* reverted changes that are unintended
Signed-off-by: Roland Häder <roland@mxchange.org>
* Continued:
- removed leading \ (uncommon, okay)
- removed entire if() block (CR by Hypolite)
Signed-off-by: Roland Häder <roland@mxchange.org>
* Removed if() block
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-13 15:47:14 -04:00
3cb7a7606e
workaround for stalling worker processes when running the daemon
2018-07-11 06:05:22 +00:00
Michael Vogel
0360f7197a
Several more warnings ... ( #5340 )
...
* Some more warnings removed
* Even more warnings ...
* Will it ever end? ;-)
* Avoid warning in dbstructure
* Origin and OStatus ...
* There are more warnings solved ... yeah!
* And again ...
* We are not done yet
* And more ...
* And some new places ...
* And more in the feeds
* Avoid some more
* And some backend stuff
* Notifications cleared
* Some more stuff
* and again ...
* It's getting fewer ...
* Some warnings had been hidden in the notifications
* Fix the fix
* And another missing one ...
* We need the owner here, not the user
* Forgotten user
* And more ...
* And some more warnings disappeared ...
* Some more frontend warnings
* Some backend warnings removed
* Fixed sidebar for "vier"
* And more ...
* Some more ...
* And something for "remote self"
* Am I stuck in an endless loop?
* Fix: Clear tag and file field on update
* Preset page content
2018-07-10 08:27:56 -04:00
Andreas Neustifter
32ef5623ab
[frio] Improve Group Editing ( #5349 )
...
* Improve group-editing and edit-navigation.
Use icons next to groups and header for navigation to editing groups and adding new groups.
Also use icon from group-sidebar for editing groups.
* Unify look&feel of contact search bars.
* Remove nogroup page and replace with /group/none.
* Make sure proper items are selected in aside.
* Use icon instead of link for 'View Contacs' on profile page.
* Fix none-working /group/none.
* Fix highlighting for everyone in group aside.
2018-07-09 18:36:50 -04:00
Andreas Neustifter
09b7e217c7
[Suggestion] Move New User Tip Link ( #5342 )
...
* Move new member tips to navigation bar.
The link looks so forlorn when its just somewhere in there. Put it in the nav bar.
* Style new member hints link propery.
* Make changes requested by @MrPetovan .
2018-07-09 18:20:57 -04:00
c829e43725
moved get_guid to System::createGUID
2018-07-09 21:38:16 +02:00
1d745c25a7
Some more places ...
2018-07-08 12:58:43 +00:00
7d6933c898
Avoid "Trying to get property of non-object"
2018-07-08 11:46:05 +00:00
3e797547a3
Warnings fixed
2018-07-08 09:37:05 +00:00
c25c3b5981
urgent bugfix: Wrong function name for locks
2018-07-08 08:32:50 +00:00
c2d4b557ae
Only build tag and file when really needed
2018-07-08 05:44:35 +00:00
74d5eec571
Merge branch 'item-activities' of github.com:annando/friendica into item-activities
2018-07-08 04:56:35 +00:00
5ee2db8a16
Avoid undefined index
2018-07-08 04:55:45 +00:00
Michael Vogel
ff5ee74ecf
Merge branch 'develop' into item-activities
2018-07-08 06:35:50 +02:00
75aa831b32
Better not check too strict
2018-07-07 23:31:30 +00:00
4673560c55
Don't use isset
2018-07-07 23:19:28 +00:00
4467dd4972
Clear legacy item fields
2018-07-07 23:03:28 +00:00
afa194200b
Fix: Ensure that the value is set.
2018-07-07 19:39:00 +00:00
d6af9515ba
Avoid storing an icid value when iaid is stored/Fix item retraction
2018-07-07 16:38:01 +00:00
575662c2d7
Just some code cleanup
2018-07-07 11:39:37 +00:00
3389e9b213
Removing of likes should work now on comments as well
2018-07-07 10:43:43 +00:00
9e262e6157
Better handling of empty content
2018-07-06 22:08:41 +00:00
Michael Vogel
3eec97aa6e
Merge pull request #5314 from MrPetovan/task/4889-fix-tests
...
Fix tests after enabling PHP Notices
2018-07-06 22:14:01 +02:00
a49e094308
added forgotten trim
2018-07-06 15:49:27 +02:00
72638acac3
admins can forbid some nicknames from being registered
2018-07-06 15:32:56 +02:00
5a07042560
Added warning
2018-07-06 06:37:33 +00:00
f33bd5fc8e
Update does work now
2018-07-06 05:16:40 +00:00
5203f41d42
Set iaid after update
2018-07-05 22:50:33 +00:00
014eea8e12
Improve expire for item-content and item-activity
2018-07-05 22:07:50 +00:00
44e405d22b
We now store activities in a separate table
2018-07-05 22:00:38 +00:00
e41e7d2edd
Fixings
...
- fixed test for semaphore
- fixed some issues
- changed namespace in Tests back to "src/"
- changed namings
2018-07-05 20:57:31 +02:00
176ab7130f
Fixes issue 5322 - events now again are having a plink
2018-07-04 19:53:02 +00:00
f60da34357
Fix unliking liked
2018-07-04 19:07:53 +00:00
4b3ae6a862
Only use query conditions in user mode
2018-07-02 18:22:27 +00:00
Hypolite Petovan
633a71ec97
Fix notice in Item::deleteById
2018-07-02 07:49:35 -04:00
Hypolite Petovan
a380bcd1c1
Fix more undefined variable/index notice in tests
2018-07-02 07:45:25 -04:00
717ca0b7eb
Use already fetched data for magiclink
2018-07-02 05:41:55 +00:00
38160a48b0
Post update script to move old content from the item table
2018-07-01 19:02:29 +00:00
32a639891f
Improved logging for expired items
2018-07-01 09:08:58 +00:00
bffdf96d87
The "file" variable isn't stored anymore in the item table
2018-07-01 07:57:59 +00:00
Hypolite Petovan
0c553150ea
Merge pull request #5305 from annando/item-tags
...
Tags aren't stored in the item table anymore
2018-06-30 17:50:55 -04:00
60dcdd0b27
Preparation for not storing the file field into the item table.
2018-06-30 21:15:24 +00:00
bc3a569b2f
Label for the Events happening in the next 7 days was wrong
2018-06-30 17:34:27 +02:00
5ba1427806
We don't store tags in the item table anymore
2018-06-30 15:21:32 +00:00
0ab9f2e265
Preparations to not store the tags in the item table anymore
2018-06-30 13:54:01 +00:00
a8a189eec4
The detected language now moved to "item-content" as well
2018-06-30 05:18:43 +00:00
59f8cb16e5
Add item content before the transaction
2018-06-29 11:10:36 +00:00
a82cf2ae29
Delete item content for older item records
2018-06-29 06:51:48 +00:00
6b31e72905
Fix for: empty posts and comments that hadn't been transmitted to Diaspora
2018-06-29 06:20:04 +00:00
b705a91ccd
Standards and some more replace item calls
2018-06-28 03:31:10 +00:00
51a58ec2e2
Fix for fetching false fer... (sorry) verbs
2018-06-27 20:25:24 +00:00
028c9f4da5
We now store the verb in the item-content as well
2018-06-27 19:37:13 +00:00
76dab3b2d7
Use gravity instead of verb
2018-06-27 18:09:33 +00:00
f74a54b9bf
Standard stuff
2018-06-26 03:58:12 +00:00
7aa880543f
Fix shadow posts
2018-06-25 20:38:32 +00:00
89f0eec261
Use a constant fieldlist
2018-06-25 18:49:36 +00:00
c07b81c5b9
Added workarounds to fetch the complete item content
2018-06-25 16:11:27 +00:00
5f3f349006
"author-link" and "owner-link" aren't stored anymore in the item table
2018-06-25 06:45:05 +00:00
6dbbeaf8f6
Remove unneeded code
2018-06-25 06:33:12 +00:00
89fb28ae9b
Content is now stored exclusively in item-content, connected via "icid" field
2018-06-25 04:56:32 +00:00
941bab1096
We now only store the content in item-content
2018-06-24 23:09:13 +00:00
58d61810ea
We now store item content centrally
2018-06-24 21:41:49 +00:00
b03db4643f
The fetch function now centrally controls the content
2018-06-24 10:48:29 +00:00
a7d2f126eb
Fixes Issue 5276 and an endless loop in item::update
2018-06-23 10:32:53 +00:00
rabuzarus
92a84275d4
fix hovercard for not logged in users
2018-06-21 22:46:10 +02:00
Hypolite Petovan
8a3cae686b
Merge pull request #5261 from annando/and-again-abstraction
...
And again the item abstraction - and a fix for issue 5252
2018-06-21 11:50:31 -04:00
d643e00d33
Standards and a new function to fetch content
2018-06-21 15:14:01 +00:00
Hypolite Petovan
e84c48b979
Merge pull request #5259 from rabuzarus/20180616_-_magic_auth_test_2
...
port hubzillas OpenWebAuth - don't initiate magic auth if the contact is allready authentificated
2018-06-20 20:15:14 -04:00
rabuzarus
02d96623f2
port hubzillas OpenWebAuth - don't initiate magic auth if the contact is allready authentificated
2018-06-21 02:08:54 +02:00
Hypolite Petovan
a5550b4702
Merge pull request #5253 from rabuzarus/20180616_-_magic_auth_test_2
...
Port hubzillas OpenWebAuth - remote authentification
2018-06-20 17:46:04 -04:00
rabuzarus
9f493357f4
port hubzillas OpenWebAuth - fix wrong table name + fix wrong method name
2018-06-20 20:11:26 +02:00
rabuzarus
149142b4bc
port hubzillas OpenWebAuth - rename Verify class to OpenWebAuthToken
2018-06-20 19:24:02 +02:00
rabuzarus
d5afbd3357
port hubzillas OpenWebAuth - rename verify table to openwebauth-token
2018-06-20 19:18:41 +02:00
rabuzarus
f0235c4a98
port hubzillas OpenWebAuth - rename some methods and classes
2018-06-20 18:38:23 +02:00
c540154f8e
"shadow" does not exist
2018-06-19 21:41:38 +00:00
962fbc9166
Many "fetch_first" had been replaced
2018-06-19 21:33:07 +00:00
139d35438d
Fix: network had been empty
2018-06-19 21:32:42 +00:00
rabuzarus
b65e4b278b
port hubzillas OpenWebAuth - use Contact::getIdForURL to query for contact entry
2018-06-19 16:15:28 +02:00
rabuzarus
9195ea26b1
port hubzillas OpenWebAuth - add some notes to the doxygen to refer to hubzilla's source code
2018-06-19 13:30:55 +02:00
ebd76285d8
New item functions, improved feed cache behaviour
2018-06-19 05:39:56 +00:00
rabuzarus
1c7f4e3c63
port hubzillas OpenWebAuth - remote authentification
2018-06-18 23:05:44 +02:00
4714cb746b
Use the item functions at many more places
2018-06-18 20:36:34 +00:00
507956818d
Use the item classes where possible
2018-06-18 05:19:28 +00:00
23aa9dffa0
New item functions are now used in the delivery process as well
2018-06-17 21:35:33 +00:00
e42b934807
Item field list structure is unified
2018-06-17 17:14:52 +00:00
6e10de9284
New function to fetch item data especially for users
2018-06-17 17:05:17 +00:00
0280a46ab4
Use predefined field lists
2018-06-17 06:27:52 +00:00
1aec8f620d
More item abstractions for DFRN and Diaspora
2018-06-16 22:32:57 +00:00
Hypolite Petovan
7d1bb9ecf4
Merge pull request #5230 from annando/new-item-uri
...
New function for generating item URI
2018-06-16 10:54:56 -04:00
Hypolite Petovan
133cd342d4
Merge pull request #5226 from annando/even-more-abstraction
...
More item calls have been replaced with the new functions
2018-06-16 07:57:00 -04:00
14cb128264
New function for generating item URI
2018-06-16 06:44:19 +00:00
Hypolite Petovan
c651641856
Fix PHP 7.2 Warning in Model\Contact
2018-06-15 20:50:31 -04:00
bb79b8f4ac
More item calls have been replaced with the new functions
2018-06-15 22:30:49 +00:00
02fef0bcf5
Reworked notifications ("alt pager" added) / use of Item class to fetch data
2018-06-15 05:50:28 +00:00
4d4cce4867
The new function is now used here as well.
2018-06-10 10:14:53 +00:00
446a45003d
Added documentation, some indention fixes
2018-06-09 19:12:13 +00:00
baf316e898
The central item fetch does work now and the API now uses these functions
2018-06-09 16:56:37 +00:00
4874e589f1
New class function to fetch items
2018-06-07 06:03:12 +00:00
b654af28fa
We need "global"
2018-06-03 09:40:32 +00:00
d7c477d0f4
Don't probe anymore, but ensure that we got good contact data
2018-06-03 08:36:05 +00:00
3f07d01dd1
Get rid of unneeded or redundant fields
2018-06-03 07:42:56 +00:00
c6c94b8cea
Weird stuff
2018-06-02 13:00:47 +00:00
81c002370e
Only redirections to the same host do make sense
2018-06-02 08:42:46 +00:00
723b5ae803
Use MagicLinkbyId when possible
2018-06-02 08:28:01 +00:00
8a34895a23
Use magicLink whenever possible
2018-06-02 08:05:06 +00:00
b5b172500d
Merge remote-tracking branch 'upstream/develop' into public-redir
2018-06-01 12:32:51 +00:00
Hypolite Petovan
93daf7883e
Merge branch 'master' into develop
...
- Updated new develop version label
- Incremented database build number
2018-06-01 07:30:04 -04:00
ae8d7267a0
"redir" is now centralized and works with the public contact
2018-06-01 06:46:34 +00:00
9ea6d4b26d
the detected language was not stored during user creation
2018-05-31 08:27:27 +02:00
8329705eba
New function to delete items for users
2018-05-29 05:22:57 +00:00
708ddf2b02
Preparation for new deletion functionality
2018-05-26 20:23:49 +00:00
a6396dde55
Removed useless line
2018-05-26 20:08:42 +00:00
a50805c371
Grammar fix
2018-05-26 20:07:30 +00:00
bdbc51229a
Fix for not being able to delete items
2018-05-26 18:07:27 +00:00
4a67919be7
Issue 5010: Don't show removed users
2018-05-24 04:44:02 +00:00
3fe07cca57
Issue 2880: Editing post doesn't destroy mentions or hashtags anymore
2018-05-19 14:55:27 +00:00
e9848d7b8f
End subscription for unreachable subscribers
2018-05-19 03:56:29 +00:00
8983c61023
Fix: Sometimes the contact endpoints seem to be wrong
2018-05-18 12:26:10 +00:00
4355014492
Now it should work ...
2018-05-17 23:47:15 +00:00
f4a71b76dd
Dynamic priority handling
2018-05-17 23:43:44 +00:00
61824119e4
Moved functionality in new model class
2018-05-17 23:30:49 +00:00
ac67f3c154
Merge pull request #5071 from annando/fix-duplicated-posts
...
Bugfix: Only send a notifier when the item was really edited
2018-05-17 07:59:56 +02:00
b333c7ae2e
Bugfix: Only send a notifier when the item was really edited
2018-05-17 05:49:55 +00:00
6129eb1623
OpenId possibly fixed:
...
- The LightOpenId class' constructor now requires the hostname from where the
requested started, added it now
- sometimes need to invoke get_app() as $a was not around
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-17 00:24:25 +02:00
84248ac4c1
Grammar stuff
2018-05-16 03:54:08 +00:00
fe8a4d50c8
Merge branch 'item-delete' of github.com:annando/friendica into item-delete
2018-05-15 19:31:05 +00:00
4a1bbd114c
Lower priority for "remote self"
2018-05-15 19:29:14 +00:00
82937189ba
Only delete undeleted items
2018-05-15 19:25:35 +00:00
fc60e23314
Added comments / hourly workerqueue deletion
2018-05-15 17:50:29 +00:00
3e475f3b82
Delete the shadow post when it is the last one
2018-05-15 16:40:13 +00:00
4a7bf95926
Fix: Delete all item copies if it is an original item
2018-05-15 15:51:58 +00:00
ba4f9b6136
Merge pull request #5054 from annando/diaspora-comments
...
Fix: public comments weren't distributed to the followers.
2018-05-15 07:30:34 +02:00
8564eeec4e
Fix: public comments weren't distributed to the followers.
2018-05-15 04:33:28 +00:00
e409001dfb
Fixed "constant" result, maybe there is a $ missing?
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-15 03:26:20 +02:00
57e668d9e0
Continued:
...
- avoided else() block which reduces code complexibility
- used more x()
- added curly braces
- added known type-hints
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:05 +02:00
f9c695e78d
Fix SQL error during postupdate
2018-05-11 09:20:59 +00:00
3d2bc7700e
Fix SQL error
2018-05-10 20:14:51 +00:00
3eb0b795fc
Bugfix: Avoid empty avatar photos when a public contact is created
2018-05-09 06:53:57 +00:00
08bf19082c
Ensure that there will always be an author-id and owner-id in the items
2018-05-08 20:20:15 +00:00
6c35f8ebf3
Update script for setting author-id and owner-id in item and thread table
2018-05-08 17:50:06 +00:00
7d6b1264ec
Fix for issue 4994: Feed items now appear again
2018-05-08 06:11:46 +00:00
1230ff146a
"remote-self" is now working for Diaspora and Twitter as well
2018-05-04 21:12:13 +00:00
4ad655ab80
Replace old database queries with the new ones
2018-05-02 19:26:15 +00:00
Michael Vogel
bd0ba24518
Merge pull request #4951 from MrPetovan/bug/4946-move-current-theme-to-app
...
Move current_theme() to App
2018-04-29 19:11:49 +02:00
Hypolite Petovan
fde3d6f870
Replace current_theme() and current_theme_url() calls
2018-04-28 18:37:25 -04:00
Hypolite Petovan
bd21fc3751
Import posts from ignored contacts
2018-04-27 21:08:19 -04:00
1e2bc1e6cf
Ensure local delivery of Diaspora comments
2018-04-27 04:11:33 +00:00
Hypolite Petovan
33a551235e
Merge pull request #4934 from annando/distribute-precaution
...
Item distribution: Better don't store these values
2018-04-26 16:26:23 -04:00
4a792761d1
Item distribution: Better don't store these values
2018-04-26 20:11:29 +00:00
Hypolite Petovan
9e700ba6ea
Merge pull request #4933 from annando/bugfix-distribute
...
Bugfix: The Distribition of public items failed with comments
2018-04-26 16:02:56 -04:00
da3658c80d
Bugfix: The Distribition of public items failed with comments# Bitte geben Sie eine Commit-Beschreibung für Ihre Änderungen ein. Zeilen,
2018-04-26 19:47:12 +00:00
Hypolite Petovan
f7f640175a
Fix PHP 7.2 warning in Model\Profile
2018-04-26 04:56:42 -04:00
66547e5107
Don't distribute for ignored contacts
2018-04-25 16:00:21 +00:00
5019d46071
We only need the uid
2018-04-24 14:58:39 +00:00
5cf745af44
Item distribution is now done via the public post
2018-04-24 13:21:25 +00:00
ba35b19af6
Public federated items now always are having an entry with "uid=0"
2018-04-23 11:14:25 +00:00
Hypolite Petovan
b0564ea40d
Fix count() warning in Model\Profile
...
- Replace x() calls with empty() in Profile::load
- Remove extraneous $a->page['aside'] initialization
2018-04-23 00:01:46 -04:00
Michael Vogel
37e5272f92
Merge pull request #4881 from MrPetovan/task/4867-guess-language-from-plaintext
...
Guess language from plaintext
2018-04-23 00:26:05 +02:00
Hypolite Petovan
d977ff78df
Uncomment some code in ItemContent::getPlaintextPost
...
- I have no idea what I'm doing
2018-04-22 11:43:27 -04:00
Michael Vogel
6e9ed3f01b
Merge pull request #4894 from MrPetovan/task/4513-show-events-reminders-attendence
...
Only show event reminders of events attendyes or attendmaybe
2018-04-22 17:38:32 +02:00
Hypolite Petovan
82ed6fff9f
Use public_contact() instead of wrong query in Profile::getEventsReminderHTML
2018-04-22 11:29:55 -04:00
Hypolite Petovan
e0b33b36a2
Decrease scope of query in Profile::getEventsReminderHTML
...
- Use specific SELECT fields
- Use INNER JOIN
2018-04-22 04:41:53 -04:00
Hypolite Petovan
08afec3170
Only show event reminders of events attendyes or attendmaybe
2018-04-21 22:53:13 -04:00
Hypolite Petovan
6d88984ee5
Move Model\Item::getPlaintextPost to Model\ItemContent::getPlaintextPost
2018-04-21 20:50:13 -04:00
Hypolite Petovan
daf94a8f63
Merge pull request #4891 from annando/private-forum-redux
...
Better working with private forums
2018-04-21 18:19:27 -04:00
16beab4652
Better working with private forums
2018-04-21 21:59:02 +00:00
Hypolite Petovan
abc50eb3ae
Improve Model\Item::addLanguageInPostopts()
...
- Use Content\BBCode::toPlaintext method
- Rename $arr parameter to $item
- Rename $lng variable to $languages
2018-04-21 04:11:32 -04:00
Hypolite Petovan
5476da53aa
Move Content\BBCode::toPlaintext() to Model\Item::getPlaintextPost()
2018-04-21 04:09:45 -04:00
Hypolite Petovan
0496822ca3
Add Exception when password is empty in User::hashPassword()
2018-04-19 07:51:26 -04:00
Michael Vogel
10465110c1
Merge pull request #4851 from MrPetovan/task/4709-add-query-based-content-filter
...
Add query based content filter
2018-04-19 08:21:53 +02:00
8a730b2d85
Issue 4655: Avoid multiplicated contact requests from the same account
2018-04-18 05:02:59 +00:00
Hypolite Petovan
6d2d15a80d
Merge pull request #4782 from Alkarex/fix-update-password
...
Fix update password rehash
2018-04-17 07:25:52 -04:00
Hypolite Petovan
17a0cc4f3d
Add Model\Term::populateTagsFromItem method
2018-04-16 22:22:58 -04:00
Alexandre Alapetite
360e2e6342
Revert removal of legacy_password column
...
https://github.com/friendica/friendica/pull/4782#issuecomment-380978218
2018-04-15 11:12:32 +02:00
Alexandre Alapetite
991a3d959e
Revert "Remove SQL column legacy_password"
...
This reverts commit 82f1f2f00e
2018-04-15 10:51:22 +02:00
a53f01bacc
Update the "photo" and "thumb" field in the "profile" table
2018-04-14 08:03:15 +00:00
75f97db4ec
Issue-4816: Avoid SQL errors / Unarchive living relais servers
2018-04-11 18:56:22 +00:00
869d8ab12d
We can now define the days after a contact is archived
2018-04-10 11:10:02 +00:00
5c2b54009e
The magic link is added at more places
2018-04-08 19:17:50 +00:00
Alexandre Alapetite
e860cdf6a8
Swap if / elseif
...
https://github.com/friendica/friendica/pull/4782#discussion_r179947984
2018-04-08 16:02:25 +02:00
Alexandre Alapetite
82f1f2f00e
Remove SQL column legacy_password
2018-04-08 14:53:12 +02:00
Alexandre Alapetite
cb26cd6d5d
Remove legacy_password test
2018-04-08 14:42:18 +02:00
Alexandre Alapetite
129f6806f6
Fix update password rehash
...
Fixes https://github.com/friendica/friendica/issues/4743
The logic for updating password was wrong:
b0a764b14c (diff-1466bb1a0a37fe9f7cf52eda8f3b431aR150)
2018-04-08 12:40:35 +02:00
Pierre Rudloff
b3235c2d02
Implement parts of the list API:
...
lists/statuses
lists/destroy
lists/update
lists/create
lists/ownerships
2018-04-07 19:16:47 +02:00
Hypolite Petovan
8b5341b84c
Fix event id typo in Model\Event
2018-04-06 20:58:09 -04:00
1e8dd96938
Fix: The register mail contained variables in a wrong order
2018-04-04 19:56:34 +00:00
6cef0fbaeb
added link to delete the account to the registration mail text
2018-04-02 18:40:52 +02:00
dece06c571
Bugfix: Prevent "Uncaught TypeError: Argument 1 passed to Friendica\Model\Event::formatListForExport() must be of the type array, object given"
2018-03-25 18:56:35 +00:00
402c0fc770
Using the default avatar when no avatar was found for the self contact
2018-03-25 17:26:40 +00:00
Hypolite Petovan
30113dd6ef
Merge pull request #4683 from annando/update-self
...
The "self" contact is now updated at a central place
2018-03-25 09:25:10 -04:00
ad3e4b894e
Update the public contact
2018-03-25 08:20:13 +00:00
abb49150db
Update the avatar
2018-03-25 08:15:22 +00:00
a0451e1c62
Merge remote-tracking branch 'upstream/develop' into update-self
2018-03-24 22:50:14 +00:00
e8e6436f08
Issue 4673: Avoid "Incorrect date value: '0000-00-00' for column 'bd'"
2018-03-24 22:27:04 +00:00
Hypolite Petovan
9665f4ed41
Merge pull request #4675 from annando/group-delete
...
Fix: Groups can now be deleted again
2018-03-24 15:25:26 -04:00
07a1796e8f
Fix: Groups can now be deleted again
2018-03-24 07:26:57 +00:00
bac60164e7
New function to keep the self contact updated
2018-03-24 06:15:18 +00:00
Hypolite Petovan
95792f6b79
Fix typo in mod/events
...
- Add todo in Model\Event
2018-03-23 06:34:21 -04:00
Hypolite Petovan
254974826f
Fix wrong contact retrieval condition in Event::store
2018-03-23 06:34:21 -04:00
Hypolite Petovan
bc12ba68cd
Fix wrong parameter check in Event::store
2018-03-23 06:34:21 -04:00
Hypolite Petovan
089f556327
Initialize $event in Event::store
2018-03-23 06:34:21 -04:00
Hypolite Petovan
89e9cbb0b5
Remove private key from event array in Event::store
2018-03-23 06:34:21 -04:00
Hypolite Petovan
6e7c6ab0fa
Remove references to include/event
2018-03-23 06:32:34 -04:00
Hypolite Petovan
f7e2071117
Replace include/event function with method calls
...
- Updated scope of Model\Event methods
- Updated use list
2018-03-23 06:32:34 -04:00
Hypolite Petovan
8c956ac0c8
Add new classes
...
- Add Model\Event class
- Add Content\Widget\CalendarExport class
2018-03-23 06:32:08 -04:00
Hypolite Petovan
27d94023ee
Merge branch 'master' into develop
2018-03-23 06:15:55 -04:00
b171fb1f24
Fix: Items with "uid=0" always had the "parent-uri" as "thr-parent"
2018-03-22 16:18:49 +00:00
Hypolite Petovan
701fd41463
Rename checkPasswordExposed to isPasswordExposed
2018-03-21 02:14:43 -04:00
Hypolite Petovan
ca13570251
Add exposed password check to manual password change
2018-03-21 01:33:35 -04:00
8053172398
Issue 4610: The query is simplified and shouldn't fail again
2018-03-17 07:50:49 +00:00
d616bb7564
Fix: In the contact search you had been able to delete your own contact
2018-03-17 06:17:32 +00:00
67fa6aa809
We now change relationships not only for OStatus contacts
2018-03-16 06:58:54 +00:00
59dd353464
DFRN: The relationship between contacts can now be changed afterwards
2018-03-16 06:43:10 +00:00
b7a5e076fc
Fix: The ownership of forum items had been wrong
2018-03-11 18:12:38 +00:00
480fde7ca8
Bugfix: missing "use"
2018-03-08 20:48:00 +00:00
Hypolite Petovan
789561c7a2
Remove/Update references to include/html2*.php
2018-03-07 16:34:17 -05:00
cd79ce3a57
Fix: Multiple accounts per mail address are allowed when not explicit forbidden
2018-03-04 22:23:52 +00:00
Hypolite Petovan
ab544e1e9f
Add missing dba::close() call in Contact::pruneUnavailable
2018-03-03 07:41:49 -05:00
Hypolite Petovan
09c717d751
Remove references to include/acl_selectors
2018-03-02 18:40:09 -05:00
Hypolite Petovan
ce9e0f3649
Move prune_deadguys to Contact
2018-03-02 18:40:08 -05:00
Hypolite Petovan
eeafb59c31
Add new class/functions
...
- Create class Core\Acl
- Add Contact::pruneUnavailable
- Add mod_content
2018-03-02 18:40:08 -05:00
b5f8d73833
Merge pull request #4527 from annando/fix-no-constant-update
...
Bugfix: No constant update in "getIdForUrl"
2018-03-02 10:58:17 +01:00
361af7bc78
Bugfix: No constant update in "getIdForUrl"
2018-03-02 03:55:24 +00:00
Hypolite Petovan
41678ec3cd
Add no_update flag to speed up Contact::getIdForURL instances
2018-03-01 19:54:45 -05:00
Hypolite Petovan
9f21e7f34f
Use default value for uid parameter in Contact::getIdForURL
2018-03-01 19:54:12 -05:00
Hypolite Petovan
4d3ea08c97
Use NOT EXISTS to improve performance
2018-02-28 08:50:26 -05:00
Hypolite Petovan
f58d8f4108
Add attendance check to event reminder
2018-02-27 20:47:18 -05:00
d4c95e0032
Contact updates should now work more reliable
2018-02-26 21:53:42 +00:00
9e721c0908
guid creation: Take the hostname from mail addresses for mail posts
2018-02-26 11:48:05 +00:00
2f2e7b9d5a
fetch_first is now used / additional logging
2018-02-22 09:51:59 +00:00
046352606e
Bugfix: $uid wasn't available in that context
2018-02-22 07:05:56 +00:00
2897333c28
Most queries are now done with the dba functions
2018-02-22 06:52:58 +00:00
8ad2ebbf47
$u is now $user
2018-02-21 23:10:29 +00:00
8e0496c040
Better naming of variables
2018-02-21 22:55:23 +00:00
5a91c746e9
$arr is now $item
2018-02-21 21:39:07 +00:00
82bd26edb9
The item class had been improved (e.g. database calls)
2018-02-21 21:08:37 +00:00
a59796d1d4
No gcontact-id anymore (It wasn't really used)
2018-02-21 05:15:55 +00:00
Hypolite Petovan
eed35c3e69
Merge pull request #4484 from annando/item-guid
...
The guid creation for posts is now done in a separate function
2018-02-20 23:22:11 -05:00
475969a1d3
The guid creation for posts is now done in a separate function
2018-02-21 04:13:13 +00:00
3e46382459
Standard stuff
2018-02-20 11:20:28 +00:00
a3af6807ac
Improved resource id creation
2018-02-20 10:02:07 +00:00
Hypolite Petovan
9e3bae5caa
Remove references to include/bbcode.php
2018-02-14 22:01:14 -05:00
Hypolite Petovan
0c52866693
Refactor bbcode() into BBCode::convert()
2018-02-14 21:33:55 -05:00
Hypolite Petovan
41cd5af54f
Merge pull request #4459 from annando/unmark-contact
...
Bugfix and improvements for unmarking potentially archived contacts
2018-02-14 17:01:17 -05:00
43b1eccbcd
Bugfix and improvements for unmarking potentially archived contacts
2018-02-14 21:18:16 +00:00
Hypolite Petovan
d419d07f73
[Scrutinizer] Fix undeclared variables in src/ (except Protocol/)
...
- Use dba::selectFirst to remove intermediate variables `$r`
- Remove unused variable `$url_recipients` in Worker\Dellivery
2018-02-14 00:05:00 -05:00
rabuzarus
af3a57376a
Item::tagDeliver(): remove contact as array key for hooks because it was never declared
2018-02-12 17:05:01 +01:00
rabuzarus
58b4169097
fix undeclared $uid variables in Item::insert()
2018-02-12 16:56:52 +01:00
rabuzarus
342b9af734
fix undeclared variables or wrong variable names (/src)
2018-02-12 16:08:28 +01:00
Hypolite Petovan
8b557c3157
Merge pull request #4433 from annando/direct-block
...
Suppress content from hidden or blocked contacts
2018-02-10 07:49:34 -05:00
ee7c587693
Suppress content from hidden or blocked contacts
2018-02-10 12:34:10 +00:00
rabuzarus
9a4d19e284
move membersince addon to core
2018-02-09 20:44:45 +01:00
Hypolite Petovan
8a9917857e
Handle authentication exceptions in Login module
...
- Break down large methods into smaller ones
- Add more authentication exception
- Add a legacy User::authenticate method
2018-02-09 00:08:01 -05:00
1424559bee
Forgotten "+"
2018-02-08 19:47:47 +00:00
70c31a6149
Improved date time formula thing.
2018-02-08 19:33:40 +00:00
d70a20a466
We now incrementally calculate the queue delivery time
2018-02-08 18:39:48 +00:00
0093f863fd
Don't add already queued items from Diaspora to the queue again
2018-02-08 11:26:24 +00:00
3890dfee4a
Wrong function order in Item::update
2018-02-07 20:09:37 +00:00
85c8bf0228
Merge pull request #4399 from MrPetovan/task/3878-move-include-bbcode-to-src
...
Move include/bbcode to src/ part 1 : Everything but bbcode()
2018-02-07 07:18:39 +01:00
7be59dbeab
Priority and capitalisation
2018-02-06 16:32:00 +00:00
e609de2957
Many item calls are now isolated in a single function
2018-02-06 12:40:22 +00:00
Hypolite Petovan
9a76a14778
Missing dba::selectFirst in Model\Item
2018-02-05 20:45:12 -05:00
Hypolite Petovan
a62b46375d
Move PROTOCOL_* constants to Model\Conversation
2018-02-05 14:09:03 -05:00
Adam Magness
4c93b592a5
Rebase
...
fix from rebase
2018-02-05 12:49:03 -05:00
Adam Magness
db8ef98537
Rename functions
...
rename functions from review comments
2018-02-05 12:48:22 -05:00
Adam Magness
992836e261
Some standards and dba
...
update some calls to use dba functions and some standards updates
2018-02-05 12:47:37 -05:00
Adam Magness
7ffcb25321
Update function names and calls
...
update function names and calls from other files
2018-02-05 12:47:04 -05:00
Adam Magness
f4fa8f085b
Functions to Item class
...
copy functions to Item class
2018-02-05 12:45:52 -05:00
Michael Vogel
fa95911fdb
Merge pull request #4393 from MrPetovan/task/3878-move-include-tags-to-src
...
Move include/tags to src/
2018-02-05 18:11:29 +01:00
Hypolite Petovan
2a5431a59e
Rename Model\Term methods
2018-02-04 16:48:50 -05:00
Hypolite Petovan
2a486903d1
Remove references to include/tags.php
2018-02-03 23:59:31 -05:00
Hypolite Petovan
9f3acceac7
Replace references to include/tags functions
2018-02-03 23:57:47 -05:00
Hypolite Petovan
507bea0e9f
Copy functions from include/tags to src
...
- Create Content\Widget\TagCloud
- Populate Worker\TagUpdate::execute
- Add Content\Widget::tagCloud
- Add Model\Term::insertFromItemId and Model\Term::insertFromItemUri
2018-02-03 23:51:40 -05:00
Hypolite Petovan
0abe4158d2
Rename Term methods ahead of the move
...
- Rename createFromItemURI() to insertFromItemFileByUri()
- Rename createFromItem() to insertFromItemFileById()
2018-02-03 22:42:31 -05:00
Hypolite Petovan
4050a7b8dc
Replace forgotten datetime_convert() instances
2018-02-03 20:47:37 -05:00
Hypolite Petovan
f020292408
Remove references to include/datetime
2018-02-03 20:47:37 -05:00
Hypolite Petovan
cea80c78e4
Replace remaining functions in include/datetime by Temporal methods
...
- Fix uses statements
2018-02-03 20:47:37 -05:00
Hypolite Petovan
593774b613
Update moved method Item::performLike() with DateTypeFormat
...
- Update use list
2018-02-03 08:56:55 -05:00
Hypolite Petovan
0454d0a670
Fix incorrect Temporal reference after Item function move rebase
2018-02-03 08:56:55 -05:00
Hypolite Petovan
5e7285b9ba
Move Temporal::convert() to DateTimeFormat::convert()
2018-02-03 08:56:55 -05:00
Hypolite Petovan
89602e44da
Add Temporal::timezoneNow() shorthand for Temporal::convert()
2018-02-03 08:56:53 -05:00
Hypolite Petovan
35d06bd9eb
Add Temporal::utc() shorthand to Temporal::convert()
2018-02-03 08:56:53 -05:00
Hypolite Petovan
8aff8a76eb
Add Temporal::utcNow()
2018-02-03 08:56:52 -05:00
Hypolite Petovan
dc366bf1f7
Refactor datetime_convert into Temporal::convert
...
- Changed parameter order to save space
- Refactor select_timezone into Temporal::getTimezoneSelect
- Refactor field_timezone into Temporal::getTimezoneField
2018-02-03 08:56:51 -05:00
Hypolite Petovan
d478ef6c6d
Add Util\Temporal to src
...
- Map include/datetime functions to Temporal methods
- Move update_contact_birthdays() to Model\Contact::updateBirthdays()
2018-02-03 08:56:51 -05:00
Hypolite Petovan
426fd7045a
Add Model\Item::performLike function
...
- Fix uses
2018-02-01 14:14:11 -05:00
f8526c1664
Some other message
2018-01-30 20:48:12 +00:00
e08be4e921
Improved message
2018-01-30 19:31:57 +00:00
edf7213297
Better message
2018-01-30 19:20:41 +00:00
ae362f01d5
Quit if follow failes because of not configured addon
2018-01-30 18:51:09 +00:00
6871481a78
Moved "limitBodySize"
2018-01-28 17:36:37 +00:00
bdbfffafea
Renamed the contact relationship functions
2018-01-28 17:26:39 +00:00
2cb74909c0
Standards
2018-01-28 16:28:59 +00:00
630cdaeb96
Added some defaults
2018-01-28 16:16:21 +00:00
e080ea03c0
Function needed to be public, not private
2018-01-28 14:06:02 +00:00
7b27dda784
Most functions now moved from include/items.php
2018-01-28 11:18:08 +00:00
Hypolite Petovan
236616995b
Remove references to library/openid
2018-01-27 18:28:04 -05:00
Adam Magness
f04d40a37e
Review update
...
Rename function, move others
2018-01-27 11:13:41 -05:00
Adam Magness
0f1be37279
Remove old file
...
remove network.php and all require_once statements
2018-01-27 08:28:20 -05:00
Adam Magness
1eb7c19c1e
Move multiple functions
...
move multiple smaller functions
2018-01-26 23:51:41 -05:00
Adam Magness
2f9642392d
Move z_fetch_url
...
move z_fetch_url method
2018-01-26 23:18:38 -05:00
Adam Magness
c67452f72e
Move fetch_url
...
move fetch_url function
2018-01-26 23:09:48 -05:00
Hypolite Petovan
9cd3b17743
Fix translation strings for use with util/extract.php
...
- Change parentheses to “\x28” and “\x29”
- Remove leading commas
- Remove quotes before commas
2018-01-24 16:51:32 -05:00
Adam Magness
208a149a7b
Review sprintf
...
remove more sprintf calls
2018-01-23 21:59:16 -05:00
Adam Magness
f0725ae384
Hopefully all t()
...
hopefully the last of the t()
2018-01-22 18:03:26 -05:00
Adam Magness
b4d0df18c5
Remove old file and requires
...
Remove pgettext.php and remove require_once calls
2018-01-22 18:03:26 -05:00
Adam Magness
07d306aa37
Finish t() for src
...
Update t() calls in src folder
2018-01-22 18:03:26 -05:00
Adam Magness
d49f986d1e
Many t() calls
...
modify many t() calls.
2018-01-22 18:03:26 -05:00
Hypolite Petovan
b0a764b14c
Use password_hash() for passwords
...
- Use legacy_password to update double-hashed passwords
2018-01-20 22:29:03 -05:00
Hypolite Petovan
986e22d9e1
Merge pull request #4292 from annando/reduce-items.php
...
Relocate functions in items.php into several classes
2018-01-20 20:24:42 -05:00
004f46e600
Standards
2018-01-21 00:18:31 +00:00
efa8dbcfb3
Relocate functions in items.php into several classes
2018-01-20 23:52:54 +00:00
Hypolite Petovan
0888f51b4b
Add password reset request expiration
...
- Change password reset link to /lostpass/[pwdreset]
2018-01-20 18:15:55 -05:00
Hypolite Petovan
209c43ebbc
Centralize password hashing in Model\User
2018-01-20 17:32:24 -05:00
7be49d9411
Don't delete - but only mark as deleted
2018-01-20 22:16:43 +00:00
Adam Magness
b86b04a81a
Change plugin to addon
...
change the use of plugin to addon where appropriate.
2018-01-20 07:48:22 -05:00
Adam Magness
6c4c567319
Remove require
...
remove require_once for plugins.php
2018-01-20 07:48:22 -05:00
Adam Magness
11cf36105c
Update Addon functions and calls
...
Update function names and calls for Addon class.
2018-01-20 07:48:22 -05:00
2d66242b4f
The delete function is now changed to the new function
2018-01-17 23:22:01 +00:00
000e6457b4
Merge remote-tracking branch 'upstream/develop' into item-delete
2018-01-17 21:54:17 +00:00
fbb024d151
Avoid sql error in process handling
2018-01-17 14:10:30 +00:00
947a1b894f
Wall postings need to be treated especially as well.
2018-01-17 14:09:24 +00:00
2df5a14ce5
Delete could work now, needs testing
2018-01-17 07:08:49 +00:00
32c1c04a1c
Merge remote-tracking branch 'upstream/develop' into item-delete
2018-01-17 06:12:11 +00:00
Hypolite Petovan
c1c9a829fa
Add missing include in Model\Process
2018-01-17 00:17:58 -05:00
Hypolite Petovan
f193f01a7d
Fix issues in changed files
...
- Initializes $return in Process::insert
- Update the type hint of dba::fetch
- Remove unused $a parameter in worker_init()
- Fix uses
2018-01-17 00:17:58 -05:00
Hypolite Petovan
78ac7afe9c
Move process functions to Model\Process
...
- Add start|endProcess functions to Core\Worker
2018-01-17 00:17:58 -05:00
3ecdbb6a59
Standards
2018-01-16 23:20:07 +00:00
63a4105a59
New item class function for delete
2018-01-16 23:16:53 +00:00
f30275f6db
Oh, standards ...
2018-01-16 22:46:20 +00:00
c4d3ab6878
Transfer all item shadow functions to the item class
2018-01-16 22:23:19 +00:00
Adam Magness
33ac7a529f
Update functions and calls
...
update function names and calls
2018-01-15 20:12:07 -05:00
Adam Magness
a5b3f4b2ba
Create Queue class
...
Create queue class and functions from queue_fn.php
2018-01-15 19:28:39 -05:00
Hypolite Petovan
e36f2bb1fb
Use short form array syntax everywhere
...
- Add short form array syntax to po2php.php generation
2018-01-15 14:07:17 -05:00
Adam Magness
8c878a7ad3
Remove indexes
...
remove [0] from selectFirst objects
2018-01-15 12:37:44 -05:00
