Roland Häder
6b5d90333f
Fixes for some E_NOTICE and type-hints added ( #5358 )
...
* Fixed http://github to https://github
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixes for #4965 :
- updated messages.po file
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixed E_NOTICE where isset()/empty() was absent.
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixed missing variable $sql_order causing E_NOTICE.
Signed-off-by: Roland Häder <roland@mxchange.org>
* Continued:
- added array type-hint where known (some)
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixes:
- in Profile::load() $user is now only one-dimensional
- $a->get_hostname is no property, it is a method
Signed-off-by: Roland Häder <roland@mxchange.org>
* reverted changes that are unintended
Signed-off-by: Roland Häder <roland@mxchange.org>
* Continued:
- removed leading \ (uncommon, okay)
- removed entire if() block (CR by Hypolite)
Signed-off-by: Roland Häder <roland@mxchange.org>
* Removed if() block
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-07-13 15:47:14 -04:00
Michael Vogel
0360f7197a
Several more warnings ... ( #5340 )
...
* Some more warnings removed
* Even more warnings ...
* Will it ever end? ;-)
* Avoid warning in dbstructure
* Origin and OStatus ...
* There are more warnings solved ... yeah!
* And again ...
* We are not done yet
* And more ...
* And some new places ...
* And more in the feeds
* Avoid some more
* And some backend stuff
* Notifications cleared
* Some more stuff
* and again ...
* It's getting fewer ...
* Some warnings had been hidden in the notifications
* Fix the fix
* And another missing one ...
* We need the owner here, not the user
* Forgotten user
* And more ...
* And some more warnings disappeared ...
* Some more frontend warnings
* Some backend warnings removed
* Fixed sidebar for "vier"
* And more ...
* Some more ...
* And something for "remote self"
* Am I stuck in an endless loop?
* Fix: Clear tag and file field on update
* Preset page content
2018-07-10 08:27:56 -04:00
675a6adf35
Added comment
2018-07-08 13:52:11 +00:00
8a2230bc4c
Avoid warnings in addons
2018-07-08 12:01:36 +00:00
717ca0b7eb
Use already fetched data for magiclink
2018-07-02 05:41:55 +00:00
b03db4643f
The fetch function now centrally controls the content
2018-06-24 10:48:29 +00:00
d643e00d33
Standards and a new function to fetch content
2018-06-21 15:14:01 +00:00
ab5669e091
Some more direct SQL calls had been replaced
2018-06-19 19:06:17 +00:00
4714cb746b
Use the item functions at many more places
2018-06-18 20:36:34 +00:00
6e10de9284
New function to fetch item data especially for users
2018-06-17 17:05:17 +00:00
0280a46ab4
Use predefined field lists
2018-06-17 06:27:52 +00:00
bb79b8f4ac
More item calls have been replaced with the new functions
2018-06-15 22:30:49 +00:00
5d9083c369
Bugfix in notifications / network and display are using the new functions now
2018-06-10 07:26:37 +00:00
baf316e898
The central item fetch does work now and the API now uses these functions
2018-06-09 16:56:37 +00:00
3f07d01dd1
Get rid of unneeded or redundant fields
2018-06-03 07:42:56 +00:00
723b5ae803
Use MagicLinkbyId when possible
2018-06-02 08:28:01 +00:00
8a34895a23
Use magicLink whenever possible
2018-06-02 08:05:06 +00:00
b5b172500d
Merge remote-tracking branch 'upstream/develop' into public-redir
2018-06-01 12:32:51 +00:00
Hypolite Petovan
93daf7883e
Merge branch 'master' into develop
...
- Updated new develop version label
- Incremented database build number
2018-06-01 07:30:04 -04:00
ae8d7267a0
"redir" is now centralized and works with the public contact
2018-06-01 06:46:34 +00:00
4c36109f02
Some more places to add the user id
2018-05-26 20:03:30 +00:00
bdbc51229a
Fix for not being able to delete items
2018-05-26 18:07:27 +00:00
c9f55f6b3d
Show "Remove from your screen" or "delete" depending of the impact of the deletion
2018-05-15 21:06:34 +00:00
f34d72c143
Fixes:
...
- used empty() instead of x()
- removed superflous count()
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:22 +02:00
debcdea82a
Continued:
...
- merged 2 if() into one with &&
- added TODO for possible rewrite (avoid "complex" code)
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:05 +02:00
57e668d9e0
Continued:
...
- avoided else() block which reduces code complexibility
- used more x()
- added curly braces
- added known type-hints
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:05 +02:00
e0a07d5f27
Continued:
...
- used x() to make sure the array key is there, else an E_NOTICE is triggered
- added type-hints where it is safe
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:50:04 +02:00
c3c9a53364
added spaces + curly braces and TODOs for upcoming type-hint rewrite. Please
...
note that PHP5 allows 'array' as type-hint already (+ interface/class name).
Signed-off-by: Roland Haeder <roland@mxchange.org>
2018-05-14 22:49:58 +02:00
f7ceea7a85
added spaces + some curly braces
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2018-05-14 22:49:55 +02:00
914a4e2e0a
Fix: Public items werent visible under certain circumstances
2018-05-10 22:06:34 +00:00
6c792588fd
Ensure to mostly fetch the item with an non zero user id
2018-05-08 22:26:49 +00:00
8d513d74be
Reverted SQL sorting
2018-05-08 22:08:25 +00:00
14833edb2d
Issue 4990: Fixes missing posts on network page
2018-05-08 22:00:32 +00:00
125afb4ae5
Suppress blocked contacts from being displayed
2018-05-04 21:27:20 +00:00
78f563407a
Fix PR 4942: Fixed item query
2018-04-29 16:32:46 +00:00
Hypolite Petovan
9edff6cc5c
Add exception for self-contact in item_joins()
2018-04-28 11:38:01 -04:00
Hypolite Petovan
c417f779c4
Add missing readonly check for displaying items in item_joins
2018-04-28 07:47:02 -04:00
Hypolite Petovan
98f64ed824
Replace duplicate behaviors by Model\Term::populateTagsFromItem
...
- Replaced in include/conversation
- Replaced in include/text
2018-04-16 22:22:58 -04:00
Michael Vogel
05cff59f70
Merge pull request #4722 from MrPetovan/task/add-content_filter-hook
...
Add content_filter hook
2018-04-06 06:42:52 +02:00
3792012723
Improved accessibility for "Frio"
2018-04-05 21:50:34 +00:00
Hypolite Petovan
34fd442821
Rename social.disable_cw pconfig to system.disable_cw
2018-04-04 23:08:48 -04:00
Hypolite Petovan
41db5f0912
Display content warning as title if collapsing is deactivated
2018-04-04 23:08:48 -04:00
Hypolite Petovan
27d94023ee
Merge branch 'master' into develop
2018-03-23 06:15:55 -04:00
5bd519efff
There is now a "content-warning" field
2018-03-14 22:28:35 +00:00
Hypolite Petovan
b8fca5efe7
[PHP 7.2] Fix missing Countable warning
2018-03-03 08:48:30 -05:00
1510b3d948
tyoi, found by 朱陈锬 thanks for that!
2018-03-03 11:02:40 +01:00
Hypolite Petovan
09c717d751
Remove references to include/acl_selectors
2018-03-02 18:40:09 -05:00
Hypolite Petovan
4fe1d804ab
Merge pull request #4511 from annando/no-activity
...
Only show visible activities
2018-02-27 04:41:12 -05:00
74ff36eee9
Only show visible activities
2018-02-27 09:29:11 +00:00
20368cbbf4
Fix for network update (number of maximum comments set to 0)
2018-02-26 22:15:57 +00:00
d2728cad2e
Children for the network page are now fetched correctly in the conversation
2018-02-26 06:38:27 +00:00
a1eb5a584f
Improve the queries on the network page
2018-02-25 21:33:15 +00:00
a59796d1d4
No gcontact-id anymore (It wasn't really used)
2018-02-21 05:15:55 +00:00
Hypolite Petovan
9e3bae5caa
Remove references to include/bbcode.php
2018-02-14 22:01:14 -05:00
ee7c587693
Suppress content from hidden or blocked contacts
2018-02-10 12:34:10 +00:00
Hypolite Petovan
010cf3b1e8
Update references to BBCode methods
...
- Resolve name conflicts with Util\Network
2018-02-04 19:26:22 -05:00
Hypolite Petovan
cea80c78e4
Replace remaining functions in include/datetime by Temporal methods
...
- Fix uses statements
2018-02-03 20:47:37 -05:00
Hypolite Petovan
5e7285b9ba
Move Temporal::convert() to DateTimeFormat::convert()
2018-02-03 08:56:55 -05:00
Hypolite Petovan
0bee706e51
Add Temporal::local() shorthand for Temporal::convert()
2018-02-03 08:56:53 -05:00
Hypolite Petovan
dc366bf1f7
Refactor datetime_convert into Temporal::convert
...
- Changed parameter order to save space
- Refactor select_timezone into Temporal::getTimezoneSelect
- Refactor field_timezone into Temporal::getTimezoneField
2018-02-03 08:56:51 -05:00
03aafa8228
Public commenting is now always enabled
2018-01-31 23:22:41 +00:00
Adam Magness
f04d40a37e
Review update
...
Rename function, move others
2018-01-27 11:13:41 -05:00
Adam Magness
ca76e49c23
Move remaining functions
...
update remaining function calls
2018-01-27 08:25:54 -05:00
Hypolite Petovan
9cd3b17743
Fix translation strings for use with util/extract.php
...
- Change parentheses to “\x28” and “\x29”
- Remove leading commas
- Remove quotes before commas
2018-01-24 16:51:32 -05:00
Adam Magness
428a22cc76
More sprintf
...
eliminate more sprintf( with L10n
2018-01-24 07:18:21 -05:00
Adam Magness
3b0f69599e
Updat tt() calls
...
update function calls for tt()
2018-01-22 18:03:26 -05:00
Adam Magness
c8ecc31405
Update functions and calls
...
Update function names and calls.
2018-01-22 18:03:26 -05:00
Adam Magness
11cf36105c
Update Addon functions and calls
...
Update function names and calls for Addon class.
2018-01-20 07:48:22 -05:00
034d46196f
"last-child" is not used anymore
2018-01-18 06:54:44 +00:00
Hypolite Petovan
e36f2bb1fb
Use short form array syntax everywhere
...
- Add short form array syntax to po2php.php generation
2018-01-15 14:07:17 -05:00
Adam Magness
4fb2547df8
Update function calls
...
update function calls to use profile class
2018-01-14 21:22:39 -05:00
Hypolite Petovan
5fc4927764
Improve dba::selectFirst calls
...
- Fix remaining $r[0] references
- Rename $r to meaningful names
2018-01-11 03:43:57 -05:00
Hypolite Petovan
ae66bcaff3
Rename selectOne to selectFirst
2018-01-10 12:57:21 -05:00
Hypolite Petovan
da60893590
Replace dba::select(limit => 1) by dba::selectOne
...
- Convert array declarations to new style
2018-01-10 12:57:21 -05:00
Adam Magness
a3ef9e35ec
Update functions and calls
...
Update function names and calls.
2018-01-09 22:42:04 -05:00
2d9163ce30
Posts from contacts weren't displayed correctly
2018-01-05 19:47:55 +00:00
Hypolite Petovan
3b4f5f98f8
Merge pull request #4169 from annando/comment-dfrn
...
Precaution for incomplete threads
2018-01-04 16:31:16 -05:00
05c8cbc1e1
Precaution for incomplete threads
2018-01-04 20:59:19 +00:00
Hypolite Petovan
58d5d91831
Merge pull request #4168 from annando/comment-dfrn
...
Commenting to (nearly) every Friendica contact is now possible
2018-01-04 15:12:07 -05:00
0c9a9b6f0c
Commenting to (nearly) every Friendica contact is now possible
2018-01-04 19:48:56 +00:00
Hypolite Petovan
3b23f89ca2
Fix unused code in include
...
- Fix local formatting
- Remove unused variable
- Fix unreached breaks
- Remove commented out code
- Add some documentation
2018-01-04 12:21:13 -05:00
Hypolite Petovan
d9c6417f5d
Remove construct_acl_data()
2018-01-04 12:19:06 -05:00
ade987db47
Updates for community pages do work now
2018-01-04 15:46:56 +00:00
b677bdd4ff
Ensuring that only local users can comment on community items
2018-01-04 14:39:47 +00:00
174a1bb54b
Commenting on community timelines is now possible
2018-01-04 10:02:56 +00:00
243848eec1
Remove some currently unused stuff
2018-01-03 13:34:51 +00:00
6925299e5a
Merge remote-tracking branch 'upstream/develop' into community
2018-01-03 01:15:27 +00:00
Hypolite Petovan
3069f3b59d
Fix formatting and PHP notices in include/conversation
...
- Remove unused $nickname variable
- Remove unused $comment variable
- Use defaults() in get_responses() to check for array key existence
2018-01-02 08:09:50 -05:00
5afedb28d4
You can now comment on the community page
2017-12-23 07:33:51 +00:00
f7272be4a8
Reshares are now working
2017-12-20 18:18:25 +00:00
343f22e02f
Updating after post does now work
2017-12-20 10:16:25 +00:00
b457ed6876
Preparation for being able to comment every public item
2017-12-19 17:15:56 +00:00
88ef61df95
Removed useless "function_exists" checks
2017-12-12 04:52:33 +00:00
Hypolite Petovan
3772cf7544
Move Object\Conversation to Object\Thread
...
- Move Object\Item to Object\Post
2017-12-07 23:57:37 -05:00
Hypolite Petovan
4b0f83a12b
Finish renaming Object\Item to Object\Post
2017-12-07 23:50:38 -05:00
Michael Vogel
5747cfc79c
Revert "Move Objects to Model"
2017-12-08 05:21:51 +01:00
Hypolite Petovan
70d047ba8e
Move Object\Conversation to Object\Thread
...
- Move Object\Item to Object\Post
2017-12-07 09:05:23 -05:00
Hypolite Petovan
18d93cddf6
Move Object\Contact to Model\Contact
2017-12-07 09:04:24 -05:00
0608efc38a
We've got no mood anymore
2017-12-07 07:01:55 +00:00
Adam Magness
b1d16fbdf7
Update use statements
...
update use statements for rename to singular.
2017-12-04 09:04:36 -05:00
