0888850702
Fix missing avatar key in DFRN
...
- Addresses https://github.com/friendica/friendica/issues/6338#issuecomment-456839092
2019-02-24 13:40:04 -05:00
42c06506ce
Stop appending entry when parent is missing in OStatus
...
- Addresses https://github.com/friendica/friendica/issues/6338#issuecomment-455785854
2019-02-24 13:36:37 -05:00
458064ddde
Merge pull request #6749 from nupplaphil/6386-php_fatal
...
Fixing appending child at DFRN without a parent id.
2019-02-24 12:55:34 -05:00
5d13b94761
update phpdoc
2019-02-24 16:31:16 +01:00
bf6a765beb
Fixing appending child at DFRN without a parent id.
2019-02-24 16:30:09 +01:00
Michael Vogel
efe358c617
Merge pull request #6746 from nupplaphil/issue/6338-notices
...
Fixing notices
2019-02-24 15:44:54 +01:00
5b932867c3
Fixing https://github.com/friendica/friendica/issues/6338#issuecomment-466749280
2019-02-24 15:22:14 +01:00
67aa188830
Improve Logger calls
...
- Add context in various calls
- Remove deprecated Logger::log call in Processor
2019-02-23 17:32:13 -05:00
cb78e77850
Fix implicit mentions in outgoing ActivityPub posts
...
- Add usage of system.disable_implicit_mentions to disable implicit mention behavior
- Add usage of item own implicit mentions to be prepended to the outgoing body
2019-02-23 17:32:12 -05:00
3ac8576c8e
Fix implicit mentions in incoming ActivityPub posts
...
- Use thr-parent instead of parent-uri to retrieve implicit mentions to remove from body
- Add potential implicit mentions to 'tags' array for storage in Processor::convertImplicitMentionsInTags()
- Add usage of system.disable_implicit_mentions to disable implicit mention behavior
2019-02-23 17:32:12 -05:00
fc47a07801
Fix Diaspora outgoing implicit mention
...
- Use name instead of nick for implicit mention
- Rename $parent to $toplevel_item in Diaspora::constructComment
- Use thread parent to retrieve the expected mention instead of the top level item
2019-02-23 17:32:12 -05:00
0cc0df9e3e
Rename system.disable_mentions_removal config key to system.disable_implicit_mentions
...
- Update configuration key description
2019-02-23 17:32:11 -05:00
8c1db51a76
Improve Logger calls
...
- Replace various deprecated Logger::log calls
- Reassign log level for verbose log calls
2019-02-23 17:32:11 -05:00
ca7ceb6fe2
We should return something ;-)
2019-02-13 17:26:54 +00:00
d4baa25349
New configuration to disable the automatic mentions removal
2019-02-13 17:23:23 +00:00
63f083f6fb
Include new lines in implicit mention regular expression
2019-02-13 08:08:46 -05:00
3b7e9cc3a2
This now should really prevent sending the follow requests only once
2019-02-10 18:59:05 +00:00
04f34de3a1
Multiples follows shouldn't be send anymore
2019-02-10 18:42:51 +00:00
58eaf0ba1c
Prevent multiple send follow requests
2019-02-10 18:03:01 +00:00
Michael Vogel
c7308d98fa
Merge pull request #6614 from MrPetovan/task/6552-add-explicit-mentions
...
Add explicit mentions to ActivityPub/Diaspora comments
2019-02-10 00:52:40 +01:00
ed89a22995
Add context to some logger calls in ActivityPub\Processor
2019-02-09 08:34:54 -05:00
199fac3397
Prepend implicit author mentions in outgoing Diaspora comments
...
- Add Diaspora::prependParentAuthorMention method
2019-02-08 23:10:36 -05:00
e514ecb6fa
Prepend implicit mentions to outgoing ActivityPub messages
...
- Add Transmitter::prependMentions method
- Fix Transmitter::mentionCallback return value when contact isn't found
2019-02-08 23:09:02 -05:00
e352408876
Remove implicit mentions from incoming ActivityPub messages
...
- Add Processor::getImplicitMentionList and Processor::removeImplicitMentionsFromBody methods
- Rename Processor::constructTagList to Processor::constructTagString
- Add implicit mention skip in Processor::constructTagString
- Invert parameter order in Processor::replaceEmojis
2019-02-08 22:57:35 -05:00
1eb607b351
Add missing non-empty data condition to Protocol\PortableContact
2019-02-08 09:24:04 -05:00
066ad8c01b
Add PortableContact constants
...
- Fix typo in mod/admin
- Replace deprecated Logger::log calls
2019-02-08 08:38:13 -05:00
ebe767b290
Hopefully final fix for false notifications
2019-02-07 05:38:43 +00:00
16bf9c771d
The automatic follow request is currently deactivated, due to false notifications
2019-02-06 21:34:44 +00:00
a7963fe18a
AP: Automatically send follow requests for reshared items
2019-01-30 21:33:23 +00:00
fc0acd7b1f
AP: Debug option to deliver via AP first
2019-01-30 19:33:08 +00:00
fce46f5124
AP: Follow a note to receive all upcoming activities
2019-01-30 16:30:01 +00:00
2c0ee72064
Ap: Clarify message distribution for forum posts
2019-01-30 13:07:23 +00:00
030c0b5dc6
Another preparation for forum posts via AP
2019-01-28 06:23:06 +00:00
ebb84f5e43
DFRN comments are now stored as comments again
2019-01-24 18:54:45 +00:00
7e31cebb67
Parameters redone
2019-01-23 22:04:14 +00:00
0fdab4ed10
Fix for several fatal errors
2019-01-23 21:54:20 +00:00
a6786ac814
Update array notation in Protocol\DFRN
2019-01-23 09:07:00 -05:00
f8c782380f
Remove unused code/use statements
2019-01-23 09:06:58 -05:00
64847e7cc8
Fix types in doc blocks/prototypes
2019-01-23 09:06:58 -05:00
cef6757c92
Replace REGISTER_* constants by Module\Register::* ones
2019-01-22 22:24:15 -05:00
0cc1a07cfa
Fix default value of contact parameter of OStatus::import in mod/salmon
2019-01-22 08:53:53 -05:00
604262a70e
Extract title determination from OStatus::entryHeader logic
2019-01-22 01:59:22 -05:00
722284ca8e
Fix unused $kw variable in Protocol\Diaspora
2019-01-21 11:12:51 -05:00
e7be87df93
Fix missing $ in front of variable names
2019-01-21 11:12:49 -05:00
7f2dc40601
Fix potential bugs without expected behavior change
...
- Fix uninitialized variables
- Fix potentially not set variables
- Fix wrong parameter default value
- Fix method scope
- Fix missing return value
2019-01-21 11:04:19 -05:00
3d839bb176
Move Contact::ACCOUNT_TYPE_* constants to User::ACCOUNT_TYPE_*
...
- Keep Contact::TYPE_* constants for comparison with contact.contact-type
2019-01-21 10:56:27 -05:00
ad9c67663d
Move Contact::Page_* constants to User::PAGE_FLAGS_*
2019-01-21 10:55:37 -05:00
4a95ca280d
Remove unused code
...
- Remove commented code
- Remove unused/immediately overwritten variables
- Remove extraneous parameters
- Remove unreachable code
- Remove duplicate array keys
2019-01-21 10:48:40 -05:00
cb3f09ae4f
Refactor namespaces
...
- Remove unused use statements
- Add required use statements
- Escape global classes
2019-01-21 10:43:42 -05:00
070aa016e0
Update more PHPDoc, including in include/
2019-01-21 10:39:28 -05:00
af9067a381
Update PHPDoc in mod/
2019-01-21 10:39:27 -05:00
3282ce5389
Fix PHPDoc comments project-wide
2019-01-21 10:35:51 -05:00
55e54bb950
Replace deprecated Addon::callHooks with Hook::callAll
...
- Update documentation
2019-01-21 09:50:56 -05:00
895b3abf32
Remove/replace killme() with *exit()
2019-01-21 09:49:17 -05:00
70c183b495
AP Bugfix: We hadn't transmitted an tag url at all ...
2019-01-20 23:13:55 +00:00
e2427eb9da
We only need to fetch the content once
2019-01-20 22:56:33 +00:00
9e7c59481f
Improved ID detection
2019-01-20 22:19:53 +00:00
e5d694f7fa
AP: Only reshare stuff that is AP content
2019-01-20 21:52:43 +00:00
809e556009
Transmit via BCC if contact is hidden, don't store announces
2019-01-19 16:44:15 +00:00
d813d72b1a
Simplyfies AP relaying, fixes relaying of public contacts
2019-01-17 23:06:27 +00:00
c359c162a7
Issue 6282: Update the contact data regularly (including the network)
2019-01-16 21:39:56 +00:00
90e25faf44
Merge pull request #6447 from annando/peertube
...
Enable communication with Peertube
2019-01-14 08:40:42 -05:00
aa4aaf1971
Enable communication with Peertube
2019-01-14 12:10:11 +00:00
795268eb7a
Fix undefined offset notices in Protocol\Email
2019-01-14 00:05:51 -05:00
d113ccd93c
Making Friendica compatible to Nextcloud Social
2019-01-13 09:38:01 +00:00
297a549590
Issue 6282: Update the forum status of contacts
2019-01-12 16:09:27 +00:00
28f14c7d60
Don't show deleted contacts, changed "pending" behaviour
2019-01-12 13:28:14 +00:00
e3576fa0bd
Don't accept private answers to public parents
2019-01-10 22:51:03 +00:00
1a702359f1
Unfollow should now work with Pleroma again
2019-01-10 07:24:12 +00:00
defc89fa9a
Fixing the Accepting of contact requests
2019-01-09 22:30:26 +00:00
e447375cdd
Merge branch '2019.01-rc' into bug/6334-escape-get-app
2019-01-06 16:38:48 -05:00
9a4fc0f8bd
Issue 6347: Removing the old way to fetch Diaspora posts to avoid Hubzilla problems
2019-01-06 07:43:11 +00:00
fc87c51bb4
Merge pull request #6377 from annando/ostatus-notice
...
Prevent a notice ... again
2019-01-04 11:28:31 -05:00
d8d5031935
Prevent a notice ... again
2019-01-04 15:34:53 +00:00
5e1ceb57de
Escape global namespaced get_app() calls
...
- Add deprecated status
2019-01-03 21:27:36 -05:00
3095d4aa70
Add parent to private message notifications
...
- Fix item id for Diaspora private message notification
2018-12-30 01:10:10 -05:00
5abc22f6c5
Replace q() with DBA methods, fix code style
...
- Remove unused variables
- Fix doc block
- Fix indentation
2018-12-30 01:08:51 -05:00
fd6c64f9c1
Warning and notice fixed
2018-12-29 09:53:31 +00:00
Michael Vogel
94eca77041
Merge pull request #6315 from MrPetovan/bug/6309-add-fulltext-index-profile
...
Rework mod/match and mod/msearch
2018-12-27 18:04:06 +01:00
56d612b2f0
Merge pull request #6323 from annando/issue-6316
...
Issue 6316: Do not double encode / Avoid notice
2018-12-25 11:26:54 -05:00
ccb9be8f28
Issue 6316: Do not double encode / Avoid notice
2018-12-25 12:12:59 +00:00
a8b0aa8c8d
Normalize expected format for event fields summary, desc and location
...
- Remove unnecessary HTML escaping on event submit
- Add HTML escaping on event display
- Add HTML to BBCode conversion for received ActivityPub events
2018-12-24 23:00:35 -05:00
acaee626f5
Remove include/ requires that are now done directly from Composer
2018-12-24 09:56:25 -05:00
c43bd890a5
The "Follow" activity shouldn't be send to Diaspora
2018-12-24 14:50:21 +00:00
Jeroen De Meerleer
2d9f4b560f
Too fast
2018-12-22 17:23:18 +01:00
Jeroen De Meerleer
27eddfee27
Fixed bug
...
$curlResult is not an array
2018-12-22 17:19:34 +01:00
b6e1571b1e
Fix various notices
2018-12-15 04:32:47 -05:00
6733b77b73
Make it simpler
2018-12-03 19:29:06 +00:00
d76003797a
Fix for notice
2018-12-03 16:32:03 +00:00
51bce11b69
Issue 5911: Fix for fetching the correct user
2018-12-03 06:16:25 +00:00
57695d48b4
Merge pull request #6223 from annando/ap-dba-error
...
Fix for "Unknown column 'guid' in 'field list'"
2018-12-02 19:18:36 -05:00
2fd65503da
Avoid database error that the field "guid" is not present in the contact table
2018-12-02 15:01:08 +00:00
458981f75c
Replace x() by isset(), !empty() or defaults()
...
- Remove extraneous parentheses around empty() calls
- Remove duplicate calls to intval(), count() or strlen() after empty()
- Replace ternary operators outputting binary value with empty() return value
- Rewrite defaults() without x()
2018-11-30 09:06:22 -05:00
Michael Vogel
3f4636d490
Merge pull request #6183 from MrPetovan/bug/6135-hide-follower-only-birthdays
...
Hide follower-only birthday reminders
2018-11-24 15:55:43 +01:00
Michael Vogel
42a3610a79
Merge pull request #6184 from MrPetovan/task/normalize-bbcode-hashtags
...
Normalize BBCode hashtags links
2018-11-24 13:14:50 +01:00
ea5ba309dc
Some more AP blocking
2018-11-22 22:31:48 +00:00
2f7b138b09
Block AP delivery
2018-11-22 22:23:31 +00:00
4874f7f8ab
Remove useless rawurlencode calls for building hashtag bbcode
...
- Fix some formatting
2018-11-22 09:32:41 -05:00
de5ee56d2f
Move DFRN::birthdayEvent() to Event::createBirthday
2018-11-22 00:15:09 -05:00
d71e856535
Replace remaining occurrences of "0001-01-01" with DBA::NULL_DATE
2018-11-21 23:53:45 -05:00
27d1da0468
One space too much
2018-11-20 20:49:06 +00:00
5c39779b45
AP: Security check against forged "create" activities
2018-11-20 20:40:47 +00:00
Michael Vogel
9dfc970bd6
Merge pull request #6144 from Alkarex/ATOM-self
...
Correct self attribute in ATOM feeds
2018-11-18 12:31:15 +01:00
Alexandre Alapetite
bd19e93c09
Minor code relocation
...
https://github.com/friendica/friendica/pull/6144/files#r234385033
2018-11-17 01:36:54 +01:00
Alexandre Alapetite
dd65c5d150
Apply correct title encoding to all cases
2018-11-17 01:30:53 +01:00
Alexandre Alapetite
af38d22d38
Fix ATOM feed title encoding
...
Was HTML-encoded instead of plain Unicode.
Fixed only for feed_mode. Probably wrong as well for non_feed mode (not
sure how to test)
2018-11-16 23:52:36 +01:00
Alexandre Alapetite
d85e26d314
Refactor header with feed_mode
...
https://github.com/friendica/friendica/pull/6140#issuecomment-439475027
2018-11-16 23:29:26 +01:00
Alexandre Alapetite
97d164f69e
Correct self attribute in ATOM feeds
...
Fix for
https://github.com/friendica/friendica/issues/6128#issuecomment-439016471
Special case for DFRN to reduce the risk of unintended side effects
2018-11-16 18:54:06 +01:00
c3b6727fad
Some more feed simplification
2018-11-15 16:21:37 +00:00
5f258dac22
Make feeds look more like feeds
2018-11-15 13:21:58 +00:00
08433873f5
Issue 6128 again: We now use our regular feed that allows anonymous polling
2018-11-14 19:26:23 +00:00
7458d793ed
Removing some notices again
2018-11-11 12:15:17 +00:00
a6a3c268bb
Use atom:author/atom:uri as profile-link in Feed::import
...
- Use atom:author/atom:id as profile-id
2018-11-10 08:24:10 -05:00
Adam Magness
218f0734be
Rename removeTags to escapeTags
...
rename function and update calls.
2018-11-09 13:29:42 -05:00
Adam Magness
6827dbf734
bug fix
...
Strings not String
2018-11-08 12:59:00 -05:00
Adam Magness
ffc406d819
normalise_link calls
...
implement normaliseLink function
2018-11-08 11:28:29 -05:00
Adam Magness
5276c28a78
link_compare calls
...
implement compareLink function.
2018-11-08 10:46:50 -05:00
Adam Magness
6fc9c6de3b
base64url calls
...
implement base64UrlEncode and base64UrlDecode functions
2018-11-08 10:37:08 -05:00
Adam Magness
0efcbe5d15
protect_sprintf calls
...
implement protectSprintf function
2018-11-08 10:30:45 -05:00
Adam Magness
a0f65ca7a1
notags calls
...
implement removeTags function
2018-11-08 10:14:37 -05:00
Adam Magness
991f259ecb
random_string calls
...
implement getRandomHex function
2018-11-08 08:45:46 -05:00
c464ec33e1
Merge pull request #6099 from annando/ap-emojis
...
Using CSS for custom emojis
2018-11-08 06:54:05 -05:00
077a96fb28
Using CSS for custom emojis
2018-11-08 07:42:19 +00:00
97b6d70825
Merge pull request #6096 from annando/ap-emojis
...
We now directly support the custom emojis from Mastodon
2018-11-07 20:10:16 -05:00
cd2c7f782f
We now directly support the custom emojis from Mastodon
2018-11-07 20:34:03 +00:00
Adam Magness
e537f7d017
Function calls
...
update function calls to new class
2018-11-06 21:16:27 -05:00
dd35cd0701
Merge pull request #6086 from friendica/fabrixxm-patch-1
...
Fix Friendica node info json
2018-11-06 10:48:00 -05:00
fabrixxm
0441a169a9
Fix code style
2018-11-06 16:37:58 +01:00
Adam Magness
4f07ebb52f
Rename properly
...
rename function properly this time!
2018-11-06 06:34:32 -05:00
Adam Magness
3eecd108c5
rename function
...
rename function and update calls.
2018-11-06 06:31:48 -05:00
fabrixxm
1858204cbd
Stop PortableContacts to raise warning on malformed register_policy
2018-11-06 12:10:23 +01:00
Adam Magness
a71eb1d127
functions moved to HTML class
...
update function calls to moved class.
2018-11-05 21:06:26 -05:00
Adam Magness
9e51be7554
Revert "Update function calls"
...
This reverts commit 748fb8b946
2018-11-05 13:07:07 -05:00
Adam Magness
748fb8b946
Update function calls
...
update function calls to new class
2018-11-05 07:40:18 -05:00
Adam Magness
b07d47b0f7
Update function calls
...
update function calls to new names
2018-11-05 07:24:14 -05:00
Adam Magness
61bc9facc8
Implement functions
...
implement functions relocated to xml class
2018-11-05 07:24:14 -05:00
e759497af3
Fix small typo / Workerqueue count now only counts non deferred entries
2018-11-04 10:51:01 +00:00
ec3cec37eb
Fixes #6071 : We should use the correct variable ...
2018-11-04 09:18:36 +00:00
8f27e3aeb1
Support for fetching non-public content / preparations for forum posts
2018-11-03 21:37:08 +00:00
1395bdc188
Preparations for a relocation message / fix for notice
2018-11-02 21:57:06 +00:00
Adam Magness
d9b558a8ed
Update function calls
...
update function calls to new class.
2018-10-30 14:51:45 -04:00
Adam Magness
50da89d861
Logger Levels
...
update logger levels in calls
2018-10-30 09:58:45 -04:00
Adam Magness
14fde5dc9b
Log function
...
implement log() function.
2018-10-30 09:57:14 -04:00
84be62982a
Diaspora signature transport via AP/DFRN should be repaired now
2018-10-29 21:15:37 +00:00
4831688dc0
Diaspora signatures are now stored and transmitted correctly
2018-10-27 14:35:22 +00:00
73f596cc46
Fixes duplicated transmissions and not working undo of like/dislike
2018-10-27 11:09:23 +00:00
f2ddcbe632
AP: Event participation and editing of posts are now supported
2018-10-27 06:17:17 +00:00
cbc417114d
AP: We now transmit and process events
2018-10-26 04:13:26 +00:00
7f11b2e4e9
Deactivated BCC
2018-10-24 21:04:21 +00:00
f300c8953a
We now use bcc for the acl block
2018-10-24 20:06:57 +00:00
58f82e084d
Preparations to work with BCC
2018-10-24 19:19:51 +00:00
c25d60e107
Removed finished work from the comments
2018-10-24 04:51:37 +00:00
cb75c40f4e
adapted profile pic resize to 300px for whole system
2018-10-23 16:36:57 +02:00
dbe49a0c1a
Merge pull request #5998 from annando/ap-queue
...
Unsuccessful ActivitiyPub transmission are now deferred
2018-10-23 06:54:11 +02:00
e3e714a45f
Unsuccessful ActivitiyPub transmission are now deferred
2018-10-23 03:54:18 +00:00
e511790d62
Move NULL_DATE from boot.php to DBA::NULL_DATETIME
...
- Add DBA::NULL_DATE constant
2018-10-22 16:50:55 -04:00
d00ddc01af
Split goaway to System::externalRedirectTo() and App->internalRedirect()
2018-10-22 22:13:35 +02:00
2ef81108b3
Renamed System::redirect() to $a->redirect()
2018-10-22 22:13:22 +02:00
bb3f07b0b7
We now send the previous followers collection as well
2018-10-21 20:49:50 +00:00
1c54c27784
Bugfix: We hadn't deliverd AP posts to all intended receivers
2018-10-21 06:10:24 +00:00
4392858662
Move Global Functions - Part 3
...
- Replaced every CACHE definition
- Moved check_url to App->checkURL()
- Removed unused definition "ZCURL_TIMEOUT"
2018-10-20 18:19:55 +02:00
fea48fa85e
AP: Transmitting and receiving with non AP contacts
2018-10-20 07:53:45 +00:00
a2666b0d02
Remove reference to deleted include/security.php
2018-10-19 15:11:51 -04:00
bedab33e0b
Fix function naming
2018-10-19 13:08:46 +00:00
cdeb4682ef
Use nickname based mentions for AP
2018-10-19 05:27:54 +00:00
eb714f0487
Diaspora: Widen the magic link regular expression
2018-10-18 22:39:06 -04:00
688174e6c0
AP: Fix "null" receiver
2018-10-18 12:25:57 +00:00
8035bad8e2
AP: Fix a notice / avoid an error when fetched content hadn't been an array
2018-10-18 05:54:44 +00:00
341b83d1df
Fix Undefined index: photo in ActivityPub/Receiver
2018-10-16 18:29:28 -04:00
cb854b8b10
Fix Undefined index: timezone in Protocol\Diaspora
2018-10-16 18:29:08 -04:00
2b1d15de87
Fix undefined index: id in Protocol\Diaspora
2018-10-16 18:28:27 -04:00
8d0f4710a4
Signed Diaspora posts should now be stored more reliable
2018-10-15 21:42:55 +00:00
ce74a4d9a1
Merge pull request #5921 from annando/ap-video
...
ActivityPub: Rudimentary support for videos
2018-10-14 14:05:51 -04:00
37ad4a7d22
ActivityPub: Rudimentary support for videos
2018-10-14 17:57:44 +00:00
59d6dd809d
Merge pull request #5906 from annando/ap-switch
...
OStatus contacts are now automatically converted to AP
2018-10-14 12:04:52 -04:00
6be04a73e3
The outbox is now more complete / No more duplicates in the receiver array
2018-10-14 07:47:04 +00:00
e829e074fc
Location, coord and app are now processed as well
2018-10-13 21:37:39 +00:00
aab4fa0c31
The instrument is now added, updating AP contacts is now enabled
2018-10-13 20:36:44 +00:00
f60468677e
We now transmit location and application as well.
2018-10-13 19:49:20 +00:00
8b9aa80aad
"to" is now used for mentions, "cc" for everything else
2018-10-13 18:59:39 +00:00
efad4936b0
OStatus contacts are now automatically converted to AP
2018-10-13 18:13:01 +00:00
3c48a1f787
AP: Announce will now work
2018-10-13 16:41:29 +00:00
5af0ee1b95
We can now store it without any problem
2018-10-12 18:53:13 +00:00
986528b77f
Revert "We now store the diaspora comment data as well"
2018-10-12 10:35:43 -04:00
8268288953
We now store the diaspora comment data as well
2018-10-11 20:38:57 +00:00
1bf7521af8
Store conversation data directly from the AP receiver
2018-10-11 20:08:04 +00:00
ffbc688797
Curl Response Refactoring
...
- refactored Network::getCurl()
- replaced every Network::getCur() execution with a Curl Response
2018-10-10 21:50:13 +02:00
7c73e8634c
Curl Response Refactoring
...
- refactored Network::post()
- replaced every Network::post() execution with the new Curl container
2018-10-10 21:15:26 +02:00
2dec8895a9
Curl Response Refactoring
...
- extended Curl to parse Curl Response
- refactored Network::curl()
- replaced every Network::curl() execution with the new Curl container
2018-10-10 21:08:43 +02:00
5a02e39a65
Rename App Methods
...
- renamed a lot of App methods to CamelCase
- replaced direct public variables with get-/set-Methods
2018-10-10 00:16:06 +02:00
5f9dd11cfb
Merge pull request #5867 from annando/ap-fix-follow
...
AP: Switchting existing contacts to AP when receiving activities
2018-10-09 16:08:38 -04:00
0994aaf875
AP: Avoid a misleading log entry / unneeded field removed
2018-10-09 20:00:57 +00:00
c0f26ace2e
AP: Switchting existing contacts to AP when receiving activities
2018-10-09 19:58:15 +00:00
b5d73f840c
AP fixes: LD-signature, wrong owner for completed thres, account removal
2018-10-09 05:04:24 +00:00
4047952703
AP: Avoid an empty avatar field
2018-10-08 03:28:49 +00:00
46f77f3486
Detect the object type
2018-10-07 20:36:15 +00:00
93866b477a
Several fixes
2018-10-07 19:42:04 +00:00
bd6ba98e8d
Some more cleanup
2018-10-07 18:41:45 +00:00
1efca1b75d
owner is now actor
2018-10-07 17:35:43 +00:00
616c4a89bd
The new parsing is now active
2018-10-07 17:17:06 +00:00
36c31e4091
Switching to parsing the JSON-LD
2018-10-07 15:34:51 +00:00
3a74f3364d
Switch to parsing compacted JSON data
2018-10-07 13:37:05 +00:00
192c6c8d4f
Preparation for suggestions under AP
2018-10-06 18:42:26 +00:00
389a651005
Transmit the Diaspora GUID with activities (Like, Dislike, ...)
2018-10-06 14:02:23 +00:00
2341ce353d
Merge pull request #5842 from annando/ap-distribution
...
Improved AP distribution / Only process trusted content
2018-10-06 09:35:44 -04:00
a413ce15aa
"name" must be plaintext
2018-10-06 13:28:17 +00:00
6b374c32a2
Improved AP distribution / Only process trusted content
2018-10-06 13:16:52 +00:00
acf31ab64b
Additional check to ensure that the owner of an activity is always the author
2018-10-06 09:38:51 +00:00
510032444f
The owner of a "like" should be the author
2018-10-06 08:51:52 +00:00
41123162f1
No @brief anymore
2018-10-06 04:18:40 +00:00
13c5bc807b
Merge pull request #5829 from annando/develop
...
Cache the AP delivery process
2018-10-06 00:06:47 -04:00
9dbf8d0b9d
Spaces
2018-10-06 02:09:27 +00:00
51dbffd396
Cache the AP delivery process
2018-10-05 21:00:40 +00:00
5d7968bdf3
Avoid to do the follow stuff for the public user
2018-10-05 20:10:10 +00:00
5ed1c12349
Send a follow request upon contact switch to AP
2018-10-05 19:48:48 +00:00
fa7cddc669
AP Bugfix: Following a soapbox now works / rapid follow/unfollow should work now
2018-10-05 06:35:50 +00:00
3d74d412b2
Changed attachment handling to improve Mastodon compatibility
2018-10-05 04:04:37 +00:00
4368c922fb
is sensitive
2018-10-04 13:08:11 +00:00
0ebfa6fc12
Added to-do
2018-10-04 12:57:42 +00:00
1c615f80c4
Improved return values
2018-10-04 12:53:41 +00:00
9171b2a0f3
It's possibly better to use context links that do exist
2018-10-04 09:46:29 +00:00
06a59c8312
Funkwhale documentation added
2018-10-04 05:29:22 +00:00
72fc89d033
Simplified attachment handling
2018-10-04 05:26:00 +00:00
f6277970fa
Added some to-do
2018-10-03 19:35:01 +00:00
11a7f6c3e1
Unused "use" removed
2018-10-03 19:17:40 +00:00
cbfc3d0c28
Fix error / "about" is now converted to BBCode
2018-10-03 19:00:32 +00:00
221e197658
Tags are now transmitted as expected
2018-10-03 18:27:01 +00:00
a9a1ac808b
Attachments do work now
2018-10-03 17:36:55 +00:00
78a7e130ae
Another renamed function
2018-10-03 15:50:21 +00:00
8841519c0d
Renamed functions
2018-10-03 15:41:51 +00:00
1fe55679fc
Moved documentation
2018-10-03 09:53:12 +00:00
acd1caa114
The function is only needed in the same class
2018-10-03 09:45:54 +00:00
3ab837f3c7
Functionality is now split
2018-10-03 09:15:38 +00:00
4d2e5c2bbe
AP class will be split in processor, receiver and transmitter
2018-10-03 06:15:07 +00:00
518d461a8f
Issue 5811: "objects" instead of "object"
2018-10-02 20:12:38 +00:00
6020605d5c
Account deletion could work now.
2018-10-01 19:22:13 +00:00
72c3a62e7f
Profile update is now done via APDelivery
2018-10-01 05:44:56 +00:00
9f481c1f5e
+ is *
2018-09-30 20:48:29 +00:00
5456ef0185
Profile update and some more is now added
2018-09-30 20:26:30 +00:00
761bdafa34
Correct content type
2018-09-30 14:13:07 +00:00
e71f497295
Renamed
2018-09-30 08:14:05 +00:00
2fc79e3886
Superfluous, since we only fetch this data
2018-09-30 07:48:13 +00:00
82987d018a
Some changes for better code quality
2018-09-30 07:21:57 +00:00
b043c7e0f2
Changed constant name to keep compatible with PHP 5
2018-09-28 15:25:20 +00:00
da79566125
Relocated function
2018-09-28 03:56:41 +00:00
793387e2b5
Only communicate with contacts that aren't pending
2018-09-27 15:26:20 +00:00
e01d5e4b31
Function naming ...
2018-09-27 11:56:05 +00:00
cb9be8a7ab
UUID is now createUUID
2018-09-27 11:52:15 +00:00
5639054699
Diaspora in AP - and changed function name
2018-09-27 11:39:17 +00:00
fa868fbaf2
Some more documentation
2018-09-27 03:28:56 +00:00
897929ad40
Avoid warnings, added documentation
2018-09-26 22:45:13 +00:00
f7d7d94111
Added some doxygen headers
2018-09-26 21:38:37 +00:00
dd38b7e329
Avoid warnings
2018-09-26 20:36:47 +00:00
60b0759b50
UUID instead of GUID
2018-09-26 20:03:46 +00:00
9ec30010c5
APContact stuff is moved to an own class
2018-09-26 17:24:29 +00:00
f3814ae1fc
Changed conversation url (used for AP)
2018-09-26 13:12:27 +00:00
4699741f00
Fix delivery only for comments to native networks
2018-09-26 13:00:48 +00:00
67d2f8594c
Some more clean up
2018-09-26 07:42:40 +00:00
e91a1dfa8e
Cleaned code
2018-09-25 21:18:37 +00:00
5e3f71680c
Disabled logging
2018-09-24 21:47:10 +00:00
59c137b946
Variable fix
2018-09-24 05:35:47 +00:00
b386add315
Switch contacts from OStatus to ActivityPub
2018-09-23 22:12:12 +00:00
094c27add6
Update person, undo activity and improved security checks
2018-09-23 19:25:20 +00:00
8c7e5bb776
all endpoints are now working
2018-09-23 17:29:31 +00:00
feeec908d3
We can delete notes / changed credits
2018-09-23 09:20:25 +00:00
6df6d82427
We can now like and dislike
2018-09-23 08:52:07 +00:00
a56565fa99
AP is enabled for all users
2018-09-22 23:49:27 +00:00
ca574e1027
We can now like and dislike
2018-09-22 23:17:01 +00:00
c083ae047c
Merge remote-tracking branch 'upstream/2018.08-rc' into ap1
2018-09-22 15:18:53 +00:00
214407bdc8
Improve communication
2018-09-22 14:12:54 +00:00
0dbb6313a5
Hopefully fixes relocations that hadn't been executed
2018-09-22 06:47:35 +00:00
b906b083bc
The target inbox is now generated after the permission bloxk
2018-09-22 05:58:56 +00:00
71cbe56293
Use the follower collection
2018-09-22 04:49:16 +00:00
b7744ae3eb
Inherit the receivers from the previous post
2018-09-22 04:39:04 +00:00
b44fc62708
Improvements to signature check, private posts do work now again
2018-09-21 22:31:33 +00:00
4c224fbddd
Deliver everything to all receivers in the thread
2018-09-21 12:06:36 +00:00
5310d54c13
Fetch the receiver from the parent posting as well
2018-09-21 04:51:54 +00:00
355346298b
LD signatures will now be checked when receiving messages
2018-09-21 03:39:32 +00:00
752b5fe284
Outgoing posts are now signed
2018-09-20 21:45:23 +00:00
11310f4cf0
Relocated AP signature functions, reduced magic auth functions
2018-09-20 18:16:14 +00:00
0866fbaf8c
Code cleaning / wrong table for flags
2018-09-20 09:50:03 +00:00
0d51474e73
Relocated function
2018-09-20 05:37:01 +00:00
34cb0aa406
JSON-LD stuff is now in a separate file
2018-09-20 05:30:07 +00:00
f20bed67a9
Table "apcontact" is now in use / added functionality to handle JSON-LD
2018-09-20 05:00:49 +00:00
5de4afecf1
Table for AP contacts, JSON-LD parser included
2018-09-18 22:09:27 +00:00
cb073bea61
Private posts with Mastodon don't work - but this is expected
2018-09-18 19:36:27 +00:00
464650d4d7
Public posts to Pleroma do work now, limited posts to Hubzilla and Mastodon as well
2018-09-18 07:28:35 +00:00
f772ece86f
New delivery module for ap
2018-09-17 21:13:08 +00:00
91d1b4de5d
We now use the conversation data with AP
2018-09-17 05:51:05 +00:00
699a4140f9
Now sending does finally work - and some AP standards are improved as well
2018-09-16 20:12:48 +00:00
e4d28629e4
First posting tests
2018-09-16 17:47:00 +00:00
629cca1963
Added function to fetch missing data, code bugfixing
2018-09-16 13:04:00 +00:00
6f3b2b6586
Handling of unlisted posts, better uid detection
2018-09-16 09:06:09 +00:00
1f98414bdd
Some code cleanup
2018-09-16 05:49:13 +00:00
a7f5c1f4c6
Likes work now
2018-09-15 23:06:03 +00:00
2eabe45a8e
Contact reject does work now as well
2018-09-15 22:25:58 +00:00
e45206ae5d
Merge remote-tracking branch 'upstream/2018.08-rc' into ap1
2018-09-15 20:49:46 +00:00
f5104f3e46
Removed harcoded host names
2018-09-15 20:48:24 +00:00
86bd283705
The whole contact handling does work now, yeah ...
2018-09-15 20:31:05 +00:00
6a8ebc8639
Contact follow and unfollow workd partially
2018-09-15 18:54:45 +00:00
96f575fe28
Processing of personal inbox enabled
2018-09-15 10:14:56 +00:00
957c70d1c6
Several improvements
2018-09-15 07:40:19 +00:00
fb5b6e4a14
New uri format for our posts that is AP compatible
2018-09-15 07:37:34 +00:00
2e7ca76e15
More fields to import / like could possibly work
2018-09-14 21:10:49 +00:00
61e2c7d20d
Added AP to many network conditions / enabling inbox processing
2018-09-14 16:51:32 +00:00
c2f6b166c7
We now use the regular probing function
2018-09-13 21:57:41 +00:00
8c00e88f79
The endless saga of the fight against notices continues
2018-09-13 21:11:52 +00:00
67fa0ed433
Signature check added
2018-09-12 21:30:10 +00:00
969311cb44
Replacing the non standard "title" with "name"
2018-09-12 18:48:18 +00:00
8c07baf54b
Better http answers
2018-09-12 06:01:28 +00:00
f566db52d3
And more notices ...
2018-09-11 08:04:14 +00:00
0a5476591d
Activitity pub - first commit with much test code
2018-09-10 21:07:25 +00:00
6113fdc940
Issue 5733: Changing relationship values does work now again with DFRN
2018-09-06 09:20:45 +00:00
9ef1d827f3
Restore the behaviour to remove the remote contact upon termination
2018-09-05 05:02:06 +00:00
380eeaab88
Still there had been notices - must have a good camouflage
2018-08-31 05:08:22 +00:00
070e1e73d6
Merge pull request #5702 from annando/and-a-notice
...
and now for something completely different: A removed notice
2018-08-30 06:37:39 +02:00
02da827560
and now for something completely different: A removed notice
2018-08-30 04:05:32 +00:00
9bff31f18f
Issue 5691: Post dates of feeds sometimes had been wrong
2018-08-29 19:11:43 +00:00
Michael Vogel
601851f3d0
Removed notice - pokes do now work mostly ( #5693 )
2018-08-29 09:00:01 -04:00
5e82323456
Avoid useless contact updates
2018-08-26 07:56:33 +00:00
Roland Häder
61693419e8
Cleanups: isResult() more used, readability improved ( #5608 )
...
* [diaspora]: Maybe SimpleXMLElement is the right type-hint?
* Changes proposed + pre-renaming:
- pre-renamed $db -> $connection
- added TODOs for not allowing bad method invocations (there is a
BadMethodCallException in SPL)
* If no record is found, below $r[0] will fail with a E_NOTICE and the code
doesn't behave as expected.
* Ops, one more left ...
* Continued:
- added documentation for Contact::updateSslPolicy() method
- added type-hint for $contact of same method
- empty lines added + TODO where the bug origins that $item has no element 'body'
* Added empty lines for better readability
* Cleaned up:
- no more x() (deprecated) usage but empty() instead
- fixed mixing of space/tab indending
- merged else/if block goether in elseif() (lesser nested code blocks)
* Re-fixed DBM -> DBA switch
* Fixes/rewrites:
- use empty()/isset() instead of deprecated x()
- merged 2 nested if() blocks into one
- avoided nested if() block inside else block by rewriting it to elseif()
- $contact_id is an integer, let's test on > 0 here
- added a lot spaces and some empty lines for better readability
* Rewrite:
- moved all CONTACT_* constants from boot.php to Contact class
* CR request:
- renamed Contact::CONTACT_IS_* -> Contact::* ;-)
* Rewrites:
- moved PAGE_* to Friendica\Model\Profile class
- fixed mixure with "Contact::* rewrite"
* Ops, one still there (return is no function)
* Rewrite to Proxy class:
- introduced new Friendica\Network\Proxy class for in exchange of proxy_*()
functions
- moved also all PROXY_* constants there as Proxy::*
- removed now no longer needed mod/proxy.php loading as composer's auto-load
will do this for us
- renamed those proxy_*() functions to better names:
+ proxy_init() -> Proxy::init() (public)
+ proxy_url() -> Proxy::proxifyUrl() (public)
+ proxy_parse_html() -> Proxy::proxifyHtml() (public)
+ proxy_is_local_image() -> Proxy::isLocalImage() (private)
+ proxy_parse_query() -> Proxy::parseQuery() (private)
+ proxy_img_cb() -> Proxy::replaceUrl() (private)
* CR request:
- moved all PAGE_* constants to Friendica\Model\Contact class
- fixed all references of both classes
* Ops, need to set $a here ...
* CR request:
- moved Proxy class to Friendica\Module
- extended BaseModule
* Ops, no need for own instance of $a when self::getApp() is around.
* Proxy-rewrite:
- proxy_url() and proxy_parse_html() are both non-module functions (now
methods)
- so they must be splitted into a seperate class
- also the SIZE_* and DEFAULT_TIME constants are both not relevant to module
* No instances from utility classes
* Fixed error:
- proxify*() is now located in `Friendica\Util\ProxyUtils`
* Moved back to original place, ops? How did they move here? Well, it was not
intended by me.
* Removed duplicate (left-over from split) constants and static array. Thank to
MrPetovan finding it.
* Renamed ProxyUtils -> Proxy and aliased it back to ProxyUtils.
* Rewrite:
- stopped using deprecated NETWORK_* constants, now Protocol::* should be used
- still left them intact for slow/lazy developers ...
* Ops, was added accidentally ...
* Ops, why these wrong moves?
* Ops, one to much (thanks to MrPetovan)
* Ops, wrong moving ...
* moved back to original place ...
* spaces added
* empty lines add for better readability.
* convertered spaces -> tab for code indenting.
* CR request: Add space between if and brace.
* CR requests fixed + move reverted
- ops, src/Module/*.php has been moved to src/Network/ accidentally
- reverted some parts in src/Database/DBA.php as pointed out by Annando
- removed internal TODO items
- added some spaces for better readability
2018-08-24 01:05:49 -04:00
Michael Vogel
dc3d2d5988
"dba" is now "DBA". This hadn't been respected at some places ( #5655 )
...
* "dba" is now "DBA". This hadn't been respected at some places
* Cleaning up unneeded stuff
2018-08-23 09:51:58 -04:00
Michael Vogel
54aee2aaa7
Removed notices that revealed themselfes over night ... ( #5645 )
...
* Removed notices that revealed themselfes over night ...
* And more notices removed that occured over night
* One more ..
* Some more notices of the day ...
2018-08-21 17:35:09 +02:00
334c628511
And again ... notices
2018-08-20 21:20:21 +00:00
Michael Vogel
c1da44b7dc
We now use a central function to fetch the importer ( #5636 )
2018-08-19 13:37:56 +00:00
Michael Vogel
7f3fb34c24
Some easy to replace "q" calls have been replaced by "DBA" calls ( #5632 )
...
* Some easy to replace "q" calls have been replaced by "DBA" calls
* Simplified the GUID creation
* And one in the API ...
* And OStatus has got some DBA calls more
* Just some more replaced database calls
* The event query is now simplified
* Events are now shown again
* subthread is now using the DBA calls as well
* Some more replaced database calls
* And some more replaced database calls and prevented notices
* Better use gravity
* Some more replaced database stuff
* Some more replaced database calls in DFRN.php
* The gcontact class now has got the new DBA functions as well
* The Contact class is now changed to new database functions as well
* Small correction
* We can now delete without cascade
* One more functionality is safe for future changes
2018-08-19 12:46:10 +00:00
0342f9e084
Removed notices, will it ever end?
2018-08-17 03:19:42 +00:00
Michael Vogel
1283b99c6f
Removed notices in the frio theme ( #5610 )
...
* Removed notices in the frio theme
* And fixed notices in the notifications
* And some more in frio
* Null is the default value
* And some small notice in the probing removed
* Added note
* Clarified note
* And a removed notice in OStatus
2018-08-14 19:37:44 +00:00
b3931d066c
Issue-5605: Fixes notice
2018-08-12 08:00:37 +00:00
Roland Häder
e06fc2aa69
Stopped using deprecated constants NETWORK_* ( #5537 )
...
* Rewrite:
- stopped using deprecated NETWORK_* constants, now Protocol::* should be used
- still left them intact for slow/lazy developers ...
* Removed deprecated NETWORK_* constants as per code reviewer's request.
2018-08-11 22:40:44 +02:00
3f612e0641
Issue 5436: Don't store tags that are too long
2018-08-06 17:11:40 +00:00
Hypolite Petovan
c13dc549ed
Rename PROTOCOL_* constants to Model\Conversation::PARCEL_*
...
- Remove unused Conversation::PROTOCOL_GS_CONVERSATION constant
- Remove now renamed PROTOCOL_* constant declarations
2018-08-05 12:24:42 +02:00
Hypolite Petovan
c9b756674a
Add CW support to shared posts in Protocol\OStatus
2018-08-04 21:40:45 +02:00
Hypolite Petovan
36975d521f
Remove plural from $activityobjects variable name in Protocol\OStatus
2018-08-04 21:39:54 +02:00
Michael Vogel
2c8c803d64
Avid notices and warnings ( #5546 )
2018-08-02 19:07:20 +02:00
Michael Vogel
c72c64a6d8
Notices again ( #5543 )
...
* And again notices
* Notices in the directory
* Much more places
* Fix some double $
* Notice in ping
* Missing field
* Fix: We now remove deleted users from the directory
* Some more stuff
* Notices when removing users
* Added logging
* More logging
* Two more
2018-08-02 07:21:01 +02:00
Michael Vogel
1afc0ab028
Added logging and one more reason for a notice found ( #5538 )
...
* Added logging and one more reason for a notice found
* And one more
2018-08-01 08:47:18 +02:00
Michael Vogel
9d0f18c0b3
Yeah, and again notices ... ( #5536 )
...
* Yeah, and again notices ...
* And some more
* Block access without given user name
* Reformatting
2018-08-01 07:29:58 +02:00
Michael Vogel
71b1638d9a
Once again, notices ... ( #5535 )
2018-07-31 18:39:23 +02:00
Michael Vogel
b552b711ee
And some more notices removed ... ( #5533 )
...
* Fix for vanishing notes
* The field needs to be part of the selected fields ...
* And some more notes ...
2018-07-31 07:54:25 +02:00
Roland Häder
4d39164c1e
[WIP] Rewrite to Proxy class: ( #5507 )
...
* Rewrite to Proxy class:
- introduced new Friendica\Network\Proxy class for in exchange of proxy_*()
functions
- moved also all PROXY_* constants there as Proxy::*
- removed now no longer needed mod/proxy.php loading as composer's auto-load
will do this for us
- renamed those proxy_*() functions to better names:
+ proxy_init() -> Proxy::init() (public)
+ proxy_url() -> Proxy::proxifyUrl() (public)
+ proxy_parse_html() -> Proxy::proxifyHtml() (public)
+ proxy_is_local_image() -> Proxy::isLocalImage() (private)
+ proxy_parse_query() -> Proxy::parseQuery() (private)
+ proxy_img_cb() -> Proxy::replaceUrl() (private)
* Ops, need to set $a here ...
* CR request:
- moved Proxy class to Friendica\Module
- extended BaseModule
* Ops, no need for own instance of $a when self::getApp() is around.
* Proxy-rewrite:
- proxy_url() and proxy_parse_html() are both non-module functions (now
methods)
- so they must be splitted into a seperate class
- also the SIZE_* and DEFAULT_TIME constants are both not relevant to module
* No instances from utility classes
* Fixed error:
- proxify*() is now located in `Friendica\Util\ProxyUtils`
* Moved back to original place, ops? How did they move here? Well, it was not
intended by me.
* Removed duplicate (left-over from split) constants and static array. Thank to
MrPetovan finding it.
* Renamed ProxyUtils -> Proxy and aliased it back to ProxyUtils.
2018-07-30 22:06:22 -04:00
Michael Vogel
1eb8f04274
Fixing SQL error when receiving DFRN posts ( #5527 )
...
* Some more notices
* Fixed nasty to find notice in DFRN and OStatus
* And more notices ...
* Yeah, some removed notices ... again ...
* Fixing bad SQL query
2018-07-30 07:06:32 +02:00
Michael Vogel
a2cea16954
Some more notices ( #5526 )
...
* Some more notices
* Fixed nasty to find notice in DFRN and OStatus
* And more notices ...
* Yeah, some removed notices ... again ...
2018-07-30 06:41:20 +02:00
650c3c18e1
Fixed fatal error about when returned 'body' field is empty:
...
````
PHP Fatal error: Uncaught TypeError: Argument 1 passed to Friendica\Protocol\PortableContact::discoverServer() must be of the type array, null given, called in /var/www/../src/Protocol/PortableContact.php on line 1664 and defined in /var/www/../src/Protocol/PortableContact.php:1765
Stack trace:
````
2018-07-29 17:34:20 +02:00
Hypolite Petovan
0902ea508d
Fix parse error in Protocol\PortableContact ( #5515 )
2018-07-28 08:52:57 -04:00
Roland Häder
c30ac30f29
Possible fix for #5470 - json_decode() ( #5511 )
...
* Possible fix for #5470 :
- $data is not an object like stdClass but an array
- newer PHP versions doesn't allow cross-access like following:
$object['foo'] = 123;
$array->foo = 123;
- added type-hints for private methods for above cases
- used `if (empty($foo)) instead of just `if ($foo)` preventing some nasty
E_NOTICE
- added some empty lines for better readability
* Rewrite:
- mixture of object/array was here, causing under newer PHP versions some E_NOTICE
- this has been now finally fixed by converting any `object` type to an
associative `array`
- also changed `is_object()` to `is_array()`
2018-07-28 01:35:27 -04:00
Roland Häder
4a22710b3b
Moved global PAGE_* to Profile class ( #5500 )
...
* Rewrites:
- moved PAGE_* to Friendica\Model\Profile class
* Fixed more rewrites from plain (global namespace) PAGE_* to Friendica\Models\Profile class
* CR request:
- moved all PAGE_* constants to Friendica\Model\Contact class
- fixed all references of both classes
* CR request:
- moved ACCOUNT_TYPE_* constants from boot.php to Contact::ACCOUNT_TYPE_*
* Just copy-pasted this code from boot.php, needs to be changed to `const ACCOUNT_TYPE_FOO = x;`
* Ops, melting brain cells here ... :-/
2018-07-27 19:25:57 -04:00
Michael Vogel
82e3163e5e
Revert "Possible fix for #5470 : ( #5506 )"
...
This reverts commit 1e20fd84f7
2018-07-27 08:02:41 +02:00
Roland Häder
1e20fd84f7
Possible fix for #5470 : ( #5506 )
...
- $data is not an object like stdClass but an array
- newer PHP versions doesn't allow cross-access like following:
$object['foo'] = 123;
$array->foo = 123;
- added type-hints for private methods for above cases
- used `if (empty($foo)) instead of just `if ($foo)` preventing some nasty
E_NOTICE
- added some empty lines for better readability
2018-07-26 18:27:12 -04:00
Michael Vogel
986106a8f7
Item storage: Permissions aren't stored in the items anymore ( #5495 )
...
* The permission set is now used for item permissions
* Check for allow_cid, ... is superfluous. Checking for "private" is enough
* We query the permissionset
* Permissions are displayed correctly
* Changed index
* We don't store the permissions in the item table anymore
* Permission fields are now deprecated
* Reversed ...
2018-07-25 19:14:55 -04:00
