1
0
Fork 0
Commit graph

2855 commits

Author SHA1 Message Date
Adam Magness
748fb8b946 Update function calls
update function calls to new class
2018-11-05 07:40:18 -05:00
Adam Magness
97fcf23371 Move methods to new Util/Strings class
move string methods from xml to strings class.
2018-11-05 07:31:45 -05:00
Adam Magness
b07d47b0f7 Update function calls
update function calls to new names
2018-11-05 07:24:14 -05:00
Adam Magness
6cc339031a Rename functions
rename functions
2018-11-05 07:24:14 -05:00
Adam Magness
ae4aab872f forgotten self
forgotten self references
2018-11-05 07:24:14 -05:00
Adam Magness
61bc9facc8 Implement functions
implement functions relocated to xml class
2018-11-05 07:24:14 -05:00
Adam Magness
84e900d96f Move to XML
move functions from text to xml
2018-11-05 07:24:14 -05:00
dc4a2aeab8 Merge remote-tracking branch 'upstream/develop' into diasppora-delivery 2018-11-04 23:19:34 +00:00
ef205878b6 Cleaned up the notifier 2018-11-04 23:17:41 +00:00
bd97215147 Merge remote-tracking branch 'upstream/develop' into diasppora-delivery 2018-11-04 18:54:49 +00:00
e759497af3 Fix small typo / Workerqueue count now only counts non deferred entries 2018-11-04 10:51:01 +00:00
ec3cec37eb Fixes #6071: We should use the correct variable ... 2018-11-04 09:18:36 +00:00
8f27e3aeb1 Support for fetching non-public content / preparations for forum posts 2018-11-03 21:37:08 +00:00
1395bdc188 Preparations for a relocation message / fix for notice 2018-11-02 21:57:06 +00:00
1b43d459b6 Fix for delivering forum posts again 2018-11-01 23:52:06 +00:00
83ead5ec48
Test enhancements 2018-11-01 13:44:47 +01:00
e12942ce7f
Merge pull request #6058 from JonnyTischbein/issue_contact_batch_archive
[frio] Fix unarchive contact batch action
2018-11-01 06:41:05 +01:00
Jonny Tischbein
76c9d37006 Fix not working unarchive contact batch action 2018-10-31 21:20:44 +01:00
fc2b81d0dd
Update Install.php
Please update messages.po at Transifex as well.
2018-10-31 21:03:32 +01:00
Jonny Tischbein
b66bcb20da Redirect to previous page after NON-AJAX Post delete via second parameter in /item/drop 2018-10-31 20:09:44 +01:00
8a46c786f3
Merge pull request #6053 from zeroadam/CoreRenderer
Core Renderer Class
2018-10-31 13:57:12 -04:00
Adam Magness
70f01d6c00 Template Engine and props to Renderer
move methods and props from App to Renderer
2018-10-31 13:25:38 -04:00
2a0a7cd42a
Add missing Logger::log() 2018-10-31 17:52:41 +01:00
Adam Magness
3f74ba88c2 Move delimiter props and functions
move left and right delimiter functions and properties to Render class.
2018-10-31 12:12:15 -04:00
Adam Magness
35abc4bb64 get markup template
implement getMarkupTemplate function
2018-10-31 10:44:06 -04:00
Adam Magness
91facd2d0a replace macros
implement new replaceMacros function
2018-10-31 10:35:50 -04:00
bf878d2ebb
Adding more Logger entries in case of update process 2018-10-31 15:22:44 +01:00
Adam Magness
f6c86649c2 Create Core\Renderer Class
create new class and redirect old functions
2018-10-31 10:03:42 -04:00
3f813d853b
introducing Logger::log 2018-10-31 14:48:19 +01:00
e5530dfa63
refactoring query 2018-10-31 14:44:43 +01:00
9690dfc54e
Renamed Cache flag 2018-10-31 14:44:42 +01:00
270e817954
Adding force to update routine
- Introduced Cache::NEVER Lock (never expiring lock)
- Force flag for dbstructure update
- Moving the business logic to central place in Update class
2018-10-31 14:44:40 +01:00
f08f063a38
Replaced check_db in App 2018-10-31 14:44:24 +01:00
ffbad2dc81
moved check_db($via_worker) to Update::check($via_worker) 2018-10-31 14:44:23 +01:00
87f3fe24f7
Moving UPDATE defines/constants out of boot 2018-10-31 14:44:23 +01:00
4ae985e5ed
Setting update version & time on success 2018-10-31 14:44:23 +01:00
26aee23254
Replacing dbupdate_ in admin.php and removing it from Worker\DBUpdate 2018-10-31 14:44:22 +01:00
f2ca3e5be4
Using Locks for Updating and writing last success to config 2018-10-31 14:44:22 +01:00
e876adef8f
Moved the functions update_db and run_update_function to a Friendica\Core\Update class 2018-10-31 14:44:21 +01:00
Adam Magness
02be1d316d Documentation
add proper documentation.
2018-10-31 07:32:22 -04:00
Adam Magness
d9b558a8ed Update function calls
update function calls to new class.
2018-10-30 14:51:45 -04:00
Adam Magness
3a604029eb Create FileTag class
create class and move functions
2018-10-30 14:51:21 -04:00
f7f96e971a Avoid duplicated delivery to Diaspora 2018-10-30 17:34:18 +00:00
Adam Magness
c3ee9afa59 Bug fix
update Logger::DEBUG to Core\Logger::
2018-10-30 11:43:27 -04:00
Adam Magness
17ae53c9d7 Review Updates
create array, remove getConstants function, add self references.
2018-10-30 11:40:11 -04:00
Adam Magness
342e484533 Missing BaseObject
add use BaseObject
2018-10-30 10:02:52 -04:00
Adam Magness
50da89d861 Logger Levels
update logger levels in calls
2018-10-30 09:58:45 -04:00
Adam Magness
91ef9f238c missing use and self
add use and self statements
2018-10-30 09:57:14 -04:00
Adam Magness
26fbe8dfba Review Modifications
make changes based on review.
2018-10-30 09:57:14 -04:00
Adam Magness
7138cc97ac Correct misspelling
correct misspelled use statement
2018-10-30 09:57:14 -04:00
Adam Magness
14fde5dc9b Log function
implement log() function.
2018-10-30 09:57:14 -04:00
Adam Magness
d6d593d724 Create Logger class
Create Core\Logger class and point old functions to the new ones.
2018-10-30 09:57:14 -04:00
f7147fae96
Merge pull request #6041 from nupplaphil/install_to_module
Install to Module
2018-10-30 08:17:26 -04:00
e586e49c82
Bugfixing missing 'REQUEST_URI' for relative path installation 2018-10-30 12:58:15 +01:00
cf39c9df81
Bugfixings
- moved testargs.php to util directory
- Switch Environment check before config at automatic install
- checkPHP() is now finding the PHP binary too
- Bugfixing checkPHP() & required returned wrong status
- removing not used $_POST['phpath'] in web installer
2018-10-30 11:30:19 +01:00
84be62982a Diaspora signature transport via AP/DFRN should be repaired now 2018-10-29 21:15:37 +00:00
f0382ab919
Refactoring Installation
- centralized installation
- renamed Core\Install to Core\Installer
- avoid using $a->data[] for states
- removed unnecessary code
2018-10-29 18:44:39 +01:00
64149c41b4
Replacing error message 2018-10-29 14:40:50 +01:00
cfae736660
Code Standards 2018-10-29 14:39:09 +01:00
abb50fbf62
Install to Module
- Move Install to Module
- Some Bugfixings
2018-10-29 14:10:45 +01:00
4831688dc0 Diaspora signatures are now stored and transmitted correctly 2018-10-27 14:35:22 +00:00
73f596cc46 Fixes duplicated transmissions and not working undo of like/dislike 2018-10-27 11:09:23 +00:00
f2ddcbe632 AP: Event participation and editing of posts are now supported 2018-10-27 06:17:17 +00:00
4bcd2d7708 Declare missing $lang for default template in App->runFrontend 2018-10-26 08:13:31 -04:00
86df648107
Merge pull request #6026 from annando/ap-event
AP: We now transmit and process events
2018-10-26 00:33:48 -04:00
f174bc1bc2
Merge pull request #6028 from annando/issue-5913
Issue 5913: Fix fatal error in "RemoveUser"
2018-10-26 00:32:16 -04:00
348e0300a6 Issue 5913: Fix fatal error in "RemoveUser" 2018-10-26 04:27:23 +00:00
cbc417114d AP: We now transmit and process events 2018-10-26 04:13:26 +00:00
Jonny Tischbein
e022bac339 Code Standard + renaming deleteAllTags + move its call and add type param 2018-10-25 21:47:10 +02:00
Jonny Tischbein
26ed71cc14 Only perform Term::deleteAllTags when needed + not needed redirect 2018-10-25 21:47:10 +02:00
Jonny Tischbein
272eb5eb82 fix doxygen header + indent 2018-10-25 21:47:10 +02:00
Jonny Tischbein
fd2e06781d Fix adding / removing photo tags + tagrm delete via GET + Item::update / add Term::deleteAllTags 2018-10-25 21:47:10 +02:00
7c0b591043 Move itemCount parameter from constructor to renderFull()
- Remove Pager->itemCount property and Pager->setItemCount() method
- Update usage
2018-10-25 00:07:16 -04:00
14237a9599 Move $pager and $page_offset out of App
- Move infinite scroll data output in a module hook
- Use Pager instead of paginate() and alt_pager()
2018-10-25 00:07:15 -04:00
a976a4cb68 Add new Hook::add method to enable module hooks 2018-10-25 00:07:15 -04:00
f1ebaf5e7d Add new Content\Pager class 2018-10-25 00:07:15 -04:00
Michael Vogel
920ffab439
Merge pull request #6024 from MrPetovan/bug/fix-disabling-addons
Fix unsetting non-existent index in Addon::$addons on uninstall
2018-10-25 05:28:47 +02:00
c60a65c423 Fix unsetting non-existent index in Addon::$addons on uninstall 2018-10-24 20:44:05 -04:00
7f11b2e4e9 Deactivated BCC 2018-10-24 21:04:21 +00:00
f300c8953a We now use bcc for the acl block 2018-10-24 20:06:57 +00:00
0a790227b6 Merge remote-tracking branch 'upstream/develop' into ap-delivery 2018-10-24 19:22:07 +00:00
58f82e084d Preparations to work with BCC 2018-10-24 19:19:51 +00:00
072eeb8bec
making english sentences 2018-10-24 20:52:38 +02:00
99a33b7335
Code standards 2018-10-24 20:44:19 +02:00
310d49b82a
removed use Friendica\Core\System again 2018-10-24 20:24:22 +02:00
48535c0959
Bugfixing redirects
- Adding App->redirect if both redirects are possible
2018-10-24 20:18:46 +02:00
9c9ebfc7c9
Merge pull request #6013 from JonnyTischbein/issue_comment_media_link_prompt
[frio] Add media / link prompt in comments
2018-10-24 12:17:58 -04:00
Jonny Tischbein
d2b5f77be9 Add multimedia link for jot + enables hover text in jot + autosize in when paste link + renaming / Code Standards 2018-10-24 16:20:10 +02:00
c25d60e107 Removed finished work from the comments 2018-10-24 04:51:37 +00:00
a6f6db8d4e Improve query speed 2018-10-24 04:50:27 +00:00
c0a24d80dd Remove items more memory friendly 2018-10-24 04:46:45 +00:00
95dc030926 Show deferred worker tasks in the admin interface and workerqueue logs 2018-10-23 20:38:28 +00:00
Jonny Tischbein
d0c43c5597 Add prompt for link and media in comment + remove video symbol 2018-10-23 19:50:19 +02:00
fabrixxm
035603a516 Replace Frienica\Core\Addon::isApp() withi Friendica\Core\Hook::isAddonApp()
fix #6010
2018-10-23 17:27:53 +02:00
cb75c40f4e adapted profile pic resize to 300px for whole system 2018-10-23 16:36:57 +02:00
Michael Vogel
d61a98a995
Merge pull request #6008 from nupplaphil/fixing_tests_2
Fixing tests - part 2
2018-10-23 14:23:59 +02:00
a79daf3946
Fixing tests - part 2 2018-10-23 13:53:48 +02:00
3e6ea9383b
Making redirect message more informative 2018-10-23 12:17:41 +02:00
dbe49a0c1a
Merge pull request #5998 from annando/ap-queue
Unsuccessful ActivitiyPub transmission are now deferred
2018-10-23 06:54:11 +02:00
e3e714a45f Unsuccessful ActivitiyPub transmission are now deferred 2018-10-23 03:54:18 +00:00
dc35d2f2f3
Merge pull request #5997 from annando/notice-relocation
Fix a notice when sending relocation messages
2018-10-22 22:40:47 -04:00
3dc0bb5c4b Fix a notice when sending relocation messages 2018-10-23 02:24:24 +00:00
b6a0b686c4
Fix missing instance of Addon::isEnabled in App 2018-10-22 21:09:53 -04:00
373df31817
Fix wrong namespace for Core\System in App 2018-10-22 18:07:00 -04:00
f6e064195a
Fix Fatal Error in App 2018-10-22 18:01:17 -04:00
a22196edae Add/Fix Doxygen headers for classes 2018-10-22 16:50:55 -04:00
9eaedc576c Remove unused dbstructure hook call in App->loadDatabase 2018-10-22 16:50:55 -04:00
2debdbd0c9 Fix dbstructure console outputting addon structure as well 2018-10-22 16:50:55 -04:00
015e2a84b1 Remove obsolete require_once include/dba from Core\Addon and Core\Hook 2018-10-22 16:50:55 -04:00
19ffc0510b Move DB_UPDATE_VERSION from boot.php to config/dbstructure.php 2018-10-22 16:50:55 -04:00
fad99b8619 Switch from dbstructure.json to dbstructure.php 2018-10-22 16:50:55 -04:00
e511790d62 Move NULL_DATE from boot.php to DBA::NULL_DATETIME
- Add DBA::NULL_DATE constant
2018-10-22 16:50:55 -04:00
ca9cad3491 Move hook-related methods from Core\Addon to Core\Hook 2018-10-22 16:50:54 -04:00
0aa7671119 Add new Core\Hook class 2018-10-22 16:49:53 -04:00
Michael Vogel
c0abff0bda
Merge pull request #5990 from MrPetovan/task/move-apps-out-of-app
Road to Router Part 4: Move $apps out of App
2018-10-22 22:47:22 +02:00
3072c56057
goaway fix in App 2018-10-22 22:15:50 +02:00
32af52842b
adding defaults in mod/redir.php 2018-10-22 22:13:41 +02:00
363d00cc45
Adding $a->getBaseURL for Worker in profile_photo
Adding a TODO for Contact::magicLink
2018-10-22 22:13:39 +02:00
34989480e1
removed unnecessary System use 2018-10-22 22:13:39 +02:00
3edad1591e
replaced $return_url to $return_path to make it more clear that it is a relative path to the Friendica baseurl 2018-10-22 22:13:37 +02:00
a9510ffcdf
description fix 2018-10-22 22:13:37 +02:00
d00ddc01af
Split goaway to System::externalRedirectTo() and App->internalRedirect() 2018-10-22 22:13:35 +02:00
2ef81108b3
Renamed System::redirect() to $a->redirect() 2018-10-22 22:13:22 +02:00
Benjamin Lorteau
339a5da946 Move $apps out of App
- Move $nav_sel out of App
- Add new Content\Nav::getAppMenu() method
2018-10-22 16:02:15 -04:00
e3fe25383c Add static keyword for Core\L10n properties 2018-10-22 15:58:42 -04:00
c6f0bea51d Move $strings from App to Core\L10n
- Add L10n::init() call in App constructor
- Improve pushLang/popLang
- Remove no longer needed references to App
2018-10-22 15:58:42 -04:00
Michael Vogel
baa1094489
Merge pull request #5987 from MrPetovan/task/empty-index-php
Road to Router Part 2: Empty index.php
2018-10-22 21:56:13 +02:00
Benjamin Lorteau
37f00b5fd1 Use System::httpExit for 403 error in App 2018-10-22 15:16:59 -04:00
a0bd96d587 Remove unwarranted doxygen comments in App 2018-10-22 08:17:55 -04:00
5c13ecdf6e Improved parsing of AP profiles 2018-10-22 07:24:47 +00:00
e2c5a423c5 Improve App->runFrontend formatting
- Use single-quotes instead of double
- Use strpos() instead of substr()
- Add/remove comments
- Use Config::get default value and drop the exact match for config.private_addons
2018-10-22 00:07:56 -04:00
279196959c Move index.php content to App->runFrontend
- Replace all x() by !empty() in App
- Replace all killme() with exit()
2018-10-21 22:24:47 -04:00
rabuzarus
72a7671010
Merge pull request #5986 from annando/improve-5984
Improve PR 5984: better check for remote users as well
2018-10-22 00:03:19 +02:00
8e11f055b1 Improve PR 5984: better check for remote users as well 2018-10-21 21:56:46 +00:00
Michael Vogel
277fe547a1
Merge pull request #5978 from MrPetovan/task/make-username-length-configurable
Make username length configurable
2018-10-21 23:42:44 +02:00
4ec56a0975 Sets maximum to 64 for username_min/max_length config keys 2018-10-21 17:28:40 -04:00
1176a4240a
Merge pull request #5985 from annando/ap-followers
AP: We now send the previous followers collection as well
2018-10-21 17:05:34 -04:00
bb3f07b0b7 We now send the previous followers collection as well 2018-10-21 20:49:50 +00:00
9b387a226c Fix webmentions and microformats ("redir" only for logged in users) 2018-10-21 20:23:08 +00:00
c1bca43fee Changing default/max values for username_min/max_length
- Restoring legacy default values (3 and 48 respectively)
- Lowering the max value to 150 to take the full profile URL length into
account
2018-10-21 15:10:51 -04:00
b08408c086 Add safeguard for username_min|max_length mutual exclusion 2018-10-21 08:28:24 -04:00
Michael Vogel
f14dae8d77
Merge pull request #5979 from MrPetovan/task/mock-legacy-module
Encapsulate legacy module functions in a BaseModule-inherited class
2018-10-21 10:02:44 +02:00
Michael Vogel
614a549d28
Merge pull request #5976 from MrPetovan/bug/5975-add-missing-l10n-poplang
Add missing L10n::popLang calls
2018-10-21 09:40:49 +02:00
b6075de6f8
Merge pull request #5982 from annando/ap-inboxes
Bugfix: We hadn't deliverd AP posts to all intended receivers
2018-10-21 02:57:22 -04:00
1c54c27784 Bugfix: We hadn't deliverd AP posts to all intended receivers 2018-10-21 06:10:24 +00:00
c4cc7a4afb The limit for dbclean is now configurable 2018-10-21 05:41:40 +00:00
1a37224910 Change file_exists to is_readable in LegacyModule 2018-10-20 22:42:04 -04:00
5326cc0c2e Add Friendica\LegacyModule class 2018-10-20 22:34:26 -04:00
d360bf926a Use username_min/max_length config keys in Model\User::create 2018-10-20 16:33:54 -04:00
4392858662
Move Global Functions - Part 3
- Replaced every CACHE definition
- Moved check_url to App->checkURL()
- Removed unused definition "ZCURL_TIMEOUT"
2018-10-20 18:19:55 +02:00
4ffcb77554 Simplify L10n::t + sprintf instances 2018-10-20 09:02:35 -04:00
a8d3a4d218 Add missing L10n::popLang calls 2018-10-20 09:02:10 -04:00
fea48fa85e AP: Transmitting and receiving with non AP contacts 2018-10-20 07:53:45 +00:00
a2666b0d02
Remove reference to deleted include/security.php 2018-10-19 15:11:51 -04:00
Benjamin Lorteau
d9209b9c7a Use local temporary directory for PasswordExposedChecker cache 2018-10-19 11:26:48 -04:00
f104817967
Merge pull request #5967 from annando/ap-nick
Fix function naming
2018-10-19 10:38:51 -04:00
bedab33e0b Fix function naming 2018-10-19 13:08:46 +00:00
ec0d3a6eac
Merge pull request #5946 from JonnyTischbein/move_include_security
Move and Split include/security
2018-10-19 08:55:08 -04:00
Jonny Tischbein
cafd5ca781 update function names in logger and comments 2018-10-19 10:03:52 +02:00
cdeb4682ef Use nickname based mentions for AP 2018-10-19 05:27:54 +00:00
Michael Vogel
8cecc9fb97
Merge pull request #5962 from friendica/bug/5960-fix-register-email-translation-params
Remove superfluous L10n::t() parameter in Model\user
2018-10-19 05:34:24 +02:00
Michael Vogel
45156652cc
Merge pull request #5963 from MrPetovan/bug/5956-catch-more-diaspora-magic-links
Diaspora: Widen the magic link regular expression
2018-10-19 05:30:52 +02:00
d0681075bf Add itemsource module 2018-10-18 22:49:25 -04:00
eb714f0487 Diaspora: Widen the magic link regular expression 2018-10-18 22:39:06 -04:00
8315940c39
Merge pull request #5961 from annando/simpler-item
The handling with item-content and item-activity had been simplified
2018-10-18 18:24:09 -04:00
18763e32af
Remove superfluous L10n::t() parameter in Model\user 2018-10-18 18:22:48 -04:00
0628b44f8e The handling with item-content and item-activity had been simplified 2018-10-18 21:35:48 +00:00
ee32cf6b92
Restore preshare prepending in BBCode::convertShare
Fixes #5955
Follow-up to #5942
2018-10-18 11:23:48 -04:00
688174e6c0 AP: Fix "null" receiver 2018-10-18 12:25:57 +00:00
8035bad8e2 AP: Fix a notice / avoid an error when fetched content hadn't been an array 2018-10-18 05:54:44 +00:00
da2a17495d
Merge pull request #5951 from annando/endless-contact
Avoid endless loop when trying to fetch contact id
2018-10-18 00:44:07 -04:00
6d420dfe9e
Merge pull request #5950 from annando/no-polling
For test purposes we can now deactivate polling
2018-10-18 00:43:35 -04:00
92816dc725 Improved loop detection 2018-10-18 03:33:08 +00:00
35da40c2cb Avoid endless loop when trying to fetch contact id 2018-10-18 03:01:34 +00:00
d307aa1484 For test purposes we can now deactivate polling 2018-10-18 02:46:02 +00:00
Jonny Tischbein
a937cf06a3 add remaning/moving to files not touch by refactoring because of typo 2018-10-17 22:35:49 +02:00
Michael Vogel
a19f8d642d
Merge pull request #5942 from MrPetovan/feature/3218-add-convert-share-callback
Add BBCode::convertShare callback parameter
2018-10-17 22:01:02 +02:00
Jonny Tischbein
f3fc1f36ca Renaming functions + moving functions from security to Model/Item and BaseModule + fix multiline comments 2018-10-17 21:30:41 +02:00
Michael Vogel
389685e099
Merge pull request #5920 from MrPetovan/bug/remove-password-from-register
Avoid storing plaintext password in register table
2018-10-17 21:04:11 +02:00
e254ace9d5
Merge pull request #5947 from annando/uri-id
Use "uri-id" for item relations
2018-10-17 14:45:40 -04:00
62ad755980 Use "uri-id" for item relations 2018-10-17 18:34:24 +00:00
Jonny Tischbein
ce2b1f5715 Rename function Authentication::authenticate_success to Authentication::success 2018-10-17 18:45:32 +02:00
Jonny Tischbein
45e5a7f59f remove unsed require_onces of security.php 2018-10-17 18:39:27 +02:00
057385a4ec Add $is_quote_share parameter to convert share callback
- Restore former behavior when content is present before [share] block
2018-10-17 08:20:56 -04:00
Jonny Tischbein
05be2db725 Move include/security tp /src/Core/Authentication and /src/Util/Security 2018-10-17 14:19:58 +02:00
9239ecc5e0 Rework BBCode::convertShare to accept a callback function
- Create default convertShare callback from previous code
- Remove $simplehtml = 8 case (moved to Twitter addon)
2018-10-17 01:13:18 -04:00
b5fb81f535 Add Mastodon/Pleroma protocol guessing 2018-10-17 01:10:07 -04:00
c50be325bd Remove unused parameter $selected in Model\Item::fieldlist 2018-10-16 18:30:24 -04:00
341b83d1df Fix Undefined index: photo in ActivityPub/Receiver 2018-10-16 18:29:28 -04:00
cb854b8b10 Fix Undefined index: timezone in Protocol\Diaspora 2018-10-16 18:29:08 -04:00
2b1d15de87 Fix undefined index: id in Protocol\Diaspora 2018-10-16 18:28:27 -04:00
c4318fe05e Fix notices in Parse URL feature 2018-10-16 18:27:13 -04:00
e9c9eb9c66 Fix notice in Worker\Delivery 2018-10-16 18:26:43 -04:00
ff643c4b6a
Merge pull request #5940 from JonnyTischbein/issue_update_display_network
Fix redirect after edit post to /update_*
2018-10-16 13:37:19 -04:00
Jonny Tischbein
be2e6c3929 Fix Issue #5896 by setting static return for edit_post to display item page (kind of revert parts of #5774) 2018-10-16 19:14:55 +02:00
93c6dddc0d
Merge pull request #5939 from annando/onepoll
Onepoll hadn't polled anymore / small relocation in zrlinit for better logging
2018-10-16 11:27:48 -04:00
35a73b729f Onepoll hadn't polled anymore / small relocation in zrlinit for better logging 2018-10-16 13:17:01 +00:00
dbd2aa1196
Merge pull request #5938 from annando/magic-loop
Avoid endless loop at magic auth
2018-10-16 09:17:17 +02:00
012fe3c11e Avoid endless loop at magic auth 2018-10-16 06:32:12 +00:00
481b0ac138 Fix notices in include/enotify 2018-10-15 23:13:00 -04:00
0de1351a09 Fix notices in Network\Probe 2018-10-15 23:12:29 -04:00
8d0f4710a4 Signed Diaspora posts should now be stored more reliable 2018-10-15 21:42:55 +00:00
Benjamin Lorteau
9e1065ff87 Improve transition from previous behavior
- Simplify Model\User methods parameter list
- Use DBA methods in mod/regmod
- Replace killme with exit in mod/regmod
- Simplify goaway() calls
2018-10-15 11:58:52 -04:00
664afbcafb
Merge pull request #5926 from annando/defer-worker
Poddibility to defer worker execution
2018-10-15 08:02:51 +02:00
e2762e032c Poddibility to defer worker execution 2018-10-15 05:19:35 +00:00
Michael Vogel
0080d117ee
Merge pull request #5923 from MrPetovan/task/improve-contact-module
Improve Contact module
2018-10-15 06:02:55 +02:00
aa8039373a Update formatting of Module\Contact
- Replace double quotes with single
- Align array declarations
- Replace q() call with Model\User::getOwnerDataById()
2018-10-14 18:30:02 -04:00
a883a99fe6 Replace string fields by array in Module\Contact 2018-10-14 18:27:24 -04:00
12ddb3bb54 Replace unwarranted uses of $a->data['contact'] 2018-10-14 18:25:44 -04:00
57e8fb5cb1 Normalize uses of defaults() in Module\Contact
- Remove uses without default value
- Add relevant uses
2018-10-14 18:24:02 -04:00
756a4f1111 Fix remaining instances of "contacts" 2018-10-14 18:02:54 -04:00
Jonny Tischbein
3a95644848 Add Support for relativeDateTime in future + update Admin user waiting for deleting table header 2018-10-14 22:57:44 +02:00
74c5f1f684
Merge pull request #5891 from JonnyTischbein/move_module_contacts
Move module contacts
2018-10-14 16:42:50 -04:00
Jonny Tischbein
e41c59b193 Fix batch action choice - All Actions for one contact were taken before 2018-10-14 21:38:38 +02:00
Jonny Tischbein
d54e56c659 Fix batch action query + Fix Namespace import 2018-10-14 21:14:32 +02:00
ce74a4d9a1
Merge pull request #5921 from annando/ap-video
ActivityPub: Rudimentary support for videos
2018-10-14 14:05:51 -04:00
Jonny Tischbein
5fd4402074 code standards + fixing navigation links to /contact/... 2018-10-14 20:03:22 +02:00
Michael Vogel
68af56a10e
Merge pull request #5912 from MrPetovan/bug/fix-code-tag-nonsense
Fix [code] tag whitespace nonsense
2018-10-14 20:00:19 +02:00
37ad4a7d22 ActivityPub: Rudimentary support for videos 2018-10-14 17:57:44 +00:00
540adaf829 Use Model\Register methods in modules
- Update registration emails to avoid storing the plaintext password in
the register table
- Remove redundant sprintf() when used with L10n::t()
- Remove redundant Systen::baseUrl() with goaway()
2018-10-14 12:26:18 -04:00
59d6dd809d
Merge pull request #5906 from annando/ap-switch
OStatus contacts are now automatically converted to AP
2018-10-14 12:04:52 -04:00
123992384b Create Model\Register
- Add Model\User::exists method
2018-10-14 11:34:34 -04:00
7f143c3159 Fix various spelling mistakes 2018-10-14 11:32:54 -04:00
a769efae38 Remove whitespace clearing around code tags
- Normalize inline code blocks to <code>
2018-10-14 07:43:44 -04:00
6606c9cbb2
Merge pull request #5910 from nupplaphil/acctlink_followup
FollowUp Acctlink move
2018-10-14 06:27:02 -04:00
6c80601a4a
Merge pull request #5902 from nupplaphil/Install_Class_to_methods
Install class bugfixing & tests & changed method signature
2018-10-14 06:23:33 -04:00
248c1b8074
Type hinting & call bugfixing 2018-10-14 10:37:19 +02:00
753f61f633
FollowUp Acctlink move 2018-10-14 10:31:11 +02:00
6be04a73e3 The outbox is now more complete / No more duplicates in the receiver array 2018-10-14 07:47:04 +00:00
db0b848ae3
Merge pull request #5904 from annando/ap-announce
AP: Announce will now work
2018-10-13 20:17:14 -04:00
07da170bcf
Merge pull request #5905 from nupplaphil/move_global_functions
Move global functions
2018-10-13 19:46:57 -04:00
e829e074fc Location, coord and app are now processed as well 2018-10-13 21:37:39 +00:00
aab4fa0c31 The instrument is now added, updating AP contacts is now enabled 2018-10-13 20:36:44 +00:00
f60468677e We now transmit location and application as well. 2018-10-13 19:49:20 +00:00
8b9aa80aad "to" is now used for mentions, "cc" for everything else 2018-10-13 18:59:39 +00:00
efad4936b0 OStatus contacts are now automatically converted to AP 2018-10-13 18:13:01 +00:00
4f7cb049fb
isAjax bugfix 2018-10-13 19:10:46 +02:00
Michael Vogel
514ec1be6d
Merge pull request #5903 from nupplaphil/move_module_acctlink
Move module AcctLink
2018-10-13 19:09:59 +02:00
3f729df258
Renamed AcctLink to Acctlink 2018-10-13 19:03:38 +02:00
2c541afd47
Moved functions out of boot.php into class
- z_root() => $a->getBaseURL()
- absurl() => removed because no usage
- is_ajax() => $a->isAjax()
- current_load() => System::currentLoad()
- argc() => $a->argc
- argv($x) => $a->getArgumentValue($x)
2018-10-13 19:03:08 +02:00
3c48a1f787 AP: Announce will now work 2018-10-13 16:41:29 +00:00
508032cf9a
Move Module AcctLink 2018-10-13 18:32:14 +02:00
c32ac7f194
Install Class to methods
- Bugfixing Install checks (worked not as expected)
- Changed static methods from Install to class functions
- Added tests
2018-10-13 18:09:53 +02:00
d23386f9b2 Catching error when compacting doesn't work 2018-10-13 13:17:10 +00:00
Jonny Tischbein
bfa05156ca change links from /contacts to /contact 2018-10-13 13:29:56 +02:00
Jonny Tischbein
738cb4ace6 finish refactoring to Module\Contact 2018-10-13 11:35:51 +02:00
Jonny Tischbein
cdbddd0103 Renaming functions and class 2018-10-13 11:23:52 +02:00
4d4dd1a99c Some beautification 2018-10-12 20:52:22 +00:00
5af0ee1b95 We can now store it without any problem 2018-10-12 18:53:13 +00:00
914b3a9e3e Merge remote-tracking branch 'upstream/develop' into fix-diaspora-signature 2018-10-12 18:52:22 +00:00
1b18be6715 The virtuel fields for the diaspora signatures have to be removed at any time 2018-10-12 18:47:32 +00:00
986528b77f
Revert "We now store the diaspora comment data as well" 2018-10-12 10:35:43 -04:00
Jonny Tischbein
93ab82b7f0 Rename Contacts:content function 2018-10-11 23:45:01 +02:00
Jonny Tischbein
ba95487abf Upate Contacts module file 2018-10-11 23:41:27 +02:00
Jonny Tischbein
80ea86113d Move mod Contacts to /src/Module 2018-10-11 23:14:12 +02:00
735a5980bd
Merge pull request #5889 from annando/ap-store-diaspora
We now store the diaspora comment data as well
2018-10-11 16:42:53 -04:00
90254fd74b
Merge pull request #5888 from nupplaphil/curl_result_tests
Curl result tests
2018-10-11 16:42:09 -04:00
8268288953 We now store the diaspora comment data as well 2018-10-11 20:38:57 +00:00
fc19373ec4
Merge pull request #5887 from annando/ap-store-conversation
Store conversation data directly from the AP receiver
2018-10-11 16:32:00 -04:00
b099cba4b4
CurlResult Tests & RegEx fix 2018-10-11 22:18:27 +02:00
1bf7521af8 Store conversation data directly from the AP receiver 2018-10-11 20:08:04 +00:00
00bf0c24b6
CurlResult Tests 2018-10-11 21:19:38 +02:00
ac1ff6c8ce Try additional $_SERVER properties to get relative path of Friendica 2018-10-11 08:54:45 -04:00
a95e7f6504
Bugfixing CurlResult 2018-10-11 07:45:04 +02:00
a066befba5
Merge pull request #5878 from nupplaphil/curl_response_refactoring
Curl response refactoring
2018-10-10 18:31:49 -04:00
9711581d49
Code standard 2018-10-10 22:51:26 +02:00
b2e7ce47b3
Renaming Curl to CurlResult 2018-10-10 22:08:13 +02:00
ffbc688797
Curl Response Refactoring
- refactored Network::getCurl()
- replaced every Network::getCur() execution with a Curl Response
2018-10-10 21:50:13 +02:00
67afa069ab
Merge pull request #5877 from annando/issue-5859
Issue 5859: Avoid returning empty arrays
2018-10-10 15:23:39 -04:00
7c73e8634c
Curl Response Refactoring
- refactored Network::post()
- replaced every Network::post() execution with the new Curl container
2018-10-10 21:15:26 +02:00
c4da138eee Issue 5859: Avoid returning empty arrays 2018-10-10 19:15:16 +00:00
2dec8895a9
Curl Response Refactoring
- extended Curl to parse Curl Response
- refactored Network::curl()
- replaced every Network::curl() execution with the new Curl container
2018-10-10 21:08:43 +02:00
e6b1f9ef09
friendica-5875 Uncaught Error: Call to undefined method Friendica\App::getCurlCode() fixed 2018-10-10 18:10:38 +02:00
97dc4bba1a
some more renamings & doku 2018-10-10 09:16:06 +02:00
3d04562c87
some more renamings & doku 2018-10-10 08:54:18 +02:00
307286fc47
parameters and getURLpath to getURLPath 2018-10-10 01:18:47 +02:00
3eb4332f33
Bugfixing Backend 2018-10-10 01:16:51 +02:00
5a02e39a65
Rename App Methods
- renamed a lot of App methods to CamelCase
- replaced direct public variables with get-/set-Methods
2018-10-10 00:16:06 +02:00
5f9dd11cfb
Merge pull request #5867 from annando/ap-fix-follow
AP: Switchting existing contacts to AP when receiving activities
2018-10-09 16:08:38 -04:00
c9f1857c4a
Merge pull request #5866 from annando/ap-cleanup
AP: Avoid a misleading log entry / unneeded field removed
2018-10-09 16:06:58 -04:00
0994aaf875 AP: Avoid a misleading log entry / unneeded field removed 2018-10-09 20:00:57 +00:00
c0f26ace2e AP: Switchting existing contacts to AP when receiving activities 2018-10-09 19:58:15 +00:00
Jonny Tischbein
2db2b79bfa Give Login Form previous URL to return to. SESSION var is empty if invalid page. empty args is catched by function 2018-10-09 21:38:17 +02:00
b5d73f840c AP fixes: LD-signature, wrong owner for completed thres, account removal 2018-10-09 05:04:24 +00:00
4047952703 AP: Avoid an empty avatar field 2018-10-08 03:28:49 +00:00
3bccaccede
Merge pull request #5848 from nupplaphil/friendica-5847
friendica-5847 Console Cache List command doesn't work
2018-10-07 17:47:51 -04:00
28b4fdb1c3
Merge pull request #5854 from annando/ap-parser
We now parse a compacted JSON
2018-10-07 17:42:03 -04:00
30ad6d60fd Duplicated line removed 2018-10-07 20:51:39 +00:00
46f77f3486 Detect the object type 2018-10-07 20:36:15 +00:00
7da6da6666
Bugfixings for getAllKeys() 2018-10-07 22:14:05 +02:00
93866b477a Several fixes 2018-10-07 19:42:04 +00:00
bd6ba98e8d Some more cleanup 2018-10-07 18:41:45 +00:00
1efca1b75d owner is now actor 2018-10-07 17:35:43 +00:00
616c4a89bd The new parsing is now active 2018-10-07 17:17:06 +00:00
36c31e4091 Switching to parsing the JSON-LD 2018-10-07 15:34:51 +00:00
Jonny Tischbein
28456de249 Save return_url before login. Add login mask to many sites if not logged in. 2018-10-07 16:34:08 +02:00
3a74f3364d Switch to parsing compacted JSON data 2018-10-07 13:37:05 +00:00
772d735f12
Merge pull request #5845 from annando/ap-suggest
Preparation for suggestions under AP
2018-10-07 08:58:21 -04:00
8491f8660f
Bugfixing Memcached 2018-10-07 10:38:45 +02:00
1ec5c6b284
friendica-5847 Console Cache List command doesn't work
- filterPrefix => filterArrayKeysByPrefix()
- Logging failed Executions of getAllKeys and get from Memcached
2018-10-07 10:35:37 +02:00
571e37f4d4
Merge pull request #5844 from nupplaphil/mode_followup
Changing Friendica\App\Mode from static methods to public methods
2018-10-06 22:38:54 -04:00
3f0f3b6ae6
friendica-5847 Console Cache List command doesn't work
- Added $prefix to all CacheDriver
- Moved hostname magic to CacheDriver
- Added test for getAllKeys()
2018-10-07 00:27:54 +02:00
192c6c8d4f Preparation for suggestions under AP 2018-10-06 18:42:26 +00:00
a2fb49a2b4
Removing debugging echo
Updating Tests
2018-10-06 19:11:00 +02:00
31148e25cf
Changing Friendica\App\Mode from static methods to public methods
- Changing from static methods to public methods
- Adding dev-composer-dependency Mockery for static method mocking (f.e. Config, DBA)
- Adding ModeTest with Mocking
- removing bootstrap from phpunit.xml because of double loading tests\bootstrap.php
2018-10-06 16:27:20 +02:00
389a651005 Transmit the Diaspora GUID with activities (Like, Dislike, ...) 2018-10-06 14:02:23 +00:00
2341ce353d
Merge pull request #5842 from annando/ap-distribution
Improved AP distribution / Only process trusted content
2018-10-06 09:35:44 -04:00
a413ce15aa "name" must be plaintext 2018-10-06 13:28:17 +00:00
6b374c32a2 Improved AP distribution / Only process trusted content 2018-10-06 13:16:52 +00:00
acf31ab64b Additional check to ensure that the owner of an activity is always the author 2018-10-06 09:38:51 +00:00
510032444f The owner of a "like" should be the author 2018-10-06 08:51:52 +00:00
ce4204e81a
Merge pull request #5836 from annando/ap4
No @brief anymore
2018-10-06 09:19:28 +02:00
3b41535dfe
Merge pull request #5835 from annando/ap3
Some more AP stuff ...
2018-10-06 09:18:30 +02:00
41123162f1 No @brief anymore 2018-10-06 04:18:40 +00:00
13c5bc807b
Merge pull request #5829 from annando/develop
Cache the AP delivery process
2018-10-06 00:06:47 -04:00
09302367d5 Include AP in the contact search 2018-10-06 03:17:44 +00:00
f69c80b9e2 AP delivery is relocated to the top of the notifier 2018-10-06 03:16:38 +00:00
9dbf8d0b9d Spaces 2018-10-06 02:09:27 +00:00
3ed9e7fe1d Replace remaining $a->isInstallMode() instances 2018-10-05 20:31:32 -04:00
3564daf24d
Merge pull request #5828 from nupplaphil/mode_class
Creating Friendica\App\Mode for encapsulating the App Mode
2018-10-05 20:07:39 -04:00
7ac652e20d
Merge pull request #5831 from nupplaphil/addon_check
moving boot::check_addons to Friendica\Core\Addon::check
2018-10-05 19:45:04 -04:00
f287d76264
Merge pull request #5827 from annando/follow-on-switch
Send a follow request upon contact switch to AP
2018-10-05 19:39:38 -04:00
eb1a257224
Used new select function 2018-10-06 01:21:05 +02:00
d72473fd51
moving boot::check_addons to Friendica\Core\Addon::check
And extending Addon from BaseObject because of self::getApp()
2018-10-06 01:13:29 +02:00
8dc1d19381 Merge remote-tracking branch 'upstream/develop' into develop 2018-10-05 21:04:17 +00:00
51dbffd396 Cache the AP delivery process 2018-10-05 21:00:40 +00:00
947cc98cc4
delete unused use 2018-10-05 22:41:11 +02:00
065340dc32
Creating Friendica\App\Mode for encapsulating the App Mode 2018-10-05 22:36:09 +02:00
5d7968bdf3 Avoid to do the follow stuff for the public user 2018-10-05 20:10:10 +00:00
5ed1c12349 Send a follow request upon contact switch to AP 2018-10-05 19:48:48 +00:00
3c7d41c388
Merge pull request #5826 from annando/network-name
We now can show "Friendica (AP)" as network name
2018-10-05 15:43:16 -04:00
9fbaaa1481 We now can show "Friendica (AP)" as network name 2018-10-05 19:26:20 +00:00
fe6e600dc5
Adding "FRIENDICA_URL_PATH" to the automatic installation 2018-10-05 19:42:08 +02:00
fa7cddc669 AP Bugfix: Following a soapbox now works / rapid follow/unfollow should work now 2018-10-05 06:35:50 +00:00
3d74d412b2 Changed attachment handling to improve Mastodon compatibility 2018-10-05 04:04:37 +00:00
743e7d3ecb
Merge pull request #5815 from annando/ap2
The ActivityPub functionality is now split into 4 files
2018-10-04 09:10:17 -04:00
4368c922fb is sensitive 2018-10-04 13:08:11 +00:00
0ebfa6fc12 Added to-do 2018-10-04 12:57:42 +00:00
1c615f80c4 Improved return values 2018-10-04 12:53:41 +00:00
9171b2a0f3 It's possibly better to use context links that do exist 2018-10-04 09:46:29 +00:00
06a59c8312 Funkwhale documentation added 2018-10-04 05:29:22 +00:00
72fc89d033 Simplified attachment handling 2018-10-04 05:26:00 +00:00
f6277970fa Added some to-do 2018-10-03 19:35:01 +00:00
11a7f6c3e1 Unused "use" removed 2018-10-03 19:17:40 +00:00
cbfc3d0c28 Fix error / "about" is now converted to BBCode 2018-10-03 19:00:32 +00:00
221e197658 Tags are now transmitted as expected 2018-10-03 18:27:01 +00:00
a9a1ac808b Attachments do work now 2018-10-03 17:36:55 +00:00
Jonny Tischbein
ee32459358 goaway with argument 2018-10-03 18:28:04 +02:00
78a7e130ae Another renamed function 2018-10-03 15:50:21 +00:00
8841519c0d Renamed functions 2018-10-03 15:41:51 +00:00
Jonny Tischbein
3c9b33176f Static reason for login failure to prevent bruteforce 2018-10-03 14:32:16 +02:00
Jonny Tischbein
3ecabe0291 Fix goaway url when login failed + using info to display message 2018-10-03 13:10:49 +02:00
1fe55679fc Moved documentation 2018-10-03 09:53:12 +00:00
acd1caa114 The function is only needed in the same class 2018-10-03 09:45:54 +00:00
Michael Vogel
ec898ecd2a
Merge pull request #5792 from MrPetovan/task/add-cache-console
Add Cache console
2018-10-03 11:17:43 +02:00
3ab837f3c7 Functionality is now split 2018-10-03 09:15:38 +00:00
4d2e5c2bbe AP class will be split in processor, receiver and transmitter 2018-10-03 06:15:07 +00:00
2a7327a41c
Fix spaces in Cache\Memcachedriver 2018-10-03 00:24:26 -04:00
76cdc9e594 Renamed class 2018-10-02 20:14:28 +00:00
518d461a8f Issue 5811: "objects" instead of "object" 2018-10-02 20:12:38 +00:00
505350c9fb
Merge pull request #5794 from annando/ap1
ActivityPub support
2018-10-02 11:24:04 -04:00
3020b0fdc4 Fix missing mentions 2018-10-02 14:48:57 +00:00
fcfd04bcc9 Normalize the mentions and ensure to not have duplicates 2018-10-02 09:04:32 +00:00
d4f6261b81 Avoid notice 2018-10-02 08:31:58 +00:00
6020605d5c Account deletion could work now. 2018-10-01 19:22:13 +00:00
Michael Vogel
103535d620
Merge pull request #5773 from MrPetovan/task/rewrite-js-hooks
Rewrite JS hooks
2018-10-01 17:10:30 +00:00
72c3a62e7f Profile update is now done via APDelivery 2018-10-01 05:44:56 +00:00
9f481c1f5e + is * 2018-09-30 20:48:29 +00:00
fdc396e197 "rawcontent" is now a baseobject method 2018-09-30 20:47:28 +00:00
5456ef0185 Profile update and some more is now added 2018-09-30 20:26:30 +00:00
761bdafa34 Correct content type 2018-09-30 14:13:07 +00:00
a8b776c189 There is now "rawContent" for technical endpoints 2018-09-30 13:15:10 +00:00
cb44aa83c7 Object instead of Display 2018-09-30 12:21:57 +00:00
e71f497295 Renamed 2018-09-30 08:14:05 +00:00
2fc79e3886 Superfluous, since we only fetch this data 2018-09-30 07:48:13 +00:00
82987d018a Some changes for better code quality 2018-09-30 07:21:57 +00:00
b043c7e0f2 Changed constant name to keep compatible with PHP 5 2018-09-28 15:25:20 +00:00
da79566125 Relocated function 2018-09-28 03:56:41 +00:00
30f67d6e14 removed unneded line 2018-09-27 21:14:01 +00:00
793387e2b5 Only communicate with contacts that aren't pending 2018-09-27 15:26:20 +00:00
c4994626e9 Corrected function names 2018-09-27 13:31:32 +00:00
de8787dd5b Changed comment 2018-09-27 12:01:16 +00:00
e01d5e4b31 Function naming ... 2018-09-27 11:56:05 +00:00
cb9be8a7ab UUID is now createUUID 2018-09-27 11:52:15 +00:00
5639054699 Diaspora in AP - and changed function name 2018-09-27 11:39:17 +00:00
fa868fbaf2 Some more documentation 2018-09-27 03:28:56 +00:00
897929ad40 Avoid warnings, added documentation 2018-09-26 22:45:13 +00:00
9c62727e1d Added doxygen data 2018-09-26 22:02:14 +00:00
f7d7d94111 Added some doxygen headers 2018-09-26 21:38:37 +00:00
dd38b7e329 Avoid warnings 2018-09-26 20:36:47 +00:00
60b0759b50 UUID instead of GUID 2018-09-26 20:03:46 +00:00
9ec30010c5 APContact stuff is moved to an own class 2018-09-26 17:24:29 +00:00
f3814ae1fc Changed conversation url (used for AP) 2018-09-26 13:12:27 +00:00
4699741f00 Fix delivery only for comments to native networks 2018-09-26 13:00:48 +00:00
67d2f8594c Some more clean up 2018-09-26 07:42:40 +00:00
Hypolite Petovan
c80045edaf Remove obsolete lines from Console\Config 2018-09-25 23:00:00 -04:00
Hypolite Petovan
be0f71bedb Add new Cache console command 2018-09-25 22:59:22 -04:00
Hypolite Petovan
d420a4dec2 Add informative public static members to Core\Cache 2018-09-25 22:58:04 -04:00
Hypolite Petovan
71c08a044f Add ICacheDriver->getAllKeys method 2018-09-25 22:52:32 -04:00
Hypolite Petovan
640f76b05a Improve doc blocks in cache drivers 2018-09-25 22:51:41 -04:00
Hypolite Petovan
d1148f61ea Add missing "outdated" parameter to ICacheDriver->clear in Core\Cache 2018-09-25 22:46:45 -04:00
e91a1dfa8e Cleaned code 2018-09-25 21:18:37 +00:00
834422d52f Merge remote-tracking branch 'upstream/develop' into ap1 2018-09-24 21:48:40 +00:00
5e3f71680c Disabled logging 2018-09-24 21:47:10 +00:00
59c137b946 Variable fix 2018-09-24 05:35:47 +00:00
a6996601d5
Merge pull request #5789 from friendica/master
Update develop from master-2019.09
2018-09-23 18:55:20 -04:00
b386add315 Switch contacts from OStatus to ActivityPub 2018-09-23 22:12:12 +00:00
094c27add6 Update person, undo activity and improved security checks 2018-09-23 19:25:20 +00:00
8c7e5bb776 all endpoints are now working 2018-09-23 17:29:31 +00:00
feeec908d3 We can delete notes / changed credits 2018-09-23 09:20:25 +00:00
6df6d82427 We can now like and dislike 2018-09-23 08:52:07 +00:00
a56565fa99 AP is enabled for all users 2018-09-22 23:49:27 +00:00
ca574e1027 We can now like and dislike 2018-09-22 23:17:01 +00:00
Hypolite Petovan
adbc1d3224 Missing $a to $this conversion in App 2018-09-22 12:45:49 -04:00
c083ae047c Merge remote-tracking branch 'upstream/2018.08-rc' into ap1 2018-09-22 15:18:53 +00:00
214407bdc8 Improve communication 2018-09-22 14:12:54 +00:00
684dfd5bbd
Merge pull request #5780 from annando/fix-relocation
Hopefully fixes relocations that hadn't been executed
2018-09-22 10:56:11 +02:00
b3e3147697 Issue 5768: This logging should help finding the origin of the problem 2018-09-22 07:09:27 +00:00
0dbb6313a5 Hopefully fixes relocations that hadn't been executed 2018-09-22 06:47:35 +00:00
b906b083bc The target inbox is now generated after the permission bloxk 2018-09-22 05:58:56 +00:00
71cbe56293 Use the follower collection 2018-09-22 04:49:16 +00:00
b7744ae3eb Inherit the receivers from the previous post 2018-09-22 04:39:04 +00:00
b44fc62708 Improvements to signature check, private posts do work now again 2018-09-21 22:31:33 +00:00
Benjamin Lorteau
489d5f41d2 Add Doxygen headers for multiple function in App 2018-09-21 09:54:40 -04:00
Benjamin Lorteau
f0cdd25e34 Register Friendica stylesheet using App->registerStylesheet()
- Remove mentions of {{$stylesheet}} in head.tpl templates
2018-09-21 09:54:09 -04:00
4c224fbddd Deliver everything to all receivers in the thread 2018-09-21 12:06:36 +00:00
59cd6611ec Direkt delivery is done 2018-09-21 05:41:18 +00:00
5310d54c13 Fetch the receiver from the parent posting as well 2018-09-21 04:51:54 +00:00
355346298b LD signatures will now be checked when receiving messages 2018-09-21 03:39:32 +00:00
Hypolite Petovan
2ae6556b32 Add new 'head' hook
- Add new App->registerStylesheet method
- Reworked App->init_pagehead into App->initHead
2018-09-20 21:30:51 -04:00
Hypolite Petovan
1eaa523e61 Remove unused App->page['end']
- Remove unused empty templates
2018-09-20 21:02:28 -04:00
Hypolite Petovan
55f1d7b90e Add new footer hook
- Add new App->footerScripts array
- Add footer.tpl template
- Add documentation
- Rework App->init_page_end to App->initFooter
2018-09-20 21:01:05 -04:00
752b5fe284 Outgoing posts are now signed 2018-09-20 21:45:23 +00:00
11310f4cf0 Relocated AP signature functions, reduced magic auth functions 2018-09-20 18:16:14 +00:00
0866fbaf8c Code cleaning / wrong table for flags 2018-09-20 09:50:03 +00:00
0d51474e73 Relocated function 2018-09-20 05:37:01 +00:00
34cb0aa406 JSON-LD stuff is now in a separate file 2018-09-20 05:30:07 +00:00
f20bed67a9 Table "apcontact" is now in use / added functionality to handle JSON-LD 2018-09-20 05:00:49 +00:00
Jonny Tischbein
807ad14521 calculate form return_url for post and message instead of using SESSION var 2018-09-19 23:55:29 +02:00
5de4afecf1 Table for AP contacts, JSON-LD parser included 2018-09-18 22:09:27 +00:00
cb073bea61 Private posts with Mastodon don't work - but this is expected 2018-09-18 19:36:27 +00:00
Michael Vogel
bd0515714c
Merge pull request #5765 from MrPetovan/bug/php7-remove-pear-text_highlighter
[php7] Remove PHP code highlighting
2018-09-18 18:34:46 +00:00
Michael Vogel
1fa37586ca
Merge pull request #5764 from MrPetovan/task/update-mrpetovan-email-address
Update "mrpetovan" email address
2018-09-18 14:26:58 +00:00
464650d4d7 Public posts to Pleroma do work now, limited posts to Hubzilla and Mastodon as well 2018-09-18 07:28:35 +00:00
Hypolite Petovan
382a7f5acd Create new HTML::toMarkdown wrapper 2018-09-17 23:17:41 -04:00
f772ece86f New delivery module for ap 2018-09-17 21:13:08 +00:00
Michael Vogel
e68c48e88f
Merge pull request #5763 from MrPetovan/task/improve-getsiteinfo
Use OEmbed data when available no matter the type
2018-09-17 06:40:04 +00:00
91d1b4de5d We now use the conversation data with AP 2018-09-17 05:51:05 +00:00
699a4140f9 Now sending does finally work - and some AP standards are improved as well 2018-09-16 20:12:48 +00:00
e4d28629e4 First posting tests 2018-09-16 17:47:00 +00:00
Hypolite Petovan
102adf86ae Restore partial condition in OEmbed block of ParseUrl::getSiteInfo 2018-09-16 09:18:31 -04:00
Hypolite Petovan
96ed7525b7 Improve whitespace display from/to BBCode/HTML 2018-09-16 09:05:54 -04:00
Hypolite Petovan
ba4f368b45 Remove references to pear/Text_Highlighter 2018-09-16 09:05:00 -04:00
Hypolite Petovan
d6adcb9734 Remove text highlighting from BBCode::convert
- Move code blocks escaping from BBCode::toMarkdown to BBCode::convert
- Use "language-" class prefix for expected syntax highlighting
2018-09-16 09:04:25 -04:00
629cca1963 Added function to fetch missing data, code bugfixing 2018-09-16 13:04:00 +00:00
6f3b2b6586 Handling of unlisted posts, better uid detection 2018-09-16 09:06:09 +00:00
1f98414bdd Some code cleanup 2018-09-16 05:49:13 +00:00
Hypolite Petovan
9d0a6f90b6 Update "mrpetovan" email address
- Fix Tobias' email address
- Fix copypasted doc block in Console/PostUpdate
2018-09-15 19:28:38 -04:00
a7f5c1f4c6 Likes work now 2018-09-15 23:06:03 +00:00
2eabe45a8e Contact reject does work now as well 2018-09-15 22:25:58 +00:00
e45206ae5d Merge remote-tracking branch 'upstream/2018.08-rc' into ap1 2018-09-15 20:49:46 +00:00
f5104f3e46 Removed harcoded host names 2018-09-15 20:48:24 +00:00
86bd283705 The whole contact handling does work now, yeah ... 2018-09-15 20:31:05 +00:00
6a8ebc8639 Contact follow and unfollow workd partially 2018-09-15 18:54:45 +00:00
96f575fe28 Processing of personal inbox enabled 2018-09-15 10:14:56 +00:00
35854a0ad1 Adding "(AP)" to the server name when posted via AP 2018-09-15 10:13:41 +00:00
957c70d1c6 Several improvements 2018-09-15 07:40:19 +00:00
fb5b6e4a14 New uri format for our posts that is AP compatible 2018-09-15 07:37:34 +00:00
2e7ca76e15 More fields to import / like could possibly work 2018-09-14 21:10:49 +00:00
61e2c7d20d Added AP to many network conditions / enabling inbox processing 2018-09-14 16:51:32 +00:00
Hypolite Petovan
5b5e5ef4db Use OEmbed data when available no matter the type 2018-09-13 21:50:52 -04:00
7b45bdea17 Preparation for adding more networks there 2018-09-13 22:12:33 +00:00
c2f6b166c7 We now use the regular probing function 2018-09-13 21:57:41 +00:00
8c00e88f79 The endless saga of the fight against notices continues 2018-09-13 21:11:52 +00:00
Hypolite Petovan
70c94abd8e
Merge pull request #5759 from annando/issue-5733
Issue 5733: Removing contacts does work now on the same machine as well
2018-09-12 19:40:03 -04:00
f7b03bc5f3 Missing $ 2018-09-12 21:33:44 +00:00
67fa0ed433 Signature check added 2018-09-12 21:30:10 +00:00
969311cb44 Replacing the non standard "title" with "name" 2018-09-12 18:48:18 +00:00
7daa46503d Don't risk incompatibilities 2018-09-12 06:13:04 +00:00
96d10c25e3 Issue 5733: Removing contacts does work now on the same machine as well 2018-09-12 06:05:14 +00:00
8c07baf54b Better http answers 2018-09-12 06:01:28 +00:00
f566db52d3 And more notices ... 2018-09-11 08:04:14 +00:00
8b96a53fba Burn notices, burn 2018-09-11 04:10:11 +00:00
0a5476591d Activitity pub - first commit with much test code 2018-09-10 21:07:25 +00:00
Hypolite Petovan
791a77f441 Add overwrite parameter to App->loadConfigFile 2018-09-08 02:37:53 -04:00
99244d33f5 Fix for #5732 - too much links had been detected as photos 2018-09-07 06:10:33 +00:00
Hypolite Petovan
480d792356
Merge pull request #5732 from annando/fix-picture-posts
Fix: Posts with pictures will now look good again on connector networks
2018-09-06 19:00:44 -04:00
2592c3891c forgotten $ 2018-09-06 21:10:48 +00:00
1d4a5402ff Picture posts do work again - everything else should work as well 2018-09-06 20:30:16 +00:00
Hypolite Petovan
e735a14db9
Merge pull request #5736 from annando/issue-5733
Issue 5733: Changing relationship values does work now again with DFRN
2018-09-06 13:19:24 -04:00
Hypolite Petovan
d27cf0cb60
Merge pull request #5740 from annando/fix-fatal
Fix fatal error due to missing "use"
2018-09-06 11:58:07 -04:00
e9a73e4480 Fix fatal error due to missing "use" 2018-09-06 13:27:03 +00:00
6113fdc940 Issue 5733: Changing relationship values does work now again with DFRN 2018-09-06 09:20:45 +00:00
bd2b3b1ef5
LockDriverFixings
- release Locks in case of failures
- adding some cache tests
2018-09-06 08:11:18 +02:00
04fb885857 Fix: Posts with pictures will now look good again on connector networks 2018-09-06 04:24:34 +00:00
rabuzarus
75a2576f78 use magic links in single event view 2018-09-06 01:42:35 +02:00
9ef1d827f3 Restore the behaviour to remove the remote contact upon termination 2018-09-05 05:02:06 +00:00
Hypolite Petovan
59d06b6c78
Merge pull request #5719 from annando/notices-yeah
Good news, everyone - again somce notices removed
2018-09-04 19:09:11 -04:00
821429fdf1 Good news, everyone - again somce notices removed 2018-09-04 17:48:09 +00:00
Hypolite Petovan
9744f0e780 Update ParseUrl::getSiteinfo type recognition
- Added obsolete twitter card type provision
2018-09-02 17:50:27 -04:00
Hypolite Petovan
8bcc3c6860 Fix formatting in Util/ParseUrl
- Remove commented out code
- Replace double quotes with simple quotes
- Remove parentheses for language construct
- Add spaces around operators
- Rename variables
2018-09-02 17:46:28 -04:00
Hypolite Petovan
69e7c7feca Fix photo attachment display
- Remove double image display
- Add domain link display to all attachments
2018-09-02 17:26:05 -04:00
5250552fe2 Removed obsolete post update that sometimes never finishes 2018-09-02 17:48:25 +00:00
deca48e39d
Merge pull request #5711 from annando/and-again
The days are getting shorter, like the list of removed notices ...
2018-09-02 14:48:47 +02:00
703c668a37 More notices ... 2018-09-02 08:01:13 +00:00
fd7e45042a The days are getting shorter, like the list of removed notices ... 2018-09-02 07:47:48 +00:00
4fcae18289 Issue 5262: Comments to a forum post aren't distributed via push 2018-09-01 03:23:12 +00:00
Michael Vogel
196ef0111c
Merge pull request #5704 from MrPetovan/bug/fix-unfollow
Fix unfollow sharing-only contacts (except connector protocols)
2018-08-31 15:40:51 +00:00
380eeaab88 Still there had been notices - must have a good camouflage 2018-08-31 05:08:22 +00:00
Hypolite Petovan
804cfa0320 Reorganize Protocol constants
- Add ActivityPub protocol constant
- Add Protocol::NATIVE_SUPPORT
- Sort/group constant names
2018-08-30 17:47:48 -04:00
a3570d0027 Fix: Missing gserver entries - show correct server platform 2018-08-30 09:52:38 +00:00
070e1e73d6
Merge pull request #5702 from annando/and-a-notice
and now for something completely different: A removed notice
2018-08-30 06:37:39 +02:00
02da827560 and now for something completely different: A removed notice 2018-08-30 04:05:32 +00:00
Hypolite Petovan
f18650f3b8
Merge pull request #5700 from annando/issue-5653
Issue 5653: The mastodonemoji addon hadn't got all needed data.
2018-08-29 20:17:15 -04:00
c72d1bc8fd Issue 5653: The mastodonemoji addon hadn't got all needed data. 2018-08-29 20:46:52 +00:00
9bff31f18f Issue 5691: Post dates of feeds sometimes had been wrong 2018-08-29 19:11:43 +00:00
Michael Vogel
c7f8f190b9 Oh no, even more notices ... (#5697) 2018-08-29 14:28:13 -04:00
67227570d8 "Does" is now "perform" 2018-08-29 13:06:56 +00:00
Michael Vogel
601851f3d0 Removed notice - pokes do now work mostly (#5693) 2018-08-29 09:00:01 -04:00
d489712824 The post update version can now be set. 2018-08-29 11:48:40 +00:00
Michael Vogel
cf6140e86f Ensure that the post update doesn't end prematurely (#5684) 2018-08-28 07:56:25 -04:00
Jeroen De Meerleer
9ddb6abe08 Added widget class to invitationsbox (#5675) 2018-08-27 13:36:44 -04:00
df3b1be3b7
Merge pull request #5679 from annando/neverending-notices
The neverending story of removing notices continues ...
2018-08-27 09:12:38 +02:00
8d911b1465 The neverending story of removing notices continues ... 2018-08-27 05:37:10 +00:00
6c8ed888f5
Merge pull request #5676 from annando/issue-3501
Issue 3501: Mail contacts can be added again
2018-08-27 06:16:42 +02:00
Philipp
2838e4ebaf Automatic Install Tests & Doku (#5674)
* Automatic Installation Testing
- New dev-library "mikey179/vfsStream"
- created "reload" method for App-Reloads
- ConsoleTest now using virtual directory
- Adding Automatic Installation Tests
- Fixing some probable install-failures

* Updating README for Automatic Installation

* Updating README for Automatic Installation

* Bugfix normal installation

* Fixing copying of config files
2018-08-27 00:15:55 -04:00
2079caea14 Issue 3501: Mail contacts can be added again 2018-08-26 19:49:39 +00:00
5e82323456 Avoid useless contact updates 2018-08-26 07:56:33 +00:00
1280bb56df Removed notices in notifications 2018-08-26 05:27:50 +00:00
Michael Vogel
49dad00570 Issue 5260: Ensure that user data is really deleted (#5666)
* Issue 5260: Ensure that user data is really deleted

* Missing files
2018-08-25 17:48:50 -04:00
927e0ee0a2 Isse 4726: Fixes the condition for showing hidden contacts 2018-08-25 16:38:26 +00:00
Michael Vogel
edcd0a3744 Issue 4960: Ignoring and blocking of contacts should work again (#5657)
* Issue 4960: Ignoring and blocking of contacts should work again

* Renamed functions

* This function should be renamed as well.

* We now have a frontend to block and ignore public contacts

* Hide some parts for public contacts

* Removed notices, public contact is now accessible from dirfind as well

* We now show contact conversations and contact posts

* We now use a new conversation mode

* The update functionality is disabled until it will work completely

* Fixing tabs chaos

* Update after posts on the contacts page will now work

* Show connect link
2018-08-25 09:48:00 -04:00
6a549d4cfb
Merge pull request #5659 from annando/notices-oh-no
Oh no ... there are still some notices that want to be removed ...
2018-08-24 14:46:21 +02:00
82d097879b Oh no ... there are still some notices that want to be removed ... 2018-08-24 11:09:58 +00:00
Roland Häder
61693419e8 Cleanups: isResult() more used, readability improved (#5608)
* [diaspora]: Maybe SimpleXMLElement is the right type-hint?

* Changes proposed + pre-renaming:
- pre-renamed $db -> $connection
- added TODOs for not allowing bad method invocations (there is a
  BadMethodCallException in SPL)

* If no record is found, below $r[0] will fail with a E_NOTICE and the code
doesn't behave as expected.

* Ops, one more left ...

* Continued:
- added documentation for Contact::updateSslPolicy() method
- added type-hint for $contact of same method
- empty lines added + TODO where the bug origins that $item has no element 'body'

* Added empty lines for better readability

* Cleaned up:
- no more x() (deprecated) usage but empty() instead
- fixed mixing of space/tab indending
- merged else/if block goether in elseif() (lesser nested code blocks)

* Re-fixed DBM -> DBA switch

* Fixes/rewrites:
- use empty()/isset() instead of deprecated x()
- merged 2 nested if() blocks into one
- avoided nested if() block inside else block by rewriting it to elseif()
- $contact_id is an integer, let's test on > 0 here
- added a lot spaces and some empty lines for better readability

* Rewrite:
- moved all CONTACT_* constants from boot.php to Contact class

* CR request:
- renamed Contact::CONTACT_IS_* -> Contact::* ;-)

* Rewrites:
- moved PAGE_* to Friendica\Model\Profile class
- fixed mixure with "Contact::* rewrite"

* Ops, one still there (return is no function)

* Rewrite to Proxy class:
- introduced new Friendica\Network\Proxy class for in exchange of proxy_*()
  functions
- moved also all PROXY_* constants there as Proxy::*
- removed now no longer needed mod/proxy.php loading as composer's auto-load
  will do this for us
- renamed those proxy_*() functions to better names:
  + proxy_init()           -> Proxy::init()         (public)
  + proxy_url()            -> Proxy::proxifyUrl()   (public)
  + proxy_parse_html()     -> Proxy::proxifyHtml()  (public)
  + proxy_is_local_image() -> Proxy::isLocalImage() (private)
  + proxy_parse_query()    -> Proxy::parseQuery()   (private)
  + proxy_img_cb()         -> Proxy::replaceUrl()   (private)

* CR request:
- moved all PAGE_* constants to Friendica\Model\Contact class
- fixed all references of both classes

* Ops, need to set $a here ...

* CR request:
- moved Proxy class to Friendica\Module
- extended BaseModule

* Ops, no need for own instance of $a when self::getApp() is around.

* Proxy-rewrite:
- proxy_url() and proxy_parse_html() are both non-module functions (now
  methods)
- so they must be splitted into a seperate class
- also the SIZE_* and DEFAULT_TIME constants are both not relevant to module

* No instances from utility classes

* Fixed error:
- proxify*() is now located in `Friendica\Util\ProxyUtils`

* Moved back to original place, ops? How did they move here? Well, it was not
intended by me.

* Removed duplicate (left-over from split) constants and static array. Thank to
MrPetovan finding it.

* Renamed ProxyUtils -> Proxy and aliased it back to ProxyUtils.

* Rewrite:
- stopped using deprecated NETWORK_* constants, now Protocol::* should be used
- still left them intact for slow/lazy developers ...

* Ops, was added accidentally ...

* Ops, why these wrong moves?

* Ops, one to much (thanks to MrPetovan)

* Ops, wrong moving ...

* moved back to original place ...

* spaces added

* empty lines add for better readability.

* convertered spaces -> tab for code indenting.

* CR request: Add space between if and brace.

* CR requests fixed + move reverted
- ops, src/Module/*.php has been moved to src/Network/ accidentally
- reverted some parts in src/Database/DBA.php as pointed out by Annando
- removed internal TODO items
- added some spaces for better readability
2018-08-24 01:05:49 -04:00
Michael Vogel
dc3d2d5988 "dba" is now "DBA". This hadn't been respected at some places (#5655)
* "dba" is now "DBA". This hadn't been respected at some places

* Cleaning up unneeded stuff
2018-08-23 09:51:58 -04:00
Michael Vogel
20127a77b3 Removing a small notice in the network.php (#5652) 2018-08-22 18:46:44 -04:00
Michael Vogel
54aee2aaa7 Removed notices that revealed themselfes over night ... (#5645)
* Removed notices that revealed themselfes over night ...

* And more notices removed that occured over night

* One more ..

* Some more notices of the day ...
2018-08-21 17:35:09 +02:00
334c628511 And again ... notices 2018-08-20 21:20:21 +00:00
Philipp
d7395299fb Automatic Installation fix (#5565)
* Automatic Install Config Fix

* new unittest for AutomaticInstallation

* unittest for autoinstall
- removed password check

* removed bak-file

* automatic install
- always save environment variables
- just skip db environment if not `--savedb` is set

* fixed help (options)

* fixed help (options)

* Deleting Auto-Install tests until fix for proper DB restoring
2018-08-20 16:15:39 -04:00
Michael Vogel
16a081871c Improved profile page, improved "limit" handling (#5639)
* Improved profile page, improved "limit" handling

* Update will now work again

* Update will work now
2018-08-20 06:26:05 +02:00
Michael Vogel
c1da44b7dc We now use a central function to fetch the importer (#5636) 2018-08-19 13:37:56 +00:00
Michael Vogel
7f3fb34c24 Some easy to replace "q" calls have been replaced by "DBA" calls (#5632)
* Some easy to replace "q" calls have been replaced by "DBA" calls

* Simplified the GUID creation

* And one in the API ...

* And OStatus has got some DBA calls more

* Just some more replaced database calls

* The event query is now simplified

* Events are now shown again

* subthread is now using the DBA calls as well

* Some more replaced database calls

* And some more replaced database calls and prevented notices

* Better use gravity

* Some more replaced database stuff

* Some more replaced database calls in DFRN.php

* The gcontact class now has got the new DBA functions as well

* The Contact class is now changed to new database functions as well

* Small correction

* We can now delete without cascade

* One more functionality is safe for future changes
2018-08-19 12:46:10 +00:00
Michael Vogel
ab5cedfa50 placeholder for a funny commit description for removing some more notices (#5631) 2018-08-19 01:52:21 +00:00
Michael Vogel
060e887a31 And still there are notices that have to be removed ... (#5629)
* And still there are notices that have to be removed ...

* Notice removed in ACL part

* Fix missing fields for notifications

* Fixes issue 5630
2018-08-18 08:20:50 +02:00
d5c2c41b02
Merge pull request #5626 from annando/notices-oh-yeah
Removed notices, will it ever end?
2018-08-17 09:33:02 +02:00
Michael Vogel
b6cb83ed4c
Merge pull request #5617 from MrPetovan/task/use-contact-network
Fix bug with ACL and contact network page
2018-08-17 05:31:06 +02:00
0342f9e084 Removed notices, will it ever end? 2018-08-17 03:19:42 +00:00
bb0cf93374 Fix for storing posts of private forums 2018-08-15 20:13:10 +00:00
3488b937ea
Merge pull request #5620 from annando/fix-remove
Fix a fatal error when removing contacts
2018-08-15 14:31:13 +02:00
Hypolite Petovan
84a3cd747f Revert "Change contact post link to contact network page"
This reverts commit 4c32661022.
2018-08-15 12:12:49 +02:00
6d852ff6fd Fix a fatal error when removing contacts 2018-08-15 09:27:25 +00:00
e8334c4655 Use the Item class instead of DBA calls when possible 2018-08-15 04:41:49 +00:00
Hypolite Petovan
4c32661022 Change contact post link to contact network page 2018-08-15 00:43:45 +02:00
Hypolite Petovan
ea17370211 Fix bug with ACL and contact network page
- Require user array parameter in ACL::getFullSelectorHTML
- Change all wrong uses where user array was replaced by default
permissions array
2018-08-15 00:43:27 +02:00
Michael Vogel
1283b99c6f Removed notices in the frio theme (#5610)
* Removed notices in the frio theme

* And fixed notices in the notifications

* And some more in frio

* Null is the default value

* And some small notice in the probing removed

* Added note

* Clarified note

* And a removed notice in OStatus
2018-08-14 19:37:44 +00:00
1ca8d573e6
Merge pull request #5607 from annando/remove-contact
Remove contacts in the background
2018-08-13 06:42:08 +02:00
29aa90ec09 Remove contacts in the background 2018-08-12 17:15:47 +00:00
b3931d066c Issue-5605: Fixes notice 2018-08-12 08:00:37 +00:00
Michael Vogel
880b7177c8 And again, and again, and again, ... some more notices removed (#5601)
* And again, and again, and again, ... some more notices removed

* And some more notices ...

* Some more place
2018-08-11 23:05:42 +02:00
Roland Häder
e06fc2aa69 Stopped using deprecated constants NETWORK_* (#5537)
* Rewrite:
- stopped using deprecated NETWORK_* constants, now Protocol::* should be used
- still left them intact for slow/lazy developers ...

* Removed deprecated NETWORK_* constants as per code reviewer's request.
2018-08-11 22:40:44 +02:00
bf5896d4e3
Merge pull request #5598 from annando/issue-3838
Added a note concerning the question how to fix issue 3838
2018-08-11 07:48:33 +02:00
08fc86802a
Merge pull request #5599 from annando/postupdate
Console script to ensure that all post updates are finished
2018-08-11 07:47:28 +02:00
5037f9c460 Console script to ensure that all post updates are finished 2018-08-10 21:20:25 +00:00
7d945e8504 Added a note concerning the question how to fix issue 3838 2018-08-10 20:28:41 +00:00
170dd2a705 Some more removed notices 2018-08-10 19:39:43 +00:00
77e3e011e3 Hide deprecated networks 2018-08-10 04:59:26 +00:00
f82580c2ef Avoid probing for contacts if we don't want to update 2018-08-09 06:19:23 +00:00
Michael Vogel
276abfaba6 Issue 5158: Ignore all threads, even public ones (#5588)
* Issue 5158: Ignore all threads, even public ones

* Remove some notice

* Now it really should work

* Using "defaults"
2018-08-08 22:32:11 +02:00
0c56538cd5 Notice in tt fixed that happens with chinese translations 2018-08-08 12:17:49 +00:00
Michael Vogel
9eb2c2ec16 Fix for duplicated addon entries in the hook table (#5583) 2018-08-07 23:03:38 +02:00
Michael Vogel
eaf81e5e66
Merge pull request #5563 from MrPetovan/bug/5470-fix-various-notices
Fix various notices
2018-08-07 21:34:47 +02:00
Michael Vogel
8c2efa6df4 Facebook and App.net is removed from nearly all places (#5581)
* Facebook is removed from nearly all places

* Remove app.net as well - it's dead for some time now
2018-08-07 17:06:51 +02:00
4921303133 Issue 5541: Don't do magic things when the remote site doesn't support it 2018-08-06 19:59:41 +00:00
3f612e0641 Issue 5436: Don't store tags that are too long 2018-08-06 17:11:40 +00:00
Michael Vogel
c032011143 Post update script for setting the uri-id (#5573)
* Post update is working now

* Changed text.
2018-08-06 18:40:41 +02:00
Michael Vogel
5e61caa34f Fix for not loading the translation / some more notice removed (#5569) 2018-08-06 12:11:17 +02:00
Hypolite Petovan
c0e728e7e5 Fix query string parsing border case in Util\Proxy 2018-08-05 15:57:04 +02:00
Hypolite Petovan
6a57574091 Fix missing $profile['nickname'] in Model\Profile 2018-08-05 15:56:41 +02:00
Hypolite Petovan
45de8a28cd Fix missing $_SESSION variable in src/App 2018-08-05 15:56:21 +02:00
Michael Vogel
ef1c73fb6b
Merge pull request #5561 from MrPetovan/bug/4584-fix-twitter-gif-still-image
Restore source storing for Twitter conversations
2018-08-05 14:00:19 +02:00
Hypolite Petovan
ea45a78218 Increase Twitter parcel constant value 2018-08-05 13:59:33 +02:00
Michael Vogel
fa46e97f27 We now store the uri data in a separate table (#5560)
* We now have a item-uri table

* Fixing line endings

* New item uri table

* Rescued ItemURI.php file

* Reverting some git problem

* Corrected the dbstructure file

* Updated database.sql / we now store content in the new id fields
2018-08-05 13:09:59 +02:00
Hypolite Petovan
c4e69b7766 Add conversation storage for Twitter 2018-08-05 12:34:33 +02:00
Hypolite Petovan
6678208915 Add new Conversation::PARCEL_TWITTER constant 2018-08-05 12:25:47 +02:00
Hypolite Petovan
c13dc549ed Rename PROTOCOL_* constants to Model\Conversation::PARCEL_*
- Remove unused Conversation::PROTOCOL_GS_CONVERSATION constant
- Remove now renamed PROTOCOL_* constant declarations
2018-08-05 12:24:42 +02:00
Michael Vogel
8dea36bd8f We shouldn't cascade this deletion as well (#5558) 2018-08-05 11:02:36 +02:00
Michael Vogel
2f2b134e58 Fixes issue 5321: Likes can be undone and comments can be deleted again (#5557) 2018-08-05 06:35:11 +02:00
Hypolite Petovan
c9b756674a Add CW support to shared posts in Protocol\OStatus 2018-08-04 21:40:45 +02:00
Hypolite Petovan
36975d521f Remove plural from $activityobjects variable name in Protocol\OStatus 2018-08-04 21:39:54 +02:00
Michael Vogel
810c108297 Fix: Notes can be posted again. Never use "defaults" with "false" (#5551) 2018-08-04 16:06:36 +02:00
Hypolite Petovan
6a6695b167 Change DBStructure::definition to use config/dbstructure.json 2018-08-04 13:24:04 +02:00
Michael Vogel
2c8c803d64 Avid notices and warnings (#5546) 2018-08-02 19:07:20 +02:00
Michael Vogel
65d752d03c Notices what else? (#5545)
* Poco isn't filled, so we cannot store it

* We should initialize our variables
2018-08-02 16:11:21 +02:00
Michael Vogel
c72c64a6d8 Notices again (#5543)
* And again notices

* Notices in the directory

* Much more places

* Fix some double $

* Notice in ping

* Missing field

* Fix: We now remove deleted users from the directory

* Some more stuff

* Notices when removing users

* Added logging

* More logging

* Two more
2018-08-02 07:21:01 +02:00
Hypolite Petovan
4d17fb36d1 Fix missing fields in event reminder (#5540) 2018-08-01 09:27:13 +02:00
Michael Vogel
1afc0ab028 Added logging and one more reason for a notice found (#5538)
* Added logging and one more reason for a notice found

* And one more
2018-08-01 08:47:18 +02:00
Michael Vogel
9d0f18c0b3 Yeah, and again notices ... (#5536)
* Yeah, and again notices ...

* And some more

* Block access without given user name

* Reformatting
2018-08-01 07:29:58 +02:00
Michael Vogel
71b1638d9a Once again, notices ... (#5535) 2018-07-31 18:39:23 +02:00
Michael Vogel
b552b711ee And some more notices removed ... (#5533)
* Fix for vanishing notes

* The field needs to be part of the selected fields ...

* And some more notes ...
2018-07-31 07:54:25 +02:00
Michael Vogel
c39e0dcf2a Fix for vanishing notes (#5531)
* Fix for vanishing notes

* The field needs to be part of the selected fields ...
2018-07-30 22:23:48 -04:00
Roland Häder
4d39164c1e [WIP] Rewrite to Proxy class: (#5507)
* Rewrite to Proxy class:
- introduced new Friendica\Network\Proxy class for in exchange of proxy_*()
  functions
- moved also all PROXY_* constants there as Proxy::*
- removed now no longer needed mod/proxy.php loading as composer's auto-load
  will do this for us
- renamed those proxy_*() functions to better names:
  + proxy_init()           -> Proxy::init()         (public)
  + proxy_url()            -> Proxy::proxifyUrl()   (public)
  + proxy_parse_html()     -> Proxy::proxifyHtml()  (public)
  + proxy_is_local_image() -> Proxy::isLocalImage() (private)
  + proxy_parse_query()    -> Proxy::parseQuery()   (private)
  + proxy_img_cb()         -> Proxy::replaceUrl()   (private)

* Ops, need to set $a here ...

* CR request:
- moved Proxy class to Friendica\Module
- extended BaseModule

* Ops, no need for own instance of $a when self::getApp() is around.

* Proxy-rewrite:
- proxy_url() and proxy_parse_html() are both non-module functions (now
  methods)
- so they must be splitted into a seperate class
- also the SIZE_* and DEFAULT_TIME constants are both not relevant to module

* No instances from utility classes

* Fixed error:
- proxify*() is now located in `Friendica\Util\ProxyUtils`

* Moved back to original place, ops? How did they move here? Well, it was not
intended by me.

* Removed duplicate (left-over from split) constants and static array. Thank to
MrPetovan finding it.

* Renamed ProxyUtils -> Proxy and aliased it back to ProxyUtils.
2018-07-30 22:06:22 -04:00
Roland Häder
bf87ad4fcf Fixed E_NOTICE in listing worker queue and new utilities class added (#5521)
* Fixes for E_NOTICE in workqueue:
- introduced class `Friendica\Util\Arrays` which will hold static methods for
  handling arrays that cannot be done with PHP's functions, like implode() on
  multi-dimensional arrays
- rewrote old-school for() loop to foreach()

* Added intial unit test with some tests on empty delimiters and/or sinle and
multi-dim array.

* Added test for for 3-dimensional arrays, thanks to  nupplaphil's feedback.
2018-07-30 21:24:26 -04:00
Michael Vogel
1eb8f04274 Fixing SQL error when receiving DFRN posts (#5527)
* Some more notices

* Fixed nasty to find notice in DFRN and OStatus

* And more notices ...

* Yeah, some removed notices ... again ...

* Fixing bad SQL query
2018-07-30 07:06:32 +02:00
Michael Vogel
a2cea16954 Some more notices (#5526)
* Some more notices

* Fixed nasty to find notice in DFRN and OStatus

* And more notices ...

* Yeah, some removed notices ... again ...
2018-07-30 06:41:20 +02:00
650c3c18e1
Fixed fatal error about when returned 'body' field is empty:
````
PHP Fatal error:  Uncaught TypeError: Argument 1 passed to Friendica\Protocol\PortableContact::discoverServer() must be of the type array, null given, called in /var/www/../src/Protocol/PortableContact.php on line 1664 and defined in /var/www/../src/Protocol/PortableContact.php:1765
Stack trace:
````
2018-07-29 17:34:20 +02:00
02d4b1098e
Merge pull request #5519 from annando/test-2
Moved expiring of item content
2018-07-29 11:45:50 +02:00
6add589c3f Removed some test logging 2018-07-29 04:38:14 +00:00
bc38420801 Some more notices removed 2018-07-29 04:04:23 +00:00
dc9b10fb09 Moved expiring of item content 2018-07-29 03:54:34 +00:00
Michael Vogel
489d3daa94 Trying to clean up a little bit more (#5517)
* "post-type" replaces "bookmark" and "type"

* The permission set is now removed upon expiry

* Post update now stores the permission set

* We don't store the permissions in the item table anymore

* Postupdate now handles "postopts" as well

* "post-type" replaces "bookmark" and "type"

* "post-type" replaces "bookmark" and "type"

* "post-type" replaces "bookmark" and "type"

* The permission set is now removed upon expiry

* The permission set is now removed upon expiry

* We don't store the permissions in the item table anymore

* Postupdate now handles "postopts" as well

* Multiplicated update functions

* And some more duplicated functions ...

* Removed duplicate functions
2018-07-28 16:04:56 -04:00
Michael Vogel
91db91d315 Fix for post update (#5513)
* "post-type" replaces "bookmark" and "type"

* Removed some more type

* Added index to permission set

* The permission set is now stored

* The permission set is now removed upon expiry

* Post update now stores the permission set

* New file

* Permissions are now sorted

* The permission set is now used for item permissions

* Check for allow_cid, ... is superfluous. Checking for "private" is enough

* We query the permissionset

* Permissions are displayed correctly

* Changed index

* We don't store the permissions in the item table anymore

* Permission fields are now deprecated

* Reversed ...

* Postupdate now handles "postopts" as well

* Set deprecated fields to "null" if empty

* Postupdates are enabled again

* Fix for post update
2018-07-28 13:12:35 -04:00
Michael Vogel
36d4516e7a Missing stuff in "develop"? (#5516)
* "post-type" replaces "bookmark" and "type"

* Removed some more type

* Added index to permission set

* The permission set is now stored

* The permission set is now removed upon expiry

* Post update now stores the permission set

* New file

* Permissions are now sorted

* The permission set is now used for item permissions

* Check for allow_cid, ... is superfluous. Checking for "private" is enough

* We query the permissionset

* Permissions are displayed correctly

* Changed index

* We don't store the permissions in the item table anymore

* Permission fields are now deprecated

* Reversed ...

* Postupdate now handles "postopts" as well

* Set deprecated fields to "null" if empty

* Postupdates are enabled again

* "post-type" replaces "bookmark" and "type"

* The permission set is now stored

* The permission set is now removed upon expiry

* Postupdate now handles "postopts" as well
2018-07-28 13:11:46 -04:00
Hypolite Petovan
0902ea508d
Fix parse error in Protocol\PortableContact (#5515) 2018-07-28 08:52:57 -04:00
Roland Häder
c30ac30f29 Possible fix for #5470 - json_decode() (#5511)
* Possible fix for #5470:
- $data is not an object like stdClass but an array
- newer PHP versions doesn't allow cross-access like following:

  $object['foo'] = 123;
  $array->foo = 123;

- added type-hints for private methods for above cases
- used `if (empty($foo)) instead of just `if ($foo)` preventing some nasty
  E_NOTICE
- added some empty lines for better readability

* Rewrite:
- mixture of object/array was here, causing under newer PHP versions some E_NOTICE
- this has been now finally fixed by converting any `object` type to an
  associative `array`
- also changed `is_object()` to `is_array()`
2018-07-28 01:35:27 -04:00
Roland Häder
4a22710b3b Moved global PAGE_* to Profile class (#5500)
* Rewrites:
- moved PAGE_* to Friendica\Model\Profile class

* Fixed more rewrites from plain (global namespace) PAGE_* to Friendica\Models\Profile class

* CR request:
- moved all PAGE_* constants to Friendica\Model\Contact class
- fixed all references of both classes

* CR request:
- moved ACCOUNT_TYPE_* constants from boot.php to Contact::ACCOUNT_TYPE_*

* Just copy-pasted this code from boot.php, needs to be changed to `const ACCOUNT_TYPE_FOO = x;`

* Ops, melting brain cells here ... :-/
2018-07-27 19:25:57 -04:00
Michael Vogel
5f77e98d76 Postupdate is now working again (#5512)
* "post-type" replaces "bookmark" and "type"

* Removed some more type

* Added index to permission set

* The permission set is now stored

* The permission set is now removed upon expiry

* Post update now stores the permission set

* New file

* Permissions are now sorted

* The permission set is now used for item permissions

* Check for allow_cid, ... is superfluous. Checking for "private" is enough

* We query the permissionset

* Permissions are displayed correctly

* Changed index

* We don't store the permissions in the item table anymore

* Permission fields are now deprecated

* Reversed ...

* Postupdate now handles "postopts" as well

* Set deprecated fields to "null" if empty

* Postupdates are enabled again
2018-07-27 19:24:26 -04:00
Michael Vogel
1e83261a88
Merge pull request #5509 from friendica/revert-5506-fixes/portable-contact
Revert "Possible fix for #5470 and empty() usage"
2018-07-27 08:04:19 +02:00
Michael Vogel
82e3163e5e Revert "Possible fix for #5470: (#5506)"
This reverts commit 1e20fd84f7.
2018-07-27 08:02:41 +02:00
Roland Häder
592190892c Continued: (#5508)
- `App` is now "imported" to avoid having \Friendica\App::* everywhere
2018-07-26 22:27:28 -04:00
Roland Häder
1e20fd84f7 Possible fix for #5470: (#5506)
- $data is not an object like stdClass but an array
- newer PHP versions doesn't allow cross-access like following:

  $object['foo'] = 123;
  $array->foo = 123;

- added type-hints for private methods for above cases
- used `if (empty($foo)) instead of just `if ($foo)` preventing some nasty
  E_NOTICE
- added some empty lines for better readability
2018-07-26 18:27:12 -04:00
Michael Vogel
986106a8f7 Item storage: Permissions aren't stored in the items anymore (#5495)
* The permission set is now used for item permissions

* Check for allow_cid, ... is superfluous. Checking for "private" is enough

* We query the permissionset

* Permissions are displayed correctly

* Changed index

* We don't store the permissions in the item table anymore

* Permission fields are now deprecated

* Reversed ...
2018-07-25 19:14:55 -04:00
Roland Häder
37253656e3 Moved CONTACT_* constants to Friendica\Model\Contact class, lesser in global namespace (#5490)
* Rewrite:
- moved all CONTACT_* constants from boot.php to Contact class

* CR request:
- renamed Contact::CONTACT_IS_* -> Contact::* ;-)
2018-07-24 22:53:46 -04:00
Michael Vogel
69af69d1a0 Fallback to Diaspora if DFRN transmission fails (#5487) 2018-07-24 14:12:09 -04:00
Michael Vogel
5a8654194a
Merge pull request #5452 from MrPetovan/bug/5443-fix-worker-notices
Fix notices in OEmbed et al.
2018-07-24 17:11:53 +02:00
6771522167 Reduce cache time for OEmbed error 2018-07-24 11:05:09 -04:00
Michael Vogel
be8b68aaaf Store guid and plink with event (#5485)
* Store guid and plink with event

* One space too much
2018-07-24 10:01:31 -04:00
Hypolite Petovan
b6e3da8443 Move addLanguageToItemArray call when body is ensured 2018-07-24 08:52:25 -04:00
Hypolite Petovan
df917251ff Fix undefined oembed properties
- Add Object\OEmbed class
2018-07-24 07:56:27 -04:00
Hypolite Petovan
adc47fc8ea Fix Undefined index: nurl in Protocol\PortableContact 2018-07-24 07:55:42 -04:00
Hypolite Petovan
41fd5bef13 Fix by reference notice in Protocol\PortableContact 2018-07-24 07:54:12 -04:00
Hypolite Petovan
4e9ba728c4 Fix undefined index body in Model\Item 2018-07-24 07:54:12 -04:00
Hypolite Petovan
d09ab35816 Fix getimagesizefromstring() read errors 2018-07-24 07:54:12 -04:00
Michael Vogel
ca2c316de0 Some removed notices when viewing events (#5483) 2018-07-24 07:51:50 -04:00
432eec770b Issue 5467: Cron jobs hadn't been executed 2018-07-24 06:15:58 +00:00
de984cdaa1 Issue 5467: Fix worker and daemon 2018-07-24 03:42:44 +00:00
Hypolite Petovan
30fff2077c Ad missing use statements after dbesc conversion 2018-07-23 18:44:05 -04:00
Hypolite Petovan
a6fb3568f9 Rename dbesc to DBA::escape 2018-07-23 15:30:54 -04:00
Hypolite Petovan
d3a598f589 Update DBA::escape to match dbesc() 2018-07-23 15:13:42 -04:00
Hypolite Petovan
538b81d10d Delete Database\DBM class file 2018-07-23 11:04:15 -04:00
Hypolite Petovan
aa26943f92 Rename DBA::esc_array to DBA::escapeArray
- Rename internal method DBA::esc_array_callback to
DBA::escapeArrayCallback
2018-07-23 11:04:15 -04:00
Hypolite Petovan
ecea7425f8 Rename DBA::is_result to DBA::isResult 2018-07-23 11:04:14 -04:00
Hypolite Petovan
0ec44f3e8a Rename DBM method calls to DBA method calls 2018-07-23 11:02:24 -04:00
Hypolite Petovan
8ddb94ef06 Use DateTimeFormat::utc() instead of DBM::date() 2018-07-23 10:57:47 -04:00
Hypolite Petovan
c55e389bbc Add Database\DBM methods to Database\DBA 2018-07-23 10:57:47 -04:00
Hypolite Petovan
38f341e064
Add missing space between PHP path and script in App->proc_run (#5468) 2018-07-23 10:43:39 -04:00
Michael Vogel
2d0a749734
Merge pull request #5431 from MrPetovan/task/5410-rename-database-methods
Move DBA to src/ part 3.1: Rename DBA methods
2018-07-23 15:18:58 +02:00
Hypolite Petovan
b685ef37c9
Fix Fatal errors in Protocol\OStatus (#5466) 2018-07-23 07:48:44 -04:00
Michael Vogel
53876abfda And some more removed notices in the core (#5465) 2018-07-23 07:43:18 -04:00
Philipp
cd52d0b3e9 Using getopt for CLI arguments (#5446)
* Adding Argument class to Friendica

* Adding Argument class to Friendica

* Adding Argument class to Friendica

* fixing arguments for `spawnWorker`

* Adding `use Friendica\BaseObject` to `ApiTest.php`

* Refactoring the argument-usages of Friendica

* Refactoring the argument-usages of Friendica

* removing superfluous []
2018-07-23 07:40:52 -04:00