7eefb9aed8
Changed:
...
- empty() is maybe superflous here, still I would prefer a code style that is
written explicitly and not rely on "magic casting"
2022-06-22 18:57:01 +02:00
15d8341d9a
Converted multiple single-comment (//) to multi-line comment block (/* */)
2022-06-22 18:06:35 +02:00
b996712ef7
Images::getInfoFromURL[Cached]() will both return empty arrays on error and
...
that needs to be reflected here, too.
2022-06-22 17:20:59 +02:00
eb231bc548
Fixed: ?? didn't work here as bool won't be seen as null
2022-06-22 17:09:53 +02:00
Philipp
78bf7f187c
Merge pull request #11669 from MrPetovan/bug/11666-email-subject-double-encode
2022-06-22 16:51:23 +02:00
b96daeeeef
Merge pull request #11670 from Quix0r/fixes/more-type-hints-004
...
Fixes/more type hints 004
2022-06-22 10:49:20 -04:00
d5441da49a
Fixed:
...
- TypeError: "Argument 1 passed to Friendica\Util\XML::escape() must be of the
type string, null given, called in src/Util/XML.php line 171
2022-06-22 16:20:26 +02:00
101cd2dd10
Changes:
...
- added some documentation
- fixed some documentation
- changed more double-quotes to singl
2022-06-22 16:14:14 +02:00
ba45e59313
Changes:
...
- added more type-hints
- added missing documentation
- Email::send() now returns what mail() returns (bool)
2022-06-22 14:36:48 +02:00
ee8d0ad619
Changes:
...
- added more type-hints
- added some documentation
2022-06-22 14:36:47 +02:00
feec96cbc4
Return empty array on error (I hope it works this way).
2022-06-22 14:36:47 +02:00
2dd7d465e8
Changes:
...
- added more type-hints
- updated documentation
- changed double-quotes to single
2022-06-22 14:36:47 +02:00
74ab7648c6
Changes:
...
- addHubLink()'s 2nd parameter is DOMElement
- added more type-hints
- converted double-quotes to single
2022-06-22 14:36:46 +02:00
12add2fb64
$data can turn into bool here
2022-06-22 14:36:46 +02:00
08f55f0358
Ops, forgot to rename these, too.
2022-06-22 14:36:46 +02:00
abd0d9f3fd
Changes
...
- added type-hints
- added some documentation
- added default: block for unknown 'rel' value
- changed return type void to empty array
2022-06-22 14:36:45 +02:00
dfa95ea58d
Changes:
...
- added type-hints
- added documentation
2022-06-22 14:36:45 +02:00
84bfc37bf1
Changes:
...
- added more type-hints
- added missing documentation
2022-06-22 14:36:45 +02:00
fa973d3b0f
Merge pull request #11671 from MrPetovan/bug/fatal-errors
...
Add expected type-hint to BoundariesPager::renderFull
2022-06-22 14:30:39 +02:00
e9f7bb477d
Add expected type-hint to BoundariesPager::renderFull
...
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1162634199
2022-06-22 07:49:45 -04:00
7295138f8d
Remove type-hint inconsistent with expected return value in Database->getVariable
2022-06-22 07:47:15 -04:00
d68f307337
Remove email subject encoding from ItemCCEmail constructor
...
- It was wrongly re-encoded in Emailer::send
2022-06-21 21:12:09 -04:00
a05baaf249
Merge pull request #11668 from Quix0r/renames/logger
...
Renamings in logger class to make them more clear
2022-06-21 20:52:19 -04:00
2f358607c7
Changes:
...
- renamed Logger::getLogger() to getInstance() (@MrPetovan )
2022-06-22 01:50:10 +02:00
dependabot[bot]
6443713af1
Bump guzzlehttp/guzzle from 6.5.5 to 6.5.8
...
Bumps [guzzlehttp/guzzle](https://github.com/guzzle/guzzle ) from 6.5.5 to 6.5.8.
- [Release notes](https://github.com/guzzle/guzzle/releases )
- [Changelog](https://github.com/guzzle/guzzle/blob/6.5.8/CHANGELOG.md )
- [Commits](https://github.com/guzzle/guzzle/compare/6.5.5...6.5.8 )
---
updated-dependencies:
- dependency-name: guzzlehttp/guzzle
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-06-21 20:47:00 +00:00
cdcfb4064b
Changes:
...
- added type-hints
- added missing documentation
- renamed Logger::getWorker() to Logger::getLogger() as there is no worker class
returned but the actual (inner) logger
2022-06-21 21:22:16 +02:00
1c57ea7f75
Merge pull request #11665 from Quix0r/rewrites/dba-array-string-table
...
Rewrites/dba array string table
2022-06-21 15:15:57 -04:00
8092188991
Added important comment from @nupplaphil@github.com
2022-06-21 21:12:59 +02:00
f38ad168f5
Reverted and improved TODO:
...
------
@nupplaphil : There is no easy possibility to add a logger here, that's why there
isn't any yet and instead a placeholder.. This execution point is a critical
state during a testrun, and tbh I'd like to leave here no further logic (yet)
because I spent hours debugging cases, where transactions weren't fully closed
and strange/unpredictable errors occur (sometimes -mainly during debugging other
errors :) ...)
-----
2022-06-21 19:21:25 +02:00
80c8ec17c2
Fixed documentation
2022-06-21 18:43:25 +02:00
0332a57bfd
Rewrote to suggestions from @MrPetovan (I tried to maintain the old way of
...
['scheme' => 'table'] with my version).
2022-06-21 18:13:01 +02:00
3b8d9a7248
Use protected $this->logger instead
2022-06-21 17:54:48 +02:00
9ccb113530
Ops, autorun.sh is there but looks like lesser "multi-project" friendly as
...
MYSQL_* must be defined. I might still use my version as that is
project-specific.
2022-06-21 17:48:10 +02:00
dcedd2e5d9
Ops, WWORD ...
2022-06-21 13:54:03 +02:00
5e57ad4d44
Added simple wrapper script to run PHPUnit tests for you. To use this, you need
...
to set at least 4 variables in your ~/.bashrc (recommended):
export FRIENDICA_MYSQL_HOST="localhost"
export FRIENDICA_MYSQL_DATABASE="friendica_test"
export FRIENDICA_MYSQL_USER="friendica_test"
export FRIENDICA_MYSQL_PASSWWORD="friendica_test"
Then you can put ./bin/dev/run_tests.sh into your .git/hooks/pre-commit file
2022-06-21 13:47:40 +02:00
5fe428d3e4
Fixed:
...
- PHPUnit\Framework\Error\Notice: Undefined index: language in /.../src/Util/EMailer/MailBuilder.php on line 122
2022-06-21 13:47:40 +02:00
a7651fa1d5
Changes:
...
- let's at least log the error message, yes it does flood your logfile
2022-06-21 13:47:40 +02:00
1080a840f5
Changes:
...
- Database->$driver can no longer be NULL, an empty string is fine anyway
2022-06-21 13:47:39 +02:00
945cd1a2c2
Fixed:
...
- since $table can be now schema.table, this needs being taken care off
- maybe this foreach(explode()) is a bit an overkill as only 1 or 2 entries
can be found in it
2022-06-21 13:47:39 +02:00
0d81a08e3c
WIP: Properly some fixes? Also why is DROP VIEW IF EXISTS is being killed?
2022-06-21 13:47:39 +02:00
44a9ec9b17
Rewrite:
...
- avoid having array|string for $table to have a "string" type-hint for $table
- you now have to do it for yourself by giving 'schema.table' as parameter
2022-06-21 13:47:38 +02:00
f62c28008a
Removed comment
2022-06-21 13:47:38 +02:00
cefffde691
Changes:
...
- added type-hints
- added some missing documentation
2022-06-21 13:47:37 +02:00
f1867463a0
Changes:
...
- added more type-hints
2022-06-21 13:47:37 +02:00
77c37ff2db
Fixed:
...
- Uncaught Exception TypeError: "Argument 3 passed to
Friendica\Protocol\DFRN::createActivity() must be of the type string, null
given, called ..."
2022-06-21 13:47:37 +02:00
e6ddb167f6
Merge pull request #11664 from tobiasd/20220621-fr
...
update FR translations THX kalon33
2022-06-21 07:43:12 -04:00
4650ff53d9
Merge pull request #11662 from MrPetovan/bug/11661-splitattachment-null
...
Ensure parameter 4 of Post\Media::splitAttachment is a boolean value
2022-06-21 06:48:52 +02:00
fff6e30782
update FR translations THX kalon33
2022-06-21 06:45:14 +02:00
d2ca812647
Merge pull request #11660 from Quix0r/fixes/more-type-hints-003
...
More type-hints - Batch 003
2022-06-20 21:53:17 -04:00
3e522ed512
Fixed:
...
- prevent NULL from being handled over to XML::escape()
- still I wonder that an object can be? It is a string-only accepting method
2022-06-21 01:42:37 +02:00
