605e7d55b3
Continued:
...
- added more type-hints
- some methods in Diaspora returned void but integer was documented so I
changed it to -1 to have a proper type-hint
2022-06-17 17:18:31 +02:00
0c9aff8a09
Also need to declare $profile or otherwise an invocation of
...
Receiver::getReceiverForActor() will fail.
2022-06-17 17:18:31 +02:00
af8cd5ca86
Worker::getWaitingJobForPID() can also return FALSE on failure ... :-(
2022-06-17 17:18:31 +02:00
227bab43a8
Ops, wrong type-hint here, must be string ($nickname can never be an integer).
2022-06-17 17:18:31 +02:00
f7c1eaa858
Continued:
...
- added type-hints
- removed out-dated documentation
- added some missing documentation
2022-06-17 17:18:31 +02:00
e484b6d6dc
Continued:
...
- added more type-hints
- added some documentation
- Contact::getAccountType() should only process string, not null
2022-06-17 17:18:31 +02:00
45b5f67bca
Fix for non-existing record system.mobile_theme in config table
2022-06-17 17:18:31 +02:00
5c9ce790bf
Fixed:
...
- $object_data['actor'] can be null, but Receiver::getReceivers()'s 2nd
parameter expect it to be string
2022-06-17 17:18:31 +02:00
33768ea1c6
Some fixes:
...
- $gsid's default value cannot sadly be 0, it now must be null to allow some
code work
- added some more type-hints
- documented a bit more
2022-06-17 17:18:31 +02:00
4e53666c70
Added more type-hints
2022-06-17 17:18:31 +02:00
7560dccc08
Added again more type-hints
2022-06-17 17:18:31 +02:00
2766c7d9cf
Continued:
...
- added more type-hints
- added some missing documentation
2022-06-17 17:18:31 +02:00
a587217f47
Fixed "Argument 4 passed to Friendica\Protocol\DFRN::processVerbs() must be of the type bool"
2022-06-17 17:18:31 +02:00
dd54e52575
MrPetovan brought the right one up:
...
> Since this is depending on remote systems, the log can quickly fill with unactionable messages.
2022-06-17 17:18:31 +02:00
c351099c5a
Ops, bad type-hint here
2022-06-17 17:18:31 +02:00
2c5595c358
Another incompatible method declaration fixed + type-hints added
2022-06-17 17:18:31 +02:00
40d7f29a11
Continued:
...
- more type-hints
- fixed incompatible method declarations
2022-06-17 17:18:31 +02:00
1edc6b3c3b
Added more type-hints for "App" classes
2022-06-17 17:18:31 +02:00
42b04f397b
Added more type-hints
2022-06-17 17:18:31 +02:00
aa5f0d5ec1
Added more type-hints and documented a few methods
2022-06-17 17:18:31 +02:00
97e27cb523
Added more type-hints
2022-06-17 17:18:31 +02:00
c2e889cfae
Added more type-hints
2022-06-17 17:18:31 +02:00
a8a21c7fb6
Merge pull request #11652 from Quix0r/fixes/causer-id
...
Misspelled braces causing "undefined index 'causer-id'" message
2022-06-17 10:12:22 -04:00
5106bb2881
Added parenthesis
2022-06-17 09:41:11 +02:00
a903dbd77e
Wrong braces causing 'undefined index causer-id'. See #11632
2022-06-16 23:00:16 +02:00
51b31a846f
Merge pull request #11649 from Quix0r/fixes/return-type-fetch-content
...
Fixes incompatible returned type from HTTPSignature::fetch() method
2022-06-16 13:16:06 -04:00
6035de6883
Continued:
...
- added more type-hints
- also cannot return FALSE when array is set
2022-06-16 19:06:41 +02:00
341d8860d1
Merge pull request #11647 from Quix0r/fixes/type-error-exception
...
Followup PR for bad #11624 PR
2022-06-16 11:53:15 -04:00
51a7b5c584
Made also this one sweeter (null-coalscing)
2022-06-16 17:36:47 +02:00
0e1f734b03
Also make this null-coalscing
2022-06-16 17:35:01 +02:00
e8fee5644b
Ops, syntax errors get unnoticed with a simple editor. :-(
2022-06-16 17:10:02 +02:00
624e4c192c
Changed to null-coalscing style (??) as sugguested by @MrPetovan
2022-06-16 16:59:54 +02:00
962b06bf41
Added check as suggested by @MrPetovan for empty $message.
2022-06-16 16:54:51 +02:00
f2b7326650
This will 2 things:
...
1) The first change prevents "expensive" code in HTML::toBBcode() to be executed
just for an empty string which makes no sense.
2) The above change was maybe flawed as $apcontact['about'] would have never
been created, not even empty which could have side effects
Thanks to @annando to make me rethink this part of code.
2022-06-16 16:54:50 +02:00
7814ba4fc4
Fixes for bad invocations of HTML::toBBCode() (1st parameter is now string)
2022-06-16 16:54:50 +02:00
b200874f17
Ops:
...
- wrong way around (!empty($foo)) is proper
- also needed to be checked on $acitivty['content']
2022-06-16 16:54:50 +02:00
b1e4c0931a
Fixes and type-hints:
...
- added more checked type-hints as they prevent bad method invocations
- fixed TypeError for HTML::toBBCode() invocations with NULL as first (wrong)
argument, thanks to @tobias@social.diekershoff.de pointing this out.
2022-06-16 16:54:49 +02:00
bb57d45237
Merge pull request #11645 from Quix0r/fixes/e-notice_use
...
Fixed possible "Trying to access array offset on value of type bool" E_NOTICE
2022-06-16 08:45:50 -04:00
e9af4b5bb9
Shorter code, thanks to @annando pointing this out
2022-06-16 13:29:30 +02:00
65da5246ca
Fixed possibble "Trying to access array offset on value of type bool" E_NOTICE
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2022-06-16 10:07:41 +02:00
13ef86d4a3
Merge pull request #11644 from Quix0r/fixes/file-permissions
...
Fixed file permissions
2022-06-16 10:02:31 +02:00
58c48977ec
These files should never have executable files
2022-06-16 09:14:23 +02:00
fd0d4aedee
Font files should NEVER be executable
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2022-06-16 09:13:48 +02:00
207bf58801
Merge pull request #11624 from Quix0r/fixes/type-hints
...
Added more known type-hints
2022-06-15 16:32:25 -04:00
5fa954208a
Changes:
...
- ops, wasn't actually fixing `return;` to proper `return '';`
- added more type-hints
- added TODO ($uid is unused)
2022-06-15 22:28:33 +02:00
a3fa95e8e4
Changes:
...
- added more type-hints
- changed `return;` to `return '';` when `string` was requested as returned type-hint
(thanks to @MrPetovan )
2022-06-15 22:05:38 +02:00
34aee64349
Added more type-hints
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2022-06-15 21:52:51 +02:00
143e4c4a18
Added more known type-hints
...
Signed-off-by: Roland Häder <roland@mxchange.org>
2022-06-15 21:52:50 +02:00
98954dd14e
Merge pull request #11643 from annando/avatar-path
...
You can now store the avatar in a separate folder and host
2022-06-15 06:25:31 +02:00
726c4dff7d
You can now store the avatar in a separate folder and host
2022-06-15 03:59:26 +00:00
