Commit graph

547 commits

Author SHA1 Message Date
Philipp Holzer
f4ad82bcfb
make ACLFormatter::expand() nullable and return an empty array
- optimize tests
2019-11-01 15:43:16 +01:00
Philipp Holzer
aa7be41728
Fix ACLFormatterTest
- Add nullable to expand() function again
- Add angle bracket support to toString()
2019-11-01 14:13:29 +01:00
bef7eeed13 Fix 7778: Don't return empty string in permissions 2019-10-29 06:01:50 +00:00
9f460c6797
Merge pull request #7765 from nupplaphil/task/move_text
Move include/text.php to class structure
2019-10-23 15:57:01 -04:00
Philipp Holzer
c9e1098dd2
Adapt naming convention 2019-10-23 21:39:00 +02:00
Philipp Holzer
ad67fd3aa8
Move is_a_date_arg to DateTimeFormat::isYearMonth
- Improved functionality
- Added tests
2019-10-23 02:39:28 +02:00
Philipp Holzer
5843a80b6c
Move perms2str to ACLFormatter::aclToString()
- including new tests
2019-10-23 00:54:34 +02:00
Philipp Holzer
f65f7f11c3
Move expand_acl to ACLFormatter::expand()
- including tests
2019-10-23 00:40:14 +02:00
Philipp Holzer
04a86dad75
remove superfluous line 2019-10-22 22:52:40 +02:00
Philipp Holzer
1fe9b789f3
Add some PHP doc 2019-10-22 22:51:52 +02:00
Philipp Holzer
6b2c28e2d7
Add checks & realpath() usage
- New util class "FileSystem"
- Add check in admin summary too
2019-10-22 22:47:37 +02:00
Philipp Holzer
0e84a843a4
Add Fallback in case the logfile isn't accessible.
- Fixes https://github.com/friendica/friendica/issues/7756#issuecomment-544227862
2019-10-21 21:53:55 +02:00
4664249fec Improved comment 2019-10-17 21:49:29 +00:00
36ba7fa79c Merge remote-tracking branch 'upstream/develop' into http-417 2019-10-17 21:37:24 +00:00
5dcf6bfc58 Remove extra spaces before closing parentheses in src/ 2019-10-16 08:58:09 -04:00
146646c4d4 Replace deprecated calls to defaults() by ?? and ?: in src/ 2019-10-16 08:38:52 -04:00
440da8a9f4 eol 2019-10-12 14:07:22 +00:00
c1ab93a5d8 Strings.php: Spaces are transformed to Tabs. 2019-10-12 10:28:18 +00:00
2c2beb5c0a
Revert Util\Strings::escapeHtml changes from #7725
- Breaks display of inserted mentions
2019-10-11 22:19:20 -04:00
dew-git
e1e1d26b5b Revert random_int changes. 2019-10-11 00:00:15 -08:00
dew-git
b5dac16def Comply with coding style. 2019-10-10 20:50:51 -08:00
dew-git
811cdcdfcb Fix security vulnerbilities.
Fix possible length extension attack, predicable generators, timing attacks on hash comparision and improved formatting.
2019-10-10 15:21:41 -08:00
83b00ef308 New function "isAuthenticated" 2019-09-28 18:09:11 +00:00
6e9026e033 Renamed function, beginning to replace the "remote_user" function 2019-09-28 09:36:41 +00:00
3dd94355b7 Fix permissions when viewing photos, applying same fix to items as well 2019-09-27 05:49:23 +00:00
704cdf1b5a New function to store the "remote" session value / making the changes work 2019-09-26 04:47:42 +00:00
5254147ccc Fix "redir" loop 2019-09-23 22:13:20 +00:00
f51b275b17 Add parameter type hints in Temporal::getDateofBirthField 2019-09-21 10:52:55 -04:00
118e737a49 Remove dependency to App object in Temporal::getDateofBirthField 2019-09-21 05:15:52 -04:00
5ea8116cfd Workaround for HTTP error 417 2019-09-02 20:39:51 +00:00
Philipp Holzer
df7ec0cdf7
php notice fixings
addons:
- bufferapp (missing errorcode)
- twitter (wrong field name 'nickname')
core:
- bbcode (incomplete attachementdata)
- crypto (uninitialized key)
2019-08-27 08:27:07 +02:00
Philipp Holzer
08be92a862
Moved BaseURL to App namespace (because similar type as Arguments/Modules/Modes) 2019-08-15 17:23:00 +02:00
b4c673a620 We now use a central function for fetching the postdata 2019-07-30 22:26:01 +00:00
Philipp Holzer
6c2cf494b5
Remove DependencyFactory
- Include all necessary classes in `dependencies.config.php`
- Add DI-reference to BaseObject (acts as a global registry)
- Refactor all static "init()" methods to use the global registry

- Refactor Logging for Worker-Logger a little bit
2019-07-27 23:54:12 +02:00
46f7b79c7d Switch server blocklist check to case-insensitive shell wildcard 2019-07-25 22:36:25 -04:00
3812d3d445 Enable two-factor app-specific passwords for ejabberd 2019-07-23 05:11:33 -04:00
Philipp Holzer
55999730e0
Introduce DICE
- Adding dice library
- Adding dependency config

- Removing Factories
- Refactoring App\Mode constructor
- Refactoring App\Router constructor
- Refactoring BasePath for DI usage
- Refactoring ConfigFileLoader constructor
- Refactoring Profiler constructor

- Adjust entrypoints (index, console, worker, ..)

- Adding functional test for DI
- Fix tests because of refactorings
2019-07-21 01:22:10 +02:00
Philipp Holzer
346290cc23
Reverted indention 2019-07-16 21:54:22 +02:00
Philipp Holzer
46a260aa01
Fix indentations 2019-07-16 20:19:56 +02:00
Philipp Holzer
92fb0a82ca
Dynamic config loading
- Move settings, defaults and dbstructure to directory 'static'
- Dynamic loading of config files (after the static loading)
- Filter out '-sample.config.php' and '-sample.ini.php' files
- Remove unnecessary ConfigFileManager
- Move ConfigFileLoader to Utils
- Add tests for multi-loading for INI, config and sample-filtering
2019-07-16 20:16:43 +02:00
Philipp Holzer
c82127ffb7
Splitting ConfigCache & PConfigCache
- Remove IConfigCache & IPConfigCache
- Add new PConfigCache
- Add missing Logger::init() (bugfixing tests)
2019-07-12 22:53:37 +02:00
Philipp Holzer
7c54edd4b4
Fixing Network::post() caused by wrong argument 2019-06-10 19:34:16 +02:00
7bbacd3878 Fixes PR 7242: Now the "post" function works again 2019-06-10 16:58:00 +00:00
Philipp Holzer
cc7444d84d
Move internal recursion-counter to the end of all cur/fetchUrl parameters 2019-06-10 14:34:54 +02:00
Philipp Holzer
10683a43c8
Add typed parameter for methods in Friendica\Util\Network 2019-06-10 12:06:41 +02:00
Dean Townsley
19e99f7e81 Use accessing function for session variable 2019-06-09 21:06:42 -05:00
Dean Townsley
5c93db4097 remove leftover logging 2019-06-09 21:06:42 -05:00
Dean Townsley
af85e498ce expand permission check to remote array
This check was preventing multiple private images from different
users on the same server from loading on the same page.
It was only checking for permission for the single id returned by the
remote_user() function rather than the multiple possible autheniticated
id's stored in the remote arry session variable.
2019-06-09 21:06:42 -05:00
Philipp Holzer
4c5dd9f47c
Add more Strings::isHex() checks to photos 2019-05-30 10:30:15 +02:00
Philipp Holzer
3de540d1d1
Adding hexadecimal check for photos
see https://github.com/friendica/friendica/issues/6917#issuecomment-492798238
2019-05-29 20:28:25 +02:00
4e207ef786 Enable addon using emailer hooks to skip default call to mail() 2019-05-26 21:36:09 -04:00
956ae6241d Add exception message chain, string trace and original object to JsonLD normalize error logging 2019-05-20 15:28:54 -04:00
3395f56036 Add Unicode support to autolink regular expression
- Explicitly exclude non-breaking spaces from URLs as \s doesn't include them
2019-05-19 18:51:55 -04:00
6f3019ecdd Revert PR 7158 since it breaks umlauts 2019-05-19 09:34:49 +00:00
8fb9722cdc Replace htmlspecialchars_decode with html_entity_decode in XML::unescape
- Replace htmlspecialchars with htmlentities in XML::escape
- This allows for converting all entities from Diaspora messages to regular characters
2019-05-18 13:15:51 -04:00
87b98b8249 Sending direct messages via AP does work now - receiving is pending 2019-05-14 17:50:45 +00:00
eef85584c2 AP: Parsing of messages from Pleroma should work now again 2019-04-26 06:17:37 +00:00
af92f46a2d Workaround for systems who don't use a correct context in ActivityPub 2019-04-25 13:30:30 +00:00
1480380af6
Basepath Hardening 2019-04-14 16:17:58 +02:00
03e149270b
bugfix 2019-04-14 14:40:26 +02:00
1dd1684885
Hardening save method in BaseURL 2019-04-10 20:38:39 +02:00
40c075cf47
BaseURL hardening 2019-04-09 08:48:04 +02:00
edd4f06ad0
Adding tests 2019-04-09 08:31:18 +02:00
318a3ca785
Create own base URL class which holds the whole base url business logic 2019-04-09 08:31:16 +02:00
6f94e51ba6 Add Strings::sanitizeFilePathItem method 2019-03-31 21:39:19 -04:00
55325f191b Merge remote-tracking branch 'upstream/develop' into ap-delivery-failure 2019-03-26 21:36:46 +00:00
198e150ba8 Archive inboxes after 5 days of delivery failures 2019-03-25 21:51:32 +00:00
d78598b64e
Fixing basepath issue 2019-03-25 09:39:33 +01:00
23654ce566
Added Update checks
- Logging
- Console
- Admin overview
2019-03-24 22:51:30 +01:00
49def0dc27
Adding ConfigFileSaver and tests 2019-03-24 13:47:35 +01:00
fa31bb6dde
remove basepath and hostname from admin panel and add update path 2019-03-24 13:47:31 +01:00
383a6715c3
Added first version of ConfigCacheSaver 2019-03-23 19:34:54 +01:00
d03dedee63 Set Timezone to 'UTC' for every Logger (Develop) 2019-03-22 23:14:48 -04:00
f63956851b Adding Logger Tests 2019-03-22 23:13:26 -04:00
aee348fa02 Adding Logger Tests 2019-03-22 23:13:26 -04:00
7bebb03f95 Fix php doc 2019-03-22 23:13:25 -04:00
eec4ee3fed Rename & Testfix 2019-03-22 23:13:25 -04:00
cc8a6c85ae typo 2019-03-22 23:13:24 -04:00
7658916540 Added StreamLoggerTest 2019-03-22 23:13:24 -04:00
81ba5376d0 Added StreamLogger and ProfilerLogger 2019-03-22 23:13:23 -04:00
22f1983cc0 cleanup sysloglogger 2019-03-22 23:11:14 -04:00
25b6db6aca Moving Profiling to class 2019-03-22 23:07:39 -04:00
4810ca570f Refactored Logging environment (cleaned up) 2019-03-22 23:00:38 -04:00
21158e7699 Syslog - Disabling 2019-03-22 22:55:46 -04:00
d712d36814 Adding UID and Level To String mapping 2019-03-22 22:52:46 -04:00
ae40963507 Code cleanup 2019-03-22 22:52:46 -04:00
ec59e538fc Adding ident 2019-03-22 22:52:46 -04:00
9c5e0ae415 Adding SyslogLogger 2019-03-22 22:52:45 -04:00
0aab620d32 Enable remote authentication with HTTP Signatures 2019-03-19 06:44:51 +00:00
a876c20850 Use HTTP-Signature to authenticate when fetching photos. 2019-03-18 22:33:20 +00:00
0c738c4f8b Exclude punctuation from domain in autolinker regular expression 2019-03-17 19:37:26 -04:00
8f96e383a7
Remove new lines from domain name part of autolinker regular expression in Util\Strings
- Fixes issue where the autolinker would include the next paragraph is a pathless URL was followed by new lines.
2019-03-11 14:37:56 -04:00
184b51ec56 Move autolink regex in Util\Strings 2019-03-09 23:25:53 -05:00
d40cbdce32 Remove unnecessary @throws tag in Util\Network 2019-03-08 22:39:08 -05:00
a911baf8e5 Avoid transmitting a deletion message when we don't have a key 2019-03-04 06:52:43 +00:00
888e2ce2a9 Added forgotten "use" 2019-03-03 07:05:57 +00:00
3237dab1a4 Added warning about an empty key 2019-03-03 07:01:11 +00:00
0b2cdf5d26 Issue 6395: Don't log details to avoid memory issues 2019-02-28 09:07:24 +00:00
2b53784094
Reuse existing Strings::getRandomHex function 2019-02-27 18:32:25 +01:00
8c1db51a76 Improve Logger calls
- Replace various deprecated Logger::log calls
- Reassign log level for verbose log calls
2019-02-23 17:32:11 -05:00
1917f04153 Rewrite Term class
- Move term type constants from TERM_* to Term::*
- Move term object type constants from TERM_OBJ_* to Term::OBJECT_TYPE_*
- Add Term::isType() method
- Add Strings::startsWith()  method
2019-02-23 17:32:11 -05:00
1a0398a5b3
Merge pull request #6723 from nupplaphil/issue/6658-worker_id
Adding worker ID to log
2019-02-23 08:38:08 -05:00
3aae84edd1
[rendertime] Timing problem during addon config read 2019-02-23 01:24:08 +01:00
ee37632695
Adding worker id & functionname to worker logs 2019-02-22 20:10:27 +01:00
466f7a0ee5
adding test 2019-02-20 17:20:17 +01:00
107293bd61
Fixing rendertime 2019-02-20 17:12:40 +01:00
1df19d3553
Merge pull request #6697 from annando/memory-jsonld
Avoid memory issue in exception of JSON-LD parser
2019-02-19 09:40:01 +01:00
4facd1dfdb Avoid memory issue in exception 2019-02-19 07:49:27 +00:00
5e5c39b0e1
Refactored DependencyFactory for Profiler 2019-02-17 21:12:12 +01:00
c36a0eabdb
fixing reset() 2019-02-17 10:34:48 +01:00
3d07774509
removed wrong log-output 2019-02-17 01:57:59 +01:00
88fd871844
refactoring & test fixing 2019-02-17 01:18:21 +01:00
6d73dcbe3d
Adding composer & tests 2019-02-17 00:03:38 +01:00
0a7861da65
Dependency of callstack moved one layer up 2019-02-16 23:17:10 +01:00
5e6e1a8025
Introducing Profiler 2019-02-16 23:11:30 +01:00
b79bd63231
move isDirectoryUsable to System 2019-02-05 22:30:18 +01:00
6a9d73f7d9
Refactoring ConfigCacheLoader methods 2019-02-05 22:27:57 +01:00
4af0119b73
3) Introducing ConfigFactory 2019-02-03 22:22:04 +01:00
d7e35b5802
Making the processor name more explicit 2019-01-28 18:41:29 +01:00
26af96f31a
improving code 2019-01-28 18:26:35 +01:00
9fe1da5f94
Double backslash 2019-01-28 12:35:14 +01:00
88e2cc9fa2
removing array prefix (compatibility) 2019-01-28 11:35:08 +01:00
a5e12f53e8
Logger Unique ID 2019-01-28 11:21:48 +01:00
b90c8c6346 Logger: Display the correct file, function and line number 2019-01-24 14:23:42 +00:00
Michael Vogel
6e7ca479d6
Merge pull request #6508 from nupplaphil/logger_enh
Adding an explicit FriendicaProcessor
2019-01-24 11:15:57 +01:00
7634663970
Adding an explicit FriendicaProcessor 2019-01-24 08:13:44 +01:00
64847e7cc8 Fix types in doc blocks/prototypes 2019-01-23 09:06:58 -05:00
0c19c4c75d Fix missing reference to 'data' key in Util\Crypto
- Fix doc blocks
2019-01-23 09:06:57 -05:00
ce177f22c8 Fix doc blocks and return value type 2019-01-21 11:36:01 -05:00
7f2dc40601 Fix potential bugs without expected behavior change
- Fix uninitialized variables
- Fix potentially not set variables
- Fix wrong parameter default value
- Fix method scope
- Fix missing return value
2019-01-21 11:04:19 -05:00
ad9c67663d Move Contact::Page_* constants to User::PAGE_FLAGS_* 2019-01-21 10:55:37 -05:00
9e0be97703 Bugfixing legacy loglevel 2019-01-21 10:54:41 -05:00
4a95ca280d Remove unused code
- Remove commented code
- Remove unused/immediately overwritten variables
- Remove extraneous parameters
- Remove unreachable code
- Remove duplicate array keys
2019-01-21 10:48:40 -05:00
cb3f09ae4f Refactor namespaces
- Remove unused use statements
- Add required use statements
- Escape global classes
2019-01-21 10:43:42 -05:00
3282ce5389 Fix PHPDoc comments project-wide 2019-01-21 10:35:51 -05:00
2e602afd3e Add Monolog 2019-01-21 10:10:40 -05:00
2f49c4a058 Revert "Add monolog" 2019-01-21 10:08:09 -05:00
fabrixxm
c3c0332536 return default mimetype for unknown extensions 2019-01-21 10:00:47 -05:00
df230126c9 skipStackFramesCount to 1 to skip static method 2019-01-21 09:59:11 -05:00
45bde8fef1 Adding more information in case of warning (or dev) 2019-01-21 09:59:11 -05:00
6150c2fa9c Bugfixing 2019-01-21 09:59:11 -05:00
7f7ed16dc2 Log format 2019-01-21 09:59:09 -05:00
8f9c0fe149 Adding Develop and normal Logging instances 2019-01-21 09:59:08 -05:00
55e54bb950 Replace deprecated Addon::callHooks with Hook::callAll
- Update documentation
2019-01-21 09:50:56 -05:00
895b3abf32 Remove/replace killme() with *exit() 2019-01-21 09:49:17 -05:00
ce37e981cb This fixes a problem when the URL is too long 2019-01-16 22:34:57 +00:00
ae2a8b796c Avoid a notice in HTTP signature check, preparation for authentication 2019-01-15 06:31:12 +00:00
9bec202232 Adding the date to signed get requests as well 2019-01-14 16:33:23 +00:00
2f2184cf12 Date check added for HTTP signatures 2019-01-14 16:03:13 +00:00
aa4aaf1971 Enable communication with Peertube 2019-01-14 12:10:11 +00:00
c1dec50248 Avoiding some notices 2019-01-13 18:03:13 +00:00
8b5b66838d Issue 6438: Avoid fatal error 2019-01-13 16:00:27 +00:00
d113ccd93c Making Friendica compatible to Nextcloud Social 2019-01-13 09:38:01 +00:00
a20fa6a3a9 Add ensureQueryParameter method to Util\Strings 2019-01-11 19:27:56 -05:00
5e1ceb57de Escape global namespaced get_app() calls
- Add deprecated status
2019-01-03 21:27:36 -05:00
37c7a18d00 Replace latin-1 by latin1 in charset detection
- Simplify conditional for charset conversion
2018-12-29 00:43:00 -05:00
Michael Vogel
94eca77041
Merge pull request #6315 from MrPetovan/bug/6309-add-fulltext-index-profile
Rework mod/match and mod/msearch
2018-12-27 18:04:06 +01:00
5b74f066f2 Fix formatting in Util\Strings 2018-12-26 11:02:50 -05:00
acaee626f5 Remove include/ requires that are now done directly from Composer 2018-12-24 09:56:25 -05:00
c485ca6f06 Fix ActivityPub with Nextcloud 2018-12-17 20:13:56 +00:00
b6e1571b1e Fix various notices 2018-12-15 04:32:47 -05:00
cced018825 Possibly fix a memory issue with large posts 2018-12-11 18:48:33 +00:00
491fc5f78a Issue 6168: "redir" now mostly use OWA 2018-12-04 07:12:55 +00:00
458981f75c Replace x() by isset(), !empty() or defaults()
- Remove extraneous parentheses around empty() calls
- Remove duplicate calls to intval(), count() or strlen() after empty()
- Replace ternary operators outputting binary value with empty() return value
- Rewrite defaults() without x()
2018-11-30 09:06:22 -05:00
Adam Magness
218f0734be Rename removeTags to escapeTags
rename function and update calls.
2018-11-09 13:29:42 -05:00
Adam Magness
063f0e9cb0 Rename escapeTags to escapeHtml
rename function and update calls.
2018-11-09 13:27:58 -05:00
Adam Magness
b5a97c1abe Move getTags to BBCode
move getTags function to BBCode class and update calls.
2018-11-09 13:24:19 -05:00
Adam Magness
e4354a0d7b Update and Remove isValidEmail
change function calls, and remove unneeded function.
2018-11-09 13:18:42 -05:00
Adam Magness
087f50d820 Missing Use statements
missing use
2018-11-08 11:58:42 -05:00
Adam Magness
ffc406d819 normalise_link calls
implement normaliseLink function
2018-11-08 11:28:29 -05:00
Adam Magness
5276c28a78 link_compare calls
implement compareLink function.
2018-11-08 10:46:50 -05:00
Adam Magness
6fc9c6de3b base64url calls
implement base64UrlEncode and base64UrlDecode functions
2018-11-08 10:37:08 -05:00
Adam Magness
916b3e551e format_network_name calls
implement formatNetworkName function
2018-11-08 10:24:47 -05:00
Adam Magness
b99925060a autoname calls
implement getRandomName function
2018-11-08 10:22:20 -05:00
Adam Magness
0e01568ccd escape_tags calls
implement escapeTags function
2018-11-08 10:20:03 -05:00
Adam Magness
a0f65ca7a1 notags calls
implement removeTags function
2018-11-08 10:14:37 -05:00
Adam Magness
991f259ecb random_string calls
implement getRandomHex function
2018-11-08 08:45:46 -05:00
Adam Magness
fd597472f1 Split text.php to Strings class
move functions to new strings class
Split text.php to Strings class

move functions to new Strings class
2018-11-08 08:33:28 -05:00
cd2c7f782f We now directly support the custom emojis from Mastodon 2018-11-07 20:34:03 +00:00
Adam Magness
352da9bcf3 Update function calls
update function calls for moved functions
2018-11-06 09:52:58 -05:00
049cd963f3
Using random_int directly 2018-11-05 21:15:30 +01:00
6e10bdf361
Move random Digits to Crypto class 2018-11-05 21:02:54 +01:00
Adam Magness
186cd1d415 Revert "Move methods to new Util/Strings class"
This reverts commit 97fcf23371.
2018-11-05 13:07:15 -05:00
Adam Magness
9e51be7554 Revert "Update function calls"
This reverts commit 748fb8b946.
2018-11-05 13:07:07 -05:00
Adam Magness
748fb8b946 Update function calls
update function calls to new class
2018-11-05 07:40:18 -05:00
Adam Magness
97fcf23371 Move methods to new Util/Strings class
move string methods from xml to strings class.
2018-11-05 07:31:45 -05:00
Adam Magness
6cc339031a Rename functions
rename functions
2018-11-05 07:24:14 -05:00
Adam Magness
ae4aab872f forgotten self
forgotten self references
2018-11-05 07:24:14 -05:00
Adam Magness
84e900d96f Move to XML
move functions from text to xml
2018-11-05 07:24:14 -05:00
8f27e3aeb1 Support for fetching non-public content / preparations for forum posts 2018-11-03 21:37:08 +00:00
1395bdc188 Preparations for a relocation message / fix for notice 2018-11-02 21:57:06 +00:00
Adam Magness
35abc4bb64 get markup template
implement getMarkupTemplate function
2018-10-31 10:44:06 -04:00
Adam Magness
91facd2d0a replace macros
implement new replaceMacros function
2018-10-31 10:35:50 -04:00
Adam Magness
50da89d861 Logger Levels
update logger levels in calls
2018-10-30 09:58:45 -04:00
Adam Magness
14fde5dc9b Log function
implement log() function.
2018-10-30 09:57:14 -04:00
58f82e084d Preparations to work with BCC 2018-10-24 19:19:51 +00:00
cb75c40f4e adapted profile pic resize to 300px for whole system 2018-10-23 16:36:57 +02:00
dbe49a0c1a
Merge pull request #5998 from annando/ap-queue
Unsuccessful ActivitiyPub transmission are now deferred
2018-10-23 06:54:11 +02:00
e3e714a45f Unsuccessful ActivitiyPub transmission are now deferred 2018-10-23 03:54:18 +00:00
e511790d62 Move NULL_DATE from boot.php to DBA::NULL_DATETIME
- Add DBA::NULL_DATE constant
2018-10-22 16:50:55 -04:00