Pierre Rudloff
7d953d952e
Various small fixes ( #4795 )
...
* Use strict comparison to avoid 0 == false
* Avoid unecessary loop
* Avoid undefined variable
* Fix wrong variable name
* Don't try to use the $status_info variable if it does not exist
* Avoid undefined variable
* Check that variable is defined before trying to use it
* Don't cast $data array to boolean
* Fix undefined array
* $reactivate_group variable is not always defined
* Variable $found is not always defined
* Remove unused return statement
* Fix undefined array
* api_unique_id_to_nurl() requires an integer as argument
* Don't try to use $uinfo if it is false
* Don't use the same variable names in inner loop
* Throw an exception if $fileext is not defined
2018-04-09 15:34:53 -04:00
Pierre Rudloff
773591a6ba
Add some missing return types
2018-04-09 19:53:02 +02:00
Pierre Rudloff
4b36f3ad05
api_format_data() seems to never return an object
2018-04-09 19:34:09 +02:00
Pierre Rudloff
9cde7881ee
Throw a ForbiddenException if api_get_user() returns false
2018-04-09 18:52:38 +02:00
Pierre Rudloff
d0591dd882
The first argument for api_format_items() must be an array
2018-04-08 01:06:40 +02:00
Pierre Rudloff
9c351bad68
Fix wrong use of empty()
2018-04-08 00:55:05 +02:00
Pierre Rudloff
bef3799942
Use empty() instead of !x()
2018-04-07 23:21:51 +02:00
Pierre Rudloff
333eb5f9dd
Add missing variable
2018-04-07 23:20:30 +02:00
Pierre Rudloff
b775cba8c2
Remove confusing comment
2018-04-07 22:39:38 +02:00
Pierre Rudloff
036803d8c7
Typo
2018-04-07 22:37:57 +02:00
Pierre Rudloff
5d8d62015c
Make list_id parameter mandatory in api/lists/statuses
2018-04-07 22:36:54 +02:00
Pierre Rudloff
6401eb988b
Use dba to access database in api_lists_statuses()
2018-04-07 22:35:19 +02:00
Pierre Rudloff
fea7ec2482
We don't need type casting for dba::select() arguments
2018-04-07 22:18:39 +02:00
Pierre Rudloff
c5aaa61d11
Rename api_list_create() to api_lists_create() for consistency
2018-04-07 22:15:35 +02:00
Pierre Rudloff
c4edad212b
Use dba to access the database in list API functions
2018-04-07 19:55:41 +02:00
Pierre Rudloff
929440417c
We don't really need the unsen bit in api_lists_statuses()
2018-04-07 19:52:47 +02:00
Pierre Rudloff
b3235c2d02
Implement parts of the list API:
...
lists/statuses
lists/destroy
lists/update
lists/create
lists/ownerships
2018-04-07 19:16:47 +02:00
Pierre Rudloff
78a979ee58
Add profile_image_url_profile_size and profile_image_url_large properties to user object returned by API ( fixes #4695 )
...
This allows some clients to display a bigger avatar on profiles.
2018-04-07 13:31:17 +02:00
Hypolite Petovan
27d94023ee
Merge branch 'master' into develop
2018-03-23 06:15:55 -04:00
Hypolite Petovan
789561c7a2
Remove/Update references to include/html2*.php
2018-03-07 16:34:17 -05:00
Hypolite Petovan
5e806ff598
Replace html2plain calls by HTML::toPlaintext
2018-03-07 16:29:44 -05:00
Hypolite Petovan
b5666bd27f
Replace html2bbcode calls by HTML::toBBCode
2018-03-07 16:24:13 -05:00
Hypolite Petovan
95752b79e8
Add cache performance to API and worker
2018-03-04 23:13:19 -05:00
506f851b23
Bugfix: Avoid that Twidere is crashing
2018-03-04 19:25:02 +00:00
a3af6807ac
Improved resource id creation
2018-02-20 10:02:07 +00:00
Hypolite Petovan
9e3bae5caa
Remove references to include/bbcode.php
2018-02-14 22:01:14 -05:00
Hypolite Petovan
0c52866693
Refactor bbcode() into BBCode::convert()
2018-02-14 21:33:55 -05:00
rabuzarus
26fd6b1c33
fix undeclared variables or wrong variable names (/include)
2018-02-11 22:13:29 +01:00
30cfca40d8
Use a more simple HTML for API output
2018-02-10 13:33:15 +00:00
85c8bf0228
Merge pull request #4399 from MrPetovan/task/3878-move-include-bbcode-to-src
...
Move include/bbcode to src/ part 1 : Everything but bbcode()
2018-02-07 07:18:39 +01:00
e609de2957
Many item calls are now isolated in a single function
2018-02-06 12:40:22 +00:00
Hypolite Petovan
010cf3b1e8
Update references to BBCode methods
...
- Resolve name conflicts with Util\Network
2018-02-04 19:26:22 -05:00
Hypolite Petovan
f020292408
Remove references to include/datetime
2018-02-03 20:47:37 -05:00
Hypolite Petovan
5e7285b9ba
Move Temporal::convert() to DateTimeFormat::convert()
2018-02-03 08:56:55 -05:00
Hypolite Petovan
35d06bd9eb
Add Temporal::utc() shorthand to Temporal::convert()
2018-02-03 08:56:53 -05:00
Hypolite Petovan
8aff8a76eb
Add Temporal::utcNow()
2018-02-03 08:56:52 -05:00
Hypolite Petovan
38ff1b455b
Add Temporal::MYSQL constant
...
- Rename Temporal::convert() parameter names
2018-02-03 08:56:52 -05:00
Hypolite Petovan
b854905150
Move ATOM_TIME to Temporal::ATOM
2018-02-03 08:56:52 -05:00
Hypolite Petovan
dc366bf1f7
Refactor datetime_convert into Temporal::convert
...
- Changed parameter order to save space
- Refactor select_timezone into Temporal::getTimezoneSelect
- Refactor field_timezone into Temporal::getTimezoneField
2018-02-03 08:56:51 -05:00
Hypolite Petovan
974539913c
Remove include/like references
2018-02-01 14:17:22 -05:00
Hypolite Petovan
a286e8bf3b
Replace do_like() calls
2018-02-01 14:17:08 -05:00
7b27dda784
Most functions now moved from include/items.php
2018-01-28 11:18:08 +00:00
Adam Magness
f04d40a37e
Review update
...
Rename function, move others
2018-01-27 11:13:41 -05:00
Adam Magness
c67452f72e
Move fetch_url
...
move fetch_url function
2018-01-26 23:09:48 -05:00
Adam Magness
177edd2b6e
Rename class to BBCode
...
Rename Plaintext class to BBCode
2018-01-26 20:01:32 -05:00
Adam Magness
21881f2885
Update function calls
...
update to new function calls
2018-01-26 19:14:47 -05:00
Adam Magness
8eecad4c7f
String correction
...
monthly is monthly
2018-01-23 22:43:22 -05:00
Adam Magness
5142e65726
Review updates
...
improve a t() call and move some to tt()
2018-01-23 22:38:47 -05:00
Adam Magness
208a149a7b
Review sprintf
...
remove more sprintf calls
2018-01-23 21:59:16 -05:00
Adam Magness
c8ecc31405
Update functions and calls
...
Update function names and calls.
2018-01-22 18:03:26 -05:00
Adam Magness
b86b04a81a
Change plugin to addon
...
change the use of plugin to addon where appropriate.
2018-01-20 07:48:22 -05:00
Adam Magness
11cf36105c
Update Addon functions and calls
...
Update function names and calls for Addon class.
2018-01-20 07:48:22 -05:00
034d46196f
"last-child" is not used anymore
2018-01-18 06:54:44 +00:00
2d66242b4f
The delete function is now changed to the new function
2018-01-17 23:22:01 +00:00
Hypolite Petovan
e36f2bb1fb
Use short form array syntax everywhere
...
- Add short form array syntax to po2php.php generation
2018-01-15 14:07:17 -05:00
Adam Magness
b3e6a1d283
Update functions and calls
...
Update functions and calls.
2018-01-15 12:14:09 -05:00
fabrixxm
2d0fe7a30f
Fix api login
2018-01-13 09:22:40 +01:00
Hypolite Petovan
5fc4927764
Improve dba::selectFirst calls
...
- Fix remaining $r[0] references
- Rename $r to meaningful names
2018-01-11 03:43:57 -05:00
Hypolite Petovan
ae66bcaff3
Rename selectOne to selectFirst
2018-01-10 12:57:21 -05:00
Hypolite Petovan
da60893590
Replace dba::select(limit => 1) by dba::selectOne
...
- Convert array declarations to new style
2018-01-10 12:57:21 -05:00
Adam Magness
a3ef9e35ec
Update functions and calls
...
Update function names and calls.
2018-01-09 22:42:04 -05:00
Hypolite Petovan
d1b3b7fbe4
Review changes
...
- Remove doc for unused config value
- Restore api_get_user($a) calls
2018-01-04 13:26:09 -05:00
Hypolite Petovan
35a18f6825
Fix unused code in include (second pass)
2018-01-04 12:21:13 -05:00
Hypolite Petovan
3b4625ebdd
Fix unused code in include/api
2018-01-04 12:19:06 -05:00
Hypolite Petovan
b39e06ed23
Merge pull request #4136 from Rudloff/feature/update_profile_api
...
Cleaner way to get user URL in api_account_update_profile
2017-12-26 17:13:58 -06:00
Pierre Rudloff
8b10bfe3a8
Cleaner way to get user URL in api_account_update_profile
2017-12-26 21:50:08 +01:00
Hypolite Petovan
06f32aaaa6
Merge pull request #4130 from Rudloff/feature/update_profile_api
...
Basic support for account/update_profile API (fixes #4094 )
2017-12-25 20:06:34 -05:00
Pierre Rudloff
c490a718ac
Update profile in directory when calling api_account_update_profile
2017-12-26 01:09:51 +01:00
Pierre Rudloff
94244024ac
Improve conditions in api_account_update_profile
2017-12-26 01:05:12 +01:00
Pierre Rudloff
8c17b96749
Missing return types in docblocks
2017-12-25 21:14:02 +01:00
Pierre Rudloff
ee5301018a
Fix typo
2017-12-25 21:12:08 +01:00
Pierre Rudloff
de5dae0751
Basic support for account/update_profile API ( fixes #4094 )
2017-12-25 21:10:26 +01:00
Hypolite Petovan
75ba84efa8
Merge pull request #4129 from annando/issue-4121
...
API: Better use "about" instead of "pdesc"
2017-12-25 09:23:46 -05:00
0475fc1fce
API: Better use "about" instead of "pdesc"
2017-12-25 05:39:11 +00:00
Hypolite Petovan
c6a00f5ac4
Merge pull request #4126 from annando/issue-4121
...
Fix for issue 4121 - now the description isn't empty
2017-12-24 21:19:21 -05:00
ba4329da61
Fixed typo
2017-12-24 23:07:14 +00:00
Pierre Rudloff
37eecad8cc
Add missing doc in api.php
2017-12-24 15:01:43 +01:00
e848e376b8
Fix for issue 4121 - now the description isn't empty
2017-12-24 11:51:38 +00:00
Pierre Rudloff
0305aa2d82
Lint api.php
2017-12-24 00:27:45 +01:00
Hypolite Petovan
1fd62ee626
Merge pull request #4122 from Rudloff/feature/cleanup_api
...
Various fixes in api.php
2017-12-22 20:04:07 -05:00
Pierre Rudloff
ca73ec5cbb
Incorrect return type
2017-12-23 01:36:55 +01:00
Pierre Rudloff
f2758d00fb
Unused variable
2017-12-23 01:34:12 +01:00
Pierre Rudloff
da6a7b1fce
Typo
2017-12-23 01:32:47 +01:00
Pierre Rudloff
70ab9dc9be
Undefined variable
2017-12-23 01:31:29 +01:00
Pierre Rudloff
521d4b09b6
Unused argument
2017-12-23 01:27:17 +01:00
Pierre Rudloff
b4cf27e767
api_format_data can also return an array
2017-12-23 01:25:43 +01:00
Pierre Rudloff
37aef32440
Remove unused variable
2017-12-23 01:23:28 +01:00
Pierre Rudloff
0691d83bbc
Typo
2017-12-23 01:23:20 +01:00
1fc3993990
Code cleaning
2017-12-22 23:10:32 +00:00
a309d3c733
Bugfix for the api call for remoteauth
2017-12-22 23:00:49 +00:00
Pierre Rudloff
890cda11ed
Only use "@throws" in phpdoc if the function explicitely throws an exception
2017-12-19 14:52:46 +01:00
Pierre Rudloff
e44da4a498
Close DB connection in api_saved_searches_list
2017-12-19 14:42:13 +01:00
Pierre Rudloff
30cb37cda5
Implement saved_searches/list API
2017-12-19 14:22:38 +01:00
Hypolite Petovan
256bf2e888
Merge pull request #4104 from Rudloff/feature/incoming_api
...
Implement friendships/incoming and users/lookup APIs
2017-12-19 05:39:23 -05:00
Pierre Rudloff
a817a1a070
Throw NotFoundException if results are empty in api_users_lookup
2017-12-19 11:37:55 +01:00
Hypolite Petovan
394e94cbc1
Merge pull request #4103 from Rudloff/feature/profile_colors
...
Add support for profile_*_color in API
2017-12-19 05:35:36 -05:00
Pierre Rudloff
27646cc4ad
Code standards in api_get_user
2017-12-19 11:33:59 +01:00
Pierre Rudloff
35c4a7940a
Use dba::select() instead of dba::p() in api_get_user
2017-12-19 01:31:32 +01:00
Pierre Rudloff
e11190b4cf
Implement friendships/incoming and users/lookup APIs
2017-12-18 23:51:03 +01:00
Pierre Rudloff
3e9bc61bbf
Add support for profile_*_color in API
2017-12-18 21:57:30 +01:00
Hypolite Petovan
7a6706b0f7
Merge pull request #4097 from Rudloff/feature/search_api
...
Implement search API (fixes #929 )
2017-12-18 09:28:33 -05:00
Pierre Rudloff
02733c66f3
Use LIKE instead of REGEXP in api_search
2017-12-18 15:23:15 +01:00
Pierre Rudloff
3e4af13772
Implement the blocks/list API
2017-12-18 15:20:42 +01:00
Pierre Rudloff
5899d821ef
Remove useless intval() in api_search
2017-12-18 14:36:06 +01:00
Pierre Rudloff
31d63d929d
Use dba::inArray() instead of dba::fetch() in api_search
2017-12-18 14:28:04 +01:00
Pierre Rudloff
ee8468affe
Improve api_search()
...
Use dba::p() instead of q()
Move exception to the beginning
Remove useless GROUP BY
Remove useless protect_sprintf()
2017-12-18 14:00:10 +01:00
Pierre Rudloff
4a5d988d8c
Implement search API ( fixes #929 )
2017-12-18 13:05:27 +01:00
1fbf6c014b
Possible API speed ups for public timeline
2017-12-17 17:47:15 +00:00
Hypolite Petovan
691e4561e6
Merge pull request #4088 from annando/api-external-url
...
API: Path to post added / "external_url" support
2017-12-17 10:57:46 -05:00
Michael Vogel
9ff4d2d838
Merge pull request #4084 from MrPetovan/task/4071-add-networkpublic_timeline-api
...
Add statuses/networkpublic_timeline api method
2017-12-17 16:52:17 +01:00
26a89aa6ed
API: Path to post added / "external_url" support
2017-12-17 15:16:18 +00:00
Hypolite Petovan
cdd5bd5615
Improve networkpublic_timeline SQL performance
...
- Use thread.iid for max_id and ordering
2017-12-17 10:06:12 -05:00
995f2d719d
Merge remote-tracking branch 'upstream/develop' into issue-4069
2017-12-17 12:10:32 +00:00
3c835ccb22
Alternate fix for issue 4069
2017-12-17 11:11:28 +00:00
Michael Vogel
de56a3a824
Merge pull request #4079 from MrPetovan/task/4069-add-pagination-to-statuses-api
...
Add pagination to API statuses/friends and statuses/followers
2017-12-17 11:31:01 +01:00
Hypolite Petovan
53e3e49324
Add statuses/networkpublic_timeline api method
2017-12-16 15:41:50 -05:00
Hypolite Petovan
78c053c6b9
Add max_id support for statuses/user_timeline API
...
- Add documentation
- Improve formatting
2017-12-16 11:34:44 -05:00
Hypolite Petovan
ecde6e456d
Add pagination to API statuses/friends and statuses/followers
...
- Add doc blocks for both API calls
- Remove unused parameters
2017-12-16 10:16:25 -05:00
89ad41aca5
Bugfix: Calls to a renamed function had been changed
2017-12-14 18:06:48 +00:00
Hypolite Petovan
4fe8dab08d
Remove include/group.php
2017-12-09 13:45:54 -05:00
Hypolite Petovan
abdecd2b2f
Use new Model methods for groups
2017-12-09 13:45:17 -05:00
Hypolite Petovan
fe89e7760e
Fix formatting all around
2017-12-09 13:42:02 -05:00
Hypolite Petovan
a42595a30c
Move Object\Contact to Model\Contact
2017-12-07 23:56:12 -05:00
Hypolite Petovan
3fc3e67b70
Separate Object\Photo into Model\Photo and Object\Image
...
- Renamed a bunch of functions to shorter or clearer names
2017-12-07 23:54:51 -05:00
Michael Vogel
5747cfc79c
Revert "Move Objects to Model"
2017-12-08 05:21:51 +01:00
Hypolite Petovan
18d93cddf6
Move Object\Contact to Model\Contact
2017-12-07 09:04:24 -05:00
Hypolite Petovan
52bddd580c
Separate Object\Photo into Model\Photo and Object\Image
...
- Renamed a bunch of functions to shorter or clearer names
2017-12-07 08:56:11 -05:00
Adam Magness
0c48b4188b
Non Static calls
...
update calls to non static
2017-12-04 21:10:54 -05:00
Adam Magness
d3473f9999
Update use
...
Forgot to update a use statement.
2017-12-04 18:30:18 -05:00
Adam Magness
9c7b6d9d5f
Functions and Standards
...
Standards and convert to dba functions where possible.
2017-12-04 14:52:04 -05:00
Adam Magness
b1d16fbdf7
Update use statements
...
update use statements for rename to singular.
2017-12-04 09:04:36 -05:00
Adam Magness
6e5471def3
Rename to singular
...
Rename and update references. Standards and a require_once.
2017-12-04 09:01:27 -05:00
Adam Magness
2f0da29c75
Features to src
...
Move Features to class in Friendica\Content namespace. Update function calls and references.
2017-12-04 08:33:49 -05:00
Adam Magness
0373056448
Review and Use statements
...
use statements and review changes.
2017-11-29 17:29:11 -05:00
Adam Magness
0091d318e5
Function names
...
Update function names and corresponding function calls
2017-11-29 12:17:12 -05:00
Adam Magness
54827e7fed
Photo to src
...
Move Photo to Friendica\Object namespace and replace require_once statments with use statements.
2017-11-29 07:52:27 -05:00
Hypolite Petovan
ec6f5193e2
Switch to User::authenticate
...
- Removed hash('whirlpool') to check password
2017-11-26 14:46:08 -05:00
Hypolite Petovan
1f4fc87fd9
Use new HTTPExceptions in API
2017-11-23 23:48:15 -05:00
Adam Magness
609a4de5d0
src Standards
...
This basically completes coding standards changes for the entire src directory, with the exception of App.php
2017-11-23 14:01:58 -05:00
c6c180e8b9
Some more changed calls
2017-11-22 09:11:44 +00:00
Adam Magness
ddacbf2c13
XML class standards
...
updated the xml class for PSR-2
2017-11-20 12:56:31 -05:00
Hypolite Petovan
ec02af593d
Change called method names
...
- Add GlobalContact::getRandomUrl
- Rename Contact::getIdForURL
- Rename Diaspora::sendUnshare
- Remove unused parameter $self in Contact::terminateFriendship
2017-11-19 17:03:39 -05:00
Hypolite Petovan
b92fc24ff0
Add Contact Object
...
- Add Profile Object
- Add User Model
- Add use statements
2017-11-19 16:55:28 -05:00
2de457489f
"CreateShadowentry" and "ProfileUpdate" now moved as well
2017-11-19 16:59:37 +00:00
925d2d2383
Directory moved
2017-11-18 07:59:30 +00:00
Adam Magness
bc49fc974c
Capitalized XML
...
Acronym classes should be capitalized
2017-11-10 07:45:33 -05:00
Adam Magness
f245bc8359
Move xml to namespace
...
Relocate xml from include to src
Related to #3878
2017-11-10 07:18:24 -05:00
Adam Magness
aa13302bbc
Review updates
...
Documentation and yet another use statement
2017-11-08 08:37:03 -05:00
Adam Magness
4ca68c7af0
Class file relocations
...
Issue #3878
2017-11-08 08:37:03 -05:00
Adam Magness
6189f6c8e7
Relocate class files from /include to /src/
...
dbm, Diaspora, dfrn, and NotificationsManager moved to namespace. Includes and references in files updated.
2017-11-08 08:36:48 -05:00
