Commit graph

6679 commits

Author SHA1 Message Date
10a4802d81
Merge pull request #9552 from annando/zero-user
Avoid problems with uid=0
2020-11-19 16:23:28 -05:00
303aaa00ca Mode switch for insert 2020-11-19 19:34:48 +00:00
Michael Vogel
e4c6341bf4
Merge pull request #9551 from MrPetovan/task/4140-ldap-auth-logging
Make Model\User::getAuthenticationInfo accessible to addons
2020-11-19 18:21:34 +01:00
bd0e2dc0a8 Avoid problems with uid=0 2020-11-19 17:19:14 +00:00
a66e66359c Make Model\User::getAuthenticationInfo accessible to addons
- It contains the centralized authentication requirements for user records
2020-11-19 11:20:17 -05:00
3af5f6b8ee Some more foreign keys added 2020-11-19 06:26:30 +00:00
Michael Vogel
f69c043bec
Update src/Protocol/OStatus.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-11-18 18:07:20 +01:00
a1dcbedc6f Fix Notice: Undefined variable: valid in /src/Protocol/OStatus.php on line 526 2020-11-18 13:47:29 +00:00
0edc058a17 Ensure that the daemon is called faster and more reliably 2020-11-18 13:29:10 +00:00
f36ecdf6bf Replacing deprecated log calls 2020-11-18 09:14:12 +00:00
4f7d42a0d3 Fixed copy&paste error 2020-11-18 05:55:15 +00:00
b09ffa0697 Relocate system user creation 2020-11-18 05:33:17 +00:00
d7fa58d81c Ensure to never delete the "0" user 2020-11-18 05:24:04 +00:00
81a03b137b Test: only insert empty user 2020-11-18 05:04:17 +00:00
1e9d3342a3 Changed order of inserts 2020-11-18 00:13:39 +00:00
fed1ace311 Fix condition 2020-11-17 23:59:14 +00:00
317921e51c Changed order 2020-11-17 23:45:16 +00:00
3fe7d035d4 Merge remote-tracking branch 'upstream/develop' into post-user 2020-11-17 23:31:41 +00:00
Michael Vogel
dc5624b0b6
Merge pull request #9543 from MrPetovan/bug/notices
Address several notices
2020-11-18 00:30:31 +01:00
096cb19d12 Suppress notice when causer-id exists but not causer-link in Model\Item::isAllowedByUser
- Address https://github.com/friendica/friendica/issues/9252#issuecomment-723440980
2020-11-17 18:06:16 -05:00
ccad67c68f Use correct contact key in Protocol\ActivityPub\Transmitter
- Address https://github.com/friendica/friendica/issues/9252#issuecomment-719866843
2020-11-17 17:59:39 -05:00
93380b8471 Suppress notice while logging in Model\Contact
- Address https://github.com/friendica/friendica/issues/9252#issuecomment-716042132
2020-11-17 17:57:37 -05:00
283b70928d Remove top-level parent check from Protocol\OStatus
- It's done in Item::insert instead
- Address part of https://github.com/friendica/friendica/issues/9252#issuecomment-729171051
2020-11-17 17:54:07 -05:00
54aef550c5 Remove superfluous mentions of parent-uri in Protocol\Diaspora
- Address part of https://github.com/friendica/friendica/issues/9252#issuecomment-729171051
2020-11-17 17:54:07 -05:00
7615c022be Improved logging 2020-11-17 22:41:53 +00:00
219c651289 Removed test logging 2020-11-17 22:38:52 +00:00
eaa58da25b New table "post-user" and more foreign keys 2020-11-17 22:33:44 +00:00
b2666e7794 Escape user name in introduction fields help text
- HTML help text aren't escaped in the template

# Conflicts:
#	src/Module/Notifications/Introductions.php
2020-11-16 18:21:11 -05:00
ba0d3b2435
Merge pull request #9537 from annando/item-lock
Fallback to database lock if locking fails
2020-11-16 16:05:24 -05:00
deb6b7a7c3 Fallback to database lock if locking fails 2020-11-16 19:46:20 +00:00
a69c98e32f
Merge pull request #9535 from annando/ap-relay
Relay code reworked to support AP delivery
2020-11-15 20:27:08 -05:00
0384bf3e76 Relay code reworked to support AP delivery 2020-11-15 23:28:05 +00:00
Michael Vogel
42be636118
Merge pull request #9515 from MrPetovan/task/9464-block-replies
Reject replies when author is blocked by thread owner
2020-11-15 18:44:48 +01:00
dbb33399bc Prevent image descriptions from being replaced by local smilies
- AP-received emojis have their code in the image description
2020-11-15 00:12:26 -05:00
b5d3fcb8d4 Move top-level permission check outside of Model\Item::getTopLevelParentData
- It wasn't checked when the direct parent was also the top-level parent
2020-11-14 10:11:26 -05:00
cb963a3259 Retrieve local top level parent item separately to check permissions in Model\Item::getTopLevelParentData 2020-11-14 10:11:26 -05:00
2e7c505ac0 Revert wrong item.thr-parent field usage in Protocol\OStatus 2020-11-14 10:08:52 -05:00
042f6b98ac Remove unnecessary data array assignment in Protocol\Feed 2020-11-14 10:08:51 -05:00
5ce8cc24de Clarify parameter type in DFRN::mail 2020-11-14 10:08:51 -05:00
ff66633a44 Remove references to item.parent-uri in Worker\OnePoll 2020-11-14 10:08:51 -05:00
a9d114316d Ensure the parent field isn't set during Item insertion
- Avoid a database error if a null value is provided
2020-11-14 10:08:51 -05:00
d3708cf1c2 Fix wrong variable use in Model\Item::getTopLevelParent
- It was preventing items at levels 3 and beyond to be inserted
- Logging for missing top level parent has been bumped to notice
2020-11-14 10:08:51 -05:00
355cd401ae Replace uri fields conditions by gravity condition in Model\Item::insert 2020-11-14 10:08:51 -05:00
ffc364f2a4 Reject replies when author is blocked by thread owner in Model\Item::insert
- Move user-level item permission to Model\Item::isAllowedByUser
- Add user-level check for comments on top-level item
2020-11-14 10:08:50 -05:00
0f2a5daf09 Replace confusing uses of item.parent-uri with expected item.thr-parent 2020-11-14 10:08:50 -05:00
0c3a5c815e Remove obsolete references to item.parent-uri 2020-11-14 10:08:50 -05:00
d7e1ce47bb Use item.thr-parent as expected in Model\Item::insert()
- Rework Model\Item::getTopLevelParent
- Backward compatibility with item.parent-uri is ensured
2020-11-14 10:08:50 -05:00
490ce976c1
Merge pull request #9531 from annando/fatal
Check for empty body to prevent a fatal error
2020-11-12 13:41:26 -05:00
ae363b74ad Check for empty body to prevent a fatal error 2020-11-12 16:52:55 +00:00
6dee10f340
Merge pull request #9530 from annando/fatal
Fix fatal errors
2020-11-12 07:57:53 -05:00
36c65643fb Fix fatal errors 2020-11-12 05:17:48 +00:00
Michael Vogel
acae3df0a2
Merge pull request #9526 from MrPetovan/bug/9525-mastodon-emojis-tag
Restore expected implementation of JsonLD::fetchElementArray
2020-11-12 05:47:46 +01:00
a8f16788f4 Prevent multiple replacements for the same emoji in Protocol\ActivityPub\Processor::replaceEmojis 2020-11-11 18:28:26 -05:00
42db861759
Merge pull request #9527 from annando/fetch-object-by-url
Fix: Fetch object by URL
2020-11-11 13:14:20 -05:00
ba38ab2c55 Fix: Fetch object by URL 2020-11-11 17:55:33 +00:00
fa003eaa84 Fix expected implementation of JsonLD::fetchElementArray
- Added expected field value matching
2020-11-11 11:19:08 -05:00
Michael Vogel
61dcd62921
Merge pull request #9522 from MrPetovan/bug/ap-blocked-followers
Prevent ActivityPub message transmission to blocked followers
2020-11-11 15:28:04 +01:00
0de8319c15 Filter blocked contacts out from Protocol\ActivityPub\Transmitter::getContacts 2020-11-11 09:18:51 -05:00
4fce6a919f Suppress notice when network page is empty 2020-11-11 03:05:12 -05:00
6b8c8b03c6 Prevent ActivityPub message transmission to blocked followers 2020-11-11 02:52:23 -05:00
Michael Vogel
7765bd8e43
Merge pull request #9512 from MrPetovan/bug/9501-admin-users-fixes
[frio] Improve admin user list display
2020-11-10 07:07:59 +01:00
b1bc8ebbfa
Merge pull request #9517 from annando/no-duplicated
Improve duplicate check
2020-11-09 16:00:52 -05:00
c4f1719e8d Improve duplicate check 2020-11-09 20:29:42 +00:00
8fe5da930a Only set the current notify as seen when user enabled detailed notifications 2020-11-09 11:41:21 -05:00
a35707ec8f Improve admin user field is_deletable to check user.account_removed 2020-11-09 10:08:33 -05:00
7debe1e999 [AP] Use contact.alias if it exists instead of contact.url for mention links
- Make mentions links handled by Mastodon for logged in users
2020-11-08 23:32:02 -05:00
edd439cfab Simplify code in Content\Text\BBCode::convert
- Use performWithEscapedTags instead of custom solution
2020-11-08 23:25:46 -05:00
ae00111f5b Fix redirect/form paths in Module\Admin\Users\Index|Active 2020-11-08 20:09:10 -05:00
ecb0c46323 Normalize mention formatting for AP 2020-11-08 14:21:20 -05:00
4b090c2c08 Never mention yourself in AP messages 2020-11-08 14:21:08 -05:00
388c0b69d6 Split admin/users into 6 separate modules
- They now feature working pagination
2020-11-08 12:53:12 -05:00
213716d44c Remove unused code in Module\Register 2020-11-08 12:53:12 -05:00
126ef0ae82 [frio] Add link to settings in account delegation page 2020-11-08 12:53:12 -05:00
ffb4292b0b Improve accuracy of User::getList with type = blocked
- user.blocked is used for pending registrations as well
2020-11-08 12:53:12 -05:00
498dda7999 Fix parser issues when a video is linked without a matching extension 2020-11-08 09:24:01 +00:00
eb8caaa5e7 Restore the connection check 2020-11-07 11:44:39 +00:00
8906615b2c Test if PDO doesn't work on the tests 2020-11-07 10:27:22 +00:00
84924d1c05 Test the tes 2020-11-07 10:12:31 +00:00
d6a1a836f1 Simplified connection test 2020-11-07 09:58:20 +00:00
3a5cdecb62 New function to fetch the database driver 2020-11-07 09:02:02 +00:00
43749c3069 The "attach" field is now deprecated 2020-11-07 08:22:59 +00:00
d383f49f1e The "[attach]" field is replaced by the "post-media" table 2020-11-06 04:14:29 +00:00
bb99b0bebe Allow models extending BaseModel to have an id equal to 0 2020-11-05 10:03:40 -05:00
c9c3d022bd
Merge pull request #9492 from annando/fix-fatal
Handle fatal error when attachment url is null
2020-11-04 09:56:53 -05:00
4e65b54b60
Merge pull request #9490 from annando/forum-fix
Fix: Posts sent to forums had been rejected
2020-11-04 09:56:20 -05:00
49fee4096a Handle fatal error when attachment url is null 2020-11-04 13:14:33 +00:00
29ec0bb98d Replaced debug log 2020-11-04 13:05:07 +00:00
e5704eb05a Fix: Posts sent to forums had been rejected 2020-11-04 08:57:21 +00:00
Michael Vogel
bf50f80399 Fix fatal error "Argument 2 passed to Friendica\Model\Post\Media::getAttachElement() must be of the type int, string given" 2020-11-04 07:58:04 +01:00
65b07aead4 Indention, documentation 2020-11-03 20:30:59 +00:00
4965d6aa54 The profile page does now shows reshared items 2020-11-03 19:24:47 +00:00
1e1d7a4411 Ensure we provide a mediaType string to Post\Media::getAttachElement
- Address https://github.com/friendica/friendica/issues/9250#issuecomment-720101289
2020-11-02 00:23:08 -05:00
ba4685dfb1 API: Support for reshared items 2020-11-01 11:01:57 +00:00
c030275815 API: accounts and trends 2020-10-31 22:32:26 +00:00
752f5b09d7 Use the raw body if not null 2020-10-31 16:32:41 +00:00
e6030e5f82 API: Media attachments are now supported 2020-10-31 16:10:27 +00:00
42d246ef73 API: Media attachments are now supported 2020-10-31 16:09:27 +00:00
6b12ef14f5 Fixed spelling 2020-10-31 14:09:44 +00:00
8485c8c357 The post-media table now works with the "attach" field as well 2020-10-31 13:26:08 +00:00
db8be13bbf Fix order on network page 2020-10-30 22:13:14 +00:00
5956de645d Improve expiry query 2020-10-30 20:26:16 +00:00
da370c44ba Added lock for contacts, improved logging 2020-10-30 17:26:12 +00:00
930897046d Merge remote-tracking branch 'upstream/develop' into item-lock 2020-10-29 21:07:24 +00:00
46bd1704df Fix notice "Undefined index: network" and warning "strpos(): Empty needle" 2020-10-29 13:28:27 +00:00
56fe1400a7 Next renamed function 2020-10-29 09:03:06 +00:00
e3df7eb131 Superfluous to-do removed 2020-10-29 08:50:35 +00:00
5ac73a847d Functions renamed 2020-10-29 08:48:08 +00:00
e548d647aa New table for attached media files 2020-10-29 05:20:26 +00:00
017bdd3fbb
Merge pull request #9460 from annando/issue-9457
Issue 9457: Fix network order for starred and mention
2020-10-27 11:25:16 +01:00
a012234d82 Publish the provider fields in the API 2020-10-26 19:40:09 +00:00
2f3918c3a3 Issue 9457: Fix network order for starred and mention 2020-10-26 06:54:10 +00:00
44a4b66539 Improved self contact detection 2020-10-25 20:40:25 +00:00
d8d96e6e61 Display the user fields for the admin account 2020-10-25 20:32:45 +00:00
319ceeda3b Publish the profile fields 2020-10-25 18:21:18 +00:00
463f8ee3f3 Use lowercase for tags 2020-10-25 17:59:28 +00:00
825189e8e9 Don't publish some fields 2020-10-25 17:42:42 +00:00
72efcc8169 "locked" is boolean 2020-10-25 16:59:38 +00:00
13b14bff91 Return 'null' on empty card 2020-10-25 16:55:05 +00:00
efcd76d3a7 Spaces to tabs 2020-10-25 16:26:47 +00:00
a643888aeb More data for the Mastodon status class 2020-10-25 16:13:31 +00:00
d9452588bd Avoid deleting newly create item-uri entries 2020-10-25 07:41:01 +00:00
59cb53b011
Merge pull request #9455 from annando/remote-self
Move "remote self" to the contact settings
2020-10-24 18:15:02 -04:00
89509f02e4 Move "remote self" to the contact settings 2020-10-24 21:42:49 +00:00
d639912f38 Disable the "proc_open" option when it isn't available 2020-10-24 19:33:38 +00:00
fd0e5cfe48 Added logging for executing child processes 2020-10-24 18:40:15 +00:00
8bd45ab857 "commented" is the default 2020-10-24 13:44:31 +00:00
adb660f1ad Issue 9451: We now do store the tab in a config again 2020-10-24 13:11:44 +00:00
58383f38d7 Alternative item insert lock mechanism 2020-10-24 13:09:35 +00:00
592ac53ffc Worker priority / no shadow worker 2020-10-24 08:05:03 +00:00
f405336680 Avoid duplicate item entries 2020-10-23 19:10:17 +00:00
Philipp
74305b3dc8
Merge pull request #9441 from annando/fatal
Fix Fatal error
2020-10-20 19:33:39 +02:00
c9d79040cb Fixes notice: Undefined index: nobody in /src/Util/HTTPSignature.php on line 450 2020-10-20 15:19:06 +00:00
097e3d6dcc Fix Fatal error: Uncaught TypeError: Argument 1 passed to Friendica\Model\Contact::getByURL() must be of the type string, null given 2020-10-20 15:15:33 +00:00
4719af6724
Merge pull request #9440 from annando/one-click-follow
Follow/Unfollow contact with a single click
2020-10-20 11:09:56 -04:00
33575a94fa Follow/Unfollow contact with a single click 2020-10-20 03:49:58 +00:00
feabf80476
Merge pull request #9437 from nupplaphil/task/httprequest_head
Add HTTPRequest::head() function
2020-10-19 08:36:00 -04:00
5232a8583f
Merge pull request #9436 from nupplaphil/task/test_notices
Fix notices/deprecation notes/wrong calls in "test" directory
2020-10-19 07:26:16 -04:00
335cd76baf
Merge pull request #9431 from annando/network-order
Network: Fix continuous load issues
2020-10-19 07:23:22 -04:00
d524a9569f
lower loglevel 2020-10-18 22:32:36 +02:00
a74d88c4ee
Remove 'headers' option occurrences and add a warning if used. 2020-10-18 22:31:26 +02:00
c19f1a83ce
Remove option 'novalidate' flag from HTTPRequest options 2020-10-18 22:23:07 +02:00
54d78f9ce1
Removed completely un-used 'http_auth' option from HTTPRequest 2020-10-18 22:19:03 +02:00
61da51c2d5
Add HTTPRequest::head() function 2020-10-18 22:15:53 +02:00
a6fc9cd32e
Remove $binary flag for HTTPRequest::get(), HTTPRequest::fetch(), HTTPRequest::fetchAll() (deprecated since PHP 5.1.3) 2020-10-18 20:56:31 +02:00
d55ecb9288
Fix a lot of notices/warnings/deprecation notes in the test directory 2020-10-18 20:52:27 +02:00
90b5421c01 Use $get 2020-10-18 04:05:52 +00:00
Michael Vogel
7db4fa6bf4
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-10-17 21:24:51 +02:00
14274bc204 Store the selected network tab in a session variable 2020-10-17 18:52:05 +00:00
009bf0d3ec Merge remote-tracking branch 'upstream/develop' into dbclean-limit 2020-10-17 14:10:02 +00:00
Michael Vogel
2c0db7546b
Update src/Core/Worker.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-10-17 15:54:52 +02:00
7efd01880c Define a maintenance window 2020-10-17 12:39:42 +00:00
5a685427ac Post expiry: Limit for deletions 2020-10-17 08:16:17 +00:00
e8679a3a13 Fix DB Error "Column 'uri' in where clause is ambiguous" 2020-10-17 07:48:18 +00:00
a24ae975a9 Network: Fix continuous load issues 2020-10-17 07:31:03 +00:00
06e3294415 Centralize routes file existence check in App\Router 2020-10-15 21:45:51 -04:00
df23690a93 Add routes file recompute on last modification time change 2020-10-15 11:45:15 -04:00
472cc10ac5
Merge pull request #9424 from annando/no-dbclean
Replace "dbclean" with new expiry functionality
2020-10-15 10:33:10 -04:00
2db7a4971c Count removed, added logging for iten uri 2020-10-15 09:42:18 +00:00
53a9c65daa Only set values if the uri isn't empty 2020-10-15 07:40:24 +00:00
9704a9bf25 Move the repair functionality to the daily cron 2020-10-15 07:34:21 +00:00
84b6c18b94 Replace "dbclean" with new expiry functionality 2020-10-15 06:02:17 +00:00
5abe069cba Remove Widget::accounts in favor of Widget::accounttypes 2020-10-13 22:30:40 -04:00
4d15cc01e2 Move network module to src/
- Update ForumManager to use a base URL
- Split network module into Conversation\Network and Search\Filed modules
- Implement boundaries pager in network module
- Allow no selection in filter widgets
2020-10-13 07:52:13 -04:00
9537a6d0f7 Remove unused App->force_max_items property 2020-10-13 07:52:13 -04:00
4427876c05 Implement correct behavior for min_id in boundary pagination
- The previous behavior of since_id systematically showed the most recent results
2020-10-13 00:11:39 -04:00
Michael Vogel
4f6bf9e518
Update src/Object/Post.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-10-12 03:58:56 +02:00
a173bf8eab Diaspora: Native reshares only work with toplevel posts 2020-10-11 21:45:49 +00:00
dbdc8c91f6 Diaspora announce / Renaming share buttons 2020-10-11 19:58:28 +00:00
f3fd99da60 Don't change resharer when resharing 2020-10-11 17:37:04 +00:00
7c5aa0bbf1 "announce" is activated for Twitter as well 2020-10-11 12:27:19 +00:00
d3e19bc880 Support for real reshares 2020-10-11 08:49:47 +00:00
e3cf708dd8
Merge pull request #9401 from annando/accounttype
Filter for account type for contacts
2020-10-10 07:16:32 -04:00
b3e14fd07d Only allow editing of mail/feed contact details 2020-10-10 10:06:34 +00:00
2d4a3f482b Use new function for validity check 2020-10-10 07:14:43 +00:00
35d8b078ce Renamed "Accounts" to "Account Types" 2020-10-10 07:14:18 +00:00
4b9cbac23e Filter for account type for contacts 2020-10-09 19:08:50 +00:00
ae6b380362
Merge pull request #9373 from nupplaphil/task/server_env
Introduce possibility for mapping $_SERVER variables to config-cache values
2020-10-08 15:00:31 -04:00
00974324fe Don't show failed contacts 2020-10-07 20:06:15 +00:00
d785af23c1 Display number of group members in contact widget 2020-10-07 06:19:09 +00:00
b63d037967
Merge pull request #9380 from annando/Improved-language-detection/display
Display language name / only search for available languages
2020-10-07 06:46:01 +02:00
bda87e6536 Display language name / only search for available languages 2020-10-07 04:15:02 +00:00
a79f750a9e Fix refresh after comment/like 2020-10-07 04:01:52 +00:00
bb676f780c Changed documentation 2020-10-06 20:36:57 +00:00
5580b148a6 Added description 2020-10-06 19:51:51 +00:00
Philipp
2a464a156f
Update src/Database/Database.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-10-06 20:55:36 +02:00
5998c3995e Issue-9358 (now for real) commenting and updating on contact now work 2020-10-06 18:47:23 +00:00
d39ee428f0
Introduce "static/env.config.php" for environment variable mapping to config cache entries
- Added new database.port config value (used for MYSQL_PORT)
- Removed now obsolete db environment variable functionality
- Added functionality to load env variables (overwrites DB based cached)
2020-10-06 20:43:29 +02:00
3587e89482
Introduce a "DatabaseException" class for fatal exceptions (used in testmode to throw an exception in case of DB errors) 2020-10-06 20:03:38 +02:00
f255749c6a Issue 9358: liking and commenting on the community page now gives a feedback 2020-10-06 05:18:54 +00:00
9954bf8adf
Merge pull request #9365 from annando/better-plaintext
Improve plaintext generation for language detection
2020-10-05 23:11:42 -04:00
Michael Vogel
20652870b6
Update src/Content/Text/BBCode.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-10-06 04:55:28 +02:00
860a25eb38
Merge pull request #9368 from annando/update-commented
Update the "commented" field only on several verbs
2020-10-05 16:12:30 -04:00
77fcdede9b Fix tests 2020-10-05 18:11:05 +00:00
79af93405b Update the "commented" field only on several verbs 2020-10-05 17:57:24 +00:00
6c3ffb75a6 Issue 9366: filter account types on the network page 2020-10-05 16:48:28 +00:00
Michael Vogel
397f239abb
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2020-10-05 17:40:06 +02:00
16224a7001 Improve plaintext generation for language detection 2020-10-05 12:50:18 +00:00
f096b8c879
Merge pull request #9362 from annando/post-update-term
Postupdate: Check for existence of the "term" table
2020-10-05 06:35:47 +02:00
6778d4f7ce
Merge pull request #9364 from annando/issue-9363
Issue 9363: Display the latest post update version
2020-10-05 06:34:46 +02:00
cb5a9ae286 Issue 9363: Display the latest post update version 2020-10-04 20:46:42 +00:00