* Rewrite:
- stopped using deprecated NETWORK_* constants, now Protocol::* should be used
- still left them intact for slow/lazy developers ...
* Removed deprecated NETWORK_* constants as per code reviewer's request.
* And again notices
* Notices in the directory
* Much more places
* Fix some double $
* Notice in ping
* Missing field
* Fix: We now remove deleted users from the directory
* Some more stuff
* Notices when removing users
* Added logging
* More logging
* Two more
* Rewrite to Proxy class:
- introduced new Friendica\Network\Proxy class for in exchange of proxy_*()
functions
- moved also all PROXY_* constants there as Proxy::*
- removed now no longer needed mod/proxy.php loading as composer's auto-load
will do this for us
- renamed those proxy_*() functions to better names:
+ proxy_init() -> Proxy::init() (public)
+ proxy_url() -> Proxy::proxifyUrl() (public)
+ proxy_parse_html() -> Proxy::proxifyHtml() (public)
+ proxy_is_local_image() -> Proxy::isLocalImage() (private)
+ proxy_parse_query() -> Proxy::parseQuery() (private)
+ proxy_img_cb() -> Proxy::replaceUrl() (private)
* Ops, need to set $a here ...
* CR request:
- moved Proxy class to Friendica\Module
- extended BaseModule
* Ops, no need for own instance of $a when self::getApp() is around.
* Proxy-rewrite:
- proxy_url() and proxy_parse_html() are both non-module functions (now
methods)
- so they must be splitted into a seperate class
- also the SIZE_* and DEFAULT_TIME constants are both not relevant to module
* No instances from utility classes
* Fixed error:
- proxify*() is now located in `Friendica\Util\ProxyUtils`
* Moved back to original place, ops? How did they move here? Well, it was not
intended by me.
* Removed duplicate (left-over from split) constants and static array. Thank to
MrPetovan finding it.
* Renamed ProxyUtils -> Proxy and aliased it back to ProxyUtils.
* Fixes for E_NOTICE in workqueue:
- introduced class `Friendica\Util\Arrays` which will hold static methods for
handling arrays that cannot be done with PHP's functions, like implode() on
multi-dimensional arrays
- rewrote old-school for() loop to foreach()
* Added intial unit test with some tests on empty delimiters and/or sinle and
multi-dim array.
* Added test for for 3-dimensional arrays, thanks to nupplaphil's feedback.
* Some more notices
* Fixed nasty to find notice in DFRN and OStatus
* And more notices ...
* Yeah, some removed notices ... again ...
* Fixing bad SQL query
* Rewrites:
- moved PAGE_* to Friendica\Model\Profile class
* Fixed more rewrites from plain (global namespace) PAGE_* to Friendica\Models\Profile class
* CR request:
- moved all PAGE_* constants to Friendica\Model\Contact class
- fixed all references of both classes
* CR request:
- moved ACCOUNT_TYPE_* constants from boot.php to Contact::ACCOUNT_TYPE_*
* Just copy-pasted this code from boot.php, needs to be changed to `const ACCOUNT_TYPE_FOO = x;`
* Ops, melting brain cells here ... :-/
* The permission set is now used for item permissions
* Check for allow_cid, ... is superfluous. Checking for "private" is enough
* We query the permissionset
* Permissions are displayed correctly
* Changed index
* We don't store the permissions in the item table anymore
* Permission fields are now deprecated
* Reversed ...
* Fixes/rewrites:
- use empty()/isset() instead of deprecated x()
- merged 2 nested if() blocks into one
- avoided nested if() block inside else block by rewriting it to elseif()
- $contact_id is an integer, let's test on > 0 here
- added a lot spaces and some empty lines for better readability
* CR request:
- removed stray spaces
- added some where they improve readability
* Fixes:
- got rid of x() in whole mod/item.php file
- added missing 'prv' and 'forum' columns, maybe one day, let's rewrite this
again. it is kinda a maintenance nightmare, keeping up with column renames and
such. Well, for now it should be okay.
* Should be DBA::isResult()
* Added missing columns 'wall' and 'post-type'.
* Convention:
- curly brace after a a method/function declaration belongs to next line
- added space for better readability
- fixed E_NOTICE about missing array element "page-flags-raw" (should be
"page_flags_raw"?)
- same with account-type-raw -> account_type_raw
- added spaces to nicely indent code
* Prevents 4 E_NOTICEs when POST fields are not set.
* Don't use x().
* Replaced usage of x() which is deprecated with !isset().
* Use empty() according to MrPetovan
* "normal" is an uncommon logger level:
- changed LOGGER_NORMAL -> LOGGER_INFO
- added LOGGER_WARNING (a common logger level)
* Used constants instead of values (MrPetovan)
- added internal TODO to decide about is_result() usage
- removed semicolon (not needed here) from SQL query
- added empty line
Signed-off-by: Roland Häder <roland@mxchange.org>
* "post-type" replaces "bookmark" and "type"
* Removed some more type
* Added index to permission set
* The permission set is now stored
* The permission set is now removed upon expiry
* Post update now stores the permission set
* New file
* Permissions are now sorted
* Changed documentation
- fixed E_NOTICE in mod/follow.php
- fixed 2 E_NOTICE in src/Protocol/Diaspora.php
- added more type-hints for `array` type where known
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixed E_NOTICE when no 'term' was provided, maybe better encapsulate this whole
$_GET, $_POST and $_SESSION thing into a `Request` class?
Signed-off-by: Roland Häder <roland@mxchange.org>
* Rewrote to recommendation by @MrPetovan which results in really nicer code.
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixes applied:
- `if (is_array($some_array))` is better code style than `if ($some_array)` as
the `if()` block really needs an array to be found
- same with `if ($some_id)`, maybe `if ($some_id > 0)` is a more proper check
- added missing field 'emailcc' to Item::ITEM_FIELDLIST
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixes E_NOTICE of missing variable (PHP's lazyness again).
Signed-off-by: Roland Häder <roland@mxchange.org>
* Use !empty() to avoid accessing empty array.
Signed-off-by: Roland Häder <roland@mxchange.org>
- Remove obsolete file-only config list
- Fix heading level
- Add transition instruction for $lang
- Add reference to config.ini.php, settings.ini.php and addon.ini.php
- Add link to help page in admin warning about legacy config file
- Fix Notice messages in Core\Install and Database\DBStructure
- Move local config file template from htconfig.tpl to local.ini.tpl
- Remove htconfig.php
* Use "LEFT JOIN" to always fetch the item. Needed for update routines.
* New conversion routine that now covers every item
* Post update is now activated
* We now use a hash based upon RIPEMD-320 for content and activity
* The hash doesn't contain the plink anymore
* Legacy item fields are now "null"able
* New hash function for a server unique item hash
* Introduction of the legacy mode (usage of old item fields)
* Code simplification
* We don't need the "uri" fields anymore in item-activity and item-content
* Use the "created" and not the "received" date for the hash
* Avoiding several notices
* Some more warnings removed
* Improved uri-hash / Likes on Diaspora are now getting a creation date
* Corrected the post update version
* Ensure an unique uri-hash
* Don't delete orhaned item data at the moment
* Partly reworked, due to strange behaviour
* Some more parts reworked
* Using the uri currently seems to be more reliable
* Using the uri here as well
* Use the hash values again
* Grouped item fields in different categories
* Notices again
* use the gravity (we always should)
* Added hint for disabled post updates
* Notices ...
* Issue #5337: Personal notes are displayed again
* Use the gravity again
* Added Worker queue page
* Added worker queue template
* Added translation strings
* Added en-US translation
* #TGWHT: Thank god we have Typo
* Where donkey == true
* Added in to menu correctly
* Updated link in summary page
* Updated link on summary page for frio theme
* Updated q() to dba::select()
* Revert "Added translation strings"
This reverts commit f1f3694a2412f69c39559650759b6483013f0f17.
* Revert "Added en-US translation"
This reverts commit 61777489e3add56e81c4f976599d8a2e025265cb.
* Fixed http://github to https://github
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixes for #4965:
- updated messages.po file
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixed E_NOTICE where isset()/empty() was absent.
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixed missing variable $sql_order causing E_NOTICE.
Signed-off-by: Roland Häder <roland@mxchange.org>
* Continued:
- added array type-hint where known (some)
Signed-off-by: Roland Häder <roland@mxchange.org>
* Fixes:
- in Profile::load() $user is now only one-dimensional
- $a->get_hostname is no property, it is a method
Signed-off-by: Roland Häder <roland@mxchange.org>
* reverted changes that are unintended
Signed-off-by: Roland Häder <roland@mxchange.org>
* Continued:
- removed leading \ (uncommon, okay)
- removed entire if() block (CR by Hypolite)
Signed-off-by: Roland Häder <roland@mxchange.org>
* Removed if() block
Signed-off-by: Roland Häder <roland@mxchange.org>
* tinymce is not used anymore, we can delete the cuson CSS file
* mv the plugins_details template to addon_details
* renamed template called from admin panel
* some CSS classes that should be addon where still plugin
* Insert a warning into the generated quattro CSS files
* Some more warnings removed
* Even more warnings ...
* Will it ever end? ;-)
* Avoid warning in dbstructure
* Origin and OStatus ...
* There are more warnings solved ... yeah!
* And again ...
* We are not done yet
* And more ...
* And some new places ...
* And more in the feeds
* Avoid some more
* And some backend stuff
* Notifications cleared
* Some more stuff
* and again ...
* It's getting fewer ...
* Some warnings had been hidden in the notifications
* Fix the fix
* And another missing one ...
* We need the owner here, not the user
* Forgotten user
* And more ...
* And some more warnings disappeared ...
* Some more frontend warnings
* Some backend warnings removed
* Fixed sidebar for "vier"
* And more ...
* Some more ...
* And something for "remote self"
* Am I stuck in an endless loop?
* Fix: Clear tag and file field on update
* Preset page content
* Improve group-editing and edit-navigation.
Use icons next to groups and header for navigation to editing groups and adding new groups.
Also use icon from group-sidebar for editing groups.
* Unify look&feel of contact search bars.
* Remove nogroup page and replace with /group/none.
* Make sure proper items are selected in aside.
* Use icon instead of link for 'View Contacs' on profile page.
* Fix none-working /group/none.
* Fix highlighting for everyone in group aside.
* Move new member tips to navigation bar.
The link looks so forlorn when its just somewhere in there. Put it in the nav bar.
* Style new member hints link propery.
* Make changes requested by @MrPetovan.
- removed/fixed whitespaces and mixture of spaces/tabs (some)
- added new-line character at end of files (POSIX-compilant)
- reverted some code which I had messed up (compared to upstream/develop)
- removed duplicate dba::update() invocation in src/Protocol/DFRN.php
- also removed no longer valid TODO
Signed-off-by: Roland Häder <roland@mxchange.org>
- ./vendor/ is being prepared by executing `utils/composer.phar install`, no
need to have it around
- converted .gitignore to LF line-ending (more common over the whole project)
- no need to have them around ...
Signed-off-by: Roland Häder <roland@mxchange.org>
- The LightOpenId class' constructor now requires the hostname from where the
requested started, added it now
- sometimes need to invoke get_app() as $a was not around
Signed-off-by: Roland Häder <roland@mxchange.org>
- avoided else() block which reduces code complexibility
- used more x()
- added curly braces
- added known type-hints
Signed-off-by: Roland Häder <roland@mxchange.org>
- added missing curly braces (and some absent caused parser errors)
- <include|require>[_once] are keywords, so don't use them as such
- removed/added empty lines
Signed-off-by: Roland Häder <roland@mxchange.org>
When Curl tries to fetch the rewrite test URL and something goes wrong the user
has no clue what was the problem. This problems can include:
- The rewriting not working at all.
- HTTPS redirects do not work.
- Curl does not accept the presented SSL cert.
This commit fixes this by providing the Curl error message to the user to further
debug the problem.
Fixes #3629.~
Themes have to be installed to be usable by the system. This is not done
automatically which lead to the problems with the site when themes where
switched right after the install and before the "Reload themes" button
was pressed in the admin page.
This patch makes sure that the selected them is always installed when
it is selected by the user either in the admin or settings page.
Fixes#4921.
- Added $install_mode in Class App instead
- Extracted the install business logic to a new Class Install
- Replaced all $a->module == 'install' with $a->install_mode
The new member tips link looks very misplaced and forlorn at the current position.
Move it to the tab-bar (in a somewhat crude fashion, but its for 14 days/user only.)
The page /friendica/ contains an Impressum section which is activated with an AddOn.
Add more space after last paragraph of information, before impressum, because site
looks quite cramped otherwise.
Fix part of https://github.com/friendica/friendica/issues/4665
`php [shell file]` does not work, so use `php [php file]` instead.
`php bin/console.php` is more robust than e.g. `bin/console` which does
not work on Windows, or *nix systems without Bash
