Merge pull request #4375 from MrPetovan/task/3878-move-friendica_smarty-to-src

Move include/friendica_smarty to src/

include/text.php

@@ -16,7 +16,6 @@ use Friendica\Model\Profile;
 use Friendica\Model\Term;
 use Friendica\Util\Map;
 
-require_once "include/friendica_smarty.php";
 require_once "mod/proxy.php";
 require_once "include/conversation.php";
 

src/App.php

@@ -288,12 +288,7 @@ class App
 		$this->is_friendica_app = ($_SERVER['HTTP_USER_AGENT'] == 'Apache-HttpClient/UNAVAILABLE (java 1.4)');
 
 		// Register template engines
-		$dc = get_declared_classes();
+		$this->register_template_engine('Friendica\Render\FriendicaSmartyEngine');
-		foreach ($dc as $k) {
-			if (in_array('Friendica\Render\ITemplateEngine', class_implements($k))) {
-				$this->register_template_engine($k);
-			}
-		}
 
 		self::$a = $this;
 	}
@@ -602,7 +597,7 @@ class App
 			$this->template_engines[$name] = $class;
 		} else {
 			echo "template engine <tt>$class</tt> cannot be registered without a name.\n";
-			killme();
+			die();
 		}
 	}
 

src/Render/FriendicaSmarty.php

@@ -1,10 +1,18 @@
 <?php
+/**
+ * @file src/Render/FriendicaSmarty.php
+ */
+namespace Friendica\Render;
 
-use Friendica\Core\Addon;
+use Smarty;
-use Friendica\Render\ITemplateEngine;
 
 define('SMARTY3_TEMPLATE_FOLDER', 'templates');
 
+/**
+ * Description of FriendicaSmarty
+ *
+ * @author benlo
+ */
 class FriendicaSmarty extends Smarty
 {
 	public $filename;
@@ -19,8 +27,10 @@ class FriendicaSmarty extends Smarty
 		// setTemplateDir can be set to an array, which Smarty will parse in order.
 		// The order is thus very important here
 		$template_dirs = ['theme' => "view/theme/$theme/" . SMARTY3_TEMPLATE_FOLDER . "/"];
-		if (x($a->theme_info, "extends"))
+		if (x($a->theme_info, "extends")) {
 			$template_dirs = $template_dirs + ['extends' => "view/theme/" . $a->theme_info["extends"] . "/" . SMARTY3_TEMPLATE_FOLDER . "/"];
+		}
+
 		$template_dirs = $template_dirs + ['base' => "view/" . SMARTY3_TEMPLATE_FOLDER . "/"];
 		$this->setTemplateDir($template_dirs);
 
@@ -44,53 +54,3 @@ class FriendicaSmarty extends Smarty
 	}
 
 }
-
-class FriendicaSmartyEngine implements ITemplateEngine
-{
-	static $name = "smarty3";
-
-	public function __construct()
-	{
-		if (!is_writable('view/smarty3/')) {
-			echo "<b>ERROR:</b> folder <tt>view/smarty3/</tt> must be writable by webserver.";
-			killme();
-		}
-	}
-
-	// ITemplateEngine interface
-	public function replaceMacros($s, $r)
-	{
-		$template = '';
-		if (gettype($s) === 'string') {
-			$template = $s;
-			$s = new FriendicaSmarty();
-		}
-
-		$r['$APP'] = get_app();
-
-		// "middleware": inject variables into templates
-		$arr = [
-			"template" => basename($s->filename),
-			"vars" => $r
-		];
-		Addon::callHooks("template_vars", $arr);
-		$r = $arr['vars'];
-
-		foreach ($r as $key => $value) {
-			if ($key[0] === '$') {
-				$key = substr($key, 1);
-			}
-			$s->assign($key, $value);
-		}
-		return $s->parsed($template);
-	}
-
-	public function getTemplateFile($file, $root = '')
-	{
-		$a = get_app();
-		$template_file = get_template_file($a, SMARTY3_TEMPLATE_FOLDER . '/' . $file, $root);
-		$template = new FriendicaSmarty();
-		$template->filename = $template_file;
-		return $template;
-	}
-}

src/Render/FriendicaSmartyEngine.php

@@ -0,0 +1,59 @@
+<?php
+/**
+ * @file src/Render/FriendicaSmartyEngine.php
+ */
+namespace Friendica\Render;
+
+use Friendica\Core\Addon;
+
+class FriendicaSmartyEngine implements ITemplateEngine
+{
+	static $name = "smarty3";
+
+	public function __construct()
+	{
+		if (!is_writable('view/smarty3/')) {
+			echo "<b>ERROR:</b> folder <tt>view/smarty3/</tt> must be writable by webserver.";
+			killme();
+		}
+	}
+
+	// ITemplateEngine interface
+	public function replaceMacros($s, $r)
+	{
+		$template = '';
+		if (gettype($s) === 'string') {
+			$template = $s;
+			$s = new FriendicaSmarty();
+		}
+
+		$r['$APP'] = get_app();
+
+		// "middleware": inject variables into templates
+		$arr = [
+			"template" => basename($s->filename),
+			"vars" => $r
+		];
+		Addon::callHooks("template_vars", $arr);
+		$r = $arr['vars'];
+
+		foreach ($r as $key => $value) {
+			if ($key[0] === '$') {
+				$key = substr($key, 1);
+			}
+
+			$s->assign($key, $value);
+		}
+		return $s->parsed($template);
+	}
+
+	public function getTemplateFile($file, $root = '')
+	{
+		$a = get_app();
+		$template_file = get_template_file($a, SMARTY3_TEMPLATE_FOLDER . '/' . $file, $root);
+		$template = new FriendicaSmarty();
+		$template->filename = $template_file;
+
+		return $template;
+	}
+}