Merge pull request #6016 from annando/remove-data

Remove items more memory friendly

src/Protocol/ActivityPub/Processor.php

@@ -17,10 +17,7 @@ use Friendica\Core\Config;
 use Friendica\Protocol\ActivityPub;
 
 /**
- * ActivityPub Protocol class
+ * ActivityPub Processor Protocol class
- *
- * To-Do:
- * - Store Diaspora signature
  */
 class Processor
 {

src/Protocol/ActivityPub/Transmitter.php

@@ -39,9 +39,6 @@ require_once 'include/api.php';
  *
  * Complicated object types:
  * - Undo Announce
- *
- * General:
- * - Queueing unsucessful deliveries
  */
 class Transmitter
 {

src/Worker/RemoveContact.php

@@ -7,6 +7,7 @@ namespace Friendica\Worker;
 
 use Friendica\Database\DBA;
 use Friendica\Core\Protocol;
+use Friendica\Model\Item;
 
 require_once 'include/dba.php';
 
@@ -15,12 +16,21 @@ class RemoveContact {
 
 		// Only delete if the contact is to be deleted
 		$condition = ['network' => Protocol::PHANTOM, 'id' => $id];
-		$r = DBA::exists('contact', $condition);
+		$contact = DBA::selectFirst('contact', ['uid'], $condition);
-		if (!DBA::isResult($r)) {
+		if (!DBA::isResult($contact)) {
 			return;
 		}
 
 		// Now we delete the contact and all depending tables
+		$condition = ['uid' => $contact['uid'], 'contact-id' => $id];
+		do {
+			$items = Item::select(['id'], $condition, ['limit' => 100]);
+			while ($item = Item::fetch($items)) {
+				DBA::delete('item', ['id' => $item['id']]);
+			}
+			DBA::close($items);
+		} while (Item::exists($condition));
+
 		DBA::delete('contact', ['id' => $id]);
 	}
 }

src/Worker/RemoveUser.php

@@ -20,6 +20,13 @@ class RemoveUser {
 		}
 
 		// Now we delete all user items
-		Item::delete(['uid' => $uid], PRIORITY_LOW);
+		$condition = ['uid' => $uid, 'deleted' => false];
+		do {
+			$items = Item::select(['id'], $condition, ['limit' => 100]);
+			while ($item = Item::fetch($items)) {
+				Item::deleteById($item['id'], PRIORITY_LOW);
+			}
+			DBA::close($items);
+		} while (Item::exists($condition));
 	}
 }