strk/friendica
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Merge pull request #4221 from annando/oembed-no-title

Browse source 
Better treatment of Oembed detection with no OEmbed data and not title
This commit is contained in:
Hypolite Petovan 2018-01-12 18:39:14 -05:00 committed by GitHub
commit 779f6601f4
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
src/Content/OEmbed.php
View file

@ -202,23 +202,22 @@ class OEmbed
// add link to source if not present in "rich" type
if ($j->type != 'rich' || !strpos($j->html, $embedurl)) {
$ret .= '<h4>';
if (isset($j->title)) {
if (isset($j->provider_name)) {
if (!empty($j->title)) {
if (!empty($j->provider_name)) {
$ret .= $j->provider_name . ": ";
}
$embedlink = (isset($j->title)) ? $j->title : $embedurl;
$ret .= '<a href="' . $embedurl . '" rel="oembed">' . $embedlink . '</a>';
if (isset($j->author_name)) {
$ret .= '<a href="' . $embedurl . '" rel="oembed">' . $j->title . '</a>';
if (!empty($j->author_name)) {
$ret .= ' (' . $j->author_name . ')';
}
} elseif (isset($j->provider_name) || isset($j->author_name)) {
} elseif (!empty($j->provider_name) || !empty($j->author_name)) {
$embedlink = "";
if (isset($j->provider_name)) {
if (!empty($j->provider_name)) {
$embedlink .= $j->provider_name;
}
if (isset($j->author_name)) {
if (!empty($j->author_name)) {
if ($embedlink != "") {
$embedlink .= ": ";
}
@ -230,6 +229,8 @@ class OEmbed
}
$ret .= '<a href="' . $embedurl . '" rel="oembed">' . $embedlink . '</a>';
} else {
$ret .= '<a href="' . $embedurl . '" rel="oembed">' . $embedurl . '</a>';
}
$ret .= "</h4>";
} elseif (!strpos($j->html, $embedurl)) {