More usage of dbm::is_result($r) instead of count($r):
- count() returns very different results and never a boolean (not even false on error condition). - therefore you should NOT use it in boolean expressions. This still *can* be done in PHP because of its lazyness. But it is discouraged if it comes to more clean code. Signed-off-by: Roland Häder <roland@mxchange.org>
This commit is contained in:
parent
293436e5fd
commit
6a8a36f12d
115 changed files with 439 additions and 437 deletions
|
|
@ -14,7 +14,7 @@ function crepair_init(&$a) {
|
|||
intval(local_user()),
|
||||
intval($contact_id)
|
||||
);
|
||||
if(! count($r)) {
|
||||
if(! dbm::is_result($r)) {
|
||||
$contact_id = 0;
|
||||
}
|
||||
}
|
||||
|
|
@ -43,7 +43,7 @@ function crepair_post(&$a) {
|
|||
);
|
||||
}
|
||||
|
||||
if(! count($r))
|
||||
if(! dbm::is_result($r))
|
||||
return;
|
||||
|
||||
$contact = $r[0];
|
||||
|
|
@ -110,7 +110,7 @@ function crepair_content(&$a) {
|
|||
);
|
||||
}
|
||||
|
||||
if(! count($r)) {
|
||||
if(! dbm::is_result($r)) {
|
||||
notice( t('Contact not found.') . EOL);
|
||||
return;
|
||||
}
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue