strk/friendica
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Code standards

Browse source
This commit is contained in:
Michael 2020-05-14 03:48:26 +00:00
parent 04005f2878
commit 3dc231ffd6
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/Model/Item.php
View file

@ -1379,7 +1379,7 @@ class Item
* There is a timing issue here that sometimes creates double postings. * There is a timing issue here that sometimes creates double postings.
* An unique index would help - but the limitations of MySQL (maximum size of index values) prevent this. * An unique index would help - but the limitations of MySQL (maximum size of index values) prevent this.
*/ */
if (($item["uid"] == 0) && self::exists(['uri' => trim($item['uri']), 'uid' => 0])) { if (($item['uid'] == 0) && self::exists(['uri' => trim($item['uri']), 'uid' => 0])) {
Logger::notice('Global item already stored.', ['uri' => $item['uri'], 'network' => $item['network']]); Logger::notice('Global item already stored.', ['uri' => $item['uri'], 'network' => $item['network']]);
return true; return true;
} }
@ -1393,7 +1393,7 @@ class Item
* @param array $item * @param array $item
* @return boolean item is valid * @return boolean item is valid
*/ */
private static function validItem(array $item) private static function isValid(array $item)
{ {
// When there is no content then we don't post it // When there is no content then we don't post it
if ($item['body'].$item['title'] == '') { if ($item['body'].$item['title'] == '') {
@ -1483,7 +1483,7 @@ class Item
} }
/** /**
* Return the id of the givven item array when it had been stored before * Return the id of the given item array if it has been stored before
* *
* @param array $item * @param array $item
* @return integer item id * @return integer item id
@ -1742,7 +1742,7 @@ class Item
// The contact-id should be set before "self::insert" was called - but there seems to be issues sometimes // The contact-id should be set before "self::insert" was called - but there seems to be issues sometimes
$item["contact-id"] = self::contactId($item); $item["contact-id"] = self::contactId($item);
if (!self::validItem($item)) { if (!self::isValid($item)) {
return 0; return 0;
} }