strk/friendica
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Sanitize negative followers count on APContact

Browse source 
Please see
https://github.com/friendica/friendica/issues/9498#issuecomment-818894106
and related discussion regarding this - it appears it's possible for AP
users, maybe just Mastodon users, to have a negative followers count.
This causes fatal errors in Friendica, so I think we should sanitize
this input.
This commit is contained in:
RealKinetix 2021-07-14 10:15:19 -07:00
parent fd37a57678
commit 2ebebe9abc
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/Model/APContact.php
View file

@ -272,6 +272,11 @@ class APContact
if (!empty($apcontact['followers'])) { if (!empty($apcontact['followers'])) {
$followers = ActivityPub::fetchContent($apcontact['followers']); $followers = ActivityPub::fetchContent($apcontact['followers']);
// Mastodon seriously allows for this condition?
// Jul 14 2021 - See https://mastodon.online/@goes11 for a negative followers count
if ($followers['totalItems'] < 0) {
$followers['totalItems'] = 0;
}
if (!empty($followers['totalItems'])) { if (!empty($followers['totalItems'])) {
$apcontact['followers_count'] = $followers['totalItems']; $apcontact['followers_count'] = $followers['totalItems'];
} }