nupplaPhil/friendica
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

More usage of dbm::is_result($r) instead of count($r):

Browse source 
- count() returns very different results and never a boolean (not even false on
  error condition).
- therefore you should NOT use it in boolean expressions. This still *can* be
  done in PHP because of its lazyness. But it is discouraged if it comes to
  more clean code.

Signed-off-by: Roland Häder <roland@mxchange.org>
This commit is contained in:
Roland Häder 2016-12-13 10:44:13 +01:00
commit 6a8a36f12d
115 changed files with 439 additions and 437 deletions
Download patch file Download diff file Expand all files Collapse all files

10
mod/profperm.php
View file

@ -42,7 +42,7 @@ function profperm_content(&$a) {
intval($a->argv[2]),
intval(local_user())
);
if(count($r))
if(dbm::is_result($r))
$change = intval($a->argv[2]);
}
@ -52,7 +52,7 @@ function profperm_content(&$a) {
intval($a->argv[1]),
intval(local_user())
);
if(! count($r)) {
if(! dbm::is_result($r)) {
notice( t('Invalid profile identifier.') . EOL );
return;
}
@ -64,7 +64,7 @@ function profperm_content(&$a) {
);
$ingroup = array();
if(count($r))
if(dbm::is_result($r))
foreach($r as $member)
$ingroup[] = $member['id'];
@ -94,7 +94,7 @@ function profperm_content(&$a) {
$members = $r;
$ingroup = array();
if(count($r))
if(dbm::is_result($r))
foreach($r as $member)
$ingroup[] = $member['id'];
}
@ -138,7 +138,7 @@ function profperm_content(&$a) {
dbesc(NETWORK_DFRN)
);
if(count($r)) {
if(dbm::is_result($r)) {
$textmode = (($switchtotext && (count($r) > $switchtotext)) ? true : false);
foreach($r as $member) {
if(! in_array($member['id'],$ingroup)) {