nupplaPhil/friendica
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

More usage of dbm::is_result($r) instead of count($r):

Browse source 
- count() returns very different results and never a boolean (not even false on
  error condition).
- therefore you should NOT use it in boolean expressions. This still *can* be
  done in PHP because of its lazyness. But it is discouraged if it comes to
  more clean code.

Signed-off-by: Roland Häder <roland@mxchange.org>
This commit is contained in:
Roland Häder 2016-12-13 10:44:13 +01:00
commit 6a8a36f12d
115 changed files with 439 additions and 437 deletions
Download patch file Download diff file Expand all files Collapse all files

10
mod/group.php
View file

@ -43,7 +43,7 @@ function group_post(&$a) {
intval($a->argv[1]),
intval(local_user())
);
if(! count($r)) {
if(! dbm::is_result($r)) {
notice( t('Group not found.') . EOL );
goaway($a->get_baseurl() . '/contacts');
return; // NOTREACHED
@ -107,7 +107,7 @@ function group_content(&$a) {
intval($a->argv[2]),
intval(local_user())
);
if(count($r))
if(dbm::is_result($r))
$result = group_rmv(local_user(),$r[0]['name']);
if($result)
info( t('Group removed.') . EOL);
@ -125,7 +125,7 @@ function group_content(&$a) {
intval($a->argv[2]),
intval(local_user())
);
if(count($r))
if(dbm::is_result($r))
$change = intval($a->argv[2]);
}
@ -136,7 +136,7 @@ function group_content(&$a) {
intval($a->argv[1]),
intval(local_user())
);
if(! count($r)) {
if(! dbm::is_result($r)) {
notice( t('Group not found.') . EOL );
goaway($a->get_baseurl() . '/contacts');
}
@ -209,7 +209,7 @@ function group_content(&$a) {
intval(local_user())
);
if(count($r)) {
if(dbm::is_result($r)) {
$textmode = (($switchtotext && (count($r) > $switchtotext)) ? true : false);
foreach($r as $member) {
if(! in_array($member['id'],$preselected)) {