nupplaPhil/friendica
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

enhance semaphore lock testing

Browse source
This commit is contained in:
Philipp Holzer 2019-08-17 19:38:51 +02:00
parent c803dcb6c5
commit 1237ac1062
No known key found for this signature in database
GPG key ID: D8365C3D36B77D90
1 changed files with 19 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
tests/src/Core/Lock/SemaphoreLockTest.php
View file

@ -22,7 +22,7 @@ class SemaphoreLockTest extends LockTest
$configMock $configMock
->shouldReceive('get') ->shouldReceive('get')
->with('system', 'temppath', NULL, false) ->with('system', 'temppath', NULL, false)
->andReturn('/tmp'); ->andReturn('/tmp/');
$dice->shouldReceive('create')->with(Configuration::class)->andReturn($configMock); $dice->shouldReceive('create')->with(Configuration::class)->andReturn($configMock);
// @todo Because "get_temppath()" is using static methods, we have to initialize the BaseObject // @todo Because "get_temppath()" is using static methods, we have to initialize the BaseObject
@ -43,11 +43,13 @@ class SemaphoreLockTest extends LockTest
} }
/** /**
* Test if semaphore locking works even for * Test if semaphore locking works even when trying to release locks, where the file exists
* but it shouldn't harm locking
*/ */
public function testMissingFileNotOverriding() public function testMissingFileNotOverriding()
{ {
$file = get_temppath() . '/test.sem'; $file = get_temppath() . '/test.sem';
touch($file);
$this->assertTrue(file_exists($file)); $this->assertTrue(file_exists($file));
$this->assertFalse($this->instance->releaseLock('test', false)); $this->assertFalse($this->instance->releaseLock('test', false));
@ -64,9 +66,24 @@ class SemaphoreLockTest extends LockTest
public function testMissingFileOverriding() public function testMissingFileOverriding()
{ {
$file = get_temppath() . '/test.sem'; $file = get_temppath() . '/test.sem';
touch($file);
$this->assertTrue(file_exists($file)); $this->assertTrue(file_exists($file));
$this->assertFalse($this->instance->releaseLock('test', true)); $this->assertFalse($this->instance->releaseLock('test', true));
$this->assertTrue(file_exists($file)); $this->assertTrue(file_exists($file));
} }
/**
* Test acquire lock even the semaphore file exists, but isn't used
*/
public function testOverrideSemFile()
{
$file = get_temppath() . '/test.sem';
touch($file);
$this->assertTrue(file_exists($file));
$this->assertTrue($this->instance->acquireLock('test'));
$this->assertTrue($this->instance->isLocked('test'));
$this->assertTrue($this->instance->releaseLock('test'));
}
} }