Continued:

- used x() to make sure the array key is there, else an E_NOTICE is triggered
- added type-hints where it is safe

Signed-off-by: Roland Häder <roland@mxchange.org>
This commit is contained in:
Roland Häder 2018-05-10 13:19:50 +02:00
parent 17a39340b5
commit e0a07d5f27
No known key found for this signature in database
GPG key ID: B72F8185C6C7BD78
2 changed files with 5 additions and 5 deletions

View file

@ -935,7 +935,7 @@ function api_reformat_xml(&$item, &$key)
* *
* @return string The XML data * @return string The XML data
*/ */
function api_create_xml($data, $root_element) function api_create_xml(array $data, $root_element)
{ {
$childname = key($data); $childname = key($data);
$data2 = array_pop($data); $data2 = array_pop($data);
@ -960,7 +960,7 @@ function api_create_xml($data, $root_element)
$i = 1; $i = 1;
foreach ($data2 as $item) { foreach ($data2 as $item) {
$data4[$i++.":".$childname] = $item; $data4[$i++ . ":" . $childname] = $item;
} }
$data2 = $data4; $data2 = $data4;

View file

@ -1609,16 +1609,16 @@ function sort_thr_commented(array $a, array $b)
} }
function render_location_dummy(array $item) { function render_location_dummy(array $item) {
if ($item['location'] != "") { if (x($item, 'location') && !empty($item['location'])) {
return $item['location']; return $item['location'];
} }
if ($item['coord'] != "") { if (x($item, 'coord') && !empty($item['coord'])) {
return $item['coord']; return $item['coord'];
} }
} }
function get_responses(array $conv_responses, array $response_verbs, $ob, $item) { function get_responses(array $conv_responses, array $response_verbs, $ob, array $item) {
$ret = []; $ret = [];
foreach ($response_verbs as $v) { foreach ($response_verbs as $v) {
$ret[$v] = []; $ret[$v] = [];