mexon/friendica
1
0
Fork 0
Code Pull requests Activity

Update false evaluations

Browse source 
=== false and !== false to is_null where appropriate.
This commit is contained in:
Adam Magness 2017-12-06 14:57:06 -05:00
parent 09d798ba77
commit cadfef63c4
7 changed files with 13 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
boot.php
View file

@ -742,7 +742,7 @@ function run_update_function($x)
// delete the config entry to try again. // delete the config entry to try again.
$t = Config::get('database', 'update_' . $x); $t = Config::get('database', 'update_' . $x);
if ($t !== false) { if (!is_null($t)) {
return false; return false;
} }
Config::set('database', 'update_' . $x, time()); Config::set('database', 'update_' . $x, time());

2
include/nav.php
View file

@ -209,7 +209,7 @@ function nav_info(App $a)
// Provide a banner/logo/whatever // Provide a banner/logo/whatever
$banner = Config::get('system', 'banner'); $banner = Config::get('system', 'banner');
if ($banner === false) { if (is_null($banner)) {
$banner = '<a href="https://friendi.ca"><img id="logo-img" src="images/friendica-32.png" alt="logo" /></a><span id="logo-text"><a href="https://friendi.ca">Friendica</a></span>'; $banner = '<a href="https://friendi.ca"><img id="logo-img" src="images/friendica-32.png" alt="logo" /></a><span id="logo-text"><a href="https://friendi.ca">Friendica</a></span>';
} }

2
include/network.php
View file

@ -126,6 +126,7 @@ function z_fetch_url($url, $binary = false, &$redirects = 0, $opts = array())
if (x($opts, 'timeout')) { if (x($opts, 'timeout')) {
@curl_setopt($ch, CURLOPT_TIMEOUT, $opts['timeout']); @curl_setopt($ch, CURLOPT_TIMEOUT, $opts['timeout']);
} else { } else {
// if Config::get returns null, intval will be 0 which will also evaluate to false
$curl_time = intval(Config::get('system', 'curl_timeout')); $curl_time = intval(Config::get('system', 'curl_timeout'));
@curl_setopt($ch, CURLOPT_TIMEOUT, (($curl_time !== false) ? $curl_time : 60)); @curl_setopt($ch, CURLOPT_TIMEOUT, (($curl_time !== false) ? $curl_time : 60));
} }
@ -302,6 +303,7 @@ function post_url($url, $params, $headers = null, &$redirects = 0, $timeout = 0)
if (intval($timeout)) { if (intval($timeout)) {
curl_setopt($ch, CURLOPT_TIMEOUT, $timeout); curl_setopt($ch, CURLOPT_TIMEOUT, $timeout);
} else { } else {
// if Config::get returns null, intval will be 0 which will also evaluate to false
$curl_time = intval(Config::get('system', 'curl_timeout')); $curl_time = intval(Config::get('system', 'curl_timeout'));
curl_setopt($ch, CURLOPT_TIMEOUT, (($curl_time !== false) ? $curl_time : 60)); curl_setopt($ch, CURLOPT_TIMEOUT, (($curl_time !== false) ? $curl_time : 60));
} }

8
src/Content/Feature.php
View file

@ -23,13 +23,15 @@ class Feature
{ {
$x = Config::get('feature_lock', $feature, false); $x = Config::get('feature_lock', $feature, false);
if ($x === false) { if (is_null($x)) {
$x = PConfig::get($uid, 'feature', $feature, false); $x = PConfig::get($uid, 'feature', $feature, false);
} }
if ($x === false) {
if (is_null($x)) {
$x = Config::get('feature', $feature, false); $x = Config::get('feature', $feature, false);
} }
if ($x === false) {
if (is_null($x)) {
$x = self::getDefault($feature); $x = self::getDefault($feature);
} }

2
src/Network/FKOAuthDataStore.php
View file

@ -171,7 +171,7 @@ class FKOAuthDataStore extends OAuthDataStore
dba::delete('tokens', array('id' => $token->key)); dba::delete('tokens', array('id' => $token->key));
if (!is_null($ret) && $uverifier !== false) { if (!is_null($ret) && !is_null($uverifier)) {
Config::delete("oauth", $verifier); Config::delete("oauth", $verifier);
} }

2
src/Worker/OnePoll.php
View file

@ -92,7 +92,7 @@ Class OnePoll
if ($contact['subhub']) { if ($contact['subhub']) {
$poll_interval = Config::get('system', 'pushpoll_frequency'); $poll_interval = Config::get('system', 'pushpoll_frequency');
$contact['priority'] = (($poll_interval !== false) ? intval($poll_interval) : 3); $contact['priority'] = ((!is_null($poll_interval)) ? intval($poll_interval) : 3);
$hub_update = false; $hub_update = false;
if (datetime_convert('UTC', 'UTC', 'now') > datetime_convert('UTC', 'UTC', $t . " + 1 day")) { if (datetime_convert('UTC', 'UTC', 'now') > datetime_convert('UTC', 'UTC', $t . " + 1 day")) {

4
view/theme/vier/theme.php
View file

@ -110,13 +110,13 @@ EOT;
function get_vier_config($key, $default = false, $admin = false) { function get_vier_config($key, $default = false, $admin = false) {
if (local_user() && !$admin) { if (local_user() && !$admin) {
$result = PConfig::get(local_user(), "vier", $key); $result = PConfig::get(local_user(), "vier", $key);
if ($result !== false) { if (!is_null($result)) {
return $result; return $result;
} }
} }
$result = Config::get("vier", $key); $result = Config::get("vier", $key);
if ($result !== false) { if (!is_null($result)) {
return $result; return $result;
} }