The function to check for maxload and the lockfile is centralized

boot.php

@@ -30,7 +30,7 @@ require_once('include/cache.php');
 require_once('library/Mobile_Detect/Mobile_Detect.php');
 require_once('include/features.php');
 require_once('include/identity.php');
-
+require_once('include/pidfile.php');
 require_once('update.php');
 require_once('include/dbstructure.php');
 
@@ -1098,6 +1098,41 @@ class App {
 		return($this->is_friendica_app);
 	}
 
+	function maxload_reached() {
+
+		$maxsysload = intval(get_config('system', 'maxloadavg'));
+		if ($maxsysload < 1)
+			$maxsysload = 50;
+
+		$load = current_load();
+		if ($load) {
+			if (intval($load) > $maxsysload) {
+				logger('system: load '.$load.' too high.');
+				return true;
+			}
+		}
+		return false;
+	}
+
+	function is_already_running($task, $taskname, $timeout = 540) {
+
+		$lockpath = get_lockpath();
+		if ($lockpath != '') {
+			$pidfile = new pidfile($lockpath, $taskname);
+			if ($pidfile->is_already_running()) {
+				logger("Already running");
+				if ($pidfile->running_time() > $timeout) {
+					$pidfile->kill();
+					logger("killed stale process");
+					// Calling a new instance
+					if ($task != "")
+						proc_run('php', $task);
+				}
+				return true;
+			}
+		}
+		return false;
+	}
 }
 
 /**

include/cron.php

@@ -34,7 +34,6 @@ function cron_run(&$argv, &$argc){
 	require_once('include/Contact.php');
 	require_once('include/email.php');
 	require_once('include/socgraph.php');
-	require_once('include/pidfile.php');
 	require_once('mod/nodeinfo.php');
 
 	load_config('config');
@@ -42,32 +41,10 @@ function cron_run(&$argv, &$argc){
 
 	// Don't check this stuff if the function is called by the poller
 	if (App::callstack() != "poller_run") {
-		$maxsysload = intval(get_config('system','maxloadavg'));
+		if (App::maxload_reached())
-		if($maxsysload < 1)
+			return;
-			$maxsysload = 50;
+		if (App::is_already_running('include/cron.php', 'cron', 540))
-
-		$load = current_load();
-		if($load) {
-			if(intval($load) > $maxsysload) {
-				logger('system: load '.$load.' too high. cron deferred to next scheduled run.');
 			return;
-			}
-		}
-
-		$lockpath = get_lockpath();
-		if ($lockpath != '') {
-			$pidfile = new pidfile($lockpath, 'cron');
-			if($pidfile->is_already_running()) {
-				logger("cron: Already running");
-				if ($pidfile->running_time() > 9*60) {
-					$pidfile->kill();
-					logger("cron: killed stale process");
-					// Calling a new instance
-					proc_run('php','include/cron.php');
-				}
-				exit;
-			}
-		}
 	}
 
 	$last = get_config('system','last_cron');

include/cronhooks.php

@@ -19,39 +19,16 @@ function cronhooks_run(&$argv, &$argc){
 
 	require_once('include/session.php');
 	require_once('include/datetime.php');
-	require_once('include/pidfile.php');
 
 	load_config('config');
 	load_config('system');
 
 	// Don't check this stuff if the function is called by the poller
 	if (App::callstack() != "poller_run") {
-		$maxsysload = intval(get_config('system','maxloadavg'));
+		if (App::maxload_reached())
-		if($maxsysload < 1)
+			return;
-			$maxsysload = 50;
+		if (App::is_already_running('include/cronhooks.php', 'cronhooks', 1140))
-
-		$load = current_load();
-		if($load) {
-			if(intval($load) > $maxsysload) {
-				logger('system: load ' . $load . ' too high. Cronhooks deferred to next scheduled run.');
 			return;
-			}
-		}
-
-		$lockpath = get_lockpath();
-		if ($lockpath != '') {
-			$pidfile = new pidfile($lockpath, 'cronhooks');
-			if($pidfile->is_already_running()) {
-				logger("cronhooks: Already running");
-				if ($pidfile->running_time() > 19*60) {
-					$pidfile->kill();
-					logger("cronhooks: killed stale process");
-					// Calling a new instance
-					proc_run('php','include/cronhooks.php');
-				}
-				exit;
-			}
-		}
 	}
 
 	$last = get_config('system','last_cronhook');

include/delivery.php

@@ -57,17 +57,8 @@ function delivery_run(&$argv, &$argc){
 			continue;
 		}
 
-		$maxsysload = intval(get_config('system','maxloadavg'));
+		if (App::maxload_reached())
-		if($maxsysload < 1)
-			$maxsysload = 50;
-
-		$load = current_load();
-		if($load) {
-			if(intval($load) > $maxsysload) {
-				logger('system: load ' . $load . ' too high. Delivery deferred to next queue run.');
 			return;
-			}
-		}
 
 		// It's ours to deliver. Remove it from the queue.
 

include/discover_poco.php

@@ -20,25 +20,14 @@ function discover_poco_run(&$argv, &$argc){
 
 	require_once('include/session.php');
 	require_once('include/datetime.php');
-	require_once('include/pidfile.php');
 
 	load_config('config');
 	load_config('system');
 
 	// Don't check this stuff if the function is called by the poller
-	if (App::callstack() != "poller_run") {
+	if (App::callstack() != "poller_run")
-		$maxsysload = intval(get_config('system','maxloadavg'));
+		if (App::maxload_reached())
-		if($maxsysload < 1)
-			$maxsysload = 50;
-
-		$load = current_load();
-		if($load) {
-			if(intval($load) > $maxsysload) {
-				logger('system: load '.$load.' too high. discover_poco deferred to next scheduled run.');
 			return;
-			}
-		}
-	}
 
 	if(($argc > 2) && ($argv[1] == "dirsearch")) {
 		$search = urldecode($argv[2]);
@@ -54,23 +43,9 @@ function discover_poco_run(&$argv, &$argc){
 		die("Unknown or missing parameter ".$argv[1]."\n");
 
 	// Don't check this stuff if the function is called by the poller
-	if (App::callstack() != "poller_run") {
+	if (App::callstack() != "poller_run")
-		$lockpath = get_lockpath();
+		if (App::is_already_running('include/discover_poco.php', 'discover_poco'.$mode.urlencode($search), 1140))
-		if ($lockpath != '') {
+			return;
-			$pidfile = new pidfile($lockpath, 'discover_poco'.$mode.urlencode($search));
-			if($pidfile->is_already_running()) {
-				logger("discover_poco: Already running");
-				if ($pidfile->running_time() > 19*60) {
-					$pidfile->kill();
-					logger("discover_poco: killed stale process");
-					// Calling a new instance
-					if ($mode == 0)
-						proc_run('php','include/discover_poco.php');
-				}
-				exit;
-			}
-		}
-	}
 
 	$a->set_baseurl(get_config('system','url'));
 

include/onepoll.php

@@ -31,7 +31,6 @@ function onepoll_run(&$argv, &$argc){
 	require_once('include/Contact.php');
 	require_once('include/email.php');
 	require_once('include/socgraph.php');
-	require_once('include/pidfile.php');
 	require_once('include/queue_fn.php');
 
 	load_config('config');
@@ -61,20 +60,9 @@ function onepoll_run(&$argv, &$argc){
 	}
 
 	// Don't check this stuff if the function is called by the poller
-	if (App::callstack() != "poller_run") {
+	if (App::callstack() != "poller_run")
-		$lockpath = get_lockpath();
+		if (App::is_already_running('', 'onepoll'.$contact_id, 540))
-		if ($lockpath != '') {
+			return;
-			$pidfile = new pidfile($lockpath, 'onepoll'.$contact_id);
-			if ($pidfile->is_already_running()) {
-				logger("onepoll: Already running for contact ".$contact_id);
-				if ($pidfile->running_time() > 9*60) {
-					$pidfile->kill();
-					logger("killed stale process");
-				}
-				exit;
-			}
-		}
-	}
 
 	$d = datetime_convert();
 

include/poller.php

@@ -29,17 +29,8 @@ function poller_run(&$argv, &$argc){
 	if (poller_max_connections_reached())
 		return;
 
-	$load = current_load();
+	if (App::maxload_reached())
-	if($load) {
-		$maxsysload = intval(get_config('system','maxloadavg'));
-		if($maxsysload < 1)
-			$maxsysload = 50;
-
-		if(intval($load) > $maxsysload) {
-			logger('system: load ' . $load . ' too high. poller deferred to next scheduled run.');
 		return;
-		}
-	}
 
 	// Checking the number of workers
 	if (poller_too_much_workers(1)) {

include/pubsubpublish.php

@@ -74,28 +74,14 @@ function pubsubpublish_run(&$argv, &$argc){
 	};
 
 	require_once('include/items.php');
-	require_once('include/pidfile.php');
 
 	load_config('config');
 	load_config('system');
 
 	// Don't check this stuff if the function is called by the poller
-	if (App::callstack() != "poller_run") {
+	if (App::callstack() != "poller_run")
-		$lockpath = get_lockpath();
+		if (App::is_already_running("include/pubsubpublish.php", 'pubsubpublish', 540))
-		if ($lockpath != '') {
-			$pidfile = new pidfile($lockpath, 'pubsubpublish');
-			if($pidfile->is_already_running()) {
-				logger("Already running");
-				if ($pidfile->running_time() > 9*60) {
-					$pidfile->kill();
-					logger("killed stale process");
-					// Calling a new instance
-					proc_run('php',"include/pubsubpublish.php");
-				}
 			return;
-			}
-		}
-	}
 
 	$a->set_baseurl(get_config('system','url'));
 

include/queue.php

@@ -22,29 +22,15 @@ function queue_run(&$argv, &$argc){
 	require_once("include/datetime.php");
 	require_once('include/items.php');
 	require_once('include/bbcode.php');
-	require_once('include/pidfile.php');
 	require_once('include/socgraph.php');
 
 	load_config('config');
 	load_config('system');
 
 	// Don't check this stuff if the function is called by the poller
-	if (App::callstack() != "poller_run") {
+	if (App::callstack() != "poller_run")
-		$lockpath = get_lockpath();
+		if (App::is_already_running('include/queue.php', 'queue', 540))
-		if ($lockpath != '') {
-			$pidfile = new pidfile($lockpath, 'queue');
-			if($pidfile->is_already_running()) {
-				logger("queue: Already running");
-				if ($pidfile->running_time() > 9*60) {
-					$pidfile->kill();
-					logger("queue: killed stale process");
-					// Calling a new instance
-					proc_run('php',"include/queue.php");
-				}
 			return;
-			}
-		}
-	}
 
 	$a->set_baseurl(get_config('system','url'));
 

include/update_gcontact.php

@@ -16,7 +16,6 @@ function update_gcontact_run(&$argv, &$argc){
 		unset($db_host, $db_user, $db_pass, $db_data);
 	};
 
-	require_once('include/pidfile.php');
 	require_once('include/Scrape.php');
 	require_once("include/socgraph.php");
 
@@ -38,20 +37,9 @@ function update_gcontact_run(&$argv, &$argc){
 	}
 
 	// Don't check this stuff if the function is called by the poller
-	if (App::callstack() != "poller_run") {
+	if (App::callstack() != "poller_run")
-		$lockpath = get_lockpath();
+		if (App::is_already_running('', 'update_gcontact'.$contact_id, 540))
-		if ($lockpath != '') {
+			return;
-			$pidfile = new pidfile($lockpath, 'update_gcontact'.$contact_id);
-			if ($pidfile->is_already_running()) {
-				logger("update_gcontact: Already running for contact ".$contact_id);
-				if ($pidfile->running_time() > 9*60) {
-					$pidfile->kill();
-					logger("killed stale process");
-				}
-				exit;
-			}
-		}
-	}
 
 	$r = q("SELECT * FROM `gcontact` WHERE `id` = %d", intval($contact_id));