mexon/friendica
1
0
Fork 0
Code Pull requests Activity

Improve tests :-)

Browse source
This commit is contained in:
Philipp Holzer 2021-10-22 21:54:36 +02:00 committed by Hypolite Petovan
parent 1c100bbac0
commit 6a7cbefaa5
1 changed files with 51 additions and 42 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

93
tests/src/Contact/FriendSuggest/Factory/FriendSuggestTest.php
View file

@ -23,25 +23,32 @@ class FriendSuggestTest extends MockedTest
'note' => 'a common note', 'note' => 'a common note',
'created' => '2021-10-12 12:23:00' 'created' => '2021-10-12 12:23:00'
], ],
'assertion' => [ 'assertion' => new Entity\FriendSuggest(
'uid' => 12, 12,
'cid' => 13, 13,
'name' => 'test', 'test',
'url' => 'https://friendica.local/profile/test', 'https://friendica.local/profile/test',
'request' => 'https://friendica.local/dfrn_request/test', 'https://friendica.local/dfrn_request/test',
'photo' => 'https://friendica.local/photo/profile/test', 'https://friendica.local/photo/profile/test',
'note' => 'a common note', 'a common note',
'created' => new \DateTime('2021-10-12 12:23:00', new \DateTimeZone('UTC')), new \DateTime('2021-10-12 12:23:00', new \DateTimeZone('UTC'))
'id' => null, ),
],
], ],
'minimum' => [ 'minimum' => [
'input' => [ 'input' => [
'id' => 20, 'id' => 20,
], ],
'assertion' => [ 'assertion' => new Entity\FriendSuggest(
'id' => 20, 0,
] 0,
'',
'',
'',
'',
'',
new \DateTime('now', new \DateTimeZone('URC')),
28
),
], ],
'full' => [ 'full' => [
'input' => [ 'input' => [
@ -55,49 +62,49 @@ class FriendSuggestTest extends MockedTest
'created' => '2021-10-12 12:23:00', 'created' => '2021-10-12 12:23:00',
'id' => 666, 'id' => 666,
], ],
'assertion' => [ 'assertion' => new Entity\FriendSuggest(
'uid' => 12, 12,
'cid' => 13, 13,
'name' => 'test', 'test',
'url' => 'https://friendica.local/profile/test', 'https://friendica.local/profile/test',
'request' => 'https://friendica.local/dfrn_request/test', 'https://friendica.local/dfrn_request/test',
'photo' => 'https://friendica.local/photo/profile/test', 'https://friendica.local/photo/profile/test',
'note' => 'a common note', 'a common note',
'created' => new \DateTime('2021-10-12 12:23:00', new \DateTimeZone('UTC')), new \DateTime('2021-10-12 12:23:00', new \DateTimeZone('UTC')),
'id' => 666, 666
], ),
], ],
]; ];
} }
public function assertFriendSuggest(Entity\FriendSuggest $friendSuggest, array $assertion) public function assertFriendSuggest(Entity\FriendSuggest $assertion, Entity\FriendSuggest $friendSuggest)
{ {
self::assertEquals($assertion['id'] ?? null, $friendSuggest->id); self::assertEquals($assertion->id, $friendSuggest->id);
self::assertEquals($assertion['uid'] ?? 0, $friendSuggest->uid); self::assertEquals($assertion->uid, $friendSuggest->uid);
self::assertEquals($assertion['cid'] ?? 0, $friendSuggest->cid); self::assertEquals($assertion->cid, $friendSuggest->cid);
self::assertEquals($assertion['name'] ?? '', $friendSuggest->name); self::assertEquals($assertion->name, $friendSuggest->name);
self::assertEquals($assertion['url'] ?? '', $friendSuggest->url); self::assertEquals($assertion->url, $friendSuggest->url);
self::assertEquals($assertion['request'] ?? '', $friendSuggest->request); self::assertEquals($assertion->request, $friendSuggest->request);
self::assertEquals($assertion['photo'] ?? '', $friendSuggest->photo); self::assertEquals($assertion->photo, $friendSuggest->photo);
self::assertEquals($assertion['note'] ?? '', $friendSuggest->note); self::assertEquals($assertion->note, $friendSuggest->note);
if (empty($assertion['created'])) {
self::assertInstanceOf(\DateTime::class, $friendSuggest->created);
} else {
self::assertEquals($assertion['created'], $friendSuggest->created);
}
} }
public function testCreateNew() public function testCreateNew()
{ {
$factory = new FriendSuggest(new VoidLogger()); $factory = new FriendSuggest(new VoidLogger());
$this->assertFriendSuggest($factory->createNew(12, 13), ['uid' => 12, 'cid' => 13]); $this->assertFriendSuggest(
$factory->createNew(12, 13),
new Entity\FriendSuggest(12, 13, '', '', '', '', '',
new \DateTime('now', new \DateTimeZone('UTC')), null
)
);
} }
/** /**
* @dataProvider dataCreate * @dataProvider dataCreate
*/ */
public function testCreateFromTableRow(array $input, array $assertion) public function testCreateFromTableRow(array $input, Entity\FriendSuggest $assertion)
{ {
$factory = new FriendSuggest(new VoidLogger()); $factory = new FriendSuggest(new VoidLogger());
@ -108,6 +115,8 @@ class FriendSuggestTest extends MockedTest
{ {
$factory = new FriendSuggest(new VoidLogger()); $factory = new FriendSuggest(new VoidLogger());
$this->assertFriendSuggest($factory->createEmpty(66), ['id' => 66]); $this->assertFriendSuggest($factory->createEmpty(66), new Entity\FriendSuggest(0, 0, '', '', '', '', '',
new \DateTime('now', new \DateTimeZone('UTC')), 66
));
} }
} }