friendica/php-json-ld
4
1
Fork 2
Code Issues Pull requests Releases 5 Activity

Provide access to test result via test instead of earl report.

Browse source 
- Reduces memory consumption because global state is serialized
  for every test and the test result is large (do not link it to
  the earl report listener as it is global).
This commit is contained in:
Dave Longley 2013-09-15 16:19:22 -04:00
parent 3f4dc75ac5
commit 907904183d
1 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
test.php
View file

@ -18,6 +18,7 @@ class JsonLdTestCase extends PHPUnit_Framework_TestCase {
public function run(PHPUnit_Framework_TestResult $result = NULL) { public function run(PHPUnit_Framework_TestResult $result = NULL) {
global $EARL; global $EARL;
$EARL->attach($result); $EARL->attach($result);
$this->result = $result;
parent::run($result); parent::run($result);
} }
@ -439,7 +440,7 @@ class EarlReport extends PHPUnit_Util_Printer
implements PHPUnit_Framework_TestListener { implements PHPUnit_Framework_TestListener {
public function __construct() { public function __construct() {
$this->filename = null; $this->filename = null;
$this->result = null; $this->attached = false;
$this->report = (object)array( $this->report = (object)array(
'@context' => (object)array( '@context' => (object)array(
'doap' => 'http://usefulinc.com/ns/doap#', 'doap' => 'http://usefulinc.com/ns/doap#',
@ -487,8 +488,8 @@ class EarlReport extends PHPUnit_Util_Printer
* @param PHPUnit_Framework_Test $result the result to attach to. * @param PHPUnit_Framework_Test $result the result to attach to.
*/ */
public function attach(PHPUnit_Framework_TestResult $result) { public function attach(PHPUnit_Framework_TestResult $result) {
if(!$this->result && $this->filename) { if(!$this->attached && $this->filename) {
$this->result = $result; $this->attached = true;
$result->addListener($this); $result->addListener($this);
} }
} }
@ -539,13 +540,12 @@ class EarlReport extends PHPUnit_Util_Printer
PHPUnit_Framework_Test $test, PHPUnit_Framework_Test $test,
PHPUnit_Framework_AssertionFailedError $e, $time) { PHPUnit_Framework_AssertionFailedError $e, $time) {
$this->addAssertion($test->test, false); $this->addAssertion($test->test, false);
if($this->result->shouldStop()) { if($test->result->shouldStop()) {
printf("\n\nFAILED\n"); printf("\n\nFAILED\n");
printf("Test: %s\n", $test->test->name); printf("Test: %s\n", $test->test->name);
printf("Purpose: %s\n", $test->test->data->purpose); printf("Purpose: %s\n", $test->test->data->purpose);
printf("EXPECTED: %s\n", Util::jsonldEncode($test->test->expected)); printf("EXPECTED: %s\n", Util::jsonldEncode($test->test->expected));
printf("ACTUAL: %s\n", Util::jsonldEncode($test->test->actual)); printf("ACTUAL: %s\n", Util::jsonldEncode($test->test->actual));
exit(0);
} }
} }