friendica/friendica
6
0
Fork 1
mirror of https://github.com/friendica/friendica synced 2024-05-27 22:48:19 +02:00
Code Issues Packages Projects Releases 1 Wiki Activity
36537 commits 2 branches 63 tags 244 MiB
Commit graph

10884 commits

Author SHA1 Message Date
Hank Grabowski 7e91a88d9b Add unsupported Friendica notification types to built query 2023-02-13 17:26:24 -05:00
Michael 8fe6419d39 New class for c2s activities 2023-02-13 21:27:11 +00:00
Hank Grabowski 8bfca6373a Remove extraneous, unused, non-standard 'count' parameter from request list 
- artifact of when I was playing around with the endpoint that somehow
    didn't get deleted when I did the ultimate commit.
 2023-02-13 15:13:17 -05:00
Michael 7b871f3ecd Merge remote-tracking branch 'upstream/develop' into c2s-post 2023-02-13 19:20:18 +00:00
Michael b02e48e9c3 Split C2S activity 2023-02-13 15:32:14 +00:00
Hypolite Petovan b168ff3e17
Merge pull request #12772 from nupplaphil/feat/config_hybrid 
Revert node.config.php into Config table
 2023-02-13 08:16:29 -05:00
Michael a7b3949ca0 Added documentation 2023-02-13 11:57:02 +00:00
Philipp Holzer 3894b6fa41
Fix logic 2023-02-13 11:34:32 +01:00
Michael 2c41ebbfaa passing the return value 2023-02-13 06:27:45 +00:00
Philipp Holzer 2bc9f085df
Add docs 2023-02-12 23:54:11 +01:00
Philipp Holzer 4dc164a5a1
manually check and create the Config table before running the update 2023-02-12 16:44:56 +01:00
Philipp Holzer aeb3c7e96c
don't try to use the Config table if it doesn't exist 2023-02-12 16:23:51 +01:00
Philipp Holzer a9c0636573
remove maybeSerialize (always serialize) 2023-02-12 15:48:41 +01:00
Philipp Holzer 8881882bce
another phpunit optimiziation .. 2023-02-12 15:41:25 +01:00
Michael edb1ce0417 C2S: Posting is now possible 2023-02-12 14:18:03 +00:00
Philipp Holzer 2d090f0d80
adhere php-cs 2023-02-12 13:17:55 +01:00
Philipp Holzer a153c3f594
Fix and adapt tests 2023-02-12 13:09:14 +01:00
Philipp Holzer 23742c22c3
suppress E_WARNING at tests with vfs:// 2023-02-12 11:41:20 +01:00
Philipp Holzer 7895024e75
add license 2023-02-10 14:54:17 +01:00
Philipp Holzer 513ef03421
Revert node.config.php into Config table 2023-02-10 14:06:22 +01:00
Philipp Holzer 6db89adc04
Re-Add Config table 2023-02-10 14:06:22 +01:00
Philipp Holzer 98857f8d7a
Add exception if lock wasn't successful 2023-02-10 14:06:21 +01:00
Michael 6eadbb35dc Redirect AP requests to the root to the system actor 2023-02-10 10:29:35 +00:00
Michael 5fdeed8ed8 C2S: Improve C2S-API, fix inbox endpoint 2023-02-08 20:16:19 +00:00
Hypolite Petovan 7621c8aac5
Merge pull request #12778 from annando/issue-12764 
Issue 12764: Fix photo permissions when posting via web
 2023-02-07 10:15:00 -05:00
Michael 4d4e34dc64 Issue 12764: Fix photo permissions when posting via web 2023-02-07 14:18:01 +00:00
Hypolite Petovan 447709377c Ensure arbitrary HTTPException messages are HTML escaped 
- These messages can include user-supplied strings
 2023-02-04 20:36:33 -05:00
Hypolite Petovan 4e355c0f5e Create specific module to display HTML message when a conversation isn't found in Module\Item\Display 2023-02-04 20:28:04 -05:00
Michael f455f7e7d1 Fixes "Invalid URL for photo" for photos without host 2023-02-04 12:14:40 +00:00
Michael Vogel ac469742b1
Merge pull request #12762 from MrPetovan/bug/warnings 
Ward against potentially missing "platform" array key in Model\GServer::fetchSiteinfo
 2023-02-02 11:54:50 +01:00
Hypolite Petovan a836c5c3f1
Merge pull request #12752 from annando/c2s 
First implementation of ActivityPub C2S
 2023-02-01 11:48:24 -05:00
Michael 18dcf77a6d Desciption added 2023-02-01 16:33:07 +00:00
Hypolite Petovan 301fa681c5 Ward against potentially missing "platform" array key in Model\GServer::fetchSiteinfo 
- Address https://github.com/friendica/friendica/issues/12488#issuecomment-1411635902
 2023-02-01 08:35:33 -05:00
Michael a3d645645a Fix #12757 2023-01-31 05:45:24 +00:00
Michael f078b6bc18 Issue 12753: For remote-self feed items the plink mustn't point to the original feed link 2023-01-30 06:58:36 +00:00
Michael b90d6a5638 Updated class description 2023-01-29 17:51:04 +00:00
Michael 101b3c9703 First implementation of ActivityPub C2S 2023-01-29 14:41:14 +00:00
Philipp df021b07e3
Merge pull request #12747 from MrPetovan/bug/warnings 
Address a couple of warnings
 2023-01-29 08:21:46 +01:00
Philipp 450c753004
Merge pull request #12746 from MrPetovan/bug/fatal-errors 
Remove Feed contacts from profile contact list
 2023-01-29 08:21:26 +01:00
Hypolite Petovan 48a7958ef9 Check $url variable for value before using it in Module\Photo::getPhotoById 
- Address https://github.com/friendica/friendica/issues/12488#issuecomment-1407342540
 2023-01-29 00:12:59 -05:00
Hypolite Petovan 9a270de9c2 Prevent the use of $shared_item if it's falsy in Mastodon\Status::createQuote 
- Address https://github.com/friendica/friendica/issues/12488#issuecomment-1407342324
 2023-01-29 00:11:13 -05:00
Hypolite Petovan b1eae0c9aa Remove Feed contacts from profile contact list 
- These contact don't have a public pendant and therefore shouldn't be shown to visitors
- Address https://github.com/friendica/friendica/issues/12486#issuecomment-1406191980
 2023-01-29 00:07:20 -05:00
Hypolite Petovan b66787f0de Improve return value consistency in Util\BasePath::getPath 2023-01-28 22:19:47 -05:00
Hypolite Petovan 1dc97e30e0 Read local files instead of performing self HTTP requests in JsonLD::documentLoader 2023-01-28 22:17:05 -05:00
Michael 3f618218c7 Old stuff removed 2023-01-28 18:50:45 +00:00
Michael 999cdc7db9 Avoid more local links and bad http requests 2023-01-28 14:57:04 +00:00
Michael Vogel fc46778a00
Merge pull request #12735 from MrPetovan/bug/fatal-errors 
Address a couple of Fatal errors
 2023-01-27 08:55:27 +01:00
Michael Vogel 1d7d6fe35c
Merge pull request #12736 from MrPetovan/bug/12733-webfinger-apcontact 
Replace custom WebFinger implementation by Probe::getWebfingerArray in APContact::fetchWebfingerData
 2023-01-27 08:27:20 +01:00
Hypolite Petovan 79dc5c177e Replace custom WebFinger implementation by Probe::getWebfingerArray in APContact::fetchWebfingerData 
- This implementation didn't support separate domains for the address and the final account
 2023-01-27 01:24:28 -05:00
Hypolite Petovan 91d8cd2c87 Prevent fatal error when probing WebFinger address in Network\Probe::feed 2023-01-27 01:24:22 -05:00
Michael Vogel 94b63e6a00
Apply suggestions from code review 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2023-01-27 07:21:08 +01:00
Michael ba4860b787 Avoid local network communication / invalid url requests 2023-01-27 05:55:45 +00:00
Hypolite Petovan be105db759 Check the image URL has a host before retrieving it in Photo::importProfilePhoto 
- Address https://github.com/friendica/friendica/issues/12486#issuecomment-1404324012
 2023-01-25 22:31:07 -05:00
Hypolite Petovan 0259af1118 Cast key values to int in Mastodon\Stats 
- Address https://sekretaerbaer.de/display/61b27817-3763-cd4c-5fca-b4d397968464
 2023-01-25 22:11:22 -05:00
Michael 3e8c38946d Catch not fetchable posts 2023-01-25 23:03:51 +00:00
Michael ae3afaad94 Restore default value 2023-01-25 22:38:11 +00:00
Michael 30093fd2ec Quote for notifications 2023-01-25 20:35:10 +00:00
Michael b6fcfebd56 Switch parameters 2023-01-25 20:14:33 +00:00
Michael b46f18bdf9 Fix reply via API / fix missing variable 2023-01-25 10:16:24 +00:00
Michael c27fdc7167 Unused "use" removed 2023-01-25 06:34:15 +00:00
Michael 49d513f8d2 API: added positiv list for quote support 2023-01-25 06:26:17 +00:00
Hypolite Petovan b4cbe4250e Remove Text\BBCode::scaleExternalImage 
- Image size is a CSS concern, not a PHP one
 2023-01-23 20:40:20 -05:00
Michael b61923700e Display, not diplay 2023-01-23 22:30:28 +00:00
Michael c471a78b05 Issue 12358: Allow blocking of every contact 2023-01-23 21:44:30 +00:00
Michael d0373ab414 Issue 12603: Support quote in the api / Issue 12654: prevent privacy leakage 2023-01-23 21:24:50 +00:00
Michael ff28044cf6 Issue 12603: Support quotes in the API 2023-01-23 19:00:20 +00:00
Michael 5a01fb0521 Don't show reblogged on single post 2023-01-23 17:56:45 +00:00
Michael 0364972242 Merge remote-tracking branch 'upstream/develop' into api 2023-01-23 17:52:54 +00:00
Michael 87e9dafc56 Removed duplicated "be" 2023-01-23 06:48:42 +00:00
Michael 75cac38fe3 Updated messages.po 2023-01-23 06:43:13 +00:00
Michael Vogel 807c2dfe6a
Update src/Module/Settings/Connectors.php 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2023-01-23 04:52:41 +01:00
Michael b2d7c4ec43 Merge remote-tracking branch 'upstream/develop' into api 2023-01-22 19:11:21 +00:00
Michael 8e4e2eecb7 Issue 12702: Let the user decide how to handle spoiler texts 2023-01-22 17:10:31 +00:00
Michael edf3e9c4b6 Improved block check for redirects 2023-01-22 12:33:38 +00:00
Michael 2ecc797541 API: Show different ids on reshares / don't check for client secret 2023-01-22 11:25:31 +00:00
Philipp ced77ccbce
Merge pull request #12697 from MrPetovan/bug/deprecated 
Fix a few PHP8.2 deprecation messages
 2023-01-21 23:00:32 +01:00
Philipp Holzer 98da37076d
Add more transparent errors and make it possible to see them in logs 2023-01-21 21:07:20 +01:00
Philipp Holzer 8082b68185
Remove another URL check at App 2023-01-21 21:07:20 +01:00
Philipp Holzer 3de78fc60b
Remove BaseURL Auto-Check 2023-01-21 21:07:20 +01:00
Hypolite Petovan 73c8720d41 Declare history property in Mastodon\Card 
- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1383173055
 2023-01-21 14:25:21 -05:00
Hypolite Petovan c79cec2652 Replace deprecated uses of ${var} in strings 
- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1383147421
 2023-01-21 14:25:21 -05:00
Hypolite Petovan 7e618856ab Replace deprecated use of "self" in callables 
- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1383147421
 2023-01-21 14:25:21 -05:00
Hypolite Petovan 881cb456e2 Throw an exception when parse_url fails in HttpClient->request 
- Address part of https://github.com/friendica/friendica/issues/12011#issuecomment-1383147421
 2023-01-21 14:25:21 -05:00
Philipp Holzer a7c4a3023a
Add "Database::INSERT_IGNORE" for the initial value check 2023-01-21 20:02:40 +01:00
Philipp Holzer 9627af924a
Add support for toString/Serializable 2023-01-21 19:42:48 +01:00
Hypolite Petovan d3ef2b23cc Don't select deleted contact when in Contact::createFromProbeForUser 2023-01-21 09:18:17 -05:00
Hypolite Petovan 6749ace4b7 Reset pending value when unfollowing a contact 2023-01-21 09:18:17 -05:00
Hypolite Petovan 5519b50900 Apply changes to user-contact table first in Contact::update 
- The truncateFieldsForTable call in the same method was potentially restricting the fields that could be updated in the user-contact table
 2023-01-21 09:18:17 -05:00
Hypolite Petovan dcfb8bb73e Fix connection acknowledgement not appearing on contact page 
- Remove obsolete template variables
- Move contact_edit vier template to base template
 2023-01-21 09:18:17 -05:00
Roland Häder 27969e8ca6
Continued: 
- moved if() block to suggested position by MrPetovan, for me I want to have all
  conditions checked at the start of the method, e.g. no unwanted null
  references or (in this case) if the URL is blacklisted
- normalized URLs are without SSL, means http://host/path/file.ext so they exist
  only once for contacts and servers (aka. instances)
- documented returned type `void`
 2023-01-21 01:07:14 +01:00
Roland Häder ba08692403
Continued: 
- just for consistency ...
 2023-01-20 02:43:59 +01:00
Roland Häder a0704db43a
Continued: 
- some trolls managed to flood gserver with useless URLs. They can be blocked
  by domain blocking them, but still it floods gserver table with dead entries
- this hack tries to change that so they won't enter gserver at all. Let's hope
  these trolls as `activitypub-trolls.cf` learn a lesson (and get adults soon)

Signed-off-by: Roland Häder <roland@mxchange.org>
 2023-01-20 01:50:55 +01:00
Philipp 15938c5b87
Merge pull request #12695 from MrPetovan/bug/fatal-errors 
Address a few fatal errors
 2023-01-19 08:09:03 +01:00
Hypolite Petovan c05956137a Default maintenance reason to empty string in Module\Maintenance 
- Address https://github.com/friendica/friendica/issues/12486#issuecomment-1383250546
 2023-01-18 21:01:07 -05:00
Hypolite Petovan 3b99b98678 Truncate integer values before inserting them 
- Address https://github.com/friendica/friendica/issues/12486#issuecomment-1383250353
 2023-01-18 20:58:49 -05:00
Hypolite Petovan d2033d4c92 Allow colon in password 
- It was disallowed because of a too strict intepretation of RFC2617
 2023-01-18 20:34:20 -05:00
Hypolite Petovan 81cd334664 Fix wrong logic in password allowed regular expression 2023-01-18 20:27:29 -05:00
Hypolite Petovan 16e1c8f893
Merge pull request #12690 from annando/statistics 
Nodeinfo data has moved to key values
 2023-01-18 08:37:20 -05:00
Michael 73e163100c Nodeinfo data has moved to key values 2023-01-18 05:04:37 +00:00
Hypolite Petovan c7e944e793
Merge pull request #12680 from nupplaphil/feat/addon_logger 
Introduce new Hook logic
 2023-01-17 16:37:03 -05:00
Michael 259fe7fcf2 Merge remote-tracking branch 'upstream/develop' into blocked-server 2023-01-17 19:25:09 +00:00
Philipp Holzer 5358e195d7
Fix Introspection 2023-01-17 20:11:48 +01:00
Philipp Holzer 8eed43a7dd
Add whitespace .. 2023-01-17 19:23:20 +01:00
Philipp Holzer 3b262f44a3
Adhere feedback 2023-01-17 19:15:37 +01:00
Philipp eed6db2465
Apply suggestions from code review 
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
 2023-01-17 19:12:33 +01:00
Michael 356a2a9a5a News "blocked" field on the gserver table 2023-01-17 17:25:19 +00:00
Daniel Siepmann da58b894a4
Properly handle feed item creation date with surrounding whitespace 
Some feeds might have whitespace around the creation date.
This can't be parsed by DateTimeFormat methods.
Therefore the incoming creation date is trimmed to not contain any
surrounding whitespace for proper handling.

Relates: #12686
 2023-01-17 07:18:47 +01:00
Philipp Holzer 293c121c48
Adhere PHP-CS.. 2023-01-16 22:25:26 +01:00
Philipp Holzer f609e38600
Introduce new Hook logic 
- InstanceManager for computing strategies and to allow decorators
- Adapting Core\Logger to use it
 2023-01-16 22:20:33 +01:00
Philipp Holzer ab6efea9b2
Replace Config-Cache dependency with Config-Model (no more DB-waiting necessary) 2023-01-15 16:17:08 +01:00
Philipp Holzer a6fb683bcd
Remove BasePath dependency from App\Mode 2023-01-15 16:17:07 +01:00
Philipp dd6d96d048
Merge pull request #12678 from MrPetovan/bug/12677-addon_admin 
Remove App dependency from addon admin form method
 2023-01-15 15:55:08 +01:00
Hypolite Petovan 6e4663e747 Remove App dependency from addon admin form method 2023-01-15 09:42:18 -05:00
Hypolite Petovan 21f172c585
Merge pull request #12674 from nupplaphil/bug/config_typesafe 
Config: Improve the node.config.php transformation
 2023-01-15 09:38:29 -05:00
Philipp Holzer bc60eb6cb7
Apply feedback and describe the encoding method 2023-01-15 11:57:43 +01:00
Philipp d63aca97b8
Merge pull request #12673 from annando/andstatus-api 
API: Accept "redirect_uris" as both array and string
 2023-01-15 01:01:06 +01:00
Philipp Holzer 4c28f9cf9c
Config: Improve the node.config.php transformation 
- Add more types
- Improvement for assoziative arrays and key-value arrays
- Add a lot more tests
 2023-01-15 00:53:51 +01:00
Michael e06f699dd9 Added Documentation, updated messages.po 2023-01-14 21:20:04 +00:00
Michael af2a38c5b3 API: Accept "redirect_uris" as both array and string 2023-01-14 21:07:47 +00:00
Philipp 0c14e51112
Merge pull request #12666 from MrPetovan/bug/12661-public-calendar-export 
Enable calendar export for public_calendar = true
 2023-01-14 19:20:20 +01:00
Hypolite Petovan 323765110c Enable calendar export for public_calendar = true 2023-01-14 10:39:18 -05:00
Hypolite Petovan e73adde5fb Remove App dependency from Hook::callSingle 
- This was causing a circular dependency with the logger_instance hook
 2023-01-14 10:38:37 -05:00
Hypolite Petovan 2d555b60dd
Merge pull request #12670 from annando/fix-avatar-cache 
Ensure to reset the avatar paths when deleting avatar cache
 2023-01-14 09:47:21 -05:00
Michael 3e3f2555dc Ensure to reset the avatar paths when deleting avatar cache 2023-01-14 13:10:43 +00:00
Hypolite Petovan 91ff24b0e4
Merge pull request #12663 from nupplaphil/sec/xss_404 
Security: Use htmlspecialchars() for user input in Arguments class
 2023-01-13 13:57:41 -05:00
Philipp Holzer 0530755332
Security: Use htmlspecialchars() for user input in Arguments class 2023-01-12 20:24:39 +01:00
Hypolite Petovan a7d0355849
Merge pull request #12659 from DanielSiepmann/12658-fix-feed-urls-with-whitespace 
Properly handle feed item urls with surrounding whitespace
 2023-01-12 07:57:30 -05:00
Daniel Siepmann 6633b0af4b
Properly handle feed item urls with surrounding whitespace 
Some feeds might have whitespace around the URLs of each item.
This can't be handled by parse_url.
Therefore the incoming url is trimmed to not contain any surrounding
whitespace for proper handling.

Relates: #12658
 2023-01-12 13:47:57 +01:00
Michael 8a902afde5 Updated messages.po - again 2023-01-12 07:06:24 +00:00
Michael 6cdafb6b63 Fix "Undefined constant Friendica\Content\Conversation::PARCEL_DIASPORA" 2023-01-12 06:57:31 +00:00
Michael f542211189 Mode depending control for the behaviour with blocked contacts 2023-01-12 06:25:55 +00:00
Hypolite Petovan ec54b303c5
Merge pull request #12655 from annando/fix-communication 
Fix: Forum posts from some contacts weren't distributed
 2023-01-11 17:04:41 -05:00
Michael 53e8b21ca3 Fix: Forum posts from some contacts weren't distributed 2023-01-11 21:55:32 +00:00
Philipp Holzer fef10e8a57
Improve encapsulation 2023-01-11 22:00:29 +01:00
Philipp Holzer 11a8bd17e3
Assure that deleted cat/keys are working as expected 
- A deleted cache-key would delete a merged cache-key as well
- Deleting a key in the Model results in reloading the config to assure any value from underlying files
 2023-01-11 21:53:34 +01:00
Philipp Holzer fd882abd80
Revert Cache delete() behavior to stable version 2023-01-11 21:10:59 +01:00
Hypolite Petovan 5c8cd8fdd6 Replace remaining mentions of "Status" by "Conversations" or "Posts" 2023-01-11 09:01:29 -05:00
Hypolite Petovan d0648b10ef Convert Content\Nav to dynamic object 
- Remove DI dependency in Module\Apps
 2023-01-11 09:01:24 -05:00
Hypolite Petovan 3966b58965 Only show line number if it's provided in System::callstack 
- Address https://github.com/friendica/friendica/issues/12488#issuecomment-1377373973
 2023-01-10 10:41:20 -05:00
Hypolite Petovan 3fcafd1d50 Replace HTML regular expression by HTML::extractCharset in ParseUrl::getSiteInfo 
- Address https://github.com/friendica/friendica/issues/12488#issuecomment-1374537440
 2023-01-10 10:36:59 -05:00
Hypolite Petovan 5e2b655b43 Add implementation of HTTP Media Type 
- Add charset extraction from DOMDocument
- TESTS!
 2023-01-10 10:36:58 -05:00
Hypolite Petovan f4b5d22396
Merge pull request #12644 from annando/improve-ignore 
Improve the ignore behaviour
 2023-01-10 09:05:48 -05:00
Michael 20a2cec0b0 Moved permission assigning / simplified block check 2023-01-10 05:59:25 +00:00
Hypolite Petovan 14e4c0db8e Check image property is set in Object\Image 
- Property was either an object or null, strict comparison with "false" was inaccurate
- Address https://github.com/friendica/friendica/issues/12486#issuecomment-1374888800
 2023-01-09 16:06:22 -05:00
Hypolite Petovan b77f3a7525 Check for URI ID existence in Post\Media::insert 
- Address https://github.com/friendica/friendica/issues/12486#issuecomment-1374538325
 2023-01-09 16:06:22 -05:00
Hypolite Petovan 4d5d8e5b64 Add line number to output in System::callstack 2023-01-09 16:06:22 -05:00
Hypolite Petovan 670b518875 Include other unique key column in condition in Model\Tag:store 
- Address https://github.com/friendica/friendica/issues/12486#issuecomment-1372640002
 2023-01-09 16:06:22 -05:00
Michael 4e0da578fa Merge remote-tracking branch 'upstream/develop' into improve-ignore 2023-01-09 17:23:10 +00:00
Hypolite Petovan 6bee344681 Add yet another case to DateTimeFormat::fix 
- Address https://github.com/friendica/friendica/issues/12488#issuecomment-1372637862
 2023-01-09 11:38:25 -05:00
Michael 840f25cc5c Improve ignoring of messages 2023-01-09 16:23:39 +00:00