friendica/friendica
6
0
Fork 1
mirror of https://github.com/friendica/friendica synced 2024-05-23 15:04:59 +02:00
Code Issues Packages Projects Releases 1 Wiki Activity
34341 commits 2 branches 63 tags 241 MiB
Commit graph

9543 commits

Author SHA1 Message Date
Michael 138a15404f Fix processing of incoming Diaspora messages 2022-07-20 05:38:53 +00:00
Michael 7dcd02938d Remove entries from queue / relay detection 2022-07-20 05:37:40 +00:00
Roland Häder 1fbda27aad
Changes: 
- rewrote a lot local variables to an array and returned it instead of an
  anonymous array
- added more debug/warning logging in case something went wrong -> lesser guessing! ;-)
- changed double-quote to single
 2022-07-20 01:08:15 +02:00
Hypolite Petovan d69ac56338
Merge pull request #11753 from Quix0r/fixes/missing-contact-array 
Fixed missing $contact array, at least initialize it empty
 2022-07-19 17:58:02 -04:00
Roland Häder 2ef0566ba5
Fixed: 
- "Undefined variable: contact in .../src/Protocol/Diaspora.php on line 4097
Trying to access array offset on value of type null in .../src/Protocol/Diaspora.php on line 4097"
- see https://github.com/friendica/friendica/issues/11632#issuecomment-1189465336
 2022-07-19 23:46:09 +02:00
Roland Häder 3c540517e7
Ops 2022-07-19 23:40:29 +02:00
Roland Häder cf8698afe6
This is the correct way: 
<?php
if (!isset($foo['account_removed) || $foo['account_removed'])
?>
 2022-07-19 18:08:18 +02:00
Roland Häder 4e5179a7b3
Changes: 
- added some missing type-hints
- fixed some documentation (e.g. empty * line between @param and @return/throws)
 2022-07-19 18:02:38 +02:00
Roland Häder cb2a052a70
Fixed E_NOTICE, for some strange reason 'account_removed' isn't around? 2022-07-18 23:49:58 +02:00
Michael a676cf8bed Merge remote-tracking branch 'upstream/develop' into enqueue-posts 2022-07-18 14:05:04 +00:00
Michael ce38e63399 Add and delete entries 2022-07-18 14:03:49 +00:00
Hypolite Petovan 42d411712b
Merge pull request #11742 from annando/server-detection 
Improved server detection
 2022-07-18 08:50:59 -04:00
Hypolite Petovan 2e9d1a9046
Merge pull request #11746 from annando/warn 
Check for GMP module
 2022-07-18 08:49:50 -04:00
Michael ac47aed1b4 Merge remote-tracking branch 'upstream/develop' into enqueue-posts 2022-07-18 05:32:44 +00:00
Michael af8e059990 Renamed platform definition file 2022-07-18 03:48:19 +00:00
Michael 3bd706fcfc Superfluous todo removed 2022-07-18 03:32:49 +00:00
Michael 2f462ffa16 Store incoming posts in a queue 2022-07-18 03:31:00 +00:00
Hypolite Petovan 121607b8d9
Merge pull request #11740 from annando/json-ld 
Improved JsonLD parsing
 2022-07-17 17:44:53 -04:00
Michael 46fdd9893c Merge remote-tracking branch 'upstream/develop' into server-detection 2022-07-17 15:42:09 +00:00
Philipp 6175f9086e
Merge pull request #11747 from annando/fixes 
Emergency fixes to fix a bunch of fatal errors
 2022-07-17 16:34:53 +02:00
Michael 9a4be84853 Only check for string value 2022-07-17 13:13:14 +00:00
Michael 6882e70024 Match the documentation 2022-07-17 13:00:34 +00:00
Michael 2ddf37f32d Emergency fixes to fix a bunch of fatal errors 2022-07-17 11:47:12 +00:00
Michael 23953be7cb Merge remote-tracking branch 'upstream/develop' into warn 2022-07-17 08:51:46 +00:00
Michael f2a4aecc05 Check for GMP module 2022-07-17 06:34:37 +00:00
Michael d52f52f45f Somed added documentation 2022-07-17 05:42:44 +00:00
Philipp 1894302011
Merge pull request #11739 from Quix0r/fixes/missing-return-statements 
Fixes/missing return statements
 2022-07-16 16:23:32 +02:00
Michael 0a19759e4f Fix wrong variable type 2022-07-16 13:44:35 +00:00
Michael 8b7cb5d9ef Merge remote-tracking branch 'upstream/develop' into server-detection 2022-07-16 12:44:21 +00:00
Roland Häder cb7f52cc6a
Fixed: 
- $item is the proper array here,
- see https://github.com/friendica/friendica/issues/11632#issuecomment-1186119430
 2022-07-16 12:19:09 +02:00
Michael 8db0e090d7 Merge remote-tracking branch 'upstream/develop' into json-ld 2022-07-16 09:33:24 +00:00
Michael 8cc362fb8b Improved JSonLD parsing 2022-07-16 09:25:12 +00:00
Michael abe3fd7605 Improved check for invalid certificates 2022-07-16 08:27:38 +00:00
Roland Häder ce7af4edb8
All these methods need to return an integer (0=Success) or otherwise doExecute() 
will return NULL.
 2022-07-16 08:17:47 +02:00
Michael 896fd3fc91 Use the redirect value 2022-07-14 05:39:25 +00:00
Roland Häder a38209db1e
Changed: 
- added a final check on $link_item, as it might not be initialized or no
  record was found, thanks to @AlfredSK for reporting this
- see #11632
 2022-07-13 22:05:53 +02:00
Roland Häder 4cb5cadba8
Added returned type-int "int" 2022-07-13 21:10:50 +02:00
Hypolite Petovan 1d94e2866a Enable the view module in maintenance mode 
- This allows to load the default theme CSS
- Theme scripts have been updated to reflect the possibility they will be included in maintenance mode
 2022-07-12 19:48:36 -04:00
Philipp Holzer 74c5c66cb5
Add docs 2022-07-13 00:27:39 +02:00
Philipp Holzer d74e57ef2c
include suggested changes 2022-07-13 00:23:12 +02:00
Philipp Holzer a910fd8864
Split DBStructure & View to avoid DB-calls and dependencies for basic operations 
- new "Definition" classes vor DB and Views
- new "Writer" classes to create SQL definitions for DB and Views
- DBStructure & View are responsible to execute DB-querys
 2022-07-12 23:40:31 +02:00
Philipp Holzer 8e547510a0
Fix HTTP Client redirect Bug 2022-07-12 20:11:53 +02:00
Hypolite Petovan 74991d1f95 Fix type hint typo in Protocol\Email::messageGetPart 
- Address https://github.com/friendica/friendica/issues/11724
 2022-07-11 23:05:13 -04:00
Michael dad05f1c76 Only fetch the first word for the platform 2022-07-10 13:52:38 +00:00
Michael 85c7bacb00 Improved server detection 2022-07-10 13:01:47 +00:00
Hypolite Petovan 05ed13a279
Merge pull request #11719 from nupplaphil/feat/type_use 
adhere `use` and type-hints :-)
 2022-07-09 17:42:42 -04:00
Hypolite Petovan eb8237dd89 Remove unused uid parameter in Item::newURI 2022-07-09 07:39:51 -04:00
Philipp Holzer e8fd495847
adhere use and type-hints :-) 2022-07-09 11:41:36 +02:00
Hank Grabowski 96d3b5bcf1 Merge branch 'develop' into feature-optional-network-group-count 2022-07-08 15:35:26 -04:00
Hank Grabowski e57e1ba1e5 Make network counts at the group level system level configurable 2022-07-08 15:29:34 -04:00
Philipp Holzer 34f2b2f558
Add the right exceptions for BaseUrl::redirect and respect them when catching exceptions at the Trust page 2022-07-07 21:47:39 +02:00
Philipp Holzer e4a83eafb8
Add a lot of log-points 2022-07-07 21:33:41 +02:00
Roland Häder bf809c9d57
Fixed: 
> TypeError: "Argument 2 passed to Friendica\Protocol\ActivityPub\Transmitter::sendContactReject()
> must be of the type int, string given

I followed here here the documentation, may fix #11708
 2022-07-06 05:43:00 +02:00
Roland Häder 4875524101
Fixed: 
- added exception to prevent `TypeError` because of missing `uri-id` entry
- maybe fixes #11708
 2022-07-05 18:53:51 +02:00
Michael cc75eb5d18 Improved server detection 2022-07-05 05:04:05 +00:00
Roland Häder ba33c95e97
Fixes: 
"Argument 1 passed to Friendica\Content\Text\BBCode::toPlaintext() must be of the type string, null given, called in /var/www/.../htdocs/mod/display.php on line 305"
 2022-07-03 14:45:12 +02:00
Hypolite Petovan 181c142bb4 Remove overly strict type-hint in ActivityPub\Transmission::createCachedActivityFromItem 
- Fix "Return value of Friendica\Protocol\ActivityPub\Transmitter::createCachedActivityFromItem() must be of the type array, bool returned" error
 2022-07-02 22:16:59 -04:00
Hypolite Petovan e6feed65bf Rename Smilies::pregHeart to better match its purpose 
- Fix "Argument 1 passed to Friendica\Content\Smilies::pregHeart() must be of the type string, array given" error
 2022-07-02 22:14:20 -04:00
Roland Häder 3326c4cb31
Added missing type-hints, #11700 2022-07-01 02:50:34 +02:00
Roland Häder 1ee0e6f711
Changes: 
- no NULL anymore for 2nd parameter OEmbed::toHTML()
- some double-quotes to single
 2022-06-30 15:03:12 +02:00
Roland Häder 6186aac792
Fixed type-hints 2022-06-30 14:58:45 +02:00
Roland Häder 99902bb478
Changes 
- ops, also this needs change since null is no longer wanted
 2022-06-30 14:52:37 +02:00
Roland Häder 5c0e8c62de
Changes 
- renamed Widget::accounttypes() to Widget::accountTypes()
- fixed type-hint the documentation was wrong
 2022-06-30 14:50:28 +02:00
Roland Häder 83cbe586ac
Changes 
- renamed Item::visibleActivity() to Item::isVisibleActivity() as this returns
  a boolean value
- added some type-hints
- added some documentation
 2022-06-30 14:18:13 +02:00
Roland Häder e33f5612ab
Changes: 
- added some type-hints
- added some documentation
- changed some double-quotes to single
 2022-06-27 15:16:18 +02:00
Roland Häder a392a22eee
Changes: 
- added some type-hints
- fixed some documentation (void is lately returned, not null)
- added some documentation
 2022-06-27 15:16:17 +02:00
Roland Häder 703ba1439b
Some empty lines 2022-06-27 15:16:17 +02:00
Roland Häder 98bc5216ef
A bit more documentation 2022-06-27 15:16:17 +02:00
Roland Häder 9871e9718e
Changes: 
- added some type-hints
 2022-06-27 15:16:16 +02:00
Roland Häder 6c5acf9ee0
Fixed: 
- "Argument 3 passed to Friendica\Model\Photo::createPhotoForExternalResource()
  must be of the type string, null given
 2022-06-27 15:16:16 +02:00
Roland Häder ff9707713b
Fixed: 
- Friendica\Content\BoundariesPager::renderFull(int $itemCount) must be
  compatible with Friendica\Content\Pager::renderFull(int $itemCount): string
 2022-06-27 15:16:15 +02:00
Roland Häder 8e19998191
Fixes: 
- more "bool expected but null returned" errors
 2022-06-27 13:49:53 +02:00
Roland Häder 7c049abfda
Fixed: 
- Contact/User::isBlocked() needs to return boolean, but sometimes (strangely)
  a NULL can come from database, so let's cast it

This tries to fix:
TypeError: "Return value of Friendica\Model\Contact\User::isBlocked() must be of the type bool, null returned"
 2022-06-27 11:39:18 +02:00
Roland Häder 4bdce6948f
Changed: 
- $publicContact['about'] can be NULL, causing following error:
--------------------------
Argument 1 passed to Friendica\Content\Text\BBCode::toPlaintext() must be of
the type string, null given, called in /.../src/Object/Api/Twitter/User.php
--------------------------
The "expensive" code there can be avoided being called by an empty string or
NULL to increase performance.
 2022-06-26 23:28:48 +02:00
Philipp e594656a48
Merge pull request #11684 from MrPetovan/bug/11651-ap-fetch-queue 
Create ActivityPub\FetchQueue and ActivityPub\FetchQueueItem classes
 2022-06-26 13:36:19 +02:00
Hypolite Petovan 91f5a7cc6b Convert potential spaces in Memcache(d) key names 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1166475036
- Add test for space in cache keys
 2022-06-26 07:30:30 -04:00
Philipp Holzer b67e488236
adaptions 2022-06-26 10:13:32 +02:00
Philipp Holzer 0223c030a9
Improve 2 factor usage 2022-06-25 23:04:00 +02:00
Philipp Holzer f3de8d7764
improve 2fa token field 2022-06-25 22:48:35 +02:00
Philipp Holzer 759d9d9f1a
Add more 2fa properties 2022-06-25 22:48:34 +02:00
Philipp Holzer b86ff1e970
Rename 2FA recovery message 2022-06-25 22:48:34 +02:00
Hypolite Petovan da32fa8fa6 Create ActivityPub\FetchQueue and ActivityPub\FetchQueueItem classes 
- These classes are used to flatten the recursive missing activity fetch that can hit PHP's maximum function nesting limit
- The original caller is responsible for processing the remaining queue once the original activity has been fetched
 2022-06-25 12:40:54 -04:00
Hypolite Petovan 3c70d592f6
Merge pull request #11689 from Quix0r/rewrites/double-quotes-single 
Changed more double-quotes to single
 2022-06-25 12:02:01 -04:00
Roland Häder e10dd20036
Made @TODO more clear? 2022-06-25 17:58:27 +02:00
Hypolite Petovan a7d49877a8 Centralize share tag attribute extraction code in Content\Text\BBCode 2022-06-25 11:46:52 -04:00
Roland Häder 4164cdacf5
Changes: 
- added type-hints
- added documentation
 2022-06-25 16:48:37 +02:00
Roland Häder 804b759df1
Changes: 
- let's get rid of that `Database::exists()` is being misused for checking table existence
- reformatted array
 2022-06-25 16:48:37 +02:00
Roland Häder f689faca99
Changed double-quotes to single 2022-06-25 16:48:36 +02:00
Roland Häder 88870d18be
Changes: 
- added some type-hints
- added documentation
 2022-06-25 16:48:36 +02:00
Roland Häder 39675fe683
Space for the rescue. ;-) 2022-06-25 16:48:35 +02:00
Roland Häder b0693c1ad7
Reformatted array 2022-06-25 16:48:35 +02:00
Roland Häder f12cc9648e
Changes: 
- added some type-hints
- changed some double-quotes to single
 2022-06-25 16:48:35 +02:00
Hypolite Petovan aa133b5437 Add explicit gserver.site_name string truncate in Model\GServer 
- Avoids "Data too long for column 'site_name'" database errors
 2022-06-25 06:25:48 -04:00
Hypolite Petovan a2afb101cd Fix off-by-one error in Message ID header count check in Util\Emailer 2022-06-25 05:35:24 -04:00
Hypolite Petovan c75dbfd3d7 Update default value for LocalRelationship->priority to avoid null values 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1166192993
 2022-06-25 05:06:22 -04:00
Hypolite Petovan 636b84b41c Update return value type-hint of GServer::getProtocol 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1164880874
 2022-06-25 05:06:22 -04:00
Hypolite Petovan c5b46fe748
Merge pull request #11681 from Quix0r/fixes/item-guidfromuri-allow-null 
Allowing Item::getFromUri()'s 2nd parameter a null value
 2022-06-24 10:15:26 -04:00
Roland Häder 82bb36e13d
Changes: 
- Made Item::guidFromUri()'s $host parameter optional (allowing null)
- added some type-hints
- added documentation
- this may fix reported issue in #11630
 2022-06-24 03:17:57 +02:00
Philipp Holzer 2dc38e5632
Move documentation :-) 2022-06-23 23:23:36 +02:00
Philipp Holzer 5bf5b5e6c9
adaptions :-) 2022-06-23 23:01:09 +02:00
Philipp Holzer 12ba37e8d2
add more doc 2022-06-23 22:46:46 +02:00
Philipp Holzer 13783089e7
Add copyright 2022-06-23 22:44:17 +02:00
Philipp Holzer d441b90bda
Respect Forwarded-For headers 2022-06-23 22:42:35 +02:00
Roland Häder 657a8a7cb5
Changes: 
- documented null value
- two ' to much!
 2022-06-23 17:30:17 +02:00
Roland Häder 202857ba7d
No need to log $tid here 2022-06-23 17:30:17 +02:00
Roland Häder fd8f4269ff
Reformatted code 2022-06-23 17:30:17 +02:00
Roland Häder 5699b03e8d
Changes: 
- added some nodes to OpenSearch descriptor
- still no UTF-8 encoding!
- added some type-hints
 2022-06-23 17:30:16 +02:00
Roland Häder a49fb9cbf9
Changes: 
- added some type-hints
- added documentation
 2022-06-23 17:30:16 +02:00
Roland Häder 84d3eecc33
Changes: 
- added some type-hints
- changed double-quotes to single
 2022-06-23 17:30:15 +02:00
Roland Häder 57e741f2cf
More type-hints added 2022-06-23 17:30:15 +02:00
Roland Häder 182c3db9b8
Changes: 
- added type-hints
- added missing documentation
 2022-06-23 17:30:15 +02:00
Roland Häder b8353a6eb7
Changes: 
- reformatted some array
- added missing documentation
- added type-hints
- changed double-quotes to single
 2022-06-23 17:30:14 +02:00
Roland Häder c6c936a80f
Added more type-hints 2022-06-23 17:30:14 +02:00
Roland Häder 3f74a59f73
Added some type-hints 2022-06-23 17:30:14 +02:00
Roland Häder 69a68be800
Added some missing type-hints 2022-06-23 17:30:13 +02:00
Roland Häder d8ff966d21
Throw IAE again (should never become visible) 2022-06-23 17:30:13 +02:00
Roland Häder 35c78ce14c
Ops, cannot return Thread? 2022-06-23 17:30:12 +02:00
Roland Häder c2e26b4f49
Changed: 
- Introduced InvalidArgumentException (should never come)
- added type-hints
 2022-06-23 17:30:12 +02:00
Roland Häder 2f3705f471
Continued: 
- renamed varibales to $camelCase
- added type-hints
- updated documentation
 2022-06-23 17:30:11 +02:00
Roland Häder 0ddb315b23
$id in Transmitter::sendContactAccept() is a string, see Introduction class 2022-06-23 16:48:00 +02:00
Hypolite Petovan bf600905d3
Merge pull request #11676 from Quix0r/fixes/array-element-missing 
Maybe this fixes missing array element
 2022-06-23 09:06:59 -04:00
Roland Häder 636fef26f1
Maybe this fixes missing array element 2022-06-23 07:40:49 +02:00
Roland Häder 589d0360a4
So simple ... Ops! 2022-06-23 04:58:45 +02:00
Roland Häder 69676c9f7b
Changes: 
- enabled sub-directories for compiled/cached files which avoids large+slow
  directory descriptors
- changed some double-quotes to single
 2022-06-23 04:24:55 +02:00
Roland Häder 7eefb9aed8
Changed: 
- empty() is maybe superflous here, still I would prefer a code style that is
  written explicitly and not rely on "magic casting"
 2022-06-22 18:57:01 +02:00
Roland Häder 15d8341d9a
Converted multiple single-comment (//) to multi-line comment block (/* */) 2022-06-22 18:06:35 +02:00
Roland Häder b996712ef7
Images::getInfoFromURL[Cached]() will both return empty arrays on error and 
that needs to be reflected here, too.
 2022-06-22 17:20:59 +02:00
Roland Häder eb231bc548
Fixed: ?? didn't work here as bool won't be seen as null 2022-06-22 17:09:53 +02:00
Philipp 78bf7f187c
Merge pull request #11669 from MrPetovan/bug/11666-email-subject-double-encode 2022-06-22 16:51:23 +02:00
Roland Häder d5441da49a
Fixed: 
- TypeError: "Argument 1 passed to Friendica\Util\XML::escape() must be of the
  type string, null given, called in src/Util/XML.php line 171
 2022-06-22 16:20:26 +02:00
Roland Häder 101cd2dd10
Changes: 
- added some documentation
- fixed some documentation
- changed more double-quotes to singl
 2022-06-22 16:14:14 +02:00
Roland Häder ba45e59313
Changes: 
- added more type-hints
- added missing documentation
- Email::send() now returns what mail() returns (bool)
 2022-06-22 14:36:48 +02:00
Roland Häder ee8d0ad619
Changes: 
- added more type-hints
- added some documentation
 2022-06-22 14:36:47 +02:00
Roland Häder feec96cbc4
Return empty array on error (I hope it works this way). 2022-06-22 14:36:47 +02:00
Roland Häder 2dd7d465e8
Changes: 
- added more type-hints
- updated documentation
- changed double-quotes to single
 2022-06-22 14:36:47 +02:00
Roland Häder 74ab7648c6
Changes: 
- addHubLink()'s 2nd parameter is DOMElement
- added more type-hints
- converted double-quotes to single
 2022-06-22 14:36:46 +02:00
Roland Häder 12add2fb64
$data can turn into bool here 2022-06-22 14:36:46 +02:00
Roland Häder 08f55f0358
Ops, forgot to rename these, too. 2022-06-22 14:36:46 +02:00
Roland Häder abd0d9f3fd
Changes 
- added type-hints
- added some documentation
- added default: block for unknown 'rel' value
- changed return type void to empty array
 2022-06-22 14:36:45 +02:00
Roland Häder dfa95ea58d
Changes: 
- added type-hints
- added documentation
 2022-06-22 14:36:45 +02:00
Roland Häder 84bfc37bf1
Changes: 
- added more type-hints
- added missing documentation
 2022-06-22 14:36:45 +02:00
Hypolite Petovan e9f7bb477d Add expected type-hint to BoundariesPager::renderFull 
- Address https://github.com/friendica/friendica/issues/11630#issuecomment-1162634199
 2022-06-22 07:49:45 -04:00
Hypolite Petovan 7295138f8d Remove type-hint inconsistent with expected return value in Database->getVariable 2022-06-22 07:47:15 -04:00
Hypolite Petovan d68f307337 Remove email subject encoding from ItemCCEmail constructor 
- It was wrongly re-encoded in Emailer::send
 2022-06-21 21:12:09 -04:00
Roland Häder 2f358607c7
Changes: 
- renamed Logger::getLogger() to getInstance() (@MrPetovan)
 2022-06-22 01:50:10 +02:00
Roland Häder cdcfb4064b
Changes: 
- added type-hints
- added missing documentation
- renamed Logger::getWorker() to Logger::getLogger() as there is no worker class
  returned but the actual (inner) logger
 2022-06-21 21:22:16 +02:00
Roland Häder 80c8ec17c2
Fixed documentation 2022-06-21 18:43:25 +02:00
Roland Häder 0332a57bfd
Rewrote to suggestions from @MrPetovan (I tried to maintain the old way of 
['scheme' => 'table'] with my version).
 2022-06-21 18:13:01 +02:00
Roland Häder 5fe428d3e4
Fixed: 
- PHPUnit\Framework\Error\Notice:  Undefined index: language in /.../src/Util/EMailer/MailBuilder.php on line 122
 2022-06-21 13:47:40 +02:00
Roland Häder 1080a840f5
Changes: 
- Database->$driver can no longer be NULL, an empty string is fine anyway
 2022-06-21 13:47:39 +02:00