Commit graph

1570 commits

Author SHA1 Message Date
Josh Soref 04cbbcd2ff spelling: phppath
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 20:04:07 -04:00
Josh Soref a4a95d0b41 spelling: enabled
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 20:03:51 -04:00
Josh Soref 3f34b0633f spelling: type
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:14:16 -04:00
Josh Soref 4206a8de3b spelling: targeting
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:14:16 -04:00
Josh Soref 3fcd546151 spelling: structure
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:14:16 -04:00
Josh Soref 7dfdcf66e4 spelling: recipient
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:14:16 -04:00
Josh Soref 035f3fed25 spelling: intended
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:03:23 -04:00
Josh Soref 0da14c11c6 spelling: highly
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:03:23 -04:00
Josh Soref f6fda5840d spelling: failure
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:03:23 -04:00
Josh Soref 9369691713 spelling: existence
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:03:23 -04:00
Josh Soref 23f2bd1a2d spelling: encouraged
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:03:23 -04:00
Josh Soref 4139134cfd spelling: effectiveness
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:03:23 -04:00
Josh Soref c7b358f446 spelling: attachment
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:03:22 -04:00
Josh Soref abbea6f002 spelling: and
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-03-26 16:03:22 -04:00
Michael 72952d2c92 Issue 11535: Automatically open and close the registration 2023-03-21 21:44:26 +00:00
Hypolite Petovan 241a512589 Ensure FactorySession->create returns an object no matter what
- Rename redundant method name createSession
- Add exception logging
2023-03-18 23:36:07 -04:00
Michael 54d5f2df43 More reliable system variables 2023-03-15 21:16:21 +00:00
Michael bd3120d6cb Use non static logger call 2023-02-27 07:02:06 +00:00
Michael 2b513a48c7 Catch all errors thrown by "fetchRaw" 2023-02-26 14:08:33 +00:00
Philipp Holzer 41251458a0
language and static 2023-02-20 17:23:01 +01:00
Philipp Holzer d772331b91
Fix multiple serialized values 2023-02-20 17:22:59 +01:00
Philipp Holzer f0c29edcde
Adapt BaseURL calls to new UriInterface 2023-02-18 21:12:21 +01:00
Philipp Holzer dbb7022ca5
Refactor Installer due new BaseURL logic 2023-02-18 21:12:20 +01:00
Michael baf75adfca Some loglevels are adjusted to more reasonablöe levels 2023-02-16 20:47:37 +00:00
Philipp Holzer 3894b6fa41
Fix logic 2023-02-13 11:34:32 +01:00
Philipp Holzer 4dc164a5a1
manually check and create the Config table before running the update 2023-02-12 16:44:56 +01:00
Philipp Holzer aeb3c7e96c
don't try to use the Config table if it doesn't exist 2023-02-12 16:23:51 +01:00
Philipp Holzer a9c0636573
remove maybeSerialize (always serialize) 2023-02-12 15:48:41 +01:00
Philipp Holzer 2d090f0d80
adhere php-cs 2023-02-12 13:17:55 +01:00
Philipp Holzer a153c3f594
Fix and adapt tests 2023-02-12 13:09:14 +01:00
Philipp Holzer 23742c22c3
suppress E_WARNING at tests with vfs:// 2023-02-12 11:41:20 +01:00
Philipp Holzer 7895024e75
add license 2023-02-10 14:54:17 +01:00
Philipp Holzer 513ef03421
Revert node.config.php into Config table 2023-02-10 14:06:22 +01:00
Philipp Holzer 98857f8d7a
Add exception if lock wasn't successful 2023-02-10 14:06:21 +01:00
Philipp Holzer 9627af924a
Add support for toString/Serializable 2023-01-21 19:42:48 +01:00
Philipp Holzer 5358e195d7
Fix Introspection 2023-01-17 20:11:48 +01:00
Philipp Holzer 8eed43a7dd
Add whitespace .. 2023-01-17 19:23:20 +01:00
Philipp Holzer 3b262f44a3
Adhere feedback 2023-01-17 19:15:37 +01:00
Philipp eed6db2465
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-17 19:12:33 +01:00
Philipp Holzer 293c121c48
Adhere PHP-CS.. 2023-01-16 22:25:26 +01:00
Philipp Holzer f609e38600
Introduce new Hook logic
- InstanceManager for computing strategies and to allow decorators
- Adapting Core\Logger to use it
2023-01-16 22:20:33 +01:00
Philipp Holzer ab6efea9b2
Replace Config-Cache dependency with Config-Model (no more DB-waiting necessary) 2023-01-15 16:17:08 +01:00
Hypolite Petovan 21f172c585
Merge pull request #12674 from nupplaphil/bug/config_typesafe
Config: Improve the node.config.php transformation
2023-01-15 09:38:29 -05:00
Philipp Holzer bc60eb6cb7
Apply feedback and describe the encoding method 2023-01-15 11:57:43 +01:00
Philipp Holzer 4c28f9cf9c
Config: Improve the node.config.php transformation
- Add more types
- Improvement for assoziative arrays and key-value arrays
- Add a lot more tests
2023-01-15 00:53:51 +01:00
Hypolite Petovan e73adde5fb Remove App dependency from Hook::callSingle
- This was causing a circular dependency with the logger_instance hook
2023-01-14 10:38:37 -05:00
Philipp Holzer fef10e8a57
Improve encapsulation 2023-01-11 22:00:29 +01:00
Philipp Holzer 11a8bd17e3
Assure that deleted cat/keys are working as expected
- A deleted cache-key would delete a merged cache-key as well
- Deleting a key in the Model results in reloading the config to assure any value from underlying files
2023-01-11 21:53:34 +01:00
Philipp Holzer fd882abd80
Revert Cache delete() behavior to stable version 2023-01-11 21:10:59 +01:00
Hypolite Petovan 3966b58965 Only show line number if it's provided in System::callstack
- Address https://github.com/friendica/friendica/issues/12488#issuecomment-1377373973
2023-01-10 10:41:20 -05:00
Hypolite Petovan 4d5d8e5b64 Add line number to output in System::callstack 2023-01-09 16:06:22 -05:00
Philipp Holzer 979672a3c1
Filter disabled addons with "null" 2023-01-08 02:49:56 +01:00
Philipp Holzer 5ea50a9e81
Fix "null" addon list 2023-01-08 02:49:56 +01:00
Philipp Holzer 2293ff6206
Add test for Addon failures 2023-01-08 02:49:56 +01:00
Philipp Holzer 0429a4e429
Fix loading empty node.config.php 2023-01-08 02:49:56 +01:00
Philipp Holzer 6aaf1ea5d4
Fix addons problem more elegant 2023-01-07 20:49:29 +01:00
Philipp Holzer 9fb5b95b5e
Fix other foreach() troubles at Addon.php 2023-01-07 19:54:59 +01:00
Philipp Holzer 6454c1dee7
Don't ksort() on null 2023-01-07 19:52:43 +01:00
Philipp Holzer 6bd1740a94
omg .. wrong assertion .. 2023-01-07 15:49:55 +01:00
Philipp Holzer 6e4e2c4a82
Fix warning text 2023-01-07 15:30:45 +01:00
Philipp Holzer 6e0d16f22b
Add warning message in case node.config.php isn't writable 2023-01-07 15:16:55 +01:00
Philipp Holzer 80e8f4aa34
Execute critical worker tasks, even if we're in daemon mode 2023-01-07 13:43:16 +01:00
Philipp Holzer 5b2e02889e
Fix Update::run() 2023-01-06 17:50:56 +01:00
Philipp Holzer baf3225916
Apply Update::check() suggestions 2023-01-06 12:50:14 +01:00
Philipp Holzer c35fd68ec2
Adapt doc 2023-01-06 12:47:00 +01:00
Philipp beb3d376b2
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-06 12:46:06 +01:00
Philipp 05048d4abf
Update src/Core/Config/ValueObject/Cache.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-06 12:43:04 +01:00
Philipp 70704ccb19
Update src/Core/Update.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-06 12:42:56 +01:00
Philipp 9462bfa763
Update src/Core/Config/Util/ConfigFileManager.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-06 12:42:43 +01:00
Philipp Holzer b3772163d8
Add doc 2023-01-06 03:06:11 +01:00
Philipp Holzer ce8c820221
add description 2023-01-06 02:54:34 +01:00
Philipp d53cb31869
Update src/Core/Config/Util/ConfigFileManager.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-06 02:16:35 +01:00
Philipp Holzer e14050491a
Config fixing
- unlock/close the `node.config.php` in every circumstances
2023-01-06 01:10:57 +01:00
Philipp Holzer 5aa8e8adf1
Config fixings
- Delete now really overwrites static default/setting.config.php keys
- Delete now really overwrites static default/setting.config.php categories
- The Update::check() routine is added to different places
- Merge the given config file with the new config before writing
- Remove ConfigTransaction::get() because it's no more reliable
2023-01-06 01:03:00 +01:00
Philipp Holzer cdd57275eb
Some improvements
- Move $_SERVER into ConfigFileManager constructor
- Rename "creatConfigFileLoader" to "createConfigFileManager"
- Rename variable "loader" to "manager" in all tests
2023-01-06 01:03:00 +01:00
Philipp Holzer b4096251ba
Check 'config' table as fallback for migrations 2023-01-06 01:03:00 +01:00
Philipp 4b17d6f3bf
Update src/Core/Addon.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-04 23:12:41 +01:00
Philipp Holzer 01403d15c4
sort addon array 2023-01-04 21:55:51 +01:00
Philipp Holzer 13b234d279
Use addons config entries instead of the addon table 2023-01-04 21:55:51 +01:00
Philipp Holzer dce86be58e
Just commit config transactions if something changed 2023-01-04 19:55:22 +01:00
Philipp Holzer aabe39220d
Make flock writing easier 2023-01-04 08:16:40 +01:00
Philipp Holzer c057954896
Make BaseURL check/save transactional and make the whole process easier 2023-01-04 08:14:00 +01:00
Philipp Holzer 17105cf7d1
Fix config read/write locking 2023-01-04 00:25:18 +01:00
Philipp Holzer 176af67e88
Fix empty fetchResult curResult at Link::fetchMimeType (thx to Marco R.) 2023-01-03 21:06:16 +01:00
Philipp beff759c82
Update src/Core/Config/Model/ConfigTransaction.php
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-03 17:39:32 +01:00
Philipp Holzer a46cd2fb36
Remove get() from config transaction interface 2023-01-03 17:26:48 +01:00
Philipp Holzer b439df892a
Apply suggestions 2023-01-03 17:24:05 +01:00
Philipp Holzer dd88d193b9
Escape single quotes and backslashes 2023-01-03 15:36:36 +01:00
Philipp Holzer 65d79d4c93
Introduce ISetConfigValuesTransactional for transactional config behaviour 2023-01-03 14:22:07 +01:00
Philipp ae1533e312
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2023-01-03 14:22:06 +01:00
Philipp Holzer 88b3effc18
Use toConfigValue in case of serialized, legacy data 2023-01-03 14:22:05 +01:00
Philipp Holzer 1e574d5383
Refactor IManageConfigValues interface 2023-01-03 14:22:04 +01:00
Philipp Holzer d272e8c3c7
Remove unnecessary classes 2023-01-03 14:22:03 +01:00
Philipp Holzer b871e1d264
Introduce lightweight Config model 2023-01-03 14:22:02 +01:00
Philipp Holzer 0f91d1cbde
Introduce ConfigFileManager for config files 2023-01-03 14:22:02 +01:00
Philipp Holzer fea4b202c1
Introduce ConfigFileTransformer for Config files 2023-01-03 14:22:02 +01:00
Hypolite Petovan 8bbf9e93c6 Remove dependency to the second parameter of XML::fromArray 2023-01-01 19:20:42 -05:00
Michael Vogel 6b914ccc0f
Merge pull request #12586 from MrPetovan/task/entitize-delivery-queue
Add Entity-Factory-Repository for deliver-queue
2023-01-02 00:56:13 +01:00
Hypolite Petovan a744b8b56f Replace direct database calls and anonymous arrays by repository calls and entity objects 2023-01-01 18:50:21 -05:00
Hypolite Petovan f9676c9ed2 Convert Directory Search results into contact-looking records
- Address https://github.com/friendica/friendica/issues/12488#issuecomment-1368216631
2023-01-01 18:47:45 -05:00
Michael f1bcf1ef66 Set the server status directly after transmission 2023-01-01 17:34:05 +00:00
Michael 12fac6e089 Close the database 2023-01-01 15:37:47 +00:00
Michael 360614d2cf Merge remote-tracking branch 'upstream/develop' into inbox-gsid 2023-01-01 15:25:28 +00:00
Michael fe897c7ef4 Increase the year 2023-01-01 15:14:45 +00:00
Michael 7307646cf8 Use server id on direct delivery 2023-01-01 15:13:44 +00:00
Hypolite Petovan 1874a32728 Happy New Year 2023! 2023-01-01 09:36:24 -05:00
Hypolite Petovan 319857edaa
Merge pull request #12583 from annando/delivery-queue
Bulk delivery added for all protocols
2022-12-31 11:36:54 -05:00
Michael 8e397b5849 Changes after review 2022-12-31 16:20:18 +00:00
Michael 259b99e6e9 Bulk delivery added for all protocols 2022-12-31 12:19:34 +00:00
Hypolite Petovan b0898ada29 Add previous exception to unexpected worker exception logging 2022-12-30 22:25:19 -05:00
Hypolite Petovan 6e31b8d6a5 Avoid return type exeption in HTTPSignature->post
- Prefer passing the owner record array instead of just the uid
- +4/-7 calls to User::getOwnerDataById
2022-12-30 17:23:22 -05:00
Philipp Holzer a330a3c22d
Make PHP-CS happy again 2022-12-29 22:38:01 +01:00
Philipp Holzer 86f80af432
Rename Interface 2022-12-29 22:37:12 +01:00
Philipp Holzer 7c4c409060
Change key-value table
- Make "k" as primary key
- Added "updated_at"
2022-12-29 22:36:08 +01:00
Philipp 925c30280c
Apply suggestions from code review
Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
2022-12-29 22:12:02 +01:00
Philipp Holzer b227d65dfc
Replace worker_daemon_mode config entry with key-value entry 2022-12-29 21:53:57 +01:00
Philipp Holzer 6b3265742a
Replace cron/worker "last" config entries with key-value entries 2022-12-29 21:53:57 +01:00
Philipp Holzer 10f8631cd9
Replace PostUpdate key-value config entries with key-value pair entries 2022-12-29 21:53:56 +01:00
Philipp Holzer 47764387b3
Introduce Key-Value Pair storage provider 2022-12-29 21:53:56 +01:00
Hypolite Petovan 8b1947bd78 Add Core\Logger to the introspection skip class list
- Make class list explicit to avoid confusion between similar class names
- Update skipped class string match to a safer "starts with" condition
2022-12-28 17:54:37 -05:00
Hypolite Petovan 9dbcbe0482 Remove extraneous Introspection->isTraceClassOrSkippedFunction second parameter 2022-12-28 17:51:07 -05:00
Philipp e0fa557f18
Merge pull request #12539 from annando/forum-thread
Distribute forum comments only via the forum
2022-12-27 17:51:22 +01:00
Michael ca0e3e3db7 Distribute forum comments only via the forum 2022-12-27 16:14:04 +00:00
Hypolite Petovan 5c332af844
Merge pull request #12527 from nupplaphil/feat/request_id
Introduce Request::getRequestId()
2022-12-26 16:07:35 -05:00
Philipp Holzer 5584e7a4e5
Use X-REQUEST-ID for Logging 2022-12-26 21:18:04 +01:00
Philipp Holzer 10864e50c7
Adapt Logger\Introspection
- Create an interface
- Add it as constructor parameter
2022-12-26 21:18:04 +01:00
Philipp Holzer bfc1c157f1
Adapt UserSession
- Move from App methods to UserSession methods
- Deprecate corresponding App methods
2022-12-26 21:18:04 +01:00
Michael 5298cd73b3 We now store the violation as well 2022-12-25 10:44:06 +00:00
Hypolite Petovan 43aa9cddc5 Trim terms of service rules before turning them to an array 2022-12-17 21:13:52 -05:00
Hypolite Petovan 07520719f7 Add documentation about the ACL autocomplete fields 2022-12-14 21:57:14 -05:00
Hypolite Petovan baf2f7565a
Merge pull request #12390 from annando/fixes
Only reshare the author's posts on `MIRROR_NATIVE_RESHARE`
2022-12-11 15:05:47 -05:00
Michael 2f3f41ed9c Merge remote-tracking branch 'origin/2022.12-rc' into fixes 2022-12-11 19:00:59 +00:00
Michael Vogel 884a265c5a Some small fixes 2022-12-11 11:21:02 +01:00
Michael 3ce4a1fee4 Avoid error when image couldn't be fetched 2022-12-11 10:12:20 +00:00
Hypolite Petovan 22e2578b23
Merge pull request #12322 from annando/api-rules
API: Central way to fetch the system rules
2022-12-03 17:24:52 -05:00
Michael 16b76919c0 Rules added 2022-12-03 21:15:08 +00:00
Michael b6f7d31036 API: Central way to fetch the system rules 2022-12-03 20:18:19 +00:00
Michael fa80c69d94 Only fetch the processes if needed 2022-12-03 19:44:50 +00:00
Zane C. Bowers-Hadley 8f82fb9a22 now with g 2022-12-03 04:34:17 -06:00
Zane C. Bowers-Hadley edaff99307 derp, minor fix 2022-12-03 04:31:04 -06:00
Zane C. Bowers-Hadley f664208157 get the load average in a portable manner 2022-12-03 04:24:49 -06:00
Hypolite Petovan ed7b175491 Catch worker argument type errors
- This marks the invalid worker queue item as completed instead of endlessly retrying it
- Address https://github.com/friendica/friendica/issues/11992#issuecomment-1327029331
2022-11-26 15:21:46 -05:00
Hypolite Petovan 6b555f64da Add \ReturnTypeWillChange attribute to methods inherited from native interfaces
- Part of https://github.com/friendica/friendica/issues/12011#issuecomment-1321796513
2022-11-25 08:13:05 -05:00
Michael 53b46855ef return "null" 2022-11-24 19:45:45 +00:00
Michael 6a434588a9 Silently quit on unfollow of invalid contacts 2022-11-24 05:17:14 +00:00
Hypolite Petovan fe547b7851 Centralize config.admin_email management in Model\User 2022-11-14 17:02:42 -05:00
Philipp Holzer 477bec1977
Fix some PHP8.1 issues if possible 2022-11-09 23:58:23 +01:00
Hypolite Petovan 561f22cdc4 Add title to homepage verified check mark
- Decrease log level for not found Memcached keys
2022-11-08 04:20:19 -05:00
Hypolite Petovan 23dda5d510 Deprecate default value parameters in Session and Config interfaces
- It is more efficient to use the null coalescing operator ?? that prevents the computation of the default value if the key has been found
2022-11-04 06:42:38 -04:00
Michael 842e51194e Improved bulk delivery / don't redistribute activities 2022-11-03 04:03:39 +00:00