Merge pull request #7686 from annando/noblank

Don't send blank pictures on error, fail instead.
This commit is contained in:
Hypolite Petovan 2019-10-01 09:02:52 -04:00 committed by GitHub
commit f16bf04f54
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -287,14 +287,13 @@ class Proxy extends BaseModule
} }
/** /**
* @brief Output a blank image, without cache headers, in case of errors * In case of an error just stop. We don't return content to avoid caching problems
* *
* @throws \Friendica\Network\HTTPException\InternalServerErrorException
*/ */
private static function responseError() private static function responseError()
{ {
header('Content-type: image/png'); throw new \Friendica\Network\HTTPException\InternalServerErrorException();
echo file_get_contents('images/blank.png');
exit();
} }
/** /**