Browse Source

Possibly fixed test

pull/5184/head
Michael 4 years ago
parent
commit
defd3d15b6
  1. 4
      include/api.php
  2. 6
      tests/ApiTest.php

4
include/api.php

@ -1920,7 +1920,7 @@ function api_statuses_show($type)
$statuses = Item::select(api_user(), [], $condition, $params);
/// @TODO How about copying this to above methods which don't check $r ?
if (!DBM::is_result($items)) {
if (!DBM::is_result($statuses)) {
throw new BadRequestException("There is no status with this id.");
}
@ -2000,7 +2000,7 @@ function api_conversation_show($type)
$params = ['order' => ['id' => true], 'limit' => [$start, $count]];
$statuses = Item::select(api_user(), [], $condition, $params);
if (!DBM::is_result($items)) {
if (!DBM::is_result($statuses)) {
throw new BadRequestException("There is no status with id $id.");
}

6
tests/ApiTest.php

@ -1871,7 +1871,7 @@ class ApiTest extends DatabaseTest
$this->app->argv[1] = '1.1';
$this->app->argv[3] = 'create';
$this->app->argc = 10;
$_REQUEST['id'] = 1;
$_REQUEST['id'] = 3;
$result = api_favorites_create_destroy('json');
$this->assertStatus($result['status']);
}
@ -1885,7 +1885,7 @@ class ApiTest extends DatabaseTest
$this->app->argv[1] = '1.1';
$this->app->argv[3] = 'create';
$this->app->argc = 10;
$_REQUEST['id'] = 1;
$_REQUEST['id'] = 3;
$result = api_favorites_create_destroy('rss');
$this->assertXml($result, 'status');
}
@ -1899,7 +1899,7 @@ class ApiTest extends DatabaseTest
$this->app->argv[1] = '1.1';
$this->app->argv[3] = 'destroy';
$this->app->argc = 10;
$_REQUEST['id'] = 1;
$_REQUEST['id'] = 3;
$result = api_favorites_create_destroy('json');
$this->assertStatus($result['status']);
}

Loading…
Cancel
Save