apply coding standards to lockview module

This commit is contained in:
rabuzarus 2018-09-05 14:24:51 +02:00
parent 88d25f977a
commit bd9d102da2

View file

@ -8,24 +8,27 @@ use Friendica\Core\L10n;
use Friendica\Database\DBA; use Friendica\Database\DBA;
use Friendica\Model\Item; use Friendica\Model\Item;
function lockview_content(App $a) { function lockview_content(App $a)
{
$type = (($a->argc > 1) ? $a->argv[1] : 0); $type = (($a->argc > 1) ? $a->argv[1] : 0);
if (is_numeric($type)) { if (is_numeric($type)) {
$item_id = intval($type); $item_id = intval($type);
$type='item'; $type = 'item';
} else { } else {
$item_id = (($a->argc > 2) ? intval($a->argv[2]) : 0); $item_id = (($a->argc > 2) ? intval($a->argv[2]) : 0);
} }
if (!$item_id) if (!$item_id) {
killme(); killme();
}
if (!in_array($type, ['item','photo','event'])) if (!in_array($type, ['item','photo','event'])) {
killme(); killme();
}
$fields = ['uid', 'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid']; $fields = ['uid', 'allow_cid', 'allow_gid', 'deny_cid', 'deny_gid'];
$condition = ['id' => $item_id]; $condition = ['id' => $item_id];
if ($type != 'item') { if ($type != 'item') {
$item = DBA::selectFirst($type, $fields, $condition); $item = DBA::selectFirst($type, $fields, $condition);
} else { } else {
@ -44,18 +47,20 @@ function lockview_content(App $a) {
killme(); killme();
} }
if ($item['private'] == 1
if (($item['private'] == 1) && empty($item['allow_cid']) && empty($item['allow_gid']) && empty($item['allow_cid'])
&& empty($item['deny_cid']) && empty($item['deny_gid'])) { && empty($item['allow_gid'])
&& empty($item['deny_cid'])
&& empty($item['deny_gid']))
{
echo L10n::t('Remote privacy information not available.') . '<br />'; echo L10n::t('Remote privacy information not available.') . '<br />';
killme(); killme();
} }
$allowed_users = expand_acl($item['allow_cid']); $allowed_users = expand_acl($item['allow_cid']);
$allowed_groups = expand_acl($item['allow_gid']); $allowed_groups = expand_acl($item['allow_gid']);
$deny_users = expand_acl($item['deny_cid']); $deny_users = expand_acl($item['deny_cid']);
$deny_groups = expand_acl($item['deny_gid']); $deny_groups = expand_acl($item['deny_gid']);
$o = L10n::t('Visible to:') . '<br />'; $o = L10n::t('Visible to:') . '<br />';
$l = []; $l = [];
@ -64,36 +69,44 @@ function lockview_content(App $a) {
$r = q("SELECT `name` FROM `group` WHERE `id` IN ( %s )", $r = q("SELECT `name` FROM `group` WHERE `id` IN ( %s )",
DBA::escape(implode(', ', $allowed_groups)) DBA::escape(implode(', ', $allowed_groups))
); );
if (DBA::isResult($r)) if (DBA::isResult($r)) {
foreach($r as $rr) foreach ($r as $rr) {
$l[] = '<b>' . $rr['name'] . '</b>'; $l[] = '<b>' . $rr['name'] . '</b>';
}
}
} }
if (count($allowed_users)) { if (count($allowed_users)) {
$r = q("SELECT `name` FROM `contact` WHERE `id` IN ( %s )", $r = q("SELECT `name` FROM `contact` WHERE `id` IN ( %s )",
DBA::escape(implode(', ',$allowed_users)) DBA::escape(implode(', ', $allowed_users))
); );
if (DBA::isResult($r)) if (DBA::isResult($r)) {
foreach($r as $rr) foreach ($r as $rr) {
$l[] = $rr['name']; $l[] = $rr['name'];
}
}
} }
if (count($deny_groups)) { if (count($deny_groups)) {
$r = q("SELECT `name` FROM `group` WHERE `id` IN ( %s )", $r = q("SELECT `name` FROM `group` WHERE `id` IN ( %s )",
DBA::escape(implode(', ', $deny_groups)) DBA::escape(implode(', ', $deny_groups))
); );
if (DBA::isResult($r)) if (DBA::isResult($r)) {
foreach($r as $rr) foreach ($r as $rr) {
$l[] = '<b><strike>' . $rr['name'] . '</strike></b>'; $l[] = '<b><strike>' . $rr['name'] . '</strike></b>';
}
}
} }
if (count($deny_users)) { if (count($deny_users)) {
$r = q("SELECT `name` FROM `contact` WHERE `id` IN ( %s )", $r = q("SELECT `name` FROM `contact` WHERE `id` IN ( %s )",
DBA::escape(implode(', ',$deny_users)) DBA::escape(implode(', ', $deny_users))
); );
if (DBA::isResult($r)) if (DBA::isResult($r)) {
foreach($r as $rr) foreach ($r as $rr) {
$l[] = '<strike>' . $rr['name'] . '</strike>'; $l[] = '<strike>' . $rr['name'] . '</strike>';
}
}
} }
echo $o . implode(', ', $l); echo $o . implode(', ', $l);