Apply suggestions from code review

Co-authored-by: Hypolite Petovan <hypolite@mrpetovan.com>
This commit is contained in:
Michael Vogel 2023-01-27 07:21:08 +01:00 committed by GitHub
parent ba4860b787
commit 94b63e6a00
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -353,7 +353,6 @@ class Photo extends BaseModule
// If it is a local link, we save resources by just redirecting to it. // If it is a local link, we save resources by just redirecting to it.
if (Network::isLocalLink($url)) { if (Network::isLocalLink($url)) {
System::externalRedirect($url); System::externalRedirect($url);
System::exit();
} }
$mimetext = ''; $mimetext = '';
@ -402,7 +401,6 @@ class Photo extends BaseModule
} }
if (Network::isLocalLink($url)) { if (Network::isLocalLink($url)) {
System::externalRedirect($url); System::externalRedirect($url);
System::exit();
} }
} }
return MPhoto::createPhotoForExternalResource($url, 0, $mimetext, $contact['blurhash'] ?? null, $customsize, $customsize); return MPhoto::createPhotoForExternalResource($url, 0, $mimetext, $contact['blurhash'] ?? null, $customsize, $customsize);
@ -430,7 +428,6 @@ class Photo extends BaseModule
$url = Contact::getDefaultHeader($contact); $url = Contact::getDefaultHeader($contact);
if (Network::isLocalLink($url)) { if (Network::isLocalLink($url)) {
System::externalRedirect($url); System::externalRedirect($url);
System::exit();
} }
} }
return MPhoto::createPhotoForExternalResource($url); return MPhoto::createPhotoForExternalResource($url);
@ -467,7 +464,6 @@ class Photo extends BaseModule
if (Network::isLocalLink($default)) { if (Network::isLocalLink($default)) {
System::externalRedirect($default); System::externalRedirect($default);
System::exit();
} }
$parts = parse_url($default); $parts = parse_url($default);