friendica/friendica
6
0
Fork 1
mirror of https://github.com/friendica/friendica synced 2024-05-23 12:54:58 +02:00
Code Issues Packages Projects Releases 1 Wiki Activity

Remove the locking to improve performance

Browse source
This commit is contained in:
Michael 2020-07-10 19:50:16 +00:00
parent 87f054a642
commit 84d8753d5f
1 changed files with 24 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
src/Model/GContact.php
View file

@ -609,8 +609,6 @@ class GContact
*/ */
public static function getId($contact) public static function getId($contact)
{ {
$gcontact_id = 0;
if (empty($contact['network'])) { if (empty($contact['network'])) {
Logger::notice('Empty network', ['url' => $contact['url'], 'callstack' => System::callstack()]); Logger::notice('Empty network', ['url' => $contact['url'], 'callstack' => System::callstack()]);
return false; return false;
@ -630,12 +628,12 @@ class GContact
$contact['url'] = self::cleanContactUrl($contact['url']); $contact['url'] = self::cleanContactUrl($contact['url']);
} }
DBA::lock('gcontact'); $condition = ['nurl' => Strings::normaliseLink($contact['url'])];
$fields = ['id', 'last_contact', 'last_failure', 'network']; $gcontact = DBA::selectFirst('gcontact', ['id'], $condition, ['order' => ['id']]);
$gcnt = DBA::selectFirst('gcontact', $fields, ['nurl' => Strings::normaliseLink($contact['url'])]); if (DBA::isResult($gcontact)) {
if (DBA::isResult($gcnt)) { return $gcontact['id'];
$gcontact_id = $gcnt['id']; }
} else {
$contact['location'] = $contact['location'] ?? ''; $contact['location'] = $contact['location'] ?? '';
$contact['about'] = $contact['about'] ?? ''; $contact['about'] = $contact['about'] ?? '';
$contact['generation'] = $contact['generation'] ?? 0; $contact['generation'] = $contact['generation'] ?? 0;
@ -648,15 +646,14 @@ class GContact
DBA::insert('gcontact', $fields); DBA::insert('gcontact', $fields);
$condition = ['nurl' => Strings::normaliseLink($contact['url'])]; // We intentionally aren't using lastInsertId here. There is a chance for duplicates.
$cnt = DBA::selectFirst('gcontact', ['id', 'network'], $condition, ['order' => ['id']]); $gcontact = DBA::selectFirst('gcontact', ['id'], $condition, ['order' => ['id']]);
if (DBA::isResult($cnt)) { if (!DBA::isResult($gcontact)) {
$gcontact_id = $cnt['id']; Logger::info('GContact creation failed', $fields);
// Shouldn't happen
return 0;
} }
} return $gcontact['id'];
DBA::unlock();
return $gcontact_id;
} }
/** /**