friendica/friendica
6
0
Fork 1
mirror of https://github.com/friendica/friendica synced 2024-05-12 12:49:39 +02:00
Code Issues Packages Projects Releases 1 Wiki Activity

Add FIXME

Browse source 
- Current implementation is failing tests with emojis including the zero-width-joiner character, encoded on 3 bytes only.
This commit is contained in:
Hypolite Petovan 2023-08-29 22:17:48 -04:00
parent 059a111282
commit 64b5f93a6a
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/Content/Smilies.php
View file

@ -296,7 +296,7 @@ class Smilies
{
// Strips all whitespace
$conv = preg_replace('#\s#u', '', html_entity_decode($body));
// Emojis are always 4 byte Unicode characters
// @FIXME Emojis are almost always 4 byte Unicode characters, except when they include the zero-width joiner character, encoded on 3 bytes
return (!empty($conv) && (strlen($conv) / mb_strlen($conv) == 4));
}
}