friendica
/
friendica
mirror of https://github.com/friendica/friendica
6
0
Fork 1
Code Issues Packages Projects Releases 1 Wiki Activity

Merge pull request #4449 from annando/probe-pump 

Improved profile probing for pump.io
This commit is contained in:
Hypolite Petovan 2018-02-13 08:25:47 -05:00 committed by GitHub
parent 4c91729bc9 6a486aa92b
commit 2234bb92ae
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 34 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
src/Network/Probe.php
View File

@ -652,7 +652,7 @@ class Probe
$result = self::ostatus($webfinger); $result = self::ostatus($webfinger);
} }
if ((!$result && ($network == "")) || ($network == NETWORK_PUMPIO)) { if ((!$result && ($network == "")) || ($network == NETWORK_PUMPIO)) {
$result = self::pumpio($webfinger); $result = self::pumpio($webfinger, $addr);
} }
if ((!$result && ($network == "")) || ($network == NETWORK_FEED)) { if ((!$result && ($network == "")) || ($network == NETWORK_FEED)) {
$result = self::feed($uri); $result = self::feed($uri);
@ -676,7 +676,6 @@ class Probe
$result["baseurl"] = substr($result["url"], 0, $pos).$host; $result["baseurl"] = substr($result["url"], 0, $pos).$host;
} }
} }
return $result; return $result;
} }
@ -1332,14 +1331,33 @@ class Probe
$data = []; $data = [];
// This is ugly - but pump.io doesn't seem to know a better way for it $data["name"] = $xpath->query("//span[contains(@class, 'p-name')]")->item(0)->nodeValue;
$data["name"] = trim($xpath->query("//h1[@class='media-header']")->item(0)->nodeValue);
$pos = strpos($data["name"], chr(10)); if ($data["name"] == '') {
if ($pos) { // This is ugly - but pump.io doesn't seem to know a better way for it
$data["name"] = trim(substr($data["name"], 0, $pos)); $data["name"] = trim($xpath->query("//h1[@class='media-header']")->item(0)->nodeValue);
$pos = strpos($data["name"], chr(10));
if ($pos) {
$data["name"] = trim(substr($data["name"], 0, $pos));
}
} }
$avatar = $xpath->query("//img[@class='img-rounded media-object']")->item(0); $data["location"] = $xpath->query("//p[contains(@class, 'p-locality')]")->item(0)->nodeValue;
if ($data["location"] == '') {
$data["location"] = $xpath->query("//p[contains(@class, 'location')]")->item(0)->nodeValue;
}
$data["about"] = $xpath->query("//p[contains(@class, 'p-note')]")->item(0)->nodeValue;
if ($data["about"] == '') {
$data["about"] = $xpath->query("//p[contains(@class, 'summary')]")->item(0)->nodeValue;
}
$avatar = $xpath->query("//img[contains(@class, 'u-photo')]")->item(0);
if (!$avatar) {
$avatar = $xpath->query("//img[@class='img-rounded media-object']")->item(0);
}
if ($avatar) { if ($avatar) {
foreach ($avatar->attributes as $attribute) { foreach ($avatar->attributes as $attribute) {
if ($attribute->name == "src") { if ($attribute->name == "src") {
@ -1348,9 +1366,6 @@ class Probe
} }
} }
$data["location"] = $xpath->query("//p[@class='location']")->item(0)->nodeValue;
$data["about"] = $xpath->query("//p[@class='summary']")->item(0)->nodeValue;
return $data; return $data;
} }
@ -1361,7 +1376,7 @@ class Probe
* *
* @return array pump.io data * @return array pump.io data
*/ */
private static function pumpio($webfinger) private static function pumpio($webfinger, $addr)
{ {
$data = []; $data = [];
foreach ($webfinger["links"] as $link) { foreach ($webfinger["links"] as $link) {
@ -1399,6 +1414,13 @@ class Probe
$data = array_merge($data, $profile_data); $data = array_merge($data, $profile_data);
if (($addr != '') && ($data['name'] != '')) {
$name = trim(str_replace($addr, '', $data['name']));
if ($name != '') {
$data['name'] = $name;
}
}
return $data; return $data;
} }