Nodes with registration policy "requires approval" should be listed #28

New Issue

Closed

opened 2019-03-31 12:30:06 +02:00 by AlfredSK · 5 comments

AlfredSK commented

2019-03-31 12:30:06 +02:00

(Migrated from github.com)

I hope this is the right place to report issues for the directory.

Expected behavior

Nodes with registration policy "requires approval" should be listed on the directory's server list.

Actual wrongdoing

Nodes with registration policy "requires approval" are not listed on the directory's server list. Which is kind of confusing because the nodeinfo says "openRegistrations: true" and the node is therefore listed as 'open' on the-federation.info/friendica but not on our own directory.

Steps to reproduce

Set registration policy to "requires approval" and check your nodeinfo and (after some time) the server list on your configured global directory server.

Directories used for testing

dir.libranet.de 2.2.1
dir.friendica.social 2.2.1

Friendica used for testing

libranet.de 2019.03
mordor.social 2019.03

PHP/SQL

PHP 7.2.15 / MariaDB 10.1.38

I hope this is the right place to report issues for the directory. ### Expected behavior Nodes with registration policy "requires approval" should be listed on the directory's server list. ### Actual wrongdoing Nodes with registration policy "requires approval" are **not** listed on the directory's server list. Which is kind of confusing because the nodeinfo says "openRegistrations: true" and the node is therefore listed as 'open' on the-federation.info/friendica but not on our own directory. ### Steps to reproduce Set registration policy to "requires approval" and check your nodeinfo and (after some time) the server list on your configured global directory server. ### Directories used for testing dir.libranet.de 2.2.1 dir.friendica.social 2.2.1 ### Friendica used for testing libranet.de 2019.03 mordor.social 2019.03 ### PHP/SQL PHP 7.2.15 / MariaDB 10.1.38

👍 2

AlfredSK commented

2019-10-31 19:52:24 +01:00

(Migrated from github.com)

@MrPetovan What do you think? Would it be good enough to simply change the queries from WHERE `reg_policy` = "REGISTER_OPEN" to WHERE `reg_policy` != "REGISTER_CLOSED"?

I did that in my own directory locally and it seems to work.
https://dir.libranet.de/servers

If you agree I'll do a PR on the weekend.

@MrPetovan What do you think? Would it be good enough to simply change the queries from ``WHERE `reg_policy` = "REGISTER_OPEN"`` to ``WHERE `reg_policy` != "REGISTER_CLOSED"``? I did that in my own directory locally and it seems to work. https://dir.libranet.de/servers If you agree I'll do a PR on the weekend.

MrPetovan commented

2019-10-31 19:54:21 +01:00

(Migrated from github.com)

Absolutely.

👍 2

AlfredSK commented

2019-10-31 19:57:34 +01:00

(Migrated from github.com)

Thanks for checking your GitHub notifications. :-)

😆 1

AndyHee commented

2019-11-01 07:00:30 +01:00