friendica/friendica-addons
7
2
Fork 14
Code Issues 3 Pull requests 3 Releases 16 Wiki Activity

[twitter] Add HTTP error code handling #991

Merged
MrPetovan merged 3 commits from bug/notices into 2020.06-rc 2020-06-22 06:41:53 +02:00
Conversation 0 Commits 3 Files changed 1 +26 -18
1 changed files with 26 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit b07e4bd59c - Show all commits

14
twitter/twitter.php
View file

@ -500,9 +500,15 @@ function twitter_action(App $a, $uid, $pid, $action)
break;
case 'like':
$result = $connection->post('favorites/create', $post);
if ($connection->getLastHttpCode() != 200) {
Logger::error('Unable to create favorite', ['result' => $result]);
}
break;
case 'unlike':
$result = $connection->post('favorites/destroy', $post);
if ($connection->getLastHttpCode() != 200) {
Logger::error('Unable to destroy favorite', ['result' => $result]);
}
break;
default:
Logger::warning('Unhandled action', ['action' => $action]);
@ -1048,9 +1054,8 @@ function twitter_get_relation($uid, $target, $contact = [])
try {
$status = $connection->get('friendships/show', $parameters);
} catch (TwitterOAuthException $e) {
Logger::info('Error fetching friendship status', ['user' => $uid, 'target' => $target, 'message' => $e->getMessage()]);
return $relation;
if ($connection->getLastHttpCode() !== 200) {
throw new Exception($status->errors[0]->message ?? 'HTTP response code ' . $connection->getLastHttpCode(), $status->errors[0]->code ?? $connection->getLastHttpCode());
}
$following = $status->relationship->source->following;
@ -1067,6 +1072,9 @@ function twitter_get_relation($uid, $target, $contact = [])
}
Logger::info('Fetched friendship relation', ['user' => $uid, 'target' => $target, 'relation' => $relation]);
} catch (Throwable $e) {
Logger::error('Error fetching friendship status', ['user' => $uid, 'target' => $target, 'message' => $e->getMessage()]);
}
return $relation;
}