friendica/friendica-addons
9
4
Fork 16
Code Issues 3 Pull requests 4 Releases 16 Wiki Activity

PHPStan level 3 #1603

Merged
nupplaPhil merged 15 commits from Art4/friendica-addons:phpstan-level-3 into develop 2025-04-27 02:17:42 +02:00
Conversation 1 Commits 15 Files changed 13 +1 -1
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit dda6710b10 - Show all commits

Fix error in notifyall addon

Prev Next
Art4 2025-03-13 09:36:34 +00:00
commit dda6710b10

2
notifyall/notifyall.php
View file

@ -50,7 +50,7 @@ function notifyall_post()
$recipients = DBA::p("SELECT DISTINCT `email` FROM `user`" . DBA::buildCondition($condition), $condition); $recipients = DBA::p("SELECT DISTINCT `email` FROM `user`" . DBA::buildCondition($condition), $condition);
if (! $recipients) { if (! $recipients || !is_iterable($recipients)) {
Art4 marked this conversation as resolved Outdated
MrPetovan commented 2025-03-13 16:04:40 +01:00
Outdated
Copy link

Instead of checking for this, $recipients should be assigned the result of DBA::toArray(DBA:p(...)) in order for the later foreach() to be valid. Normally, the DBA::p output requires the use of DBA::fetch() in a loop.

Sure, the PDOStatement is iterable, but the mysqli-produced result resource probably isn't.

Instead of checking for this, `$recipients` should be assigned the result of `DBA::toArray(DBA:p(...))` in order for the later `foreach()` to be valid. Normally, the `DBA::p` output requires the use of `DBA::fetch()` in a loop. Sure, the `PDOStatement` is iterable, but the `mysqli`-produced result resource probably isn't.
👍 1
Art4 commented 2025-03-14 09:22:00 +01:00
Outdated
Copy link

Done, thank you.

Done, thank you.
DI::sysmsg()->addNotice(DI::l10n()->t('No recipients found.')); DI::sysmsg()->addNotice(DI::l10n()->t('No recipients found.'));
return; return;
} }