friendica/friendica-addons
9
4
Fork 16
Code Issues 3 Pull requests 4 Releases 16 Wiki Activity

PHPStan level 3 #1603

Merged
nupplaPhil merged 15 commits from Art4/friendica-addons:phpstan-level-3 into develop 2025-04-27 02:17:42 +02:00
Conversation 1 Commits 15 Files changed 13 +3 -3
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 2667b4d78e - Show all commits

Fix error in libravatar addon

Prev Next
Art4 2025-03-13 11:38:18 +00:00
commit 2667b4d78e

6
libravatar/Services/Libravatar.php
View file

@ -361,19 +361,19 @@ class Services_Libravatar
protected function domainGet($identifier)
{
if ($identifier === null) {
return null;
return '';
}
// What are we, email or openid? Split ourself up and get the
// important bit out.
if (filter_var($identifier, FILTER_VALIDATE_EMAIL)) {
$email = explode('@', $identifier);
return $email[1];
return (string) $email[1];
Art4 marked this conversation as resolved Outdated
MrPetovan commented 2025-03-13 15:59:40 +01:00
Outdated
Copy link

I'm surprised by this, explode() reportedly only returns strings in the output array. What case is this meant to address?

I'm surprised by this, `explode()` reportedly only returns strings in the output array. What case is this meant to address?
Art4 commented 2025-03-14 09:14:39 +01:00
Outdated
Copy link

I was surprised too, but thought PHPStan complains because explode() could also return false. But now I removed the type cast and PHPStan don't show an error anymore. 🤷

I was surprised too, but thought PHPStan complains because `explode()` could also return `false`. But now I removed the type cast and PHPStan don't show an error anymore. 🤷
}
//OpenID
$url = parse_url($identifier);
$domain = $url['host'];
$domain = (string) $url['host'];
Art4 marked this conversation as resolved Outdated
MrPetovan commented 2025-03-13 16:00:29 +01:00
Outdated
Copy link

parse_url() only returns an integer for the port key, this is superfluous.

`parse_url()` only returns an integer for the `port` key, this is superfluous.
Art4 commented 2025-03-14 09:15:24 +01:00
Outdated
Copy link

Same as above: #1603 (comment)

Same as above: https://git.friendi.ca/friendica/friendica-addons/pulls/1603#issuecomment-196305
if (isset($url['port']) && $url['scheme'] === 'http'
&& $url['port'] != 80
|| isset($url['port']) && $url['scheme'] === 'https'