friendica/friendica-addons

Fork 14

new addon - cookienotice - configure, show and handle a simple cookie… #794

Merged

Ixiter merged 10 commits from develop into develop

2019-01-23 16:28:27 +01:00

Ixiter commented

2019-01-20 10:15:13 +01:00

(Migrated from github.com)

similar to the pagheheader addon, an admin user can configure a cookie usage notice which will be shown until the user confirms by clicking an OK Button.
Cookie usage notice and OK button text are configurable.
Handling of the cookie accept cookie is done by the addon.

You can see the addon in action at my https://socivitas.com (german)

similar to the pagheheader addon, an admin user can configure a cookie usage notice which will be shown until the user confirms by clicking an OK Button. Cookie usage notice and OK button text are configurable. Handling of the cookie accept cookie is done by the addon. You can see the addon in action at my https://socivitas.com (german)

JeroenED commented

2019-01-20 12:31:35 +01:00

(Migrated from github.com)

2 things

@tobiasd will ask to run xgettext (https://github.com/friendica/friendica/blob/develop/util/README)
Please remove the netbeans directory

Otherwise, great work. Will love to see this being pulled.

2 things * @tobiasd will ask to run xgettext (https://github.com/friendica/friendica/blob/develop/util/README) * Please remove the netbeans directory Otherwise, great work. Will love to see this being pulled.

Ixiter commented

2019-01-20 14:23:19 +01:00

(Migrated from github.com)

Thank you @JeroenED .

Yeps .. should do taht language stuff. Isnt that much, just a vew phrases.

I watched the .gitignore and it only ignored /netbeans/private.
I will change that.

Thank you @JeroenED . Yeps .. should do taht language stuff. Isnt that much, just a vew phrases. I watched the .gitignore and it only ignored /netbeans/private. I will change that.

tobiasd commented

2019-01-20 14:32:05 +01:00

(Migrated from github.com)

I have another question (though the base messages.po generation would be nice)--what license do you have in mind for your addon?

tobiasd (Migrated from github.com) reviewed 2019-01-20 14:33:49 +01:00

tobiasd (Migrated from github.com) reviewed 2019-01-20 14:36:26 +01:00

MrPetovan (Migrated from github.com) requested changes 2019-01-20 14:57:17 +01:00

MrPetovan (Migrated from github.com) left a comment

Thanks for your submission! I have several change requests I'd like you to honor in order to be able to accept your addon to the official repository.

Have you tested your addon with multiple themes?

Thanks for your submission! I have several change requests I'd like you to honor in order to be able to accept your addon to the official repository. Have you tested your addon with multiple themes?

Ixiter (Migrated from github.com) reviewed 2019-01-20 15:36:57 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-20 15:37:50 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-20 15:40:27 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-20 15:41:14 +01:00

MrPetovan (Migrated from github.com) reviewed 2019-01-20 16:26:51 +01:00

tobiasd (Migrated from github.com) reviewed 2019-01-20 16:51:46 +01:00

tobiasd (Migrated from github.com) reviewed 2019-01-20 17:02:39 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-20 20:36:59 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-20 20:37:37 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-20 20:39:07 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-20 20:39:22 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-20 20:40:02 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-20 20:40:23 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-20 20:40:34 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-20 20:40:43 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-20 20:41:10 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-20 20:41:21 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-20 20:41:31 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-20 20:44:18 +01:00

Ixiter commented

2019-01-20 20:45:36 +01:00

(Migrated from github.com)

i guess I fixed all from the reviews.
Also added docblocks to all functions.
I learned a lot about the codes. It was fun.

Any other hints|complaints|tipps|tricks ?

i guess I fixed all from the reviews. Also added docblocks to all functions. I learned a lot about the codes. It was fun. Any other hints|complaints|tipps|tricks ?

MrPetovan (Migrated from github.com) requested changes 2019-01-22 17:12:04 +01:00

MrPetovan (Migrated from github.com) left a comment

Second pass, sorry for the suggestions I missed before.

tobiasd (Migrated from github.com) reviewed 2019-01-23 11:03:19 +01:00

tobiasd (Migrated from github.com) reviewed 2019-01-23 11:03:46 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-23 11:03:57 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-23 11:04:12 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-23 11:04:22 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-23 11:04:30 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-23 11:04:38 +01:00

Ixiter (Migrated from github.com) reviewed 2019-01-23 11:11:02 +01:00

MrPetovan (Migrated from github.com) requested changes 2019-01-23 14:52:10 +01:00