friendica
/
friendica-addons
7
2
Fork 13
Code Issues 3 Pull Requests 2 Releases 16 Wiki Activity

[forumdirectory] Fixes, type-hints and PAGE_* moval #671

Merged
Quix0r merged 4 commits from forumdirectory/fixes-rewrites-x-empty into develop 2018-07-28 07:33:39 +02:00
Conversation 1 Commits 4 Files Changed 1 +23 -21
Quix0r commented 2018-07-25 22:44:09 +02:00 (Migrated from github.com)
Copy Link

This PR does a few things:

  • added type-hint App
  • added type-hint array to $b
  • used empty() instead of deprecated x()
  • moved PAGE_* constants to class Friendica\Model\Profile

This PR depends on https://github.com/friendica/friendica/pull/5500 from main repository.

This PR does a few things: - added type-hint `App` - added type-hint `array` to $b - used empty() instead of deprecated x() - moved PAGE_* constants to class Friendica\Model\Profile This PR **depends** on https://github.com/friendica/friendica/pull/5500 from main repository.
MrPetovan (Migrated from github.com) requested changes 2018-07-26 01:11:06 +02:00
MrPetovan (Migrated from github.com) left a comment
Copy Link

The constants should be in Model\User here as well.

The constants should be in `Model\User` here as well.
Quix0r commented 2018-07-27 02:08:54 +02:00 (Migrated from github.com)
Copy Link

I guess Model/Contact ... ;-)

I guess `Model/Contact` ... ;-)
😆 1
MrPetovan (Migrated from github.com) requested changes 2018-07-28 01:26:47 +02:00
Quix0r (Migrated from github.com) reviewed 2018-07-28 02:33:20 +02:00
MrPetovan (Migrated from github.com) approved these changes 2018-07-28 07:33:30 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
MrPetovan
Labels
Clear labels   
2018.09

   
2019.01

   
2019.03

   
2019.06

   
2019.09

   
2019.12

   
2020.03

   
2020.06

   
2020.09

   
2020.12

   
2021.03

   
2021.07

   
2021.09

   
2022.02

   
2022.06

   
2022.09

   
2022.12

   
2023.04

   
2023.05

   
2023.09

   
2024.03

   
2024.06

   
dependencies

Pull requests that update a dependency file

  
Hackathon 2021
No Label
2018.09
2019.01
2019.03
2019.06
2019.09
2019.12
2020.03
2020.06
2020.09
2020.12
2021.03
2021.07
2021.09
2022.02
2022.06
2022.09
2022.12
2023.04
2023.05
2023.09
2024.03
2024.06
dependencies
Hackathon 2021
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-addons#671
No description provided.
Delete Branch "forumdirectory/fixes-rewrites-x-empty"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?