friendica/friendica-addons

[forumdirectory] Fixes, type-hints and PAGE_* moval #671

Merged

Quix0r merged 4 commits from forumdirectory/fixes-rewrites-x-empty into develop

2018-07-28 07:33:39 +02:00

Quix0r commented

2018-07-25 22:44:09 +02:00

(Migrated from github.com)

This PR does a few things:

added type-hint App
added type-hint array to $b
used empty() instead of deprecated x()
moved PAGE_* constants to class Friendica\Model\Profile

This PR depends on https://github.com/friendica/friendica/pull/5500 from main repository.

This PR does a few things: - added type-hint `App` - added type-hint `array` to $b - used empty() instead of deprecated x() - moved PAGE_* constants to class Friendica\Model\Profile This PR **depends** on https://github.com/friendica/friendica/pull/5500 from main repository.

MrPetovan (Migrated from github.com) requested changes 2018-07-26 01:11:06 +02:00

MrPetovan (Migrated from github.com) left a comment

The constants should be in Model\User here as well.

The constants should be in `Model\User` here as well.

Quix0r commented

2018-07-27 02:08:54 +02:00

(Migrated from github.com)

I guess Model/Contact ... ;-)

I guess `Model/Contact` ... ;-)

MrPetovan (Migrated from github.com) requested changes 2018-07-28 01:26:47 +02:00

Quix0r (Migrated from github.com) reviewed 2018-07-28 02:33:20 +02:00

MrPetovan (Migrated from github.com) approved these changes 2018-07-28 07:33:30 +02:00

Sign in to join this conversation.

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: friendica/friendica-addons#671

No description provided.