[curweather] x() no longer used and more #669

Merged

Quix0r merged 5 commits from curweather/x-empty-app-spaces into develop

2018-07-25 02:19:00 +02:00

Quix0r commented

2018-07-25 00:10:38 +02:00

(Migrated from github.com)

Fixes/rewrites:

install/uninstall functions moved up (common across addons)
Added App as type-hint for $a and no & (call-by-reference) anymore
use empty() instead of deprecated x()
opening curly brace belongs into new line after function/method declaration
added a lot other curly braces for better readability
added spaces and empty lines

Fixes/rewrites: - install/uninstall functions moved up (common across addons) - Added `App` as type-hint for $a and no & (call-by-reference) anymore - use empty() instead of deprecated x() - opening curly brace belongs into new line after function/method declaration - added a lot other curly braces for better readability - added spaces and empty lines

MrPetovan (Migrated from github.com) requested changes 2018-07-25 01:14:10 +02:00

Quix0r (Migrated from github.com) reviewed 2018-07-25 01:25:56 +02:00

Quix0r (Migrated from github.com) reviewed 2018-07-25 01:26:28 +02:00

MrPetovan (Migrated from github.com) requested changes 2018-07-25 01:52:42 +02:00

Quix0r (Migrated from github.com) reviewed 2018-07-25 01:59:22 +02:00

MrPetovan (Migrated from github.com) reviewed 2018-07-25 02:08:02 +02:00

Quix0r (Migrated from github.com) reviewed 2018-07-25 02:15:32 +02:00

Quix0r commented

2018-07-25 02:16:18 +02:00

(Migrated from github.com)

Maybe remove (strong) cast?

MrPetovan (Migrated from github.com) approved these changes 2018-07-25 02:18:22 +02:00